Commit Graph

636 Commits (40a5f7bfdfa3371ecd97212bba9e4baf00a2652b)

Author SHA1 Message Date
Richard Levenberg 5cb39d0d57 Use System.Xml.XmlDocument.Load rather than Get-Content to avoid (#49206)
encoding errors when writing out XML

removing executable bit

refactor tests to handle sanity checking
2018-12-04 15:19:38 +00:00
Varun Chopra 90c3337316 Add win_partition (#46292)
* Added win_partition module

* Fixes sanity tests

* Requested changes minus changes in partition_size

* Removed trailing whitespace and fixed docstring

* Changes to parititon_size to allow variable units

* Stricter regex for partition_size
2018-11-26 11:01:59 +10:00
Jens Stark 8f449eec64 Updated help to list all features (#48875)
* Updated help to list all features

just to avoid searching powershell syntax Get-WindowsFeature

+label: docsite_pr

* added Linebreak

added Linebreak

* removed trailing whitespace

removed trailing whitespace

* slight modification of text
2018-11-26 10:33:50 +10:00
Jordan Borean c3770bf6f2
win_mapped_drive: removed docs around a system wide mount (#49017) 2018-11-22 17:05:35 +10:00
Jordan Borean a568bbed3c
win_mapped_drive - refactor module and docs (#48642)
* win_mapped_drive - refactor module and docs

* Updated code to work with become and split tokens

* use win_credential_manager instead of cmdkey

* updated credential manager module name

* harden the system token impersonation process
2018-11-22 08:12:41 +10:00
Jordan Borean 8e92cca139
win_credential: new module to manage credentials (#48840)
* win_credential_manager: new module to manage credentials

* fix sanity issues and removed CredSSP references

* renamed module to win_credential

* fix typo on test variable

* fix sanity ignore line
2018-11-22 06:55:48 +10:00
Michael Cassaniti 10af3874b5 win_snmp: Initial commit (#45710)
* win_snmp: Initial commit

* win_snmp: Better handling of lists

* win_snmp: Documentation fixes

* win_snmp: Updated documentation to match parameters

* win_snmp: Added integration tests

* win_snmp: Fixed typo in test

* win_snmp: Adjusted parameter checks to match documentation

* win_snmp: Updated option descriptions to be full sentences

* win_snmp: Better type checking and output suppression

* win_snmp: Fixed unset managers and communities

* win_snmp: Fixed skipping default registry keys

* win_snmp: Migrated to using add/set/remove action from replace

* win_snmp: Fixed check mode

* win_snmp: Fixed setting action and documentation. Expanded tests.

* win_snmp: Efficiency changes and documentation cleanup
  * Added example of explicitly setting an empty set of managers to
documentation
  * Made sure set will only remove items if there is a list of items
provided. This list can be of length 0
  * Improved efficiency in selecting next index for SNMP manager
  * Updated tests

* win_snmp: Added output of permitted managers and community strings

* win_snmp: Documentation fix
2018-11-22 06:55:10 +10:00
John R Barker 3fcc564bbb
Bulk fix DOCUMENTATION.author (Part 1) (#48934)
* Bulk fix DOCUMENTATION.author
2018-11-20 19:31:35 +00:00
Jordan Borean 9b0dd5224b
win_security_policy - add warning when using this module ot edit rights (#48850) 2018-11-20 09:21:28 +10:00
Dag Wieers f69e3e1cec win_get_url: Rewrite using AnsibleModule (#48390)
* win_get_url: Rewrite using AnsibleModule

* Fix sanity issue

* Implemented review suggestions

* Try something else

* fix circular dependency issues
2018-11-19 08:17:13 +10:00
jhawkesworth 361acd3547 win_say: Port to use CSharpUtil AnsibleBasic (#48361)
* port win-say to use CSharpUtil AnsibleBasic and add warning when requested voice not found

* win_say: fixes following code review: use C# style properties consistently; prefix changelog fragments

* fix invalid yaml in change log fragment

* win_say: fixes following code review: use generic module parameter validation where possible

* remove redundant setting of Result.changed to false, simplified some logic for readability.

* fix serialisation issue when message text is drawn from a file; allows tests to be run not in check mode and fix up some test descriptions
2018-11-19 07:07:12 +10:00
Dag Wieers 9436ce5d85
win_wait_for_process: Rewrite using AnsibleModule (#48388)
* win_wait_for_process: Rewrite using AnsibleModule

* Add mutually_exclusive and required_one_of
2018-11-17 02:15:49 +01:00
Matthew Hellmer 854e607535 Update win_wait_for_process.py (#48816)
<!--- Your description here -->
Corrected pattern example.
+label: docsite_pr
2018-11-17 02:04:56 +01:00
Jordan Borean 9ac89af355
win_chocolatey - move over to AnsibleModule and add allow_multiple (#48370) 2018-11-14 16:18:34 +10:00
Jordan Borean 6898f02431
win_shortcut: add run as admin and fix shell folder idempotency (#48584) 2018-11-14 12:15:04 +10:00
Dag Wieers a8b5d30a9e win_shortcut: Rewrite using AnsibleModule (#48384)
* win_shortcut: Rewrite using AnsibleModule

* Avoid using $args, fix issue

* Small review fixes, and use 'arguments' parameter

* Update doc with new alias version change
2018-11-13 06:20:09 +10:00
Dag Wieers 0ede11da3b win_product_facts: Implement review suggestions (#48573) 2018-11-13 05:44:57 +10:00
Dag Wieers ab8125f2a6 win_tempfile: Rewrite using AnsibleModule (#48386)
* win_tempfile: Rewrite using AnsibleModule

* Fix up error check

* Fix PSParameterizedProperty issue
2018-11-12 08:30:36 +10:00
Dag Wieers b312f7f7d7 win_defrag: Rewrite using AnsibleModule (#48381)
* win_defrag: Rewrite using AnsibleModule

* Fix delta return value
2018-11-12 08:10:47 +10:00
Dag Wieers baaa142248 win_wakeonlan: Rewrite using AnsibleModule (#48380) 2018-11-12 07:06:55 +10:00
Dag Wieers 2dd56eb15c win_product_facts: Rewrite using AnsibleModule (#48382) 2018-11-12 07:03:15 +10:00
Dag Wieers d174ebc65e win_psexec: Rewrite using AnsibleModule (#48383) 2018-11-12 07:00:57 +10:00
Michael Cassaniti a2f3f16930 win_updates: Add post search category matching to support product matching (#45708)
* win_update: Add post search category matching to support product matching

* win_updates: Return categories of each update

* win_updates: Documentation fix-up

* win_updates: Adjusted documentation to reflect regex vs sub-string match of post-cat strings

* win_updates: Sped up post-category checking

* win_updates: Updated documentation to suggest querying post-category strings

* win_updates: Simplified saving and checking post-categories

* fixed some issues and added filtered categories to return value

* win_updates: Moved all category matching to occur after initial search

* win_updates: Adjustments to satisfy PowerShell lint checks

* win_updates: Dropped category validation from action plugin

* win_updates: Documentation updates

* win_updates: Fixed plugin unit tests
2018-11-07 19:32:07 +10:00
Jordan Borean 501acae5ab
Added basic equivalent to PowerShell modules (#44705)
* Added basic equivalent to PowerShell modules

* changes based on latest review

* Added tests

* ignore sanity test due to how tests are set up

* Changes to work with PSCore

* Added documentation and change updated more modules

* Add some speed optimisations to AddType

* fix some issues in the doc changes

* doc changes
2018-11-07 10:53:17 +10:00
Jordan Borean 8a9d7b3695
win_uri: stop output from mixing with module result (#48140) 2018-11-06 11:10:03 +10:00
Dag Wieers e758f69ce3 win_domain: Add missing functionality (#46552)
* win_domain: Add missing functionality

* Fix typo: Treshold -> Threshold

* Improvements based on feedback

* moved mode checks to after pre-reqs are installed
2018-10-19 13:18:52 +10:00
Baptiste Mille-Mathias 0b9c033abe Use loop instead of with_items in examples (#47319)
with_items is deprecated
2018-10-18 17:14:35 -04:00
Jorgen f1f47d9a40 Fixed typo (#47139)
<!--- fixed typo in exclude example -->

+label: docsite_pr
2018-10-17 06:14:02 +10:00
Justin England 0bc5b799a6 Update win_scheduled_task.py (#46720)
* Update win_scheduled_task.py to document that the duration of a task trigger can be null, which will cause it to run indefinitely - docs update makes use of suboptions

* Add a fix for the validate-modules schema
2018-10-11 13:16:25 -05:00
Simon Liddicott f731e68bca Add chdir support to win_package (#46123)
* Add chdir support to win_package

* Add chdir support to uninstall too.

* Update docs to account for uninstall.

* Correct variable substitution for hashtable.

* added changelog fragment
2018-10-08 16:28:28 +10:00
Jordan Borean bc6d441cf2
Win chocolatey facts module (#46610)
* add module win_chocolatey_facts

* rename example name

* fix ansible-test errors

* add integration tests

* fix integration test

* implementation of improvement proposals

* implementation feedback

* implementation feedback

* fix trailing-whitespace

* implementation feedback

* fix version

* fix lint

* add test targets

* Updated modules docs and tests

Co-authored-by: Simon Baerlocher <sbaerlocher@users.noreply.github.com>
2018-10-08 16:12:06 +10:00
Dag Wieers 21d23829be Docs: Clean up 'win_reboot' module docs (#46377)
* Docs: Clean up 'win_reboot' module docs

This is part of a series of module doc cleanups.

* Remove hypothetical example
2018-10-04 13:19:58 +10:00
Dag Wieers 3f2f53681d Docs: Clean up 'win_service' module docs (#46407)
* Docs: Clean up 'win_service' module docs

This is part of a series of module doc cleanups.

* Fix typo pause vs paused

* Use both YAML list syntaxes
2018-10-04 11:23:41 +10:00
Jordan Borean ba638f40cf
ps-lint: ignore rules that are not relevant to Ansible (#46376) 2018-10-04 05:55:02 +10:00
Jordan Borean e283e7d5dd fixed tests after EAP set to Stop globally, ci_complete 2018-10-03 09:17:27 -07:00
Jordan Borean e972287c35 win_exec: refactor PS exec runner (#45334)
* win_exec: refactor PS exec runner

* more changes for PSCore compatibility

* made some changes based on the recent review

* split up module exec scripts for smaller payload

* removed C# module support to focus on just error msg improvement

* cleaned up c# test classifier code
2018-10-02 15:55:53 -07:00
Erwan Quelin 87416a4b91 Fix typo in the author's github username.
Ansibot is looking at the author's github username to query reviews for
modules in the same namespace.
2018-10-02 13:57:27 +02:00
Brendan Jurd ab96bbdef9 Clean up Vault docs in User Guide. (#46188)
* Fix spelling of 'separate' throughout.

* Various cleanups in the User Guide for Vault.

- Fix spelling of 'algorithm'
- Fix indentation of nested list in payload format
- Fix mysterious refernce to 'b_pkey1'.
- Fix reference to newline as '\n': the backslash is lost when rendered
to the docs website. Specify the hex value for newline instead of the
backslash escape.

* Fix formatting

* Update vault.rst
2018-09-28 10:16:58 -04:00
Kevin Subileau ac9d506a61 win_nssm: tests and several bug fixes (#44755)
* win_nssm: add failing tests for issue #44079

* win_nssm: use Run-Command instead of Invoke-Expression to prevent interpretation issue

Fix #44079

* win_nssm: add more failing tests

These tests highlight several issues with this module:
 * Service not started when state=started
 * Errors with app_parameters (see #25265)
 * Exception when passing several dependencies separated by comma as specified in doc

* win_nssm: fix service not started when state=started

Nssm status returns a multiline output that doesn't match any of the strict patterns in the switch statement.

* win_nssm: fix incorrect separator in doc for service dependencies

The dependencies parameter works with space as separator, but not with comma as shown in the documentation

* win_nssm: fix error with app_parameters parameter

Fix #25265

* win_nssm: add idempotence tests

* win_nssm: fix several idempotence issues and misbehaviors

Add missing space between arguments when app_parameters contains several keys.
Use Argv-ToString and Escape-Argument to improve arguments handling (parameters with quotes, backslashes or spaces).

* win_nssm: test parameters with spaces, quotes or backslashes

* win_nssm: restore comma as separator for service dependencies

Revert commit ddd4b4b

* win_nssm: restore support of string as dict form for app_parameters and remove support of literal YAML dict

* win_nssm: wrong variable in tests
2018-09-27 13:15:04 +10:00
aaronk1 8498b58ad5 Update win_robocopy.py (#38633)
* Update win_robocopy.py

<!--- Show example of UNC path copy of a single file, noting trailing backslash required -->

+label: docsite_pr

* addresses jborean comment, removes double quotes

* Remove trailing slash part
2018-09-27 06:28:15 +10:00
Jordan Borean d0d4f2e406
win_setup: don't fail when running as non-admin and EAP is set to Stop (#46149) 2018-09-26 13:46:24 +10:00
Dag Wieers db5b65f5d6 win_get_url: Clarify the encoded slash issue (#45376)
* win_get_url; Clarify the encoded slash issue
2018-09-24 10:18:06 -05:00
Jordan Borean 5c73d4f4bd
async: use async_dir for the async results file directory (#45461)
* win async: use async_dir for the async results file directory

* tried to unify POSIX and PowerShell async implementations of async_dir

* fix sanity issue
2018-09-20 19:37:54 +10:00
Jordan Borean 01398f61d5
Win deprecate 2.8 (#45473)
* Remove deprecated/expired functionality

* win:_msi: Remove the win_msi module

* removed some missed deprecated return options and added porting guide reference

Co-authored-by: dagwieers <dagwieers@users.noreply.github.com>
2018-09-11 14:23:48 +10:00
Jordan Borean ec6d82435f
win_scheduled_task: add deprecation warning for repetition format (#45468)
* win_scheduled_task: add deprecation warning for repetition format

* fixed up sanity issues
2018-09-11 14:22:57 +10:00
Mike Klebolt ee8a10b87d Fixes authentication error when ansible_user is a local account and computer is already joined to domain (#44270)
* Fixes authentication error when ansible_user is a local account and computer is already joined to domain

* recommended fixes
2018-09-11 13:20:45 +10:00
Jordan Borean 3371a779b6
win_group_membership - fix random issue with CI on 2012 R2 (#45462) 2018-09-11 13:07:43 +10:00
Jordan Borean 881f3a599c
windows testing - changes to accomodate future behaviour changes (#45464) 2018-09-11 13:04:23 +10:00
Jordan Borean c9c141fb6a
win_say - fix up syntax and test issues (#45450) 2018-09-11 08:23:46 +10:00
Matt Martz f89d873698
Stub out modules scheduled for 2.8 removal (#44985)
* Remove modules scheduled for 2.8

* Add changelog and porting guide

* Skip docs test on removed modules

* Don't link to removed modules
2018-08-31 16:27:32 -05:00