83e4a4048b
Fix the way pull localhosts out of inventory for delegate_to
...
This patch corrects the way we look in the inventory hosts list for
implicit localhost entries when localhost aliases are used.
Fixes #16568
2016-07-04 11:25:53 -05:00
068e447fda
Further tweaks to variable precedence to make it match our docs
...
Also removes looking at role variables from the Block, as those are
merged in separately via VariableManager
2016-06-07 12:08:01 -05:00
b37b51dcea
Fix variable precedence issue where set facts beat role params
...
Also updates doc on variable precedence, as it was incorrect for the
order of play vars/vars_prompt/vars_files in relation to set_fact and
registered variables.
Fixes #14702
Fixes #14826
2016-06-07 11:25:02 -05:00
add2d1947e
Fix recursive call of _load_inventory_file() in VariableManager
...
Fixes #16128
2016-06-06 11:25:15 -05:00
273a965dcc
Fix the way host and group vars are loaded
...
* In the VariableManager, we were not properly tracking if a file
had already been loaded, so we continuously append data to the end
of the list there for host and group vars, meaning large sets of data
are duplicated multiple times
* In the inventory, we were merging the host/group vars with the vars
local to the host needlessly, as the VariableManager already handles that.
This leads to needless duplication of the data and makes combining the
vars in VariableManager take even longer.
2016-06-02 16:52:37 -04:00
3e03004b6f
Use get_dep_chain() instead of directly using a blocks _dep_chain
...
Child blocks (whether nested or via includes) don't get a copy of the
dependency chain, so the above method should be used to ensure the block
looks at its parents dep chain.
Fixes #15996
2016-05-26 15:48:07 -04:00
33de7707c9
Do not include params when getting role vars in certain situations
...
In VariableManager, we fetch the params specifically in the next step,
so including them in the prior step is unnecessary and could lead to things
being overridden in an improper order.
In Block, we should not be getting the params for the role as they are
included earlier via the VariableManager.
Fixes #14411
2016-05-11 13:17:32 -04:00
a0dea1ac35
Fix var precedence bug introduced in ff9f5d7d
...
Fixes #14067
2016-04-19 12:40:31 -04:00
eac4cf1177
fix options_vars iteration for py3
2016-04-07 19:16:15 -07:00
eed6cf5dad
Adds 'ansible_check_mode' boolean magic variable
...
* Makes it possible to pass any options variable to VariableManager
by changing `load_options_vars(options)` in `lib/ansible/utils/vars.py`
2016-04-08 00:26:02 +02:00
0f2b1244d2
Make sure VariableManager has a view of HostVars
...
Fixes #15261
2016-04-05 11:32:28 -04:00
5dfc013e18
Merge pull request #14971 from bcoca/clear_facts
...
meta: clear_facts
2016-03-30 19:09:38 -07:00
4fc0aadd84
Only combine vars in include_vars if both are mappings
...
Fixes #15184
2016-03-30 11:11:26 -04:00
f427955640
Make default var lookup for tasks follow the dep chain
...
Related to #14296 (@jjshoe's follow-up example on that issue)
2016-03-24 09:51:36 -04:00
9d2fe2fb2c
Fixing role param precedence issues
...
* Make role param resolution follow the role dependency chain, rather
than using all roles within the play
* Also move params to be merged in after role vars in general, to match
our variable precedence rules
* Changes to the way var lookup is done in role helper methods for
get_vars(), get_inherited_vars(), and get_role_params() to make the
above possible without trampling on previously merged vars
Fixes #14472
Fixes #14475
2016-03-20 11:09:32 -04:00
61f05c2e8d
strip keys recursively
2016-03-16 13:18:29 -07:00
09699d0cd0
meta: clear_facts
...
draft implementation
2016-03-14 21:24:26 -07:00
d6546a7513
make sure group_names is always sorted
...
this makes it consistent with previous ansilbe versions and other
paths that create the group_names variable
2016-03-04 13:12:35 -05:00
a327420b67
properly combine vars if merge is set
...
hash_behaviour = merge now also applies to include vars
2016-02-12 00:55:17 -05:00
bbdfaf0522
move hostvars.vars to vars
...
this fixes duplication under hostvars and exposes all vars in the vars dict
which makes dynamic reference possible on 'non hostvars'
2015-12-22 00:24:35 -05:00
a4674906c6
Merge role params into variables separately from other variables
...
Fixes #13617
2015-12-21 13:03:09 -05:00
4426b7f6e0
fix sorting of groups for host vars
...
Fixes #13371
2015-12-03 14:23:02 -05:00
a183972477
Don't use play vars in HostVars
...
Fixes #13398
2015-12-02 14:16:47 -05:00
cc36eedf76
Ensure port is (re)set for delegated-to hosts
...
Fixes #13265
2015-11-30 14:40:23 -05:00
fbc9553bd4
Use text_type instead of unicode
2015-11-30 10:33:36 -05:00
c6a30f7000
Make sure the uuid in vars is string
2015-11-30 10:26:12 -05:00
5b6162a166
Re-adding role_name/role_uuid variables
2015-11-28 09:08:24 -05:00
91500f8f5f
Fix include param precedence in variable manager
2015-11-19 09:01:51 -05:00
180159b01d
Adding vars back in and trying to add a little more speed by avoiding copies
2015-11-17 14:44:46 -05:00
9f31c073fe
Fixing a few bugs in the HostVars performance areas
...
* Also refresh inventory in the HostVars manager process when things
are changed via add_host/group_by
* Raise j2undefined rather than return it
2015-11-17 09:15:10 -05:00
5cbeab5a3c
Performance improvements for HostVars and some bugfixes
2015-11-16 17:15:52 -05:00
62979efa14
Finish up plugin porting to global display
...
Also remove display = display which does nothing
2015-11-11 10:44:23 -08:00
566144461f
Remove internal use of display and use the top-level import
2015-11-10 12:02:29 -05:00
09994c18f3
Correct logic around determining environment variable existence
...
Fixes #13105
2015-11-09 21:04:24 -05:00
ccbcfcddfc
Move where we add environment and make it conditional on not existing
...
Also displays a warning now, because users should not be using that variable
name as it causes a collision with the internal variable of the same name.
2015-11-09 16:28:54 -05:00
937584cd52
Ensure 'environment' is set in the magic variables
...
Fixes #13033
2015-11-09 14:50:39 -05:00
7e04947599
Be more selective about what variables we cache during templating
...
Fixes #13087
2015-11-09 14:07:48 -05:00
63c47fb271
Fixing up performance
2015-11-05 16:22:37 -05:00
4203850d1a
Break apart a looped dependency to show a warning when parsing playbooks
...
Display a warning when a dict key is overwritten by pyyaml
Fixes #12888
2015-10-27 12:39:42 -07:00
cace91df56
Allow hostvars cache to be invalidated so hostvars contain all hosts after add_host
...
Fixes #12925
2015-10-27 14:12:17 -04:00
7ebfe72015
added missing string_types
2015-10-24 15:49:30 -04:00
8ce864db6f
sanatize results
2015-10-24 15:23:12 -04:00
498c27d09a
Re-adding role_names magic variable
...
Fixes #12863
2015-10-22 11:06:47 -04:00
08c9e70307
made display part of variable manager and corrected reference to it
...
fixes #12859
2015-10-21 22:29:27 -04:00
baa309309d
Bundle a new version of python-six for compatibility along with some code to make it easy for distributions to override the bunndled copy if they have a new enough version.
2015-10-16 08:21:28 -07:00
aee6de5a76
group_names should not include implied 'all', fixes #12763
2015-10-15 11:46:43 -04:00
cd2cb178ae
Totally rework the way UnsafeProxy does things
2015-10-12 18:13:09 -04:00
d15fcf05f0
Fix bug in the way temp vars were created for templating vars_files
...
Fixes #12711
2015-10-12 12:17:45 -04:00
1f82971283
Adding the inventory_file var back
2015-10-10 21:54:28 -04:00
7da478a4f4
Fix an issue where cache plugins weren't updated
...
The first call to persisting facts would work due to the assignment of a
MutableMapping calling __setitem__ but subsequent module fact data would
not be propogated to the fact cache plugins because update() doesn't
invoke __setitem__. This changes the behavior a little bit and ensures
set() is called on cache plugins.
2015-10-09 11:16:41 -04:00
James Cammarata
nitzmahone
Strahinja Kustudić
Brian Coca
Brian Coca
Yannig Perré
Toshio Kuratomi
Ben Keith
Matthew Jones