Ganesh Nalawade
c86b945a7c
Remove check_args for vyos modules ( #30739 )
...
* With addition of provider sub option validation check_args()
is no longer required.
2017-09-22 15:56:23 +05:30
Ganesh Nalawade
d72eb08902
Fix nxos provider transport warning issue ( #30610 )
...
* Fix nxos provider transport warning issue
* Add default value of transport arg in provider spec
* Remove default value if transport arg in top level spec
This ensure deprecation warning is seen only in case transport
is given as a top level arg in task
* Refactor nxos modules to reference transport value from provider
spec
* Fix unit test
* Remove transport arg assignment in nxos action plugin
* As assigning transport value is handled in provider spec
top level task arg assignment is no longer required
2017-09-22 10:32:25 +05:30
Tim Rupp
0eb0d96286
Adds module which allows users to manage partitions on a BIG-IP ( #30577 )
2017-09-21 14:48:51 +01:00
dteach
ca56a248d8
junos_facts: Add Hardware facts. ( #30304 )
...
* Add Routing Engine Facts
- Map routing engine output information to routing_engines facts dict.
- Add fact 'has_2RE', which is a quick way to determine how many REs
the chassis has.
* Fix a typo
* Fix more typos
* Add slot number to routing_engine dict
* Add facts about the installed chassis modules
* Fix typo
* Fixed another typo
* Fix Path
* Change path again.
* More Typos
* Add some deubgging
* Add additional information for hardware components.
- Return information about the Routing Engines.
- Return a fact to easily determine if the device
has two routing engines.
- Return information about the hardware modules.
* Addressed pep8 stardard failures.
* Add unit test fixtures.
* Rename fixture.
* Fix unit test failures.
- Rename the fixture file to what the unit test expects.
- Strip out junos namespace attributes.
Rename file to match what the unit test expects.
* Scrubbed the routing engine serial numbers.
* Add unit test facts for new tests.
- Add unit test for ansible_net_routing_engines fact
- Add unit test for ansible_net_modules fact
- Add unit test for ansible_net_has_2RE
* Fixed spacing.
2017-09-20 12:43:07 +05:30
David Mahler
d395166ae0
Vyos correction ( #30605 )
2017-09-20 11:57:18 +05:30
Trishna Guha
ae044f507f
fix nxos_reboot command format ( #30549 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-09-20 10:06:57 +05:30
Trishna Guha
e308176f3e
fix write_on_file nxos_snapshot ( #30545 )
...
* fix write_on_file nxos_snapshot
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* some more logic
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-09-20 10:06:38 +05:30
Matt Clay
7714dcd04e
Enable more pylint rules and fix reported issues. ( #30539 )
...
* Enable pylint unreachable test.
* Enable pylint suppressed-message test.
* Enable pylint redundant-unittest-assert test.
* Enable pylint bad-open-mode test.
* Enable pylint signature-differs test.
* Enable pylint unnecessary-pass test.
* Enable pylint unnecessary-lambda test.
* Enable pylint raising-bad-type test.
* Enable pylint logging-not-lazy test.
* Enable pylint logging-format-interpolation test.
* Enable pylint useless-else-on-loop test.
2017-09-18 23:20:32 -07:00
Toshio Kuratomi
c82cf791dd
Add a code-smell test for smart quotes and remove smart quotes from all files
2017-09-18 16:49:16 -07:00
Nathaniel Case
7dc60c3f24
nxos_install_os install_state fix
2017-09-15 15:34:32 -04:00
Kedar K
ff84fc969c
Fixes nxos_pim_rp_address module idempotence ( #29620 )
...
* Fixes nxos_pim_rp_address module idempotence
* * Adds a note in header comment to indicate no support for absent state
2017-09-15 14:21:34 -04:00
Mike Wiebe
9af6dc4751
Fix nxos_snmp_community idempotence issue ( #30388 )
...
* Fix nxos_snmp_community idempotence issue
* Use passed in name to filter
* Test updates and remove unused method
2017-09-15 07:45:51 -07:00
Mike Wiebe
173c41aefe
Rel240/fix nxos pim interface ( #29885 )
...
* fix nxos_pim_interface
* Add integration test coverage and fix unit test
* Add clarifying comments
* Make ansibot happy
2017-09-14 13:36:32 -07:00
Ganesh B. Nalawade
8c3bf20a13
Use safe_load to load yaml
...
Replad `yaml.load` with `yaml.safe_load`
2017-09-14 11:19:00 -07:00
Mike Wiebe
3faba93a2b
Fix nxos_interface error for nxapi and idempotence problem ( #29136 )
...
* Fix nxos_interface nxapi error and idempotence
* Make shippable happy
2017-09-14 10:25:35 -07:00
rahushen
37f68bffc0
fixes #27177 - nxos_aaa_server_host multiple issues ( #29103 )
2017-09-14 09:29:53 -07:00
John R Barker
4c9ad00c50
Specify default delay (DOCUMENTATION only change) ( #30344 )
...
* Specify default delay
Also clarify that tx_rate is in bps
* aggregates -> aggregate
2017-09-14 11:42:20 +01:00
Ganesh Nalawade
3ff527b1d2
Fixes #30281 eos_banner integration test failure ( #30283 )
...
* Fixes #30281 Configure login prompt for eos_banner
* Fix unit test
* Fix pep8 issue
2017-09-14 13:56:32 +05:30
saichint
4e32c92166
nxos_udld_interface: improve interface detection ( #28682 )
...
* fix for nxos_udld_interface
* Tested Note added back
2017-09-13 11:06:56 -07:00
Nathaniel Case
8c03609e54
nxos_snmp cleanup ( #28922 )
...
* Clean up nxos_snmp_contact & nxos_snmp_location
* Bring nxos_snmp_community in line
* Bring nxos_snmp_host in line
* And I would have gotten away with it too,
if it weren't for those meddling sanity tests
* Bring nxos_snmp_traps & nxos_snmp_user in line
* Appease Shippable
2017-09-13 08:23:36 -07:00
rahushen
1a266e29a7
Fixes #28793 , #27484 ( #29745 )
2017-09-13 08:08:22 -07:00
rahushen
169fbc4c94
Fixes #28493 ( #29061 )
2017-09-13 08:00:13 -07:00
rahushen
5537218c94
fixes #27066 - nxos_acl errors when there are 0 or 1 access lists configured ( #29076 )
...
* fixes #27066
* replace type() with isinstance()
2017-09-13 18:07:06 +05:30
rahushen
f1cc5a928c
Fixes #27336 - nxos_gir_profile_management issue while creating profile ( #29151 )
...
* Fixes #27336
* Correct documentation errors
2017-09-13 17:54:35 +05:30
Mike Wiebe
7292dd20ed
Fix nxos_overlay_global networking modules ( #28943 )
2017-09-13 17:33:06 +05:30
rahushen
bc6e015a86
Fixes #27138 ( #29064 )
2017-09-13 17:11:00 +05:30
Trishna Guha
578ae3b238
fix nxos_file_copy and provider getting set to None when transport is cli ( #30262 )
...
* nxos_file_copy bug fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* provider gets set to None in module level when transport is cli
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-09-13 16:36:41 +05:30
Ganesh Nalawade
d8371cec91
Fix ios_system lookup enable issue ( #30263 )
...
Fixes #29974
Add `None` check while comparing module parameter values (want) with the actual
configuration present on device (have).
2017-09-13 15:19:09 +05:30
Matt Clay
442af3744e
Miscellaneous pylint fixes.
...
The following rules are no longer disabled:
- bad-format-string
- duplicate-key
- lost-exception
- trailing-newlines
- unexpected-keyword-arg
- useless-suppression
- using-constant-test
2017-09-13 01:53:08 -07:00
Mike Wiebe
cef7ed0310
Fix nxos_mtu nxapi failure ( #30153 )
2017-09-13 10:51:46 +05:30
Jacob McGill
2489eeece0
ACI EPG TO DOMAIN: Add vm_provider docstring and add support for micr… ( #29114 )
...
* ACI EPG TO DOMAIN: Add vm_provider docstring and add support for microsoft and openstack
* Fix typo
* Fix whitespace
2017-09-12 22:53:17 +01:00
Mike Wiebe
f973f93963
Fix nxos_smu error ( #30157 )
2017-09-12 22:17:07 +01:00
Trishna Guha
5b1c91bf19
nxos_system parse name_servers fix ( #29944 )
...
* nxos_system parse name_servers fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix nxos_system tests
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-09-12 13:25:01 +05:30
Matt Clay
68aeaa58a8
Fix dangerous default args. ( #29839 )
2017-09-12 00:11:13 -07:00
Ganesh Nalawade
5caa47feb9
Add port and host check for neighbor args in junos_interface ( #29941 )
2017-09-12 11:16:20 +05:30
Tim Rupp
74ace093b8
Renames the bigip_configsync_actions module ( #29747 )
...
Retains the old name by making a symlink. We can remove it in a later
release.
2017-09-12 05:53:44 +01:00
Tim Rupp
a36ebd979d
Adds missing docs and downstream fixes ( #29664 )
...
Partition docs are not a documentation fragment, so they need to
be added
2017-09-11 23:30:34 +01:00
Jonathan Karras
e5d247fdc0
Fixes #20443 - Adjust version checking regex to account fo no comma in IOS-XE ( #29157 )
...
* Adjust version checking regex to account fo no comma in IOS-XE
* Adjusted regex to include last character of version number
2017-09-11 07:08:12 -07:00
Toshio Kuratomi
6797221107
Romain dartigues fixes ( #29169 )
...
* cloud: azure: fix typo introduced in commit 16d23e9
The commit "Add reference to VNET resource group (#26052 )"
removed an used variable.
* network: aos: error hint never shown
2017-09-09 16:20:53 -07:00
Trishna Guha
588bddbc35
nxos_banner CI fix ( #29134 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-09-08 19:33:41 +05:30
Ganesh Nalawade
772dab55c6
Add check for port and host in ios_interface ( #29119 )
...
Fixes #29118
2017-09-08 09:10:38 +05:30
Ganesh Nalawade
0b2619ff2b
Add lldp neighbor intent argument for vyos_interface ( #29092 )
...
* Add lldp neighbor intent argument for vyos_interface
* Add version_added info for neighbor argument
* Fix CI issue
2017-09-08 08:28:43 +05:30
Ricardo Carrillo Cruz
f9f0472ba5
Ignore routes that are not static manually added ( #29094 )
...
Fixes #28841
2017-09-07 17:56:09 +02:00
Ganesh Nalawade
49658f9437
Add lldp nighbors intent arg support for junos_interface ( #29057 )
...
* Add lldp neighbor state arg for junos_interfaces
* minor change
2017-09-07 12:01:40 +05:30
Nathaniel Case
f84ff216b6
Generalize nxos_bgp event-history detection ( #28890 )
...
* More general handling of event-history
* Update unit tests
2017-09-06 17:37:44 -04:00
Ganesh Nalawade
3b6b004570
Add support for neighbor argument in ios_interface ( #29035 )
...
Add missing support for lldp neighbor argument in ios_interface
2017-09-06 10:15:02 +05:30
marinus81
d69c803353
Fixed typo in resolution_immediacy values dict
2017-09-05 09:10:45 -07:00
Dag Wieers
a200ecf966
aci_rest: Accept YAML input and validate content input
...
This PR includes:
- Accept inline YAML, YAML string, inline JSON, JSON string input and
XML string input
- Validate YAML, JSON and XML input
2017-09-05 00:59:15 -07:00
Dag Wieers
a796391c9b
aci_rest: Implement idempotency
...
This PR includes:
- A new function to modify query strings in URLs
- Add rsp-subtree=modified to post/delete requests
- Test the ACI response for changes and report back
- Return the used URL back to the user
- Remove check-mode support (as it was non-functional anyway)
- Fix a bug related to method=delete and not having content set
This fixes datacenter/aci-ansible#111
2017-09-05 00:17:35 -07:00
Ganesh Nalawade
cc9ed352dd
Ensure proper conversion while backing up of junos config ( #28958 )
...
* Ensure proper conversion while backing up of junos config
* Minor changes
* Fix review comment
* Open config backup file in binary mode
2017-09-04 20:12:11 +05:30