e9bf046c26
Check mode fixes for ec2_vpc_net module ( #2179 )
...
* Check mode fixes for ec2_vpc_net module
Returns VPC object information
Detects state change for VPC, DHCP options, and tags in check mode
* Early exit on VPC creation in check mode
2016-12-08 11:24:47 -05:00
0b95051039
Fix #2526 ( #2527 )
...
Fail on unhandled exception in ec2_asg rather than raise
2016-12-08 11:24:47 -05:00
66f1f6d537
Check mode fix for ec2_group module ( #2184 )
...
The default VPC egress rules was being left in the egress rules for
purging in check mode. This ensures that the module returns the correct
change state during check mode.
2016-12-08 11:24:47 -05:00
be33879152
Fixes #4227 : just changing messaging
2016-12-08 11:24:46 -05:00
eae75cf727
Fix #3549 , failure to reference `module` in `ec2_eip` module
2016-12-08 11:24:46 -05:00
f57ece661f
Remove file extension from policy names ( #3805 )
...
Fixes #3804 .
Prevents `__file__` from contributing ".", which is an illegal character in ELB policy names.
2016-12-08 11:24:46 -05:00
4fad93561a
please remove me as maintainer
2016-12-08 11:24:46 -05:00
d6cc007380
Fixes #4227
2016-12-08 11:24:46 -05:00
f5c3f4dd6b
Update docs to indicate ec2_asg state defaults to present ( #4046 )
...
* Update docs to indicate ec2_asg state defaults to present
Hopefully fixes Issue #4016
* Forgot to flip required to false
2016-12-08 11:24:46 -05:00
7b8d625546
Make ec2_elb_lb respect VPCs when resolving groups
...
AWS security groups are unique by name only by VPC (Restated, the VPC
and group name form a unique key).
When attaching security groups to an ELB, the ec2_elb_lb module would
erroneously find security groups of the same name in other VPCs thus
causing an error stating as such.
To eliminate the error, we check that we are attaching subnets (implying
that we are in a VPC), grab the vpc_id of the 0th subnet, and filtering
the list of security groups on this VPC. In other cases, no such filter
is applied (filters=None).
2016-12-08 11:24:46 -05:00
3b32b60338
Remove trailing white space
2016-12-08 11:24:46 -05:00
04199140c5
Make group_name resolution VPC aware
...
EC2 Security Group names are unique given a VPC. When a group_name
value is specified in a rule, if the group_name does not exist in the
provided vpc_id it should create the group as per the documentation.
The groups dictionary uses group_names as keys, so it is possible to
find a group in another VPC with the name that is desired. This causes
an error as the security group being acted on, and the security group
referenced in the rule are in two different VPCs.
To prevent this issue, we check to see if vpc_id is defined and if so
check that VPCs match, else we treat the group as new.
2016-12-08 11:24:46 -05:00
531954e2f6
Enforce boolean type for dup_ok
...
Stop "choices" from being interpreted as strings.
2016-12-08 11:24:45 -05:00
4d952d6e6e
Add CAPABILITY_NAMED_IAM to cloudformation capabilities
...
While from the documentation[1] one would assume that replacing
CAPABILITY_IAM with CAPABILITY_NAMED_IAM; this as empirically been shown
to not be the case.
1: "If you have IAM resources, you can specify either capability. If you
have IAM resources with custom names, you must specify
CAPABILITY_NAMED_IAM."
http://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_CreateStack.html
2016-12-08 11:24:45 -05:00
3818cc2b95
fixes issues where iam_policy incorrected reported changed
2016-12-08 11:24:45 -05:00
4a8a052e2e
Improve documentation on security_groups-option
2016-12-08 11:24:44 -05:00
28716f565c
Add default port for aurora ( #4102 )
...
If a port isn't specified, it's looked up. The lookup breaks without
this.
Related: https://github.com/ansible/ansible-modules-core/pull/3414
2016-12-08 11:24:42 -05:00
d4cec5ccc1
Remove double-assignment of EC2 parameters ( #4081 )
...
The `source_dest_check` and `termination_protection` variables are being
assigned twice in ec2.py, likely due to an incorrect merge somewhere
along the line.
2016-12-08 11:24:40 -05:00
cf9bfc3459
Fix for #16518 - added missing regions
2016-12-08 11:24:40 -05:00
a2e6ac6ca8
IAM group modules need `module` passed
...
The IAM group modules were not receiving the `module` object, but they
use `module.fail_json()` in their exception handlers. This patch passes
through the module object so the real errors from boto are exposed,
rather than errors about "NoneType has no method `fail_json`".
2016-12-08 11:24:39 -05:00
49f9404cd2
Add s3_url requirement in doc when rgw support is enabled in s3.py
...
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
2016-12-08 11:24:38 -05:00
6346cad9d0
Add proper version_added for rgw option in s3.py
...
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
2016-12-08 11:24:38 -05:00
0b156aae16
Add Ceph RGW S3 compatibility
...
Ceph Object Gateway (Ceph RGW) is an object storage interface built on top of
librados to provide applications with a RESTful gateway to Ceph Storage
Clusters:
http://docs.ceph.com/docs/master/radosgw/
This patch adds the required bits to use the RGW S3 RESTful API properly.
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
2016-12-08 11:24:38 -05:00
0c7ec1e860
Fixes incorrect key name protocols -> protocol ( #3963 )
2016-12-08 11:24:38 -05:00
53a22ce93a
Finish python3 syntax compilation fixing for core repo
2016-12-08 11:24:37 -05:00
17985f9917
added missing colons to documentation ( #3913 )
2016-12-08 11:24:36 -05:00
81e7720f62
Iam trust policy ( #3885 )
...
* added support for trust policies
* added version_added to new params in DOC string
* update version_added on new iam args to 2.2
2016-12-08 11:24:36 -05:00
be6ce922a6
Add an example to delete Route53 alias record set ( #3834 )
2016-12-08 11:24:35 -05:00
cf31b4d8b5
Add support for PostgreSQL 9.5 in rds_param_group (fix for #3846 )
2016-12-08 11:24:35 -05:00
97917121a6
Paginate the results from `boto.iam`
...
The default pagination is every 100 items with a maximum of 1000 from
Amazon. This properly uses the marker returned by Amazon to concatenate
the various pages from the results.
This fixes #2440 .
2016-12-08 11:24:34 -05:00
585003c546
Prevent ec2group from deleting sgs during check_mode runs
2016-12-08 11:24:34 -05:00
3fa745eef9
Fixing error exception handling for python3. Does not need to be compa… ( #3840 )
...
* Fixing error exception handling for python. Does not need to be compatible with Python2.4 b/c boto is Python 2.6 and above.
* Fixing error exception handling for python. Does not need to be compatible with Python2.4 b/c boto is Python 2.6 and above.
* Fixing compile time errors IRT error exception handling for Python 3.5.
This does not need to be compatible with Python2.4 b/c Boto is Python 2.6 and above.
2016-12-08 11:24:34 -05:00
1573066ec1
Fixing error exception handling for python. Does not need to be compatible with Python2.4 b/c boto is Python 2.6 and above. ( #3839 )
2016-12-08 11:24:33 -05:00
adec050165
Add MariaDB to valid RDS engines ( #3337 )
...
* Add MariaDB to valid RDS engines
* Update RDS module documentation
2016-12-08 11:24:32 -05:00
375884464e
Add an example for SRV record in route53 ( #3749 )
2016-12-08 11:24:31 -05:00
9167abdd10
Fix S3 unavailable region error
...
This is to address this error:
fatal: [site]: FAILED! => {"changed": false, "failed": true, "msg": "Failed to connect to S3: Region does not seem to be available for awsmodule boto.s3. If the region definitely exists, you may need to upgrade boto or extend with endpoints_path"}
Commit 0dd58e9 changed the logic so an exception is thrown (by
`connect_to_aws`) before the `s3 is None` check is performed. This
changes the `None` check to a catch so the old logic can compensate.
2016-12-08 11:24:30 -05:00
cd09aab9b4
Unindenting the delete to user ( #3147 )
2016-12-08 11:24:30 -05:00
962a446238
Allow users to pick AWS Aurora as an RDS engine ( #3414 )
...
Per the [RDS docs](http://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_CreateDBInstance.html ),
add `aurora` as a valid DB engine.
2016-12-08 11:24:30 -05:00
c053fa5378
Do not expect the elb to have policies or instances. Fixes #3593 ( #3595 )
2016-12-08 11:24:30 -05:00
963cb64337
Add option to make RDS param groups for the MySQL 5.7 engine family. ( #3695 )
2016-12-08 11:24:30 -05:00
20e86d1062
Add path type to argument_spec where applicable ( #3040 )
2016-12-08 11:24:30 -05:00
ff1c591c3e
Allow create_iam_role to return an additional value of role_result and ( #2418 )
...
instance_profile_result, in addition to the existing role list and change value
2016-12-08 11:24:29 -05:00
82cefd7ce1
Added restart functionality to ec2.py
2016-12-08 11:24:26 -05:00
d13046a905
ansible-validate-modules part 4: Enable check on ansible-modules-core ( #3526 )
...
* Call ansible-validate-modules
* Correct quotes + add newline
2016-12-08 11:24:26 -05:00
7dc0dcc59e
Add missing periods to description items.
...
Current theme used by docs.ansible.com displays description items on one line. Adding periods helps readability.
2016-12-08 11:24:25 -05:00
fdcc1fe763
clarified docs on overwrite
2016-12-08 11:24:25 -05:00
52edeeca4c
Fix capitalization of AWS in ec2_lc module documentation
2016-12-08 11:24:24 -05:00
0fcc2d8973
Add more example on how to use module ec2_tags to list tags on an ins… ( #3530 )
...
* Add more example on how to use module ec2_tags to list tags on an instance
* Add more example on how to use module ec2_tags to list tags on an instance
2016-12-08 11:24:24 -05:00
3775d8e684
Extend example to demonstrate usage of ephemeral disks. ( #3550 )
2016-12-08 11:24:24 -05:00
b8204774dd
Support tagging ELBs using boto 2.0. ( #2844 )
2016-12-08 11:24:20 -05:00
4e08f94a34
corrected return docs sample
2016-12-08 11:24:20 -05:00
404f07af8e
Added improvements and documented return structure ( #2320 )
2016-12-08 11:24:19 -05:00
87946920d8
Fix an issue where by a call to ec2.get_image wasn't wrapped in a try/except, and would occasionally throw an exception in the wild. Also greatly simplifies two of the ugliest known loops to man down into a single loop. ( #2554 )
2016-12-08 11:24:19 -05:00
70b0891f95
Fix UnboundLocalError if 'access_key_ids' not supplied
...
'key_ids' is referenced before it is assigned, causing the module to fail with a UnboundLocalError instead of failing gracefully with a helpful error message. This very small patch moves the assignment of 'key_ids' to before the variable is referenced.
2016-12-08 11:24:19 -05:00
c3ebc84689
rebase for #2477 , ready_for_review ( #2581 )
2016-12-08 11:24:18 -05:00
1db444cdc2
Add exponential backoff retries to ec2_elb_lb ( #3379 )
...
ec2_elb_lb doesn't react well to AWS API throttling errors. This
implements an exponential backoff operation around some of the AWS API
calls (with random jitter, in line with AWS recommendations) to make
this more resilient.
2016-12-08 11:24:18 -05:00
0494dced3a
Fixes read replica create BC break ( #3365 )
2016-12-08 11:24:17 -05:00
42d784c24b
Added ap-northeast-2 region ( #2849 )
2016-12-08 11:24:17 -05:00
5a48a2e93e
Fix to ensure youngest snapshot is retrieved rather than oldest ( #3115 )
2016-12-08 11:24:17 -05:00
5b8d209b7e
Speed up AMI code by not attempting to create the AMI without checkin… ( #2551 )
...
* Speed up AMI code by not attempting to create the AMI without checking on the name first. Also simplifies code for reporting errors from AMI creation, greatly.
* remove sys.exit
2016-12-08 11:24:17 -05:00
ea57d8b005
Check if identifier is specified for geo,weighted or failover routing. Don't fail if record set already exist. Set choices for failover - capital PRIMARY and SECONDARY. ( #2470 )
2016-12-08 11:24:17 -05:00
02f737cdee
Fix and add more error handling for role policies
...
In case role policy was deleted, we did not handle at all if there
was authorization issue to do the deletion. Also add message when
role is not found and the policy is skipped.
2016-12-08 11:24:16 -05:00
ff755da1e5
fixed doc quoting
2016-12-08 11:24:15 -05:00
37513ca8bb
corrected required docs as only boolean is allowed
...
these complex values were not displayed and would always show the fields as requried
2016-12-08 11:24:15 -05:00
51e3c6c49b
Guard against too old boto library
...
route53 creates Record objects using `health check` and `failover`
parameters. Those parameters only became available in boto 2.28.0.
As some prominent LTS Linux releases (e.g.: Ubuntu 14.04) only ship
older boto versions (e.g.: 2.20.1 for Ubuntu 14.04), users are getting
unhelpful error messages like
TypeError: __init__() got an unexpected keyword argument 'health_check'
when running Ansible 2 against their LTS install's default boto.
We improve upon this error message by checking the boto version
beforehand.
Fixes ansible/ansible#13646
2016-12-08 11:24:14 -05:00
50622b4e6a
fix aws elasticache idempotency
2016-12-08 11:24:14 -05:00
dadf835a06
Remove access_key and secret_key as these are provided by aws doc fragment Remove ec2 doc fragment as region is not required for IAM
2016-12-08 11:24:14 -05:00
7c5b4b142a
Doing exponential backoff on route53 upon AWS throttling
2016-12-08 11:24:14 -05:00
d035961d1c
added version added
2016-12-08 11:24:13 -05:00
8c6741b2bb
fix typo in documentation
...
let's -> lets
2016-12-08 11:24:13 -05:00
b5fb47e28e
Fixed typo json_fail to fail_json
2016-12-08 11:24:13 -05:00
eaa7e717a2
Fixes #2039 Convert None to 0 when checking if ELB cookie expiration has changed
2016-12-08 11:24:12 -05:00
f24c3fb40e
Clarified IAM module doc
2016-12-08 11:24:12 -05:00
83039b93f0
Fix for issue #3109 : Executing ec2_group with rules fails with "Invalid rule parameter '['"
2016-12-08 11:24:11 -05:00
b891b0c9bc
ELB Proxy Protocol support for backends
2016-12-08 11:24:11 -05:00
e3de705d0c
Allow us to sort by all available datatypes
2016-12-08 11:24:11 -05:00
b61d531dfc
corrected typo on aws connection arguments var
2016-12-08 11:24:10 -05:00
33079b2b7f
Treat 'is_public' option as a bool
2016-12-08 11:24:10 -05:00
1cace51ed6
Bugfix: Permit SOA record type
2016-12-08 11:24:09 -05:00
2fa3f16012
Indented code so it only executes tag comparison for matching cird values
2016-12-08 11:24:09 -05:00
52accd7d1f
Use connect_to_aws where possible
...
`connect_to_aws` fixes a bug with security tokens in AWS.
Modules should use that rather than calling
`boto.x.connect_to_region`
2016-12-08 11:24:09 -05:00
7f338e13ff
Updated ec2_lc docs
2016-12-08 11:24:08 -05:00
3dde5196aa
Added explicit type for 'tags' option
2016-12-08 11:24:08 -05:00
94345349a6
Fixing issue #3057 - AttributeError: 'str' object has no attribute 'items'
2016-12-08 11:24:07 -05:00
ba2bc1dbfe
Fixing missing interpolation variable
2016-12-08 11:24:07 -05:00
f26199d962
replaced sudo with become
2016-12-08 11:24:06 -05:00
aaf762573e
Various simple linting type cleanups on modules
2016-12-08 11:24:06 -05:00
56f1d6f794
Less engrish
2016-12-08 11:24:04 -05:00
7234ead259
Update ec2.py
...
Documentation is not clear that tag used in count_tags must be an existing instance_tag
2016-12-08 11:24:04 -05:00
8769c33e46
changing default of cache_security_groups to none, removing the ['default']
...
OCD is making me fix the inconsistency with how None is typed. First Letter Capitalized All Over Now.
cleaning up the default object that was created for the cache_security_groups and removing checks dealing with it.
clean up space
Changing default cache_security_groups from [default] to None.
2016-12-08 11:24:02 -05:00
f6aa1ff9a4
Remove duplicate documentation fields
2016-12-08 11:24:01 -05:00
12be401c11
The parameters 'template' and 'template_url' are incorrectly required in all cases.
...
If the state is 'absent' they should not be required. A few lines below the correct check is already in place.
2016-12-08 11:24:01 -05:00
896dcd9787
Fixed typo in example playbook
2016-12-08 11:24:00 -05:00
a0204b80dc
tabs are bad
2016-12-08 11:24:00 -05:00
68f76c50d8
Remove explicit region parameter from ec2_ami_find
2016-12-08 11:24:00 -05:00
18ff22348a
fixed grammatical issue in iam.py. exit -> exist.
2016-12-08 11:24:00 -05:00
b9b08666f5
Fix iam_policy pdoc variable
2016-12-08 11:24:00 -05:00
a2f4d46c9b
updating choices for rds parameter engines
2016-12-08 11:24:00 -05:00
efbdea909e
Simplify logic around "present" state and skip dupes. If the policy doesn't exist or the policy document doesn't match or if we're not skipping dupes, then we go ahead and update the respective user/group/role policy.
2016-12-08 11:23:59 -05:00
c2e62ed9a9
Fix misspelling of the word 'certificate'
2016-12-08 11:23:59 -05:00
6e73c61298
added version_added
2016-12-08 11:23:59 -05:00
f36c567022
Added delete_on_termination option for volume attachment
2016-12-08 11:23:59 -05:00
2dd53a8d91
updated s3 module documentation
2016-12-08 11:23:59 -05:00
f50fbe9dd2
updated s3 docs to reflect mode choices
...
fixes #2318
2016-12-08 11:23:58 -05:00
90631aef1b
1113 fix ec2 subnet tags
2016-12-08 11:23:58 -05:00
a5e4969dc4
updated version_added
2016-12-08 11:23:58 -05:00
267dcc8eb6
Add wait_timeout option to route53 module
...
This option is used to make sure the module does not block forever.
2016-12-08 11:23:58 -05:00
e91bcba078
Add wait option to route53 module
...
This option makes the module wait for the changes to replicate to all
Amazon DNS servers.
2016-12-08 11:23:58 -05:00
cfed7e11d8
two choices for cache engine. adding them.
...
revert spacing
undoing quotes around default. will do another pull requests
Making documentation more explicit for elasticache engine choices.
2016-12-08 11:23:58 -05:00
c680611fe4
Fix `self.changed` value in `ElbManager` (ec2_elb_lb)
2016-12-08 11:23:57 -05:00
351de21ee7
made port default depending on db engine
2016-12-08 11:23:57 -05:00
1fe3387971
crrected version added
2016-12-08 11:23:57 -05:00
d0e37fa542
return allocation id for vpc address.
2016-12-08 11:23:56 -05:00
a01fe88263
staging that num_nodes is required when state=present
2016-12-08 11:23:56 -05:00
1367e73c94
be smarter when dealing with policy_json input
...
Now module will assume that if the argument is a string it is already formated as json
and will only try to convert non strings into json string.
Also removed unused 'msg' var declarations and the ifs that set them
fixes #2009
2016-12-08 11:23:56 -05:00
eba78d08f9
Update to wait and wait_timeout with a maximum of 10 minutes timeout
2016-12-08 11:23:55 -05:00
cd3f306518
Proposing a wait_for function to ensure elb has been successfully removed
2016-12-08 11:23:55 -05:00
f20b09e2ec
Add evaluate taget health for alias based records
2016-12-08 11:23:55 -05:00
444895f889
Update to ec2_vpc.py to: 1 allow interface ids and vpc peering connections as route targets 2 set state to "terminated" when VPC is removed 3 fix some comment typos
...
updates per PR comments
2016-12-08 11:23:54 -05:00
2af105bcbc
Convert enabled value to boolean to actually work, make sure we can set expiration period to 0(None) to disable it
2016-12-08 11:23:53 -05:00
9259b51c97
updated module docs, added choices to state
2016-12-08 11:23:53 -05:00
325a979876
Set the argument type for ec2_vol's encrypted parameter
...
If this is not set, Ansible parses the parameter as a string.
This is fine if the parameter is not provided by the caller, but
if it is set to False or True explicitly, ec2_vol receives this as
the string 'False' or the string 'True', both of which are truthy.
Thus, without this fix, setting the parameter results in encryption
always enabled.
2016-12-08 11:23:52 -05:00
7c8d3d9b20
Example of single instance with ssd gp2 root volume creation
2016-12-08 11:23:50 -05:00
6cb1606005
Don't raise or catch StandardError in amazon modules
2016-12-08 11:23:50 -05:00
bef2b75857
Update in Amazon IAM Policy Documentation
...
There were typos in the documentation that made the examples seem misleading of what was being demonstrated. This update fixes that.
2016-12-08 11:23:49 -05:00
fba26fda1c
Fix ec2_snapshot documentation
...
last_snapshot_min_age is added in 2.0, not 1.9
2016-12-08 11:23:49 -05:00
086038cb4f
Fix rds "promote" command never promoting
...
Previously, the `promote` command in the `rds` module would always return OK and never actually promote an instance. This was because `promote_db_instance()` had its conditions backwards: if the instance had the `replication_source` attribute indicating that it **was** a replica, it would set `changed = False` and do nothing. If the instance **wasn't** a replica, it would attempt to run `boto.rds.promote_read_replica()`, which would always fail.
2016-12-08 11:23:49 -05:00
88f221fd9f
Update ec2.py remove state tag
...
'exact_count' and 'state' are mutually exclusive options they should not be in the following examples:
- # Enforce that 5 running instances named "database" with a "dbtype" of "postgres" example and
- # Enforce that 5 instances with a tag "foo" are running
2016-12-08 11:23:49 -05:00
a90de29ceb
Minor simplification of code
2016-12-08 11:23:49 -05:00
2efb97e9d5
corrected version_added, removed empty alias
2016-12-08 11:23:49 -05:00
f7dfcc153e
Fail if any group name is not resolved to an ID.
2016-12-08 11:23:48 -05:00
5c7f72233f
Fixes #822
2016-12-08 11:23:48 -05:00
f0156dda0d
Fixed error message: TypeError: fail_json() takes exactly 1 argument (2 given)
2016-12-08 11:23:48 -05:00
0425d6be39
fixed break order
2016-12-08 11:23:48 -05:00
0bf5fa1c23
Update ec2_elb_lb.py
2016-12-08 11:23:48 -05:00
d3029a6059
Save changes of special characters to rset, without that comparison rset.to_xml() == wanted_rset.to_xml() will fail if record contains * or @ characters.
2016-12-08 11:23:48 -05:00
3c7787c05c
It may be string with int comparison, if ansible user specifies identifier as int
2016-12-08 11:23:48 -05:00
502717d387
Add rds restore example to list of examples
...
There was no db restore example. I've provided one that shows how to do the restore, then add a security group (you cannot add the security group during the restore step -- it has to be done in a modify step afterward). Also, I show how to get the endpoint.
2016-12-08 11:23:48 -05:00
8eb04fe0d3
Squash of 3 commits for bugfix.
...
Absent unction was not working on user with login profile
also fixed the exception handling
fixed the delete user function
now works with or without loginprofile (password)
typo
2016-12-08 11:23:47 -05:00
4c08545974
Absent unction was not working on user with login profile also fixed the exception handling
2016-12-08 11:23:47 -05:00
7517e6366e
use marker instead of is_truncated which does not seem to work
2016-12-08 11:23:47 -05:00
90d084d82b
loop to get all load balancers, boto limited to 400 at a time fixes #2115
2016-12-08 11:23:47 -05:00
35e6684163
Mark this as a string so it is rendered in the docs
...
When this was treated as a boolean, sphinx was leaving the Default
column on http://docs.ansible.com/ansible/ec2_module.html blank,
implying it would use AWS's default. In reality, it passes False, which
overrides the defaults at AWS (it's possible to boot an instance which
AWS claims will always have EBS optimization without it because of this
silently passed False).
2016-12-08 11:23:46 -05:00
c0d135e44c
Allow iam_policy to maintain idempotentce if the role referenced has been removed
2016-12-08 11:23:46 -05:00
6bc4c877fc
remove unneeded aliases
2016-12-08 11:23:46 -05:00
f90bcfee1f
add idle_timeout support
2016-12-08 11:23:46 -05:00
4a8bd74f52
Added launch group support for ec2 module
2016-12-08 11:23:46 -05:00
66a4cb5c13
Make cache_parameter_group the name of this new param to match with similar params (leave old name as an alias)
2016-12-08 11:23:46 -05:00
a692b2e4af
Revert "Expose cache_parameter_group_name in elasticache module"
...
This PR #1950 implements duplicate functionality to #1353
This reverts commit b04efa22c4403ca869e94e7918721306d23afa8d.
Conflicts:
cloud/amazon/elasticache.py
2016-12-08 11:23:46 -05:00
4d74c1d508
added missing version added
2016-12-08 11:23:46 -05:00
248ea2deea
Remove @ralph-tice from maintainership per his request
2016-12-08 11:23:45 -05:00
1c0b231e29
Clarity of owner, even though module is deprecated
2016-12-08 11:23:45 -05:00
742b452dc1
@lorin stepping down as maintainer
2016-12-08 11:23:45 -05:00
9cb4388f9e
Add state=running on some ec2 examples
...
`state=running` was missing in some of the ec2 module examples
2016-12-08 11:23:45 -05:00
3ad19e75cc
Expose cache_parameter_group_name in elasticache module
...
The cache_parameter_group_name was not previously exposed in
elasticachy.py, I have exposed it, as optional.
2016-12-08 11:23:45 -05:00
63c8c40a37
Update try statement as pointed out by defionscode
2016-12-08 11:23:42 -05:00
a5d95b4047
Another fix for docs
2016-12-08 11:23:42 -05:00
ac58ef1404
Correct docs build
2016-12-08 11:23:42 -05:00
55afa7e944
Added documentation for returned structure
2016-12-08 11:23:42 -05:00
9fe689eaec
fixes #12831 by updating the boto iam connection method to connect_to_region
2016-12-08 11:23:42 -05:00
aa887ce49f
Included 'block_device_mapping' in the output of module and other missing attributes
2016-12-08 11:23:42 -05:00
9f503540f1
added missing version_added to new accesslogs feature
2016-12-08 11:23:42 -05:00
28749a794a
added note on when reboot command became available fixes #2050
2016-12-08 11:23:41 -05:00
295a28e128
Docs: remove redundant quotes in ec2_elb docs
2016-12-08 11:23:41 -05:00
c340587bb8
Docs: add state choices to ec2_elb_lb
...
add state options (`present` and `absent`) to `ec2_elb-lb` doc
2016-12-08 11:23:41 -05:00
0b294d69c5
Remove duplicate logic
2016-12-08 11:23:41 -05:00
9ee13c4e55
Add region to doc and handle missing region parameter
2016-12-08 11:23:40 -05:00
11c0be06fb
Update ec2_vol.py
...
Changed=true now reported on new volume.
Only detach volume when instance is specified as 'None' or '' rather than whenever instance is not specified at all
Fix regression caused by 6b27cdc where by no volume is created if id or Name is not supplied
Remove unnecessary empty aliases
Corrected example to use acceptable parameter for ions
Added exception handling to get_all_instances call
Moved the attachment state validation code to attach_volume function rather than create_volume function
Refactored attach_volume and detach_volume so that changed state can be passed back to call
Created get_volume_info function so that state=present and state=list can return the same data. Also added instance_id as a returned value in attachment_set dict
Updated aws connection method so that boto profile can be used
2016-12-08 11:23:40 -05:00
7dd5ec5373
Added deleteOnTermination in the output of list option
2016-12-08 11:23:40 -05:00
e9071c62ba
Add missing variable initializations
...
Without this, «ec2: state=stopped instance_ids=…» would fail with a
traceback like this:
if inst.get_attribute('sourceDestCheck')['sourceDestCheck'] != source_dest_check:
NameError: global name 'source_dest_check' is not defined
2016-12-08 11:23:40 -05:00
5872e0a493
Update ec2_asg.py
2016-12-08 11:23:40 -05:00
ed3d248234
Move import statements for easier debugging (correct line numbers)
2016-12-08 11:23:40 -05:00
61af70c087
Set default of dimensions parameter to be empty dict
2016-12-08 11:23:39 -05:00
11dbd985b6
Fix error on ec2 status change
...
Both `source_dest_check` and `termination_protection` variables are not
available within the scope of the startstopec2 instance method. This just
pulls them from module.params.
2016-12-08 11:23:39 -05:00
27f93bef40
minor doc fix
2016-12-08 11:23:39 -05:00
92f88a4cb4
Replaces 'old' get_ec2_creds connection method with get_aws_connection_info to support passing in security_token for temporary creds.
2016-12-08 11:23:38 -05:00
4d227e508d
Fix a argument mismatch in elasticache
...
I think in this commit 720aeffca2bd2ae1eca158abc2d1463a8597afb6
There was bug introduced where the ElastiCacheManager init method has
a number of positional arguments like so.
```py
def __init__(self, module, name, engine, cache_engine_version, node_type,
num_nodes, cache_port, parameter_group, cache_subnet_group,
cache_security_groups, security_group_ids, zone, wait,
hard_modify, region, **aws_connect_kwargs):
```
But then later in the code the positional arguments are passed in
like this.
```py
elasticache_manager = ElastiCacheManager(module, name, engine,
cache_engine_version, node_type,
num_nodes, cache_port,
cache_subnet_group,
cache_security_groups,
security_group_ids, parameter_group, zone, wait,
hard_modify, region, **aws_connect_kwargs)
```
If you count, you can see that cache_subnet_group, is being passed in
where the manager expects to see parameter_group.
2016-12-08 11:23:38 -05:00
00f9dfac34
Change type of parameter 'template' to 'path'.
2016-12-08 11:23:38 -05:00
f85a8ac746
allow use of volume_type in volumes dict
2016-12-08 11:23:37 -05:00
507111f090
Fix to handle user directory within parameter 'template'.
2016-12-08 11:23:37 -05:00
dbf882a600
Clarify available options for device_mapping parameter of ec2_ami module
2016-12-08 11:23:37 -05:00
2962dabeda
Fix for modifying the size of an RDS instance. When attempting to modify the size of an RDS instance Ansible succeeds and returns a "changed" status. However, no changes are applied to the RDS instance. Boto is looking for a keyword parameter of "allocated_storage" to update the size, and this parameter wasn't being included.
2016-12-08 11:23:37 -05:00
63d2575f9f
ec2_group.py: added ICMP rule example
2016-12-08 11:23:37 -05:00
ec14a5c728
Adding support for access logs in ELB
2016-12-08 11:23:37 -05:00
82c898be5a
Remove 'str' type so that json is properly quoted
2016-12-08 11:23:36 -05:00
ff81aa11c0
Fixing ec2_asg termination_policy
...
If this isnt set, it wont launch the instances because it needs to default to "Default" despite what boto docs say.
2016-12-08 11:23:36 -05:00
db6c6ec5c9
Update s3.py
...
We are copying from S3, the bucket is the source, not the target.
2016-12-08 11:23:36 -05:00
08999ecfd1
Update iam_policy.py
...
Fixed doc for policy_name - it is a required field
Removed empty aliases
2016-12-08 11:23:36 -05:00
3339749017
order params, add missing tag param. update examples
2016-12-08 11:23:36 -05:00
29cfd80220
Fix improper indentation
2016-12-08 11:23:36 -05:00
5cd3217fc8
fixing termination policies for ec2_asg
2016-12-08 11:23:35 -05:00
e9c04cfdfd
Fixing bug #2058 and adding some backwards compatibility
2016-12-08 11:23:35 -05:00
4f9bb86e58
Add exception handling to iam
2016-12-08 11:23:35 -05:00
540061c9fc
Remove unnecessary json.loads
2016-12-08 11:23:35 -05:00
135e7c60de
Fix #1984 - allow load_balancer_port as a variable
2016-12-08 11:23:35 -05:00
ebbd206e86
Fixed typo for instance_tags documentation
2016-12-08 11:23:35 -05:00
fb317c72b6
Added option to set multiple ACLs for S3 objects. Also verifies the selected permissions against Boto's canned ACL strings list.
2016-12-08 11:23:35 -05:00
b1c5b17155
Use general-purpose parameter mutual exclusion code for network_interfaces
2016-12-08 11:23:35 -05:00
0afa813324
Add alias `network_interface` and accept a string for a single ENI
2016-12-08 11:23:35 -05:00
df8b2d45bc
Add network_interfaces example
2016-12-08 11:23:35 -05:00
96d8401fb4
Remove aliases specification from documentation since there are none
2016-12-08 11:23:35 -05:00
281a92bbdd
corrected whitepace
2016-12-08 11:23:34 -05:00
b952dff2c1
correct documentation formatting
2016-12-08 11:23:34 -05:00
df713192b4
Add network_interfaces parameter to ec2 module to support launch-time ENIs
2016-12-08 11:23:34 -05:00
33f5afa779
Make sure listener ports are ints.
...
May fix #1984
2016-12-08 11:23:34 -05:00
6f36629d13
Added termination_policies option
2016-12-08 11:23:33 -05:00
ffbd1efaa7
Remove non-ascii quote char
2016-12-08 11:23:33 -05:00
8048c4482a
using single device_id and enabling release on disassociation
2016-12-08 11:23:33 -05:00
488749500e
Clarified and cleaned up grammar of error messages.
2016-12-08 11:23:33 -05:00
d811a51744
Fixed call to undefined attribute when RDS module timeouts waiting.
2016-12-08 11:23:33 -05:00
e005ef0c36
Delete dead and broken code
2016-12-08 11:23:33 -05:00
b9ca912ffe
Fixing region requirement regarding euca clusters
...
Fixes ansible/ansible#11023
2016-12-08 11:23:32 -05:00
2c511a9470
Add support for S3 canned permissions. resolves #1939
2016-12-08 11:23:32 -05:00
4cd2fcf917
ec2_vol: Added missing "needs 2.0" doc
...
The ability to find-or-create a volume was added in 2.0. Added note to
the example.
2016-12-08 11:23:32 -05:00
c1526ff87b
Adding the ability to associate eips with network interfaces
2016-12-08 11:23:31 -05:00
0fff871819
one thing missed
2016-12-08 11:23:31 -05:00
217764ba3c
Rebase start/stop instance pull code
2016-12-08 11:23:31 -05:00
c7eb08b217
Return an iterable instead of None
...
By default `.get()` will return `None` on a key that doesn't exist. This
causes a `TypeError` in the `for` loop a few lines down. This change simply
returns an iterable type to avoid the error.
2016-12-08 11:23:30 -05:00
a765411284
Another way that the serialization of the boto results can fail
2016-12-08 11:23:30 -05:00
cae0c2741c
Another launchconfig field needs to be explicitly converted for json serialization
...
Fixes #1848
2016-12-08 11:23:30 -05:00
7027de77b7
fix ugly documentation
...
current version dumps a character per line in the docs: http://docs.ansible.com/ansible/cloudformation_module.html
2016-12-08 11:23:29 -05:00
bcc57875ed
adding parameter group option
2016-12-08 11:23:29 -05:00
7d85477acb
Fixes #542 error when ec2_asg arguments aren't specified
...
If max_size/min_size/desired_capacity are omitted
when updating an autoscaling group use the existing values
2016-12-08 11:23:28 -05:00
aed7d903ee
Include a CFN stack's resources in the result
2016-12-08 11:23:28 -05:00
74b4882415
ec2_ami can update an ami's launch_permissions
2016-12-08 11:23:28 -05:00
6530e76880
Refactor ec2_snapshot to make it more testable
2016-12-08 11:23:28 -05:00
83aff77c26
made `wait` default to True in ec2_snapshot
2016-12-08 11:23:28 -05:00
fcd2b354b2
Add to the ec2_snapshot module the ability to create a snapshot only if one hasn't recently been created
...
- Added snapshot_max_age parameter
- Updated docs
- Made the default value of wait to be false, as it used to be
2016-12-08 11:23:28 -05:00
49ee99fe73
result is now a dict and so needs different access syntax
...
Fixes #1848
2016-12-08 11:23:27 -05:00
b91684b8ad
Remove unneeded urllib2 import
2016-12-08 11:23:27 -05:00
99075976a8
Fix missing params to download_s3file in s3
2016-12-08 11:23:27 -05:00
689f13548f
Fixing s3 failures when bucket names contain dots
2016-12-08 11:23:27 -05:00
05974273b3
Use msg kwarg to pass error message in ec2_snapshot
2016-12-08 11:23:27 -05:00
cd072e3090
added version added to headers in s3
2016-12-08 11:23:26 -05:00
b203deee31
Fix example indentation bug
2016-12-08 11:23:26 -05:00
103b150090
Convert object into dict so it will turn into json properly
2016-12-08 11:23:26 -05:00
357d542bb3
clarified error messages to actually give back ansible module option instead of internal boto field name
2016-12-08 11:23:26 -05:00
c0eedc6e87
Fix missing alias "groups".
2016-12-08 11:23:26 -05:00
e4898a4348
If overwrite is set, download eagerly.
...
If the we are going to overwrite the file anyway,
there is no need to do any checksums locally or
grab the remote etag.
2016-12-08 11:23:26 -05:00
167e940e78
iam: don't delete passwords by default
2016-12-08 11:23:25 -05:00
9623cd570c
Add missing GPLv3 License header
...
Fixes #1643
2016-12-08 11:23:25 -05:00
682bf34a43
add headers param to s3 uploads
2016-12-08 11:23:25 -05:00
8b60dd349d
Use the common/shared MD5 function.
2016-12-08 11:23:25 -05:00
55271467d4
Remove validate_certs as the url is not user settable so we always want to validate the certificate
2016-12-08 11:23:24 -05:00
d71b1444a9
Update route53.py
...
Fix typos
2016-12-08 11:23:24 -05:00
63a619fbae
Fix iam_policy example
2016-12-08 11:23:24 -05:00
9b38e47d70
added rickmendes as maintainer
2016-12-08 11:23:23 -05:00
f46daacf67
Updated doc strings so each character isn't considered a line
2016-12-08 11:23:23 -05:00
8eba30b488
Deprecated _ec2_ami_search now verifies SSL certificates
2016-12-08 11:23:23 -05:00
fedd1bed1f
minor doc fixes, version added for latest feature
2016-12-08 11:23:22 -05:00
c0676f93f5
rds: add the ability to reboot RDS instances
2016-12-08 11:23:22 -05:00
1f560f8dae
Fixed parameter validation when creating a volume from a snapshot
2016-12-08 11:23:22 -05:00
2dc689894c
Added 'resource_tags' alias
2016-12-08 11:23:22 -05:00
a0b0c022b8
corrected version_added
2016-12-08 11:23:22 -05:00
ec6e75f1cc
attempt to fix check mode when state='absent'
2016-12-08 11:23:21 -05:00
e04a4a4114
Use mutually_exclusive in AnsibleModule
2016-12-08 11:23:21 -05:00
3d3be5e91f
Fix missing ,
2016-12-08 11:23:21 -05:00
a5a9c92fcd
Fixed dicts comparison for tags
2016-12-08 11:23:21 -05:00
54b02ee0da
ec2_vpc_net refactor
2016-12-08 11:23:21 -05:00
b7a13e263f
Add version
2016-12-08 11:23:21 -05:00
05df069176
Add module parameter for security group name. This make ec2_elb_lb module consitent with others
2016-12-08 11:23:21 -05:00
16a4ff3462
fixed minor doc issues
2016-12-08 11:23:21 -05:00
0cab021168
Revert "Revert "ec2_lc - include all launch config properties in the return""
2016-12-08 11:23:20 -05:00
af8ded66cc
Revert "ec2_lc - include all launch config properties in the return"
2016-12-08 11:23:20 -05:00
39e24e89f4
Remove default port value, it does not work in _requires_destroy_and_create logic
...
When creating a Redis cluster, every run it gets destroyed and recreated because the port number of memcached is used as the default.
2016-12-08 11:23:20 -05:00
6655cd89c4
Update elasticache.py
2016-12-08 11:23:20 -05:00
426f93a291
Remove default for engine_version
...
Redis and memcached have different engine version numbering, there can not be a shared default value.
2016-12-08 11:23:20 -05:00
1f35e578b4
s3 module: Add missing version tag to "encrypt" parameter
2016-12-08 11:23:20 -05:00
d3ef622627
Adding default cooldown to AWS ASG
2016-12-08 11:23:20 -05:00
ddd399fe7a
Throw error if encryption is set while passing a snapshot id
2016-12-08 11:23:20 -05:00
f1ab33ad7b
Adding ability to filter AWS Route 53 private hosted zones by attached VPC
2016-12-08 11:23:19 -05:00
29620b78fa
Change the default flag value to None to prevent AWS complaining: "Instance creation failed => InvalidBlockDeviceMapping: the encrypted flag cannot be specified since device /dev/sda1 has a snapshot specified."
2016-12-08 11:23:18 -05:00
2f46364921
Provide correct kwargs to rds2 connection when making a final snapshot
2016-12-08 11:23:18 -05:00
321244d881
Remove empty aliases
2016-12-08 11:23:17 -05:00
54af79692a
Add version number
2016-12-08 11:23:17 -05:00
f016cb556b
Fix hosted_zone_id after rebase.
2016-12-08 11:23:17 -05:00
3f2d1e6bfa
Add support for specifying unique hosted zone identifier
2016-12-08 11:23:17 -05:00
62b6cf85d3
Update cloudformation.py
...
Fix for inaccurate phrasing
2016-12-08 11:23:17 -05:00
848e9de950
remove double dict & fix increment bug
2016-12-08 11:23:16 -05:00
0e6e3e097e
Upstream docs show launch_config_name as required.
...
http://docs.aws.amazon.com/AutoScaling/latest/APIReference/API_AutoScalingGroup.html
Fixes #11209
Ansible behavior is correct, this commit just updates the docs to
reflect that correctness.
2016-12-08 11:23:16 -05:00
f1027ae6bc
no_log to iam password
2016-12-08 11:23:16 -05:00
b43db1d2ff
update docs for cloudformation
2016-12-08 11:23:15 -05:00
372a2286db
return health of instances and counts
2016-12-08 11:23:15 -05:00
e638913c97
iterate through all keys in a more pythonic manner
2016-12-08 11:23:15 -05:00
bc5d79fc30
update documentation, adding new params
2016-12-08 11:23:15 -05:00
98756144cf
Add ClassicLink settings to EC2_launchconfig
2016-12-08 11:23:15 -05:00
ae1080d922
Added some block_device_mapping (disks) informations to EC2 instance module ouput
2016-12-08 11:23:15 -05:00
a8da674cf4
Added "EC2 instance" termination_protection and source_dest_check changeability at run-time
2016-12-08 11:23:15 -05:00
df8013182e
Parse out space characters in route53 value list
...
Fixes: https://github.com/ansible/ansible-modules-core/issues/992
2016-12-08 11:23:15 -05:00
543cb13f42
Fix connection creation to allow usage of profiles with boto
2016-12-08 11:23:15 -05:00
f422782180
Use module.fail_json() instead of sys.exit()
2016-12-08 11:23:14 -05:00
a0466f1f8d
Add the option to pass a string as policy
2016-12-08 11:23:14 -05:00
9ad15cdae9
- List the name servers of a zone.
2016-12-08 11:23:13 -05:00
e025effc99
include all launch config properties in the return
...
make all properties available when registering the result
which is useful when wanting to launch a stand-alone instance based upon
an existing Launch Config.
2016-12-08 11:23:12 -05:00
82b809f0e2
new vpc module. does not contain subnet or route table functionality.
...
changed name to ec2_vpc_net
refactored out IGW functionality
2016-12-08 11:23:12 -05:00
1f6c177da0
Use aws connect calls that allow boto profile use
2016-12-08 11:23:12 -05:00
b318bc8b43
Add support for listing keys in a specific S3 bucket
...
Includes support for specifying a prefix, marker, and/or max_keys. Returns a list of key names (as strings).
2016-12-08 11:23:11 -05:00
4239922d07
Updating version_added for new spot_type param in ec2 module
...
Also made sure 'choices' were set on the module param, to catch errors
in user's playbooks, etc.
2016-12-08 11:23:11 -05:00
ed279d8175
Added support for spot request type specification (to support persistent spot requests).
2016-12-08 11:23:11 -05:00
99e2557b42
route53: add support for routing policies
...
It is now possible to pass various routing policies if an identity is
provided.
This commit also introduces multiple optimisations:
* Only fetch records for the given domain
* Use UPSERT instead of DELETE+CREATE to update existing records
2016-12-08 11:23:11 -05:00
86e679fe3c
iam: use modern helper to allow sts
...
previous implementation ignored the session token when present
2016-12-08 11:23:11 -05:00
bea77c938e
fixes to code to enable updates of user to groups and delete groups. Fixed example yaml to use groups
2016-12-08 11:23:10 -05:00
ab7678f199
Fixed more issues with the delete_group and paramater mismatch
2016-12-08 11:23:10 -05:00
6482ad964f
iam certificate module
...
boto import tweak
style patch
2016-12-08 11:23:10 -05:00
a51a8e1fd6
use aws connect calls that allow boto profile use
2016-12-08 11:23:10 -05:00
97a2cd0bd9
Indentation fix for with and register in the ec2_vol example
2016-12-08 11:23:09 -05:00
cc214afed6
adding 'encrypted' option into volume dict so ec2 module can easily include encrypted volumes
2016-12-08 11:23:09 -05:00
548ab163f5
Added choice validation for state arg
...
fixes traceback on invalid state arg
2016-12-08 11:23:08 -05:00
18ca7aee07
Updating cloud modules with proper github author information
2016-12-08 11:23:07 -05:00
8b2327fe3a
Fix missing instance_id param in ec2_eip.
2016-12-08 11:23:07 -05:00
b154ad4cbb
ec2_vol: fix race conditions because we handle errors before actually deleting
...
Just try to delete the volume and handle the error amazon sends
2016-12-08 11:23:07 -05:00
9babe9b07d
Get specific object version with S3 module.
...
- allow specifying version for mode=get and mode=getstr
- when version specified doesn't exist give an error message that indicates so
2016-12-08 11:23:07 -05:00
ecae3403af
Remove unnecessary wait_timeout parameter.
2016-12-08 11:23:07 -05:00
3798c8c0ce
Refactoring of ec2_eip module.
2016-12-08 11:23:07 -05:00
41f7e4ed5e
ec2_eip - PEP8 and minor style cleanups.
2016-12-08 11:23:07 -05:00
a41994974c
EC2 Security Group - Validate parameters.
2016-12-08 11:23:07 -05:00
be9cddbddf
Refactoring for easier to read
2016-12-08 11:23:06 -05:00
7cafbb5f05
Prevent memory-error from a large file
2016-12-08 11:23:06 -05:00
b57bcac72f
Add support for SNS notification ARNs in CloudFormation
2016-12-08 11:23:06 -05:00
adb53cc3c5
Add "block_device_mapping" parameter on EC2_AMI Amazon module (DOCUMENTATION) - upgraded
2016-12-08 11:23:06 -05:00
4cb7df2631
Added delobj command to delete an object within a bucket
2016-12-08 11:23:06 -05:00
75fa5811db
Added volumes dict to ec2_lc example
2016-12-08 11:23:05 -05:00
15b65fa115
Fixed bug in example where updating a user to a group Fixed bug in create_group and update_group whereby paramaters were not being set correctly.
2016-12-08 11:23:05 -05:00
f6f2359400
fix for 11177 where module readds rule even if the rules exists
2016-12-08 11:23:05 -05:00
5ae6f5b767
reverting pep changes that were breaking documentation
2016-12-08 11:23:04 -05:00
336c22bfd9
made non exec
2016-12-08 11:23:04 -05:00
fb3c457122
Elasticache Subnet Group
2016-12-08 11:23:04 -05:00
f7055c88de
Fixed a typo in ec2_vpc module documentation
2016-12-08 11:23:04 -05:00
ff7dfefbd6
cloudformation: accept local templates in yaml format
...
Since the YAML data format is a subset of JSON, it is trivial to convert
the former to the latter. This means that we can use YAML templates to
build cloudformation stacks, as long as we translate them before passing
them to the AWS API. I figure this could potentially be quite popular in
the Ansible world, since we already use so much YAML for our playbooks.
2016-12-08 11:23:04 -05:00
38d0f31cac
Streamlined rolling udpate algorithm. Still need to account for partials, and not waiting for instances if we're mass terminating them.
2016-12-08 11:23:04 -05:00
fc53c2431d
Added changed=True flag when new subnet groups created. Added conditional so that modify_db_subnet_group is only called when necessary and changed=True flag will be set.
2016-12-08 11:23:04 -05:00
77fa67a240
author fix
2016-12-08 11:23:04 -05:00
d4aff86349
iam_policy
2016-12-08 11:23:04 -05:00
9de952cb3f
Instance deregistration should try all associated ELBs. Fixes #869
2016-12-08 11:23:04 -05:00
eff6307ac3
Use auto scaling group managed ELBs if present.
2016-12-08 11:23:04 -05:00
a329dc05c0
iam module with fixes
...
iam module. fix policy issue.
bugfix
allow for modifying path without declaring new_path
2016-12-08 11:23:04 -05:00
e6e8f65e92
Creating ami should be idempotent
...
If the ami already exists, return details of the duplicate
ami instead of failing with an error.
2016-12-08 11:23:04 -05:00
dd6d5f0cb5
feature pull request: catch and retry recoverable errors
...
boto can throw SSLError when timeouts occur (among other SSL errors). Catch these so proper JSON can be returned, and also add the ability to retry the operation.
There's an open issue in boto for this: https://github.com/boto/boto/issues/2409
Here's a sample stacktrace that inspired me to work on this. I'm on 1.7, but there's no meaningful differences in the 1.8 release that would affect this. I've added line breaks to the trace for readability.
failed to parse: Traceback (most recent call last):
File "/home/ubuntu/.ansible/tmp/ansible-tmp-1419895753.17-160808281985012/s3", line 2031, in <module> main()
File "/home/ubuntu/.ansible/tmp/ansible-tmp-1419895753.17-160808281985012/s3", line 353, in main download_s3file(module, s3, bucket, obj, dest)
File "/home/ubuntu/.ansible/tmp/ansible-tmp-1419895753.17-160808281985012/s3", line 234, in download_s3file key.get_contents_to_filename(dest)
File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1665, in get_contents_to_filename response_headers=response_headers)
File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1603, in get_contents_to_file response_headers=response_headers)
File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1435, in get_file query_args=None)
File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1488, in _get_file_internal for bytes in self:
File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 368, in next data = self.resp.read(self.BufferSize)
File "/usr/local/lib/python2.7/dist-packages/boto/connection.py", line 416, in read return httplib.HTTPResponse.read(self, amt)
File "/usr/lib/python2.7/httplib.py", line 567, in read s = self.fp.read(amt)
File "/usr/lib/python2.7/socket.py", line 380, in read data = self._sock.recv(left)
File "/usr/lib/python2.7/ssl.py", line 341, in recv return self.read(buflen)
File "/usr/lib/python2.7/ssl.py", line 260, in read return self._sslobj.read(len) ssl.SSLError: The read operation timed out
2016-12-08 11:23:04 -05:00
36dfb78831
Output the Internet Gatewoy id directly instead of in a dict.
2016-12-08 11:23:03 -05:00
70188fe02a
Fixes issue 1197 for s3 module, where the file gets downloaded even if checksums match
2016-12-08 11:23:03 -05:00
bfb36f0f1f
Tell me what the igw id is if we created an igw.
2016-12-08 11:23:03 -05:00
8715ce07ae
Fix issue #1156
...
Fix as suggested in the issue.
https://github.com/ansible/ansible-modules-core/issues/1156
2016-12-08 11:23:03 -05:00
a6fd78af37
s3 put: add support for server-side encryption
...
- added 'encrypt' boolean option
- reordered module options alphanumerically
2016-12-08 11:23:02 -05:00
b6a312e489
Minor fixups found during review of #582
2016-12-08 11:23:02 -05:00
d252e7c08f
Fix for issue #1332 - when instance is has finished deleting and get_db_instance returns None, exit gracefully
2016-12-08 11:23:01 -05:00
86b6f39cf0
Do instance update after add tags to instance.
2016-12-08 11:23:01 -05:00
de813195c5
Added support for foreign security groups ( Fixes : #373 )
2016-12-08 11:23:01 -05:00
ce4c9cccf5
fixes example documenation
2016-12-08 11:23:00 -05:00
7e5a4afb6b
Update module "imports" to new style
...
Fixes #1351
2016-12-08 11:23:00 -05:00
d24fbf5c3e
fixe issue #600 , where ec2 module returns instance state as runing even after instance is terminated
2016-12-08 11:22:59 -05:00
Shawn Siefkas
Rick Mendes
Lyle Mantooth
Jasmine Hegman
Shaun Brady
chrisweaver
Matthew Martin
Michael Baydoun
Kai Kousa
Adrian Moisey
Ryan Brown
Hrishikesh Barua
Javier M. Mellid
Adam Butler
Toshio Kuratomi
Bradley Phipps
Matt Davis
mansunkuo
Elena Washington
Jonathan A. Sternberg
Michael Pappas
@
David Fischer
Roberto Bampi
Doug Luce
Kenny Woodson
Nathan Brown
kwerey
Lloyd Hazlett
Kaz Cheng
hyperized
John R Barker
cspollar
Brian Coca
Bill W
deyvsh
Sumit Roy
Constantin
jjshoe
Dennis Conrad
Marcin
Joel Thompson
Michael Moussa
William Holroyd
Rob
Kalle Lehtonen
Christian Aistleitner
Arnaud Lachaume
whiter
Ashwanth Kumar
Ted Timmons
Taras Lipatov
Fabian Fülling
Jonathan Davila
Neil Saunders
Joel
Constantin07
Tom Bamford
Ryan-Neal Mes
Will Thames
Jonathan Davila
Scott Brown
Daniel Petty
Matt Martz
Michael Baydoun
Ben Visser
Shawn Silva
techraf
Yoichi Imai
Jason Paige
Bermudez, Jaime
Henrique Rodrigues
Constantin07
Matt Ferrante
autotune
Joost Cassee
krdlab
Jon Hadfield
Etherdaemon
Mike Buzzetti
Andy Nelson
HAMSIK Adam
Michel Alexandre Salim
Arthur Clement
Jay Rogers
Michel Alexandre Salim
Max Rothman
joshuaeke
Keith Hassen
Daniel Donckers
Mike Riddle
Tom Paine
J Levitt
Rabenstein
Kevin Falcone
Adrian Bridgett
Kai Webber
Greg DeKoenigsberg
Gilad Peleg
Sarah Haskins
Val Komarov
Abhijit Menon-Sen
Frank van Tol
fperks
Gerard Lynch
Shayne Clausson
Alex Kessinger
Jens Carl
Selivanov Pavel
Nathaniel Felsen
evanccnyc@users.noreply.github.com
Evan Carter
wimnat
Tom Fotherby
Yanchek99
Taneli Lepp
Bret Martin
Bruno Galindro da Costa
Timothy Appnel
Till Backhaus
James Cammarata
Jason Cowley
David M. Lee
Scot Spinner
Michael J. Schultz
Rowan Wookey
Robb Wagoner
Matt Ferrante
Robert Jailall
Hagai Kariti
Luke Rohde
Jaime Gago
Feanil Patel
billwanjohi
Mike Putnam
Ash Caire
khassen
Artur Cygan
Baraa Basata
ayush
Herby Gillot
Eero Niemi
Brian Coca
Apoorva Kulkarni
vanga
Juho-Mikko Pellinen
Flyte
Scott Miller
Patrick Roby
Andrea Mandolo
Michael Weinrich
Jay Taylor
zimbatm
toninog
Dan Abel
Colin Hutchinson
Philip Kirkland
nitzmahone
Robert Estelle
Tyler Cross
Ching Yi, Chan
Soenke Ruempler
Bruce Pennypacker
Alex Gandy
Benno Joy
Tim Mahoney
Sankalp Khare
James Martin
Trevor Pounds
Raghu Udiyar
tedder
xiaclo
Wang Qiang
marko
Jonathan Mainguy