Commit Graph

286 Commits (4cab425618b8e8ee28447b0adc3f753af88422a3)

Author SHA1 Message Date
Dag Wieers 2413169b25
mso_st_filter_entry: Manage filter entries in templates (#51290)
A new module to manage filter entries in MSO schema templates.
2019-01-24 17:38:39 +01:00
Dag Wieers ad607083de
mso_schema_template_bd: Manage BDs in templates (#51279)
A new module to manage BDs in MSO schema templates.
2019-01-24 16:53:30 +01:00
Dag Wieers 9409826982
mso_st_externalepg: Manage external EPGs in templates (#51285)
A new module to manage external EPGs in MSO schema templates.
2019-01-24 16:53:18 +01:00
Dag Wieers 8d282de811
mso_st_bd_subnet: Manage BD subnets in templates (#51282)
A new module to manage BD subnets in MSO schema templates.
2019-01-24 16:14:51 +01:00
Dag Wieers e72bb42e21
mso_sta_epg_subnet: Manage EPG subnets in templates (#51278)
A new module to manage EPG subnets in MSO schema templates.
2019-01-24 15:43:43 +01:00
Dag Wieers 73ed1a8269
mso_schema_template: Manage templates in schemas (#51277)
A new module to manage templates in MSO schemas.
2019-01-24 15:32:07 +01:00
Dag Wieers 6d47105a2d
mso_s_t_anp: Manage ANPs in templates (#51274)
A new module to create ANPs in MSO schema templates.
2019-01-24 15:20:36 +01:00
Dag Wieers dfad17ad8a
mso_s_t_anp_epg: Manage EPGs in templates (#51275)
A new module to create EPGs in MSO schema templates.
2019-01-24 15:16:45 +01:00
Dag Wieers 7a642c783a
mso_schema: Improvements to docs (#51272) 2019-01-24 14:39:06 +01:00
Dag Wieers 31222b65c1
Fix small typo
+label: docsite_pr
2019-01-17 13:48:25 +01:00
Dag Wieers a79441ca30
Rename MSC modules to MSO nomenclature (#50959)
* msc_tenant: improve docs

* Rename MSC modules to MSO

* Rename MSC-related objects to MSO nomenclature

* Add missing doc fragments
2019-01-16 14:53:38 +01:00
Dag Wieers e515b4000c
msc_schema: Manage schemas on ACI MultiSite (#47758)
This includes the new msc_schema module and integration tests.
2019-01-15 13:14:34 +01:00
Dag Wieers 67b455a8ac
Update documentation notes, copyright and license (#50927) 2019-01-15 12:24:34 +01:00
Dag Wieers 27f4a1f927
Add support for users/sites to tenants (#50924)
* Add support for users/sites to tenants

* Better work-around
2019-01-15 11:49:54 +01:00
Dag Wieers 14b03ac15f
MSC: Various bugfixes and features enhancements (#50200)
* MSC: Various bugfixes and features enhancements

This PR includes:
- Lookups of roles, labels and domains
- Auto-create new labels
- Improvements to comparing complex datastructures
- Force removal of sites
- Support non top-level queries
- Document internal functions
- Add parameter types to modules
- Fix documentation examples
- Improvements to idempotency wrt. returning changed
- Support site locations
- Update permission list
- Various improvements to integration tests

* Fix Ci issues
2018-12-20 18:18:46 +01:00
Dag Wieers 05c6ff79f9 Convert to reduced list of known types (#50010) 2018-12-19 07:25:30 +10:00
Dag Wieers c1ac87794e
ACI: Fix module parameters (#50051)
* Fix parameter type of private_key

* Fix parameters of various ACI modules
2018-12-18 09:30:28 +01:00
Dag Wieers e8885ee4e8 ACI: Add types to modules and doc fragment (#49997)
* ACI: Add types to module doc fragment

* Add types to ACI modules too
2018-12-17 11:23:10 -06:00
Toshio Kuratomi 3fba006207 Update bare exceptions to specify Exception.
This will keep us from accidentally catching program-exiting exceptions
like KeyboardInterupt and SystemExit.
2018-12-16 15:03:19 -08:00
Dag Wieers a4998cfead
ACI: Add seealso fragments to module documentation (#49844) 2018-12-13 19:40:53 +01:00
Dag Wieers baf0ad2309 Docs: Add a "seealso" section to the module docs (#45949)
* Docs: Add a separate  "seealso" section to the module docs
to list related modules and/or related references. This clears up the notes
section for things that are actual notes.

So you can add a section in your module documentation and four types of
references are possible.

    seealso:

    # Reference by module name
    - module: aci_tenant

    # Reference by module name, including description
    - module: aci_tenant
      description: ACI module to create tenants on a Cisco ACI fabric.

    # Reference by rST documentation anchor
    - ref: aci_guide
      description: Detailed information on how to manage your ACI infrastructure using Ansible.

    # Reference by Internet resource
    - name: APIC Management Information Model reference
      description: Complete reference of the APIC object model.
      link: https://developer.cisco.com/docs/apic-mim-ref/

This PR also includes:

- Implements ansible-doc support
- Implements schema support for the seealso options
- Updates to the development documentation
- Rename filter convert_symbols_to_format to rst_ify, cfr the existing html_ify and tty_ify filters
  - This makes the existing template a lot easier to read and fixes the confusion I had myself rereading the template (again).
- We fixed the possible suboption types (which was limited to 'bool' only)

* Use latest stable instead of devel docs
2018-12-12 14:19:58 -06:00
Dag Wieers 37820be05b
aci_rest: Fix ignoring custom port (#49715) 2018-12-10 15:08:06 +01:00
dionben a796299651 Added support for L2 external domain association (l2dom). (#48670)
* Added support for L2 external domain association (l2dom).

Added support for L2 external domain association (l2dom).

* Update lib/ansible/modules/network/aci/aci_epg_to_domain.py

* Fix a few small items, restore earlier changes

Performed the necessary updates to fix this PR.

* Fix spaces

* One more miss
2018-11-19 17:22:04 +01:00
Abhijeet Kasurde 2faddfc1fe Misc typo in msc_* modules (#48716)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-19 16:50:39 +01:00
Dag Wieers 24d7b4a660
Various small fixes to MSC modules and tests (#48417) 2018-11-13 09:01:45 +01:00
Dag Wieers e21270988c
aci_epg: parameter bd is not required (#47999) 2018-11-05 19:34:15 +01:00
Dag Wieers df6b0b0e9e aci_aptiplp: Support missing policy_group (#48000)
* aci_aptiplp: Support missing policy_group

* Adapt integration tests to fix

* Add changelog fragment

* Fix

Co-Authored-By: dagwieers <dag@wieers.com>
2018-11-05 18:21:01 +00:00
Dag Wieers d1f6ff646a aci_iplpg: Support missing aep (#48001)
* aci_iplpg: Support missing aep
2018-11-05 18:20:23 +00:00
Dag Wieers 591b074e43
aci_switch_leaf_selector: Support missing policy_group (#47992)
* aci_switch_leaf_selector: Support empty policy_group

* Reorganize code

* Adapt integration tests to fix
2018-11-05 19:02:06 +01:00
Dag Wieers 6a37582158
msc_role: Manage roles on ACI MultiSite (#47757)
This includes the new msc_role module and integration tests.
2018-11-02 20:08:11 +01:00
Dag Wieers 1ac40e21b4
msc_site: Manage sites on ACI MultiSite (#47756)
This includes the new msc_site module and integration tests.
2018-11-02 20:07:10 +01:00
Dag Wieers e97ad60f3b
msc_tenant: Manage tenants on ACI MultiSite (#47755)
This includes the new msc_tenant module and integration tests.
2018-11-02 20:02:42 +01:00
Dag Wieers 7142715b15
msc_user: Manage users on ACI MultiSite (#47754)
This includes the new msc_user module and integration tests.
2018-11-02 20:00:17 +01:00
Dag Wieers 67aa98c30f
msc_label: Manage label on ACI MultiSite (#47753)
This includes the new msc_label module and integration tests.
2018-11-02 19:22:20 +01:00
Sandra McCann 6479cb6a4a mark Cisco ACI modules as certified (#46841) 2018-10-11 15:34:35 -05:00
Metzger, Simon 00d78d7ef3 added period in description. Changed integration test to work correctly. 2018-09-28 18:45:13 +02:00
Metzger, Simon 285af0b6fb added parameter leaf_port_blk_description in module and integration tests 2018-09-28 18:45:13 +02:00
Metzger, Simon be2c73ac18 be compliant to pep8 and pylint. Added integration tests. 2018-09-28 18:45:13 +02:00
Metzger, Simon cdd66295f2 changed documentation strings 2018-09-28 18:45:13 +02:00
Metzger, Simon 4d7cd4bea7 added new module aci_access_port_block_to_access_port 2018-09-28 18:45:13 +02:00
Dag Wieers 5f4173b8bf A few small fixes 2018-09-19 12:52:31 +02:00
João Soares 097902c35a Remove whitespaces 2018-09-19 12:52:31 +02:00
João Soares 01db7239ed Add input validation for the new asn parameter
Fix asn type from str to int
2018-09-19 12:52:31 +02:00
João Soares 165000adcd Update version_added on the asn parameter 2018-09-19 12:52:31 +02:00
João Soares a60b14c826 Update aci_l3out documentation 2018-09-19 12:52:31 +02:00
João Soares dd67e89f47 Add eigrp as a possible l3protocol in aci_l3out
Also fixes an error related to the required parameters. The l3out parameter is required but only 'name' was being accepted, and that should only be the alias.
2018-09-19 12:52:31 +02:00
Dag Wieers 6faf400621
aci_switch_policy_vpc_protection_group: Fix idempotency (#45091) 2018-09-03 16:39:39 +02:00
Dag Wieers cc2164f92a
ACI: Add specific info about running locally (#43903)
Since the ACI modules (like most network-related modules) run on the
local controller, this PR adds the necessary details so users are aware
of this particular feature.
2018-08-24 01:28:39 +02:00
Dag Wieers ddf3ba01d2
aci_fabric_node: Fix idempotency (with newer ACI ?) (#43848) 2018-08-09 02:27:22 +02:00
Dag Wieers 02b5057392
Support dash-separated leaf IDs (as documented) (#43846) 2018-08-09 02:27:03 +02:00
Dag Wieers 014fca8ca5
Fix all ACI examples to use delegate_to (#43439)
This is to avoid users connecting to the APIC using SSH, which is likely
to fail. In the ACI documentation (linked from every module) we go into
more details on how people are supposed to work with the modules..
2018-08-08 23:24:50 +02:00
Dag Wieers d8ba8c03f3
ACI: Make querying links and nodes possible (#43441)
This functionality was not considered when the module was written, but
there's no reason why it shouldn't be supported.

We had to rework the query string construction and object filtering.
This new functionality allows to filter on arbitrary keys and supports
None values.

This PR fixes various issues with the existing framework, including
querying specific objects using construct_url_4 (i.e.
aci_epg_to_contract and aci_static_binding_to_epg)
2018-08-07 23:54:54 +02:00
Joren Vrancken b954917761 Surround top-level function and class definitions with two blank lines. 2018-07-31 12:06:56 -07:00
Dag Wieers e899824c49
ACI: Add parameter types to module docs (#42893)
* ACI: Add parameter types to module docs

* Update validate-modules ignore list
2018-07-17 18:03:55 +02:00
Dag Wieers 5465dca7ec
aci_bd_subnet: Support parameter scope not set (#42675)
If parameter scope is not set (is None) the usual handling of lists does
not apply, and should be avoided or we get an exception.

This needs to be backported to earlier versions of Ansible.
2018-07-12 15:20:33 +02:00
Dag Wieers 27f540ac5c
Add parameter types to documentation (#42572)
Few documentation fixes
2018-07-11 23:03:24 +02:00
Dag Wieers f98a0b521f
Add querying all bindings (#42366)
Also fix an issue with one of the check-mode tests.
2018-07-06 13:32:39 +02:00
Dag Wieers b90ae65e5c
aci_static_binding_to_epg: Add description parameter (#42244)
* aci_static_binding_to_epg: Add description parameter

This PR adds the description parameter to this module.

Tis fixes #42154

* Fix added_version
2018-07-05 18:01:28 +02:00
krisek 55a94784a3 Update aci_vrf.py (#42246)
<!--- Your description here -->

+label: docsite_pr
2018-07-03 14:27:48 +02:00
Dag Wieers 09fec5a482
aci_interface_policy_ospf: Create OSPF interface policies (#42184)
* aci_interface_policy_ospf: Create OSPF interface policies

New module to create OSPF interface policies

* Fix documentation issues

* Add missing integration tests

* Update documentation and examples
2018-07-03 04:04:48 +02:00
Dag Wieers 57c0471b54
Fix ACI validate-modules issues (#42222) 2018-07-03 04:04:35 +02:00
Dag Wieers ba4680c141
ACI: Make lag_type a required parameter for queries (#40657)
Without this change, the module will simply fail with an error when
doing a query and not specifying the **lag_type** parameter.

The integration tests expect **lag_type** too, so this simply codifies
what was expected since inception.
2018-05-24 17:32:56 +02:00
Dag Wieers 9e2a59885e
aci_rest: Ensure we always return a status 2018-05-24 15:20:23 +02:00
Dag Wieers 05374da9b8
ACI: Add from_card and to_card parameters (#40653)
* ACI: Add from_card and to_card parameters

* Add version info to new parameters
2018-05-24 14:58:11 +02:00
Matt Clay 8deced3e04
Fix shebangs and file modes and update tests. (#40563)
* Add execute bit sanity test and apply fixes.
* Add shebang test for `lib` dirs and apply fixes.
* Shebang and execute bit cleanup.
2018-05-22 14:25:36 -07:00
suacide24 4c0ceaea3d changed accportgrp to accbundle (#40104)
* changed accportgrp to accbundle

* fixed shippable complaints

* changed policy_group_type to interface_type
2018-05-17 13:11:31 +02:00
suacide24 dbb4493f17 removed eth on port-channel (#40090) 2018-05-14 21:09:44 +02:00
Dag Wieers 19977e80f0 Get rid of obsolete SEQUENCETYPE-check (#40078)
And small cosmetic change to examples.
2018-05-14 10:22:15 -04:00
Jacob McGill 67f387bc3b Update default for dscp to not allow APIC to handle it (#39970) 2018-05-10 19:57:20 +02:00
Rostyslav Davydenko 5f7c7becde aci_l3out: Add initial ACI l3Out implementation (#37570)
* Initial implementation of ansible ACI L3Out module

* Small documentation and parameter name fixes

* fix copy-paste error

* fix sanity for version_added = 2.6

* Removed deprecated options. Added PIM protocol support

* aci_l3out: add more examples and query option

* Handle DSCP option properly
2018-05-10 16:29:49 +02:00
Dag Wieers d7f3d3b867
Fix module validation checks and remove old params (#39926)
This PR includes:
- Fixes to the majority of module validation issues
  (deliberate inconsistencies between docs and arg_spec)
- Removal of deprecated parameters 'method' and 'protocols'
- A few typos in the documentation

There are still some left-over validation errors, some are deliberate
(like doc strings as default to indicate ranges, etc.)
2018-05-10 08:47:08 +02:00
Alicia Cozine 4801bf96a5 fixes broken link in aci module docs (#39247)
* fixes broken link in aci module docs

* makes correct fix for aci broken link
2018-04-27 21:24:18 +02:00
Dag Wieers 3a1cd4d45a
Fix incorrect RN used in module (#38245)
This requires backporting to v2.5
2018-04-04 02:43:58 +02:00
Dag Wieers 35b7b608bf
Add missing required property to docs
<!--- Your description here -->

+label: docsite_pr
2018-04-03 03:32:49 +02:00
Dag Wieers 126a41327c
Update docs to highlight lookup plugins for templating
<!--- Your description here -->

+label: docsite_pr
2018-03-30 09:33:02 +02:00
Dag Wieers 3973eb4c30
Added an example using a templated payload file
<!--- Your description here -->

+label: docsite_pr
2018-03-30 09:27:45 +02:00
Dag Wieers cdd21e2170
Clean up module documentation (#36909)
* Clean up module documentation

This PR includes:
- Removal of `default: None` (and variations)
- Removal of `required: false`
- Fixing booleans and `type: bool` where required

* Fix remaining (new) validation issues
2018-03-15 22:15:24 +01:00
Dag Wieers cb79957b5f
Make use of named links in documentation notes (#37027)
* Make use of named links in documentation notes

Now that it is possible to name external links, we are making use of
this to make the documentation better.

* Add improvements to ACI documentation

* Disable QA for long line

* Add :menuselection: and :guilabel:

* Improve links on some modules
2018-03-06 00:05:13 +01:00
Dag Wieers 68b39f7a84
Parameter method is not required (#36816) 2018-02-28 04:56:16 +01:00
Dag Wieers 8f6eea50db
More improvements to ACI module docs (#36689)
* More improvements to ACI module docs

* Asorted improvements

* Found 2 more

* Improvements to aci_rest documentation
2018-02-25 19:13:16 +01:00
Dag Wieers 97fde8c760
ACI: Asorted fixes to documentation (#36681) 2018-02-24 22:50:54 +01:00
Dag Wieers 665f5b4e9c
ACI: Improve module index short_description (#36665) 2018-02-24 01:27:37 +01:00
Gittins a1241d99ee Updated examples aci_contract_subject_to_filter.py (#36626)
Changed examples to reference the correct module name. Previously the examples used "aci_subject_filter_binding".
2018-02-23 13:00:26 +01:00
Bruno a7db945ac6 aci example minor fix testing actual real life scenario examples (#36613) 2018-02-23 03:04:40 +01:00
Bruno 68a97ca558 added additional examples for aci modules (#36612)
* added additional examples for aci modules

* small fix on aci_fabric_node

* removing jina2 for clarity
2018-02-23 02:39:58 +01:00
Bruno 31bd214682 minor fix to exit_json for aci_static_binding_to_epg.py (#36540)
* minor fix to exit_json for aci_static_binding_to_epg.py

* The aci.exit_json() call doesn't need arguments
2018-02-21 21:17:41 +01:00
Dag Wieers 7435e115e0
ACI: Various changes to module documentation and guide (#36516)
* ACI: Various changes to module documentation and guide

This PR includes:
- We moved the object class information to the notes
- Add version information to guide chapters
- Add generic note to modules with reference to ACI guide
- Reference known issues in aci_rest documentation
- Remove module_utils function docs from modules
- Indicate which parameters are not required for querying all objects
- Added missing RETURN information

* Fix copyright strings

* Remove aci_domain_to_encap_pool.py for v2.5

* More updates

* PEP8 fix

* Improve listings of parameters/return values
2018-02-21 19:35:59 +01:00
Matt Clay f87ec440e7 Fix PEP 8 issue. 2018-02-20 21:20:32 -08:00
Bruno ef5e97ef5a aci_static_binding_to_epg fixes (#36478)
* aci_static_binding_to_epg fixes (documentation and logic for interface_mode)

* additional fixes after review
2018-02-21 00:09:53 -05:00
Dag Wieers 5635c50f9b
aci_iplpg: Various fixes to integration tests/module (#36460) 2018-02-21 00:20:38 +01:00
Dag Wieers 1720a210e9
aci_spvpg: Various fixes to integration tests/modules (#36458)
* aci_spvpg: Various fixes to integration tests/modules

This PR includes:
- A fix in module_utils aci.py
- Various fixes in integration tests

* Fix typo
2018-02-20 22:49:55 +01:00
Dag Wieers 6534e6a450
ACI: Add missing examples to module docs (#36417)
This PR includes:
- A cleanup of documentation examples for ACI modules
- A small fix in aci_rest integration test
2018-02-20 03:27:17 +01:00
Dag Wieers fb9af72b48
aci_aep: Add missing integration tests (#36414)
This PR includes:
- Add missing aci_aep integration tests
- Fix small aci_rest issue
2018-02-20 03:04:17 +01:00
Dag Wieers 79d00adc52
aci_rest: Fix error handling and improve documentation (#36295)
This PR includes:
- A fix for a recently introduced issue wrt. error handling
- Added integration tests for provoked errors
- Influence standard return values using aci library for aci_rest
- Add proxy support documentation
- Documentation update related to #34175
2018-02-19 12:01:14 +01:00
Dag Wieers d86c5aee3c aci_domain_to_encap_pool: Add integration tests (#36217) 2018-02-15 23:47:39 -08:00
Dag Wieers 334e405e6f
aci_taboo_contract: Add integration tests and examples (#36276)
This PR includes:
- Missing integration tests
- Missing examples
- Two typo's in other integration tests
2018-02-16 01:59:23 +01:00
Dag Wieers e1b5bc049c
aci_firmware_source: Add integration tests (#36246)
This PR includes:
- Rename 'protocol' parameter to 'url_protocol'
- Add limited integration tests (as we have no public firmware access)
- Add missing examples
2018-02-16 00:20:41 +01:00
Dag Wieers e431d578da
aci_encap_pool: Standardize on 'pool_allocation_mode' (#36215) 2018-02-15 02:59:54 +01:00
Dag Wieers da5cf72236
ACI: Fixes to domain parameters dependencies (#36158)
We identified an incompleteness to parameter dependencies that affects
querying all domain-related objects.

This PR also includes:
- Improvements to integration tests
- Add missing vm_provider types
- Fix examples

This relates to #36131
2018-02-14 13:51:38 +01:00
Dag Wieers 7897558b95
aci_aep_to_domain: Fix query all objects (#36131)
This PR includes:
- A fix to the module where domain_type without domain caused havoc
- A fix to the integration tests when querying all binding objects
- Improvements to integration tests
2018-02-13 19:07:23 +01:00