Commit Graph

1494 Commits (4ffe3b14d4e90ee0daec7826db8361b4c71b1296)

Author SHA1 Message Date
Ted Timmons a0f58fa2ef AWS: docfix: spelling (#47443)
Fix spelling from paramaters to parameters
2018-10-23 09:36:39 +05:30
Sloane Hertel c58c0b8547 [aws] Fix check mode bug in ec2_key (#45320)
Fix incorrect ec2_key check-mode behavior when a key already exists and key_material has been provided
2018-10-22 09:28:07 -04:00
cahlchang 6bd4665c4e add ec2_instance example docs (#47386)
* add ec2_instance example docs

* duplicate text
2018-10-22 08:11:31 +10:00
Abhijeet Kasurde bfc3ca1da1 Remove extra parameter in format_exc (#46251)
`traceback.format_exc()` does not take any argument, this fix remove
such occurances.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-18 21:50:58 -04:00
Matt Clay 37b013aca3
Enable additional pylint rules and resolve issues found. (#47221)
* Resolve unneeded-not.
* Resolve global-at-module-level.
* Resolve useless-import-alias.
* Resolve bad-whitespace.
* Resolve global-variable-not-assigned.
* Resolve logging-not-lazy.
* Resolve comparison-with-itself.
2018-10-18 13:38:08 -07:00
flowerysong 0fc639e755 ec2_tag: Fix removing tags without specifying a value (#47228) 2018-10-18 10:13:08 -04:00
Shuang Wang 0c6513e9b1 add module aws_codecommit to represent AWS CodeCommit (#46161)
* kick off

* done for the day

* beta code and test

* fix a typo

* boto3_conn and boto_exception aren't used in this code, ec2_argument_spec is used but unneeded.

* Returning when find a match avoids doing extra work, especially when pagination is involved

* add new permissions for test

* (output is changed) is preferred over accessing the attribute directly.

* pass the result through camel_dict_to_snake_dict() before returning it.

* AnsibleAWSModule automatically merges the argument_spec.

* deletes the created resources even if a test fails.

* AnsibleAWSModule automatically merges the argument_spec.

* fix typo

* fix pep8

* paginate list_repositories

* specify permissions for test

* cut the unnecessary code.

* add return doc string

* add missed ':'

* fix syntax error: mapping values are not allowed here

* add description for return

* fix syntax error

* rename module name and turn off automated integration test.
2018-10-18 14:32:06 +10:00
maxstack c11aba6ed8 [aws] New key_data argument to ec2_win_password module (#45463)
* add key_data argument

The key_data argument helps when using a private key stored in Vault.

* Add "version_added" line

Add version_added line to pass automated tests.

* remove unnecessary nesting
2018-10-17 14:01:59 -04:00
Aaron 9c08ff7a94 [aws] New module: iam_password_policy (#36200)
* Adding iam_password_policy module

* fixing various issues -- error handling, bugs

* fixing various issues based on tests

* renaming dummy var

* fixing type reference in documentation

* adding int tests and other updates

* removing typo

* fixing auth for int tests

* removing int tests for now

* readding integration tests w/ unsupported designation

* removing conflicting group

* Update aliases

* Fix unused variable
2018-10-17 13:56:13 -04:00
Sloane Hertel b808e1bc5c [s3_bucket] Cast tag keys and values to text to match the values returned (#46405)
* Cast tag keys and values to text to match the values returned

* changelog
2018-10-17 13:39:52 -04:00
Chas Schley 7fd31b1da0 [docs] Include required ARN format of actions in ec2_metric_alarm (#46514)
<!--- Your description here -->

+label: docsite_pr
2018-10-17 13:39:03 -04:00
Petr Ruzicka df57a3fc7a [aws][docs] Replace uses of now-obsolete `with_items` with `loop` (#47164) 2018-10-17 12:35:31 -04:00
Brian Scholer 2043aad582 [aws] ec2_instance: don't report changed when instance is already stopped (#46714) 2018-10-17 12:34:37 -04:00
Per-Henrik Lundblom e744c83808 [aws] ec2_vol_facts: only access volume tags when set (#46801) 2018-10-17 12:31:31 -04:00
David González b923bf708d [aws] Convert containerPort to int before comparing to avoid jinja2 string-int issues (#39215) (#47195) 2018-10-17 12:29:23 -04:00
Abhijeet Kasurde 871dd77f2b efs_facts: Documentation update (#46826)
* Update pydoc
* Update module documentation and example
* Add aliases for name as creation_token

Fixes: #28738

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-15 14:46:24 -04:00
Alicia Cozine e601521708 all amazon modules are community maintained (#46840) 2018-10-11 15:38:54 -04:00
cahlchang 1cce11b39c [AWS] Support check mode in aws ec2_instance module (#46774)
* fix checkmode

* Added checking test to existing test playbook

* Added test for check mode
2018-10-11 14:21:01 -04:00
Abhijeet Kasurde 32397531d0
lambda: fix unboundLocalError in lambda (#46729)
This fix initializes current_version to None so that
module proceeds in check mode.

Fixes: #46654

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-10 22:57:58 +05:30
Abhijeet Kasurde d76a84a6c8 [do
* Add U() in front of URL
* Add period at end of statement
* Spell check

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-10 10:44:17 -04:00
AndyG fcef4fdb26 ec2_asg: adding explanation of replace_all_instances (#46694)
* adding explanation of replace_all_instances

How does "replace_all_instances" work? does it increase the number of instances by 1 in the Load balancer and it scales in a server and waits for it to complete its health check, OR   does it terminate a node a that causes an autoscale event to happen and then adds a new server?
+label: docsite_pr
2018-10-10 19:59:27 +10:00
flowerysong be05069c61 Port the sns module to boto3 (#45634)
* Port sns to boto3

* Exception handling for ARN lookup

* sns: Add integration tests
2018-10-07 16:03:48 -04:00
Abhijeet Kasurde e5878d19de AWS: check dbname attribute before accessing (#46253)
Check dbname attribute in instance before accessing it in RDS module

Fixes: #38210

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-05 16:37:34 -04:00
Will Thames 411397a975 Use recursive_diff for kubernetes (#45645)
Move recursive_diff from cloudfront_distribution to
common.dict_transformations and reuse it in k8s modules
2018-10-02 03:24:52 -04:00
Jason Meridth 667c40e80b Fix typo in ec2_vpnc_nat_gateway module (#46304)
- Added space between `format` and `in` on return item `create_time`
2018-10-01 09:16:04 -05:00
Sloane Hertel 9efc3dc761
Fix ec2_group for EC2-Classic accounts (#46242)
* Fix ec2_group for EC2-Classic accounts

* changelog
2018-09-27 23:11:04 -04:00
Felix Fontein a727a1ee67 [aws] route53 module: fix idempotency for CAA records (#46049)
* Fixing record order for CAA records to properly handle idempotency.

* Add integration tests that reproduce CAA failure
2018-09-27 15:08:47 -04:00
Nathan Webster 3b786acb86 EC2_ASG: Enable support for launch_templates (#45647)
* Enable support for launch_templates in ec2_asg

* Fix asg create with LT and no version number

* Update mutually exclusive list

* Better function names
2018-09-25 16:39:34 -04:00
Abhijeet Kasurde 4b4b21d745 [docs] Fix typos in aws_s3 and s3_bucket module docs (#46106)
Eucalypus to Eucalyptus

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-25 08:57:44 -04:00
Vinay Dandekar fe6b7f6b5d [aws] Change IAM role name parsing to come from the ARN (#45534) 2018-09-24 12:41:23 -04:00
Sloane Hertel 485320aab8 [sns_topic] Don't mask non-authorization errors (#46030) 2018-09-24 11:58:46 -04:00
Dag Wieers f90fc8a9a2 Fix author in modules (#46068)
Fix a few cases where the author was incomplete or incorrect.
2018-09-24 10:14:29 -05:00
Abhijeet Kasurde 0ecbd50c3b Misc typo fixes (#45969)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-21 14:43:22 +01:00
Yanis LISIMA 45c7facd64 ec2_vpc_igw: migrate to boto3 (#45346)
* ec2_vpc_igw: draft migrate to boto3

* ec2_vpc_igw: migrate to boto3

* ec2_vpc_igw: fix error and implement code review

* ec2_vpc_igw: always catch BotoCoreError with ClientError, remove unused fail method

* ec2_vpc_igw: fix pep error
2018-09-20 19:56:19 +10:00
Dag Wieers 197ddd3c45
Fix incorrect type in arg_spec 2018-09-20 02:13:29 +02:00
Dag Wieers 2edf20d1ed Docs: Avoid use of 'default: null' (#45795)
Various modules document the default 'null' value, but it causes None to
be shown in the documentation explicitly.
2018-09-19 09:02:27 -05:00
Julien PRIGENT 6059246093 EFS - add support for new Provisioned Throughput (#43253)
* efs.py: Add support for EFS provisioned throughput

* efs_facts.py: Add support for EFS provisioned throughput

* efs_facts integration tests updated with provision throughput

* efs_facts: Tests refactoring - add failure and success playbook according to botocore version.

* efs_facts: More tests and new option descriptions adjustment

* efs_facts tests renamed to efs
2018-09-19 09:10:56 +10:00
Sloane Hertel 8d2df9be52 ec2_group - fix VPC precedence for security group targets (#45787)
Update the dictionary with the preferred values last to get the right order of VPC precedence

Fixes #45782
2018-09-18 15:33:19 -04:00
Will Thames d2569a3f7d Improve iam_group exception handling (#45599)
* Improve iam_group exception handling

Use AnsibleAWSModule for iam_group and handle BotoCoreErrors
as well as ClientErrors. Use fail_json_aws to improve error messages

* Add minimal iam_group test suite

Update some of the read-only IAM permissions (this is not sufficient
to run the test suite but it gets further than it did until it tries
to add a (non-existent) user)

* Clean up after tests
2018-09-17 19:53:44 -04:00
Sloane Hertel 21f4b5911e [aws] fix version_added for elb_classic_lbmodule (#45559) 2018-09-17 14:32:51 -04:00
Sloane Hertel b42c7f4512 [iam_role] A hyphen with nothing following becomes [None] rather than []. Fix example syntax. (#45742) 2018-09-17 14:32:15 -04:00
Sloane Hertel d7ca3f2bd3 ec2_group: fix regression for targets that are a list containing strings and lists (#45594)
* Fix targets that may be a list containing strings and lists which worked prior to 2.6.

* Add ec2_group integration tests for lists of nested targets

* changelog

* Add diff mode support for lists of targets containing strings and lists.
2018-09-17 14:31:41 -04:00
Jon Cormier 7aaa5da41d [aws_ssm_parameter_store] use describe_parameters paginator (#45632)
Fix the service reaching an internal limit while processing the results and returning unexpected data
2018-09-14 15:17:15 -04:00
Sloane Hertel e5269c047c [AWS] cloudfront_distribution - fix method name from 'validate_distribution_id_from_caller_reference' to 'validate_distribution_from_caller_reference' and set distribution_id to the distribution's key 'Id' (#45498) 2018-09-11 15:08:30 -04:00
Ryan Brown 4d7e261074 [aws] Remove deprecated `ec2_vpc_dhcp_options_facts` alias of ec2_vpc_dhcp_option_facts (#45322) 2018-09-07 09:09:28 -04:00
Ryan Brown 8d363f7693 [aws] Remove deprecated `ec2_vpc_dhcp_options` alias of ec2_vpc_dhcp_option (#45321) 2018-09-07 09:08:09 -04:00
Sloane Hertel 8b341619ae Fix backwards compatibility without providing prefix since boto3 does more parameter validation than boto (#45308)
Use .get() instead of assuming a rule has a Transitions or Filter key (both of which are optional)
2018-09-06 15:44:26 -04:00
Andrew McGilvray 71c4355d58 check for change of role arn in ecs task definition (#44942)
* check role arn for ecs task definition

If the task role in a ECS task definition changes ansible should create a new revsion of the task definition.
2018-09-06 15:43:30 -04:00
Vinay Dandekar 4ce09ea62d [aws] ec2_metadata_facts URL encode the metadata URL to avoid errors (#43394)
- If a field in the URL has a space it would result in a 400 without making it URL safe
- Fixes #42371 and #43378
2018-09-06 15:24:25 -04:00
Rob 7e426b0381 Fix health check configurations being ignored - #43244 (#43247)
* Fix health check configurations being ignored - #43244

* Ensure health_check_protocol is not None before check

* Simplify long indented if statement
2018-09-06 15:19:04 -04:00