Commit Graph

357 Commits (52d499d268f57b962f09170c35adf450ec53ae14)

Author SHA1 Message Date
Keith Hassen f7dfcc153e Fail if any group name is not resolved to an ID. 2016-12-08 11:23:48 -05:00
Daniel Donckers 5c7f72233f Fixes #822 2016-12-08 11:23:48 -05:00
Mike Riddle f0156dda0d Fixed error message: TypeError: fail_json() takes exactly 1 argument (2 given) 2016-12-08 11:23:48 -05:00
Brian Coca 0425d6be39 fixed break order 2016-12-08 11:23:48 -05:00
Tom Paine 0bf5fa1c23 Update ec2_elb_lb.py 2016-12-08 11:23:48 -05:00
Marcin Stolarek d3029a6059 Save changes of special characters to rset, without that comparison rset.to_xml() == wanted_rset.to_xml() will fail if record contains * or @ characters. 2016-12-08 11:23:48 -05:00
Marcin Stolarek 3c7787c05c It may be string with int comparison, if ansible user specifies identifier as int 2016-12-08 11:23:48 -05:00
J Levitt 502717d387 Add rds restore example to list of examples
There was no db restore example. I've provided one that shows how to do the restore, then add a security group (you cannot add the security group during the restore step -- it has to be done in a modify step afterward). Also, I show how to get the endpoint.
2016-12-08 11:23:48 -05:00
Rabenstein 8eb04fe0d3 Squash of 3 commits for bugfix.
Absent unction was not working on user with login profile
also fixed the exception handling

fixed the delete user function
now works with or without loginprofile (password)

typo
2016-12-08 11:23:47 -05:00
Rabenstein 4c08545974 Absent unction was not working on user with login profile also fixed the exception handling 2016-12-08 11:23:47 -05:00
Brian Coca 7517e6366e use marker instead of is_truncated which does not seem to work 2016-12-08 11:23:47 -05:00
Brian Coca 90d084d82b loop to get all load balancers, boto limited to 400 at a time fixes #2115 2016-12-08 11:23:47 -05:00
Kevin Falcone 35e6684163 Mark this as a string so it is rendered in the docs
When this was treated as a boolean, sphinx was leaving the Default
column on http://docs.ansible.com/ansible/ec2_module.html blank,
implying it would use AWS's default.  In reality, it passes False, which
overrides the defaults at AWS (it's possible to boot an instance which
AWS claims will always have EBS optimization without it because of this
silently passed False).
2016-12-08 11:23:46 -05:00
whiter c0d135e44c Allow iam_policy to maintain idempotentce if the role referenced has been removed 2016-12-08 11:23:46 -05:00
Adrian Bridgett 6bc4c877fc remove unneeded aliases 2016-12-08 11:23:46 -05:00
Adrian Bridgett f90bcfee1f add idle_timeout support 2016-12-08 11:23:46 -05:00
Kai Webber 4a8bd74f52 Added launch group support for ec2 module 2016-12-08 11:23:46 -05:00
Toshio Kuratomi 66a4cb5c13 Make cache_parameter_group the name of this new param to match with similar params (leave old name as an alias) 2016-12-08 11:23:46 -05:00
Toshio Kuratomi a692b2e4af Revert "Expose cache_parameter_group_name in elasticache module"
This PR #1950 implements duplicate functionality to #1353
This reverts commit b04efa22c4403ca869e94e7918721306d23afa8d.

Conflicts:
	cloud/amazon/elasticache.py
2016-12-08 11:23:46 -05:00
Brian Coca 4d74c1d508 added missing version added 2016-12-08 11:23:46 -05:00
Greg DeKoenigsberg 248ea2deea Remove @ralph-tice from maintainership per his request 2016-12-08 11:23:45 -05:00
Greg DeKoenigsberg 1c0b231e29 Clarity of owner, even though module is deprecated 2016-12-08 11:23:45 -05:00
Greg DeKoenigsberg 742b452dc1 @lorin stepping down as maintainer 2016-12-08 11:23:45 -05:00
Gilad Peleg 9cb4388f9e Add state=running on some ec2 examples
`state=running` was missing in some of the ec2 module examples
2016-12-08 11:23:45 -05:00
Sarah Haskins 3ad19e75cc Expose cache_parameter_group_name in elasticache module
The cache_parameter_group_name was not previously exposed in
elasticachy.py, I have exposed it, as optional.
2016-12-08 11:23:45 -05:00
Etherdaemon 63c8c40a37 Update try statement as pointed out by defionscode 2016-12-08 11:23:42 -05:00
Toshio Kuratomi a5d95b4047 Another fix for docs 2016-12-08 11:23:42 -05:00
Toshio Kuratomi ac58ef1404 Correct docs build 2016-12-08 11:23:42 -05:00
Constantin Bugneac 55afa7e944 Added documentation for returned structure 2016-12-08 11:23:42 -05:00
Etherdaemon 9fe689eaec fixes #12831 by updating the boto iam connection method to connect_to_region 2016-12-08 11:23:42 -05:00
Constantin Bugneac aa887ce49f Included 'block_device_mapping' in the output of module and other missing attributes 2016-12-08 11:23:42 -05:00
Brian Coca 9f503540f1 added missing version_added to new accesslogs feature 2016-12-08 11:23:42 -05:00
Brian Coca 28749a794a added note on when reboot command became available fixes #2050 2016-12-08 11:23:41 -05:00
Gilad Peleg 295a28e128 Docs: remove redundant quotes in ec2_elb docs 2016-12-08 11:23:41 -05:00
Gilad Peleg c340587bb8 Docs: add state choices to ec2_elb_lb
add state options (`present` and `absent`) to `ec2_elb-lb` doc
2016-12-08 11:23:41 -05:00
Val Komarov 0b294d69c5 Remove duplicate logic 2016-12-08 11:23:41 -05:00
whiter 9ee13c4e55 Add region to doc and handle missing region parameter 2016-12-08 11:23:40 -05:00
Rob 11c0be06fb Update ec2_vol.py
Changed=true now reported on new volume.
Only detach volume when instance is specified as 'None' or '' rather than whenever instance is not specified at all
Fix regression caused by 6b27cdc where by no volume is created if id or Name is not supplied
Remove unnecessary empty aliases
Corrected example to use acceptable parameter for ions
Added exception handling to get_all_instances call
Moved the attachment state validation code to attach_volume function rather than create_volume function
Refactored attach_volume and detach_volume so that changed state can be passed back to call
Created get_volume_info function so that state=present and state=list can return the same data.  Also added instance_id as a returned value in attachment_set dict
Updated aws connection method so that boto profile can be used
2016-12-08 11:23:40 -05:00
Constantin Bugneac 7dd5ec5373 Added deleteOnTermination in the output of list option 2016-12-08 11:23:40 -05:00
Abhijit Menon-Sen e9071c62ba Add missing variable initializations
Without this, «ec2: state=stopped instance_ids=…» would fail with a
traceback like this:

    if inst.get_attribute('sourceDestCheck')['sourceDestCheck'] != source_dest_check:
NameError: global name 'source_dest_check' is not defined
2016-12-08 11:23:40 -05:00
Frank van Tol 5872e0a493 Update ec2_asg.py 2016-12-08 11:23:40 -05:00
Rob ed3d248234 Move import statements for easier debugging (correct line numbers) 2016-12-08 11:23:40 -05:00
Rob 61af70c087 Set default of dimensions parameter to be empty dict 2016-12-08 11:23:39 -05:00
fperks 11dbd985b6 Fix error on ec2 status change
Both `source_dest_check` and `termination_protection` variables are not
available within the scope of the startstopec2 instance method. This just
pulls them from module.params.
2016-12-08 11:23:39 -05:00
Gerard Lynch 27f93bef40 minor doc fix 2016-12-08 11:23:39 -05:00
Shayne Clausson 92f88a4cb4 Replaces 'old' get_ec2_creds connection method with get_aws_connection_info to support passing in security_token for temporary creds. 2016-12-08 11:23:38 -05:00
Alex Kessinger 4d227e508d Fix a argument mismatch in elasticache
I think in this commit 720aeffca2bd2ae1eca158abc2d1463a8597afb6

There was bug introduced where the ElastiCacheManager init method has
a number of positional arguments like so.

```py
    def __init__(self, module, name, engine, cache_engine_version, node_type,
                 num_nodes, cache_port, parameter_group, cache_subnet_group,
                 cache_security_groups, security_group_ids, zone, wait,
                 hard_modify, region, **aws_connect_kwargs):
```

But then later in the code the positional arguments are passed in
like this.

```py
    elasticache_manager = ElastiCacheManager(module, name, engine,
                                             cache_engine_version, node_type,
                                             num_nodes, cache_port,
                                             cache_subnet_group,
                                             cache_security_groups,
                                             security_group_ids, parameter_group, zone, wait,
                                             hard_modify, region, **aws_connect_kwargs)
```

If you count, you can see that cache_subnet_group, is being passed in
where the manager expects to see parameter_group.
2016-12-08 11:23:38 -05:00
Jens Carl 00f9dfac34 Change type of parameter 'template' to 'path'. 2016-12-08 11:23:38 -05:00
Gerard Lynch f85a8ac746 allow use of volume_type in volumes dict 2016-12-08 11:23:37 -05:00
Jens Carl 507111f090 Fix to handle user directory within parameter 'template'. 2016-12-08 11:23:37 -05:00