5a6b893240
Decouple config and state check in vlan and vrf network modules ( #36386 )
...
* Decouple config and state check in {network_os }_vlan and { network_os }_vrf modules
Fixes #35567
Fixes #34754
`interfaces` option is used for configuration as well as operational state
check. If interface is configured to given vlan or vrf but if
operational state of interface is disabled it results in module failure.
Fix is to decouple same option usage for config and state.
With this fix `interfaces` is used as config option and a new
option named `associated_interfaces` will be used for intent check
for assigned interfaces.
* Fix CI failures
* Fix review comment
* Fixed integration test failure
2018-02-26 09:23:54 +05:30
713828804d
nxos_vrf fix ( #36494 )
...
* nxos_vrf fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Address review
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-21 19:33:33 +05:30
9598978e12
fix nxos_pim module doc ( #36505 )
...
* fix nxos_pim module doc
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* address review
2018-02-21 18:42:37 +05:30
f207897f32
fixed conditional error message ( #36476 )
2018-02-21 11:44:18 +05:30
47a92386c9
fix nxos_bgp_neighbor_af issues ( #36472 )
2018-02-21 10:20:24 +05:30
ef7d574920
Fix nxos_banner module for unstructured output ( #36411 )
...
* Fix nxos_banner module for unstructured output
* Refactor and bug fixes
* Fix pep8 error
2018-02-21 09:51:41 +05:30
80d19e6af3
fix nxos_bgp_neighbor issues ( #36318 )
2018-02-20 10:08:17 +05:30
736d6406c0
fix nxos_config json pipeline error ( #36236 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-19 10:11:43 +05:30
6e096cb0c9
Remove kickstart_image_required check ( #36319 )
2018-02-17 10:20:31 +05:30
e24c547a3a
Fixes for the N3500 platform that uses the A8 image ( #36261 )
...
* fix nxos_l3_interface tests as n35 doesn't support ipv6
* add terminal dont-ask to nxos_feature and nxos_lldp
* put interfaces in L2 mode for N35
* fix nxos_feature unit-tests
2018-02-17 10:16:03 +05:30
ac169f5ffd
Fix structured output bug ( #36193 )
2018-02-16 21:34:26 +05:30
75a34f6668
fix nxos_bgp_af issues ( #36147 )
...
* fix nxos_bgp_af issues
* shippable fix
* review comments
* shippable error fix
2018-02-16 09:34:24 +05:30
eab1b62cd2
fix nxos_interface_ospf issues ( #35988 )
...
* fix nxos_interface_ospf issues
* review comment
2018-02-13 09:27:22 +05:30
7a711cf942
Fix nxos_igmp_interface for diff nxos versions ( #35959 )
2018-02-12 10:30:38 +05:30
15b0371eb2
Add examples and language to better showcase the 'parents' parameter in multiple network modules ( #34486 )
...
* Add additional language and examples for 'parents' parameter to clarify its usage.
2018-02-09 13:31:37 +00:00
c7305393a3
fix nxos_evpn_vni issues ( #35930 )
2018-02-09 13:02:41 +05:30
80fcfdc0d1
fix nxos_vpc issues ( #35868 )
2018-02-08 18:50:37 +05:30
dfcae9fc8e
Remove potentially confusing `provider` from module documentation ( #35851 )
2018-02-07 16:33:11 -05:00
c9e0ce1d7d
fix nxos_vpc_interface peer_link idempotence ( #35737 )
...
* fix peer_link idempotence
* review comment
2018-02-07 08:35:43 +05:30
98f804ecb4
nxos_facts: svi support ipv4 ( #35222 )
...
* nxos_facts: svi support ipv4
* nxos_facts: copy paste error
* https://app.shippable.com/github/ansible/ansible/runs/51845/1/tests
* E111 indentation is not a multiple of four
* Update nxos_facts.py
2018-02-06 19:40:12 +05:30
109bc89bbe
fix nxos_ospf_vrf issues ( #35616 )
2018-02-05 10:59:13 +05:30
a4b7df70c7
nxos_vlan ValueError fix ( #35559 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-02 20:51:34 +05:30
dc35baa8db
fix nxos_pim_interface issues ( #35405 )
...
* fix nxos_pim_interface issues
* add absent test for pim_interface
2018-01-31 10:51:11 +05:30
a23c95023b
Module deprecation: docs, scheme and tests ( #34100 )
...
Enforce module deprecation.
After module has reached the end of it's deprecation cycle we will replace it with a docs stub.
* Replace deprecated modules with docs-only sub
* Use of deprecated past deprecation cycle gives meaningful message (see examples below)
* Enforce documentation.deprecation dict via `schema.py`
* Update `ansible-doc` and web docs to display documentation.deprecation
* Document that structure in `dev_guide`
* Ensure that all modules starting with `_` have a `deprecation:` block
* Ensure `deprecation:` block is only used on modules that start with `_`
* `removed_in` A string which represents when this module needs **deleting**
* CHANGELOG.md and porting_guide_2.5.rst list removed modules as well as alternatives
* CHANGELOG.md links to porting guide index
To ensure that meaningful messages are given to the user if they try to use a module at the end of it's deprecation cycle we enforce the module to contain:
```python
if __name__ == '__main__':
removed_module()
```
2018-01-30 12:23:52 +00:00
2293252e52
bug-35431 fixed removing encryption from user on subsequent runs of the task ( #35433 )
2018-01-30 11:26:54 +05:30
f8a89f120f
update nxos_interface doc ( #35350 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-25 20:02:02 +05:30
cff4a2d26e
fix *os_config module backward diff ( #35332 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-25 18:49:20 +05:30
0b30c42902
fix pim rp_address issues ( #35248 )
2018-01-24 11:48:49 +05:30
4bc22be614
Fix for nxos_pim issues ( #35103 )
...
* fix nxos_pim issues
* unused line removed
* unused line removed
* remove unnecessary files
2018-01-22 11:30:52 +05:30
8a6d699198
Enable nxapi nxos_banner test ( #35033 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-18 11:50:15 +05:30
9a32f5c889
Add missing extends_documentation_fragment ( #35013 )
...
NXOS modules need more work, though that will all be in
module_docs_fragments/nxos.py
2018-01-17 16:31:53 -05:00
db61f8f967
Clarify which ping module to use ( #34935 )
...
* Clarify which ping module to use
Ensure each of the ping modules link to each other
ping - Requires Python on remote-node
nxos_ping - Only on Cisco NXOS
ios_ping - Only on Cisco IOS
net_ping - For network devices
win_ping - only for Windows
2018-01-17 14:02:06 +00:00
3a144b290d
fix for nxos_vxlan_vtep_vni issues ( #34946 )
...
* fix vxlan_vtep_vni issues
* pep8 errors
2018-01-17 11:07:29 +05:30
227ff61f9d
Add module support to yamllint sanity test. ( #34964 )
...
* Add module support to yamllint sanity test.
* Fix duplicate keys in module RETURN docs.
* Fix syntax in return_common docs fragment.
* Fix duplicate keys in module EXAMPLES docs.
2018-01-16 15:08:56 -08:00
a727930f07
Remove deprecated params from module argspec nxos modules ( #34911 )
...
* Remove deprecated param from module argspec nxos modules
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix nxos_vrrp syntaxerror
* Add choices for version _nxos_ip_interface
* remove check_args function
* remove include_defaults
2018-01-16 18:23:58 +05:30
195beebcb4
Module DOCUMENTATION should match argspec ( #34895 )
...
* Module DOCUMENTATION should match argspec
Large update of many modules so that DOCUMENTATION option name and
aliases match those defined in the argspec.
Issues identified by https://github.com/ansible/ansible/pull/34809
In addition to many typos and missing aliases, the following notable
changes were made:
* Create `module_docs_fragments/url.py` for `url_argument_spec`
* `dellos*_command` shouldn't have ever had `waitfor` (was incorrectly copied)
* `ce_aaa_server_host.py` `s/raduis_server_type/radius_server_type/g`
* `Junos_lldp` enable should be part of `state`.
2018-01-16 12:18:51 +00:00
a65f702155
add config option to replace argument ( #34342 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-15 21:17:02 +05:30
c04cd8642d
fix vxlan idempotent issue ( #34750 )
2018-01-15 12:27:37 +05:30
303894dd17
fix nxos_banner ( #34695 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-11 21:13:00 +05:30
df8b01aaf7
Handle platform os version for sandbox nxos_nxapi ( #34490 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-11 21:12:00 +05:30
6f8d3ad70d
Fixes for nxos_bgp ( #34590 )
...
* fix bgp issues
* add new tests cases
* review comments
2018-01-10 10:52:26 +05:30
5e6b2495c0
Convert nxos_vrf to DI module ( #34274 )
...
* Convert nxos_vrf to DI module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add purge example and improve logic
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* revert version_added for rd param
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* update test to use network_cli
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-08 10:10:34 +05:30
c371ed8d30
nxos tests to use network_cli ( #34474 )
...
* Fix over-byte
* Fix nxos_l2_interface docs
* Update connections for tasks
* Add default ssh port
* Only report provider when using connection=local
* Send empty provider when connection=network_cli
* Fix find tasks
2018-01-05 12:39:04 -05:00
2be5ad4f08
deprecation dict not live yet ( #34493 )
2018-01-05 03:28:53 -05:00
9d2182bcf8
Deprecate nxos_switchport and Add nxos_l2_interface DI module ( #33813 )
...
* Deprecate nxos_switchport
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add nxos_l2_interface DI module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* pep8 fixes
* aggregate test for nxos_l2_interface
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* revert nxos_switchport test change
* gundalow's comment
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-05 07:44:02 +00:00
e9a5ff912a
nxos_file_copy: fix broken import and 2.6 compatibility ( #34480 )
...
* Fix broken import: paramiko could be missing
* doc: use formatting function
* Use Python 2.6 compatible format string
2018-01-05 11:36:11 +05:30
ab67539bef
Add nxos_lldp module ( #34453 )
...
* Add nxos_lldp module
* Implemetation for nxos_lldp module
* Integration test for nxos_lldp module
* Minor change
2018-01-04 18:06:15 +05:30
552d1df901
Adds parents to mutually_exclusive with src for *_config modules ( #33957 )
...
* mutually_exclusive add - ios_config parents works with lines by not src
* mutually_execlusive parents,src added to all other net modules
* tests for mutually_exclusive parents,src and whitespce removal
2018-01-03 09:47:12 -05:00
80ba767204
Convert nxos_interface to DI ( #34240 )
...
* Convert nxos_interface to DI
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add integration test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* commit for ganeshrn's comment
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-12-28 16:41:09 +05:30
60f3649ebd
Convert nxos_vlan to DI module ( #31866 )
...
* Convert nxos_vlan to DI
* fix conflict
* push fix for qalthos's comment
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-12-21 14:08:33 +05:30
Ganesh Nalawade
Trishna Guha
Lindsay Hill
saichint
Mike Wiebe
rahushen
Tyler
Nathaniel Case
chifu1234
John R Barker
Chip Gwyn
Matt Clay
Pilou
bdowling