7a9916422a
Fixing up error handling for fetch_file ops in connection plugins
...
* enable batch mode (configurable with a config option, on by default)
for sftp transfers, so we can catch errors more easily
* general cleanup in the local connection plugin and fetch action plugin
Fixes #11612
2015-07-22 14:25:47 -04:00
e64989beb4
Moving ConnectionInformation -> PlayContext
...
Also making PlayContext a child class of the Playbook Base class,
which gives it access to all of the FieldAttribute code to ensure
field values are correctly typed after post_validation
Fixes #11381
2015-07-21 12:13:50 -04:00
91a4b866b0
Fix ssh pipelining
2015-07-20 15:40:49 -04:00
2c98b271c8
Make paramiko password detection logic match ssh connection
2015-07-19 02:23:53 -04:00
1c185b68be
Rearranging some become stuff in relation to action/connection plugins
...
Moving the make_sudo_cmd() calls back up to the action level so that connection
plugins don't have to know about it at all, and moving some of the become data
(prompt and success_key) into the ConnectionInformation object so they don't
need to be passed around needlessly.
2015-07-19 01:12:23 -04:00
7a9b5b6fe8
Remove unnecessary make_become_cmd from paramiko exec_command
...
Fixes #11611
2015-07-19 00:08:09 -04:00
2a5fbd8570
Winrm fixes for devel
...
* Include fixes for winrm connection plugin from v1 code
* Fixing shell plugin use
2015-06-29 22:49:25 -04:00
548a7288a9
Use BUFSIZE when putting file as well as fetching file.
2015-06-24 01:00:22 -07:00
270be6a6f5
Fix exec_command to not use a shell
2015-06-23 22:27:45 -07:00
e461241d7b
Fix fetch_file() method
2015-06-23 14:45:44 -07:00
4246777759
Re-implement the ssh connection retry, originally added in 2df690
2015-06-23 12:14:14 -04:00
952166f48e
Fix problem with chroot connection plugins and symlinks from within the chroot.
2015-06-22 20:08:08 -07:00
61e367f549
Better error messages when the file to be transferred does not exist.
2015-06-22 20:08:08 -07:00
102de96ebf
avoid password handling when no password is supplied
2015-06-21 01:24:35 -04:00
3bad03d57a
cleaned up and optimized become handling paths
2015-06-21 01:13:22 -04:00
a77b58e351
Bumpt the BUFSIZE to 64k for better performance
2015-06-19 11:52:06 -07:00
0777d02505
Fix problem with jail and zone connection plugins and symlinks from within the jail/zone.
2015-06-19 11:09:48 -07:00
ca2f2c4ebd
Fix problem with jail and zone connection plugins and symlinks from within the jail/zone.
2015-06-19 09:41:48 -07:00
7bb2a7aa87
actually no password to handle, this should return false
2015-06-18 10:23:37 -04:00
87a0ccc354
fixed typo
2015-06-18 10:12:04 -04:00
aede9f08db
fixed case in which prompt was None
2015-06-18 10:05:23 -04:00
7c65f3ddd7
partial become support for local connection plugin
2015-06-18 01:46:43 -04:00
671118ba71
fixed become password handling with paramiko
2015-06-17 23:31:55 -04:00
744ec2bbad
put hostkey locking into function (still needs fixing)
...
implemneted become handling here, cannot generalize well enough in base class
2015-06-17 23:31:54 -04:00
d6672ad285
removed unused import
2015-06-17 23:31:54 -04:00
5cfd0f82a0
moved away from generic function for become
2015-06-17 23:31:54 -04:00
3fab516d3d
fixed detection of incorrect password
2015-06-17 23:31:54 -04:00
3b1b95b916
moved ipv6 handling to init
...
fixed become password handling
2015-06-16 15:48:10 -04:00
bb7d33adbc
moved become password handlingn to base class
2015-06-16 15:48:10 -04:00
c87591f76f
updated to new exec_command signature
2015-06-16 09:28:27 -04:00
98f5534d9c
adaptaed to new exec signature
...
should fix #11275
2015-06-16 09:12:42 -04:00
dcf81e3ffe
removed useless comments
2015-06-15 15:04:19 -04:00
8ae58f7ea3
fixed executable, correctly this time
2015-06-15 11:26:45 -04:00
1ce1c52f6f
centralized bad password handling, fixed outputing of become method
2015-06-15 01:40:53 -04:00
b89071e485
now detects incorrect password with sudo and su (at least in english)
2015-06-15 01:30:03 -04:00
580993fef7
enabled initial support for password prompt on become
...
- moved check prompt/password functions to connection, make more senes there
- TODO: consider moving make_become to connection from connection_info
- removed executable param that was never overriden outside of connection info
2015-06-15 00:09:25 -04:00
bac35ae773
set correct become mehotds for plugin
...
fixed mixup with remote password vs become_password
2015-06-14 23:49:10 -04:00
c3ccf26b70
added become check back to connections
2015-06-14 23:45:56 -04:00
a248678518
initial become support to ssh plugin
...
- password prompt detection and incorrect passwrod detection to connection info
- sudoable flag to avoid become on none pe'able commands
2015-06-14 23:03:23 -04:00
c8fde467b5
Merge pull request #11163 from sivel/ssh-private-key-fixme
...
Re-introduce ssh connection private key support
2015-06-11 09:16:27 -04:00
e88a9e943c
Use to_bytes to avoid tracebacks when passed a byte str instead of a unicode string
...
Fixes #11198
2015-06-08 11:15:11 -07:00
97bc92d2df
minor cleanup, pushed ipv6 fixing to init
...
pushed up using host short var
made close conditional, started implementing close for controlmaster
2015-06-08 10:52:08 -04:00
bdba807fd1
minor fixes to ssh error reporting
...
shoudl fix #11041
2015-06-06 00:16:35 -04:00
6f5ebb4489
Fix syntax error in winrm
2015-06-05 16:02:29 -05:00
bce281014c
Decorate the ConnectionBase methods, switch to calling super from individual connection classes
2015-06-04 13:27:18 -05:00
9754c67138
Use a decorator to ensure jit connection, instead of an explicit call to _connect
2015-06-04 13:14:28 -05:00
6a97e49a06
Re-introduce ssh connection private key support
2015-06-04 08:15:25 -05:00
7dd3ef7b60
Older python-six from early RHEL and ubuntu do not have add_metaclass but do have with_metaclass
2015-06-03 13:29:24 -07:00
3e2e81d896
missing path in import path for making paths
2015-06-02 23:42:00 -04:00
c4ae51089d
Merge pull request #11129 from sivel/fix-scp-if-ssh
...
Fix command building for scp if ssh
2015-06-02 14:02:51 -05:00
James Cammarata
Toshio Kuratomi
Hugh Saunders
Brian Coca
Brian Coca
Matt Martz