facea1ff0c
Remove unneeded pass
2016-06-13 09:43:51 -07:00
ece1ed09d5
fix for psuedo-connection hostvars not propagating to connection
...
(mostly done by jimi-c, tested working)
2016-06-10 10:14:41 -07:00
b75895df9b
Fix the error handling for loop squashing to restore the name argument into the task args
2016-05-21 07:07:26 -07:00
6f6456dff5
Adding a deprecation message for accelerated mode
2016-05-13 17:01:07 -04:00
4f0be29d65
Reworking retry/until logic to fix bugs
...
Prior to this patch, the retry/until logic would fail any task that
succeeded if it took all of the alloted retries to succeed. This patch
reworks the retry/until logic to make things more simple and clear.
Fixes #15697
2016-05-13 16:09:38 -04:00
b4e78caf25
Merge pull request #15825 from abadger/fix-squashing-traceback
...
If we can't squash for any reason, then simply do not optimize the items loop.
2016-05-12 10:59:48 -07:00
292f0ed0d6
If we can't squash for any reason, then simply do not optimize the items loop.
...
Also add more squashing testcases
Fixes #15649
2016-05-12 10:06:18 -07:00
0d7530e6da
Change error about loop variable in use to a warning
2016-05-11 21:50:12 -04:00
fb7940fc50
check that variable first
...
before using string methods to check for magic interpreter var
2016-05-05 11:14:11 -04:00
2fd7f194c8
Convert byte strings to unicode strings in our task results ( #15581 )
...
Fixes #15367
2016-04-25 12:35:25 -04:00
6eefc11c39
Make the loop variable (item by default) settable per task
...
Required for include+with* tasks which may include files that also
have tasks containing a with* loop.
Fixes #12736
2016-04-19 01:42:40 -04:00
d358a22542
Modification to 347b282 to prevent running the lookup with empty terms
...
Fixes #15258
2016-04-03 11:31:18 -04:00
5b11494437
python3 compatiblity
...
remove use of basestring
deal with configparser
2016-03-24 06:39:21 -07:00
1b242ffb89
Merge pull request #15111 from xiaket/devel
...
complete the docstring. Fixed #14794
2016-03-23 13:13:42 +05:30
f9a9e5e1b9
complete the docstring. Fixed #14794
...
Signed-off-by: 夏恺(Xia Kai) <xiaket@gmail.com>
2016-03-23 07:24:43 +00:00
09e5f0578a
Don't always insert failed in the results (again)
2016-03-10 11:02:55 -05:00
ccf646665b
Revert "Removing explicit setting of failed/failed_when"
...
This reverts commit 4e528e9535
2016-03-10 08:01:54 -05:00
4e528e9535
Removing explicit setting of failed/failed_when
2016-03-10 07:42:16 -05:00
dbff3a6bbc
Fix blind override in failed_when
...
caused all task failures to be success
2016-03-09 17:48:59 -08:00
9318727021
corrected changed_when handling
2016-03-09 16:09:05 -05:00
7067bb32b8
make all conditionals lists
...
this brings them to equivalence with when:
fixes #13905
2016-03-09 09:33:59 -05:00
71402abf21
only do squash when 'squashable field' present
2016-03-01 15:11:34 -05:00
67d5b77898
added package to special 'squashable' fields
...
apt has it as alias, this should fix https://github.com/ansible/ansible-modules-core/issues/3145
2016-02-29 15:21:17 -05:00
512d3dd621
with_ loops always should want a list
2016-02-26 14:56:54 -05:00
34541b4e5e
preserve no_log for async also
2016-02-23 15:37:39 -05:00
e02b98274b
issue callbacks per item and retry fails
...
- now workers passes queue to task_executor so it can send back events per item and on retry attempt
- updated result class to pass along events to strategy
- base strategy updated to forward new events to callback
- callbacks now remove 'items' on final result but process them directly when invoked per item
- new callback method to deal with retry attempt messages (also now obeys nolog)
- updated tests to match new signature of task_executor
fixes #14558
fixes #14072
2016-02-23 15:07:06 -05:00
6cf6130468
Fixing/cleaning up do/until logic in TaskExecutor
...
* Fixes bug where the task was not marked as failed if the number of
retries were exceeded (#14461 )
* Reorganizing logic to be a bit cleaner, and so retrie messages are
shown before sleeping (which makes way more sense)
Fixes #14461
Fixes #14580
2016-02-23 13:17:51 -05:00
d54d9dabe9
added specific info to deprecation message
...
should now show actual variable that is undefined
fixes #14526
2016-02-18 02:21:58 -08:00
347b28252a
allow skipping tasks due to undefined var
...
mimic 1.x behaviour but give out big deprecation message, not only
for missing attribute but any undefined error.
2016-02-11 14:16:38 -05:00
2adddac94c
Catch exceptions during module execution so they don't fail the worker
...
Fixes #14120
2016-02-10 09:22:57 -05:00
0e410bbc8a
Squashing was occuring even though pkgs didn't have a template that would be affected by squash
...
This broke other uses of looping (looping for delegate_to in the
reported bug)
Fixes #13980
2016-01-27 21:55:00 -08:00
1733d434d1
Fix with loop + delegate issues
...
* Don't re-use the existing connection if the remote_addr field of
the play context has changed
* When overriding variables in PlayContext (from task/variables),
don't set the same attribute based on a different variable name
if we had already previously set it from another variable name
Fixes #13880
2016-01-18 17:35:00 -05:00
c42484a029
Minor cleanup when reassigning play context to reused connections
...
* Relocate the assignment of the host address to the remote_addr field
in the play context, which was only done when the connection was created
(it's now done after the post_validate() is called on the play context)
* Make the assignment of the play context to the connection an else, since
it's not required if the connection is not reused
2016-01-18 13:36:40 -05:00
c4cbeeffa8
Fixes #13763 Update connections _play_context on every iteration
...
If this isnt updated, the _connection is reused, and thus has an outdated _play_context
This results in outdated `success_key` and `prompt` causing issues if sudo is run in a loop
Refer to the issue #13763 for more debugging and details
2016-01-11 16:30:52 +08:00
d3deb24ead
output color is now configurable
2015-12-29 17:40:47 -05:00
3ec0104128
Fixing bugs in conditional testing with until and some integration runner tweaks
2015-12-19 21:14:48 -05:00
a3dcb910b8
Fixing bugs with {changed,failed}_when and until with registered vars
...
* Saving of the registered variable was occuring after the tests for
changed/failed_when.
* Each of the above fields and until were being post_validated too early,
so variables which were not defined at that time were causing task
failures.
Fixes #13591
2015-12-18 10:58:55 -05:00
e546219426
Revert "Enable host_key checking at the strategy level"
...
This reverts commit 1a6d660d7e285cceec474952a33af4d8dffd0a8d.
2015-12-17 12:43:47 -05:00
e5c2c03dea
Enable host_key checking at the strategy level
...
Implements a new method in the ssh connection plugin (fetch_and_store_key)
which is used to prefetch the key using ssh-keyscan.
2015-12-16 21:41:07 -05:00
0434644d12
Transform exceptions into ansible messages via to_unicode instead of str to avoid tracebacks.
...
Fixes #13385
2015-12-04 11:50:39 -08:00
65747285a4
Properly check for prompting state when re-using ssh connection
...
Fixes #13278
2015-11-24 09:09:54 -05:00
272778f732
Modify task executor to reuse connection inside a loop. Fix WinRM connection to set _connected properly and display when remote shell is opened/closed. Add integration test using raw + with_items.
2015-11-23 11:53:05 -05:00
478c6c756a
marked spot that should send per item reulsts
2015-11-22 14:44:51 -08:00
78e4f176e6
Return skipped/failed async results directly
...
Fixes #13205
2015-11-19 08:30:00 -05:00
66347c9449
Fix NameError when using loops
...
vars_copy disappeared in 3d1255d190Fixes #13213 .
2015-11-19 09:21:06 +02:00
3d1255d190
Don't update job vars too early when getting loop items in TaskExecutor
...
Fixes #13113
2015-11-18 19:12:38 -05:00
b2b0fa8d13
Changed do/until failed color
...
Fixes #13130
2015-11-11 14:43:15 -05:00
94c20c9ac6
Cleanup failed/changed logic in TaskExecutor
...
Fixes #12980
2015-11-11 14:23:37 -05:00
62979efa14
Finish up plugin porting to global display
...
Also remove display = display which does nothing
2015-11-11 10:44:23 -08:00
186e034515
Move the rest of executor code to global display
2015-11-11 10:44:22 -08:00
Toshio Kuratomi
nitzmahone
James Cammarata
Toshio Kuratomi
Brian Coca
Abhijit Menon-Sen
夏恺(Xia Kai)
Karthik T
Chris Church
Marius Gedminas