Commit Graph

1802 Commits (5e6b8e53274095c7a62b8b4dadf2a9c18ac2e562)

Author SHA1 Message Date
JaegerMaKn 5e6b8e5327
dig lookup: Allow to pass port for DNS lookup (#8966)
dnspython accepts a port as part of the nameserver.

Currently, the nameservers are passed as strings which
leads dnspython to create Nameserver objects out of them
using the port that is currently set in the Resolver instance.
That creation of Nameserver objects is done right when the
`nameservers` property is set.
If a port is to be set by us, the `port` attribute of the
Resolver needs to be set before the nameservers are passed
to the Resolver so when the nameservers are passed, that new
port is used to create the Nameserver objects.
Therefore, the assignment of the `nameservers` property of the
Resolver is moved after the argument processing so the `port`
attribute is (if it's given in the lookup-call) definitely set
before the `nameservers` property.
2024-10-07 22:26:19 +02:00
Tom Paine 24b74cc4b9
opennebula inventory: add VM ID and VM host to data (#8532)
* Add VM id and VM host to opennebula inventory data

##### SUMMARY
<!--- Describe the change below, including rationale and design decisions --> To enable greater use of the inventory, add the ID of the VM, and the hostname of the host the VM is running on to the inventory output

<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->

<!--- Please do not forget to include a changelog fragment:
      https://docs.ansible.com/ansible/devel/community/collection_development_process.html#creating-changelog-fragments
      No need to include one for docs-only or test-only PR, and for new plugin/module PRs.
      Read about more details in CONTRIBUTING.md.
      -->

##### ISSUE TYPE
<!--- Pick one or more below and delete the rest.
      'Test Pull Request' is for PRs that add/extend tests without code changes. -->
- Feature Pull Request

##### COMPONENT NAME
<!--- Write the SHORT NAME of the module, plugin, task or feature below. --> opennebula.py

##### ADDITIONAL INFORMATION
<!--- Include additional information to help people understand the change here --> <!--- A step-by-step reproduction of the problem is helpful if there is no related issue -->

<!--- Paste verbatim command output below, e.g. before and after your change -->
```paste below
                "host": "foo23.host",
                "id": 1234,
```

* Create 8532-expand-opennuebula-inventory-data.yml

* Update opennebula.py

* Update changelogs/fragments/8532-expand-opennuebula-inventory-data.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Add check for empty records and add test

* fix attribute test

* fix attribute test

* fix attribute test

* fix attribute test

* Update plugins/inventory/opennebula.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* update as per guidance

* restore attribute checks

* fix attr

* fix indent

* PR Fixes

* add attribute check in case of empty variable

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Александр Бакановский <abakanovskii@astralinux.ru>
2024-10-07 22:16:29 +02:00
fgruenbauer c814fd0530
keycloak_userprofile: improve diff by deserializing fetched `kc.user.profile.config` and serializing it before sending (#8940)
* deserialize fetched `kc.user.profile.config` and serialize it before sending

* change `kc.user.profile.config` to JSON formatted string in mock `get_component` responses

* add changelog fragment
2024-10-07 22:15:45 +02:00
salty 1bdf8fc025
cloudflare_dns: Update SRV record handling for Cloudflare API changes (#8948) 2024-10-07 22:14:52 +02:00
fgruenbauer 3b109abe18
keycloak_user_federation: add module argument that allows excluding `bindCredential` from update check (#8898)
* add module argument that allows excluding `bindCredential` from update check

* add changelog fragment

* change option name to `bind_credential_update_mode` and change type to str
2024-10-07 22:14:22 +02:00
alexander cc8009621f
ipa_host: Fix enabled and disabled states (#8920)
* Fix ipa_host

* PR Fixes

* PR Fixes

* PR Doc fixes

* PR Doc fixes 2

* Fix default value
2024-10-07 22:13:51 +02:00
fgruenbauer c7e2875a4d
keycloak_user_federation: add user federation config parameter `referral` to module args (#8954)
* add keycloak referral parameter to module args

* add changelog fragment

* Update plugins/modules/keycloak_user_federation.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update changelogs/fragments/8954-keycloak-user-federation-add-referral-parameter.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
2024-10-07 22:13:14 +02:00
Manuel Luzarreta 24f2b980b7
passwordstore: Support subkey creation and update (#8952) 2024-10-07 22:12:43 +02:00
Felix Fontein 29a2df8e6b
udm_user, homectl: use legacycrypt on Python 3.13+ (#8987)
Use legacycrypt on Python 3.13+.
2024-10-07 21:56:37 +02:00
JaegerMaKn 8610223d03
dig lookup plugin: Fix using only last nameserver specified (#8970)
* dig plugin: Fix using only last nameserver given

Currently, when specifying multiple nameservers
either using multiple `@ns.example.com` arguments
or by specifying multiple nameservers in a single
argument (@ns1.example.com,ns2.example.com), due
to a bug only the very last nameserver that is
specified is actually used.
This is because for every iteration of the
    for ns in nsset
loop, the local list of nameservers is cleared
and after adding the currently processed nameserver
entry, the whole `nameservers` list of the Resolver
instance is overridden with that new list with just
one element. And as far as I can see, when setting
that `nameserver` property, the dnspython library
actually overrides the existing list and doesn't
do some trickery to append the new nameservers or
something like that.

Therefore, the assignment of the `nameservers`
property of the Resolver is moved after the argument
processing so all nameservers are added and then
collectively written to the `nameservers` property
of the Resolver.

* Add CHANGELOG fragment
2024-10-05 15:03:04 +02:00
alexander fea0ffa5aa
one_image/one_image_info: refactor (#8889)
* Refactor one_image

* Refactor one_image_info

* Add examples one_image

* Add CHANGELOG fragment

* Add integration tests for one_image

* Add integration tests for one_image_info

* Update one_image DOC

* Update one_image_info DOC

* Update one_image DOC

* Update one_image_info DOC

* Fix f-strings for one_image

* Update CHANGELOG fragment

* PR fixes

* PR fixes
2024-10-05 15:02:01 +02:00
Julien Lecomte e7ccbc2f18
Add gitlab group params (#8908)
Add new gitlab_group parameters
2024-10-04 09:10:43 +02:00
alexander 92df5e8fec
open_iscsi: Make targets optional for a portal login (#8719)
* Make targets optional for a portal login

* Add changelog

* Fix check_rc variable

* Fix idempotence

* Fix linting

* PR fixes

* Linter fixes

* PR fixes

* Change variable name
2024-10-03 15:39:17 +03:00
fgruenbauer 5d9a7ab240
keycloak_user_federation: remove `lastSync` param from kc API responses (#8812)
* remove `lastSync` param from kc API responses

* add blank line to satisfy sanity check

* add changelog fragment

* fix NoneType error introduced by changed normalize func return value
2024-10-03 15:38:09 +03:00
alexander d4fb6bf8a6
nmcli: conn_reload param and up/down states (#8897)
* Update nmcli module

* Update nmcli state

* Update test_nmcli

* Add CHANGELOG fragment

* PR Fixes

* Fix DOCUMENTATION block
2024-10-03 12:37:18 +00:00
Alexei Znamensky c4e2b73193
cmd_runner_fmt: refactor out to its own file (#8964)
* cmd_runner_fmt: refactor out to its own file

* add new file to BOTMETA.yml

* add changelog frag
2024-10-02 21:24:24 +03:00
Járedy Alves 2d660a1252
flatpak: improve flatpak name parsing in `_parse_flatpak_name` (#8909)
* flatpak: improve flatpak name parsing in `_parse_flatpak_name`

* changelog: add changelog fragment

* flatpak: fix condition in `_is_flatpak_id` function

* chore: update changelog fragment

* docs(flatpak): add guidelines for application IDs in comments
2024-10-02 09:48:45 +03:00
fgruenbauer 83080cc005
keycloak_userprofile: fix empty response by removing `parent` filter when fetching userprofile component (#8923)
* remove parent filter when fetching userprofile component

* add changelog fragment

* Update changelogs/fragments/8923-keycloak_userprofile-fix-empty-response-when-fetching-userprofile.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
2024-10-02 09:48:04 +03:00
Felix Fontein 7c913b239a
Pass absolute paths to atomic_move() (#8925)
Pass absolute paths to atmoic_move().
2024-10-01 21:55:04 +03:00
Alexei Znamensky a7d1b0fc52
python_runner/django_command: bugfixes (#8944)
* python_runner/django_command: bugfixes

* fix indentation

* join path_prefix with : when concatenating with PATH

* add changelog frag
2024-09-30 09:45:32 +03:00
Felix Fontein fe18b05f08
10.0.0: remove deprecated features (#8918)
* Remove pool option from redhat_subscription.

* Remove proxmox_default_behavior option from proxmox_kvm.

* Remove the logging option from ejabberd_user.

* Remove the ack_params_state_absent option from consul.

* irc: change defaults of use_tls and validate_certs to true.

* rhsm_repository: remove states present and absent.

* Re-add 'using'.

* Fix typo.
2024-09-28 08:11:21 +03:00
Pierre-yves Fontaniere 84e0190eee
Disk description now contains a StorageId and a RedfishURI (#8937)
* Disks controller is now uniquely identified by the controller ID

* Fix typo `StorageID` to `StorageId`

* Add changelog fragments

---------

Co-authored-by: Pierre-yves FONTANIERE <pyf@cc.in2p3.fr>
2024-09-27 22:30:54 +03:00
Alexei Znamensky 002f137134
10.0.0: CmdRunner: remove deprecated feature (#8928)
* remove deprecated feature

* remove deprecated feature from tests as well

* Adjust the integration test

* add changelog frag
2024-09-26 12:01:36 +03:00
alexander 0bc5f24863
one_service: fix recreation (#8887)
* Fix one_service unique creation

* Revert empty space

* Add CHANGELOG fragment

* Update CHANGELOG fragment
2024-09-26 11:30:57 +03:00
Alexei Znamensky 4700accbff
CmdRunner: missing parameter for get_best_parsable_locale() (#8929)
* CmdRunner: missing parameter for get_best_parsable_locale()

* add changelog frag
2024-09-26 09:49:15 +03:00
Felix Fontein d356e255e0
Deprecate hipchat module (#8922)
Deprecate hipchat module.
2024-09-25 22:02:33 +03:00
Per Fide 89ad40db41
proxmox inventory: remove duplicated credentials line (#8917)
* proxmox inventory: remove duplicated credentials line

* fixup! proxmox inventory: remove duplicated credentials line

* fixup! proxmox inventory: remove duplicated credentials line
2024-09-25 13:54:46 +03:00
alexander a32f1d699b
ipa_hostgroup: fix state params (#8900)
* Fix ipa_hostgroup

* Add CHANGELOG fragment
2024-09-23 21:32:39 +03:00
fgruenbauer deaad6e547
keycloak_realm: fix change detection in check mode by normalizing realms beforehand (#8877)
* keycloak_realm: fix change detection in check mode by normalizing realms beforehand

* add changelog fragment
2024-09-23 21:29:40 +03:00
Alexei Znamensky 0bf84ba2b6
fix comprehension (#8895)
* fix comprehension

* add changelog frag

* Update changelogs/fragments/8895-fix-comprehension.yaml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
2024-09-22 13:09:36 +03:00
alexander 38479ee9ff
npm: Add force flag (#8885)
* Add force flag for nmp module

* Add CHANGELOG fragment

* Add force to cmdrunner

* Update CHANGELOG

* Add comma
2024-09-21 10:31:50 +03:00
fgruenbauer ac302eb77d
keycloak_user_federation: set `krbPrincipalAttribute` to `''` if unset in kc responses (#8785)
* set `krbPrincipalAttribute` to `''` if unset in kc before and after responses

* add changelog fragment

* Update changelogs/fragments/8785-keycloak_user_federation-set-krbPrincipalAttribute-to-empty-string-if-missing.yaml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
2024-09-21 10:30:40 +03:00
Alexei Znamensky 6af74d1ba6
multiple modules: improve dict.items() loops (#8876)
* multiple modules: improve dict.items() loops

* simplify in memset_* modules

* add changelog frag
2024-09-18 17:34:19 +02:00
Mike Raineri 80f48cceb4
Redfish: Added steps to allow a user to change their password when their account requires a password change (#8653)
* Redfish: Added steps to allow a user to change their password when their account requires a password change

Signed-off-by: Mike Raineri <michael.raineri@dell.com>

* Bug fix

Signed-off-by: Mike Raineri <michael.raineri@dell.com>

* Bug fix

Signed-off-by: Mike Raineri <michael.raineri@dell.com>

* Bug fixes with return data handling

Signed-off-by: Mike Raineri <michael.raineri@dell.com>

* Added changelog fragment

Signed-off-by: Mike Raineri <michael.raineri@dell.com>

* Update changelogs/fragments/8652-Redfish-Password-Change-Required.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Signed-off-by: Mike Raineri <michael.raineri@dell.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
2024-09-18 17:33:30 +02:00
Alexei Znamensky 94472dd7e5
use dict comprehension in plugins, part 4 (#8858)
* use dict comprehension in plugins, part 4

* add changelog frag
2024-09-13 22:41:53 +02:00
Alexei Znamensky 37dd6ec8a3
jira: adjust module for old vardict deprecation (#8856)
* jira: adjust module for old vardict deprecation

* add changelog frag
2024-09-13 22:40:48 +02:00
Alexei Znamensky 41d87f5c9d
gio_mime: adjust module for old vardict deprecation (#8855)
* gio_mime: adjust module for old vardict deprecation

* add changelog frag
2024-09-13 22:40:34 +02:00
fgruenbauer 2ae41fa83f
keycloak_user_federation: get the before mappers from `before_comp` to fix `UnboundLocalError` (#8831)
* fix: get the before mappers from `before_comp`

* add changelog fragment

* Adjust changelog fragment.

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
2024-09-09 14:05:48 +02:00
Björn Bösel ea389e7045
bugfix(keycloak): fix parameters for realm key creation (#8823)
* bugfix(keycloak): fix parameters for realm key creation

* supply changelog fragment

* fix formatting

* fix formatting

* Update changelogs/fragments/8823-keycloak-realm-key.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
2024-09-08 14:25:33 +02:00
fgruenbauer 982b8d89b7
keycloak_user_federation: sort desired and after mappers by name (#8761)
* sort desired mappers by name

* sort mappers fetched after update by name

* only sort mapper list if there are desired mappers specified

* add fallback `''` in case `name` is not a key or `None` when sorting mappers

* add changelog fragment
2024-09-08 14:23:27 +02:00
Alexei Znamensky 26df6c7657
use dict comprehension in plugins, part 3 (#8833)
* use dict comprehension in plugins, part 3

* add changelog frag
2024-09-08 14:22:37 +02:00
Alexei Znamensky 43f8adf1a5
pipx: add new states (#8809)
* ensure minimum version of pip

* ensure pipx 1.7.0 is installed

* pipx: add new states/params

* add tests

* add license to json file

* Update plugins/modules/pipx.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* fix uninject tests

* add changelog frag

* fix doc per review

* refactor license out of pipx spec file

* Update plugins/modules/pipx.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update tests/integration/targets/pipx/files/spec.json.license

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
2024-09-07 09:49:16 +12:00
Alexei Znamensky 7e978c77b4
use dict comprehension in plugins, part 2 (#8822)
* use dict comprehension in plugins

* add changelog frag
2024-09-05 21:47:28 +02:00
Alexei Znamensky ecc048bc12
Use dict comprehension in plugins (#8814)
* use dict comprehension in plugins

* Apply suggestions from code review

* add changelog frag

* fix references in changelog frag
2024-09-01 20:22:53 +02:00
Simon Siebert 249126f429
proxmox inventory: fixing possible concatenation error (#8794)
* Fixing possible concatination error

* Create 8794-Fixing-possible-concatination-error.yaml

* Update 8794-Fixing-possible-concatination-error.yaml

Updating changelog
2024-09-01 20:22:38 +02:00
Shubham Singh Sugara 96d5e6e50e
copr: add includepkgs functionality (#8779)
* Limit package for Copr using includepkgs

* Limit package for Copr using includepkgs

* Limit package for Copr using includepkgs

* Limit package for Copr using includepkgs

* Limit package for Copr using includepkgs

* Added changes in copr module

* Excludepkgs parameter add

* Update module and params to handle a list + Docs updated

* Update module and params to handle a list + Docs updated
2024-08-26 20:09:19 +02:00
Veikko Virrankoski e9071e9871
Fix gitlab access token crash in check mode for new tokens (#8796)
Fix crash in check mode when attempting to create a new gitlab access token
2024-08-26 10:21:52 +02:00
Alexei Znamensky 9c9c4cbc3e
pipx/pipx_info: add parameter `global` (#8793)
* pipx/pipx_info: add new parameters

* add test for --global, refactor int test main file

* ensure initial state of test

* ensure PATH includes /usr/local/bin

* ensure PATH includes /usr/local/bin for entire block

* ensure minimum version of pip

* ensure pipx 1.6.0 is installed

* push recommendation for pipx 1.7.0 instead of 1.6.0

* add changelog frag

* add deprecatons to changelog frag

* add deprecatons to changelog frag, better

* Update changelogs/fragments/8793-pipx-global.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update changelogs/fragments/8793-pipx-global.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
2024-08-26 10:21:09 +02:00
Veikko Virrankoski 573a7b97c6
Fix gitlab_project container_expiration_policy for project create (#8790)
* Fix gitlab_project container_expiration_policy for project create

* Check for container_expiration_policy presence before renaming it

* Add missing links to changelog fragment

* Fix changelog grammar
2024-08-25 17:01:05 +02:00
Alexei Znamensky 4598758419
MH cause_changes: deprecate params (#8791)
* MH cause_changes: deprecate params

* add changelog frag

* Update changelogs/fragments/8791-mh-cause-changes-param-depr.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
2024-08-25 16:58:03 +02:00