ae2447df91
attribute defaults that are containers are a copy
...
This is simpler way to prevent persistent containers across instances
of classes that use field attributes
2015-12-09 08:40:06 -08:00
2820b4c243
removed default from hosts to make it requried
...
prevents writing a play w/o a hosts entry which would default to
all/empty
2015-12-09 08:40:06 -08:00
c64298de02
Revert "avoid persistent containers in attribute defaults"
...
This reverts commit 87969868d4
2015-12-09 08:40:06 -08:00
87969868d4
avoid persistent containers in attribute defaults
...
moved from the field attribute declaration and created a placeholder
which then is resolved in the field attribute class.
this is to avoid unwanted persistent of the defaults across objects which introduces
stealth bugs when multiple objects of the same kind are used in succession while
not overriding the default values.
2015-12-09 07:29:36 -08:00
398f6bbb89
Fix typo from 5ae850c
2015-12-08 14:36:36 -05:00
de690445bc
Make fact delegating configurable, defaulting to 1.x behavior
2015-12-08 14:36:33 -05:00
d4ccb0be59
have always_run override check mode for a task
...
Fixes #13418
2015-12-08 09:24:07 -08:00
540cbe0f64
Merge pull request #13445 from n-st/tasks-string-repr
...
More meaningful string representation for meta tasks (like 'noop' and 'flush_handlers')
2015-12-07 08:10:54 -05:00
955710267c
only set become defaults at last possible moment
...
tasks were overriding commandline with their defaults, not with the
explicit setting, removed the setting of defaults from task init and
pushed down to play context at last possible moment.
fixes #13362
2015-12-05 16:03:50 -05:00
a1f6d17e37
More meaningful string representation for meta tasks (like 'noop' and 'flush_handlers')
2015-12-05 15:55:39 +01:00
5f83a6aeda
Properly default remote_user for delegated-to hosts
...
Fixes #13323
2015-12-03 11:31:33 -05:00
5f1f2acfea
Merge pull request #13405 from sivel/v2-playbook-on-start
...
Get v2_playbook_on_start working
2015-12-02 12:40:24 -05:00
384b2e0234
Get v2_playbook_on_start working
...
* Move self._tqm.load_callbacks() earlier to ensure that v2_on_playbook_start can fire
* Pass the playbook instance to v2_on_playbook_start
* Add a _file_name instance attribute to the playbook
2015-12-02 11:29:51 -06:00
ce54a59cdc
Catch additional assertion errors for load_list_of_blocks
2015-12-02 10:35:20 -06:00
53cd802251
better error on invalid task lists
2015-12-02 08:14:20 -08:00
b92cb93539
unconditionally set vars on init to avoid issues with var precedence
2015-12-01 21:24:46 -08:00
a6f6a80caa
avoid inheritance issues with default=dict declaration at class level
...
this should avoid the issue of subsequent plays not prompting for a var
prompted for in a previous play.
2015-12-01 08:18:31 -08:00
dc0fae1af7
Also make sure remote_user is defaulted correctly for delegated hosts
...
Fixes #13323
2015-11-30 16:15:14 -05:00
cc36eedf76
Ensure port is (re)set for delegated-to hosts
...
Fixes #13265
2015-11-30 14:40:23 -05:00
1b743436b9
Do not double transform to unicode
2015-11-25 07:48:52 -08:00
157230c3e8
Merge pull request #13257 from chrrrles/utf8
...
fixing error with using non-ascii values for ask-sudo-password
2015-11-25 11:52:17 +09:00
1e5a205389
fixing errors with utf-8 values
...
removing utf-8 stanza
changing cast to binary_type instead
using to_unicode
2015-11-25 11:47:25 +09:00
e06b107d2d
Template (and include vars) PlaybookInclude paths
...
Fixes #13249
2015-11-23 11:54:06 -05:00
91500f8f5f
Fix include param precedence in variable manager
2015-11-19 09:01:51 -05:00
984729016e
Fix tag filtering on included files and add more debugging
...
Previously, we were filtering the task list on tags for each host
that was including the file, based on the idea that the variables
had to include the host information. However, the top level task
filtering is play-context only, which should also apply to the
included tasks. Tags cannot and should not be based on hostvars.
2015-11-16 17:15:52 -05:00
eeedaf2cbc
fixed var name typo
2015-11-15 08:43:42 -08:00
e174247734
evaluate includes for skipped tags
...
cannot evaluate for include tags as underlying tasks might have them, but skips override so this should be a performance boost
2015-11-15 07:51:36 -08:00
62979efa14
Finish up plugin porting to global display
...
Also remove display = display which does nothing
2015-11-11 10:44:23 -08:00
7ecfa072da
Move the rest of the playbook code to use global display
2015-11-11 10:44:22 -08:00
c7b69127ec
Remove dead code
2015-11-11 08:12:21 -08:00
e36b4e2a13
Merge pull request #13072 from Yannig/devel_cache_optimization
...
Cache optimization
2015-11-09 14:54:06 -05:00
76ae577519
Ensure environment is inherited properly (task->block/include->play)
2015-11-09 14:51:07 -05:00
12a6fb9633
Small speed improvement with huge inventory (100+ hosts).
2015-11-07 19:32:10 +01:00
226c7f4c7b
Revert "added setting of ansible_ssh_user to current user as backwards compatibilty issue"
...
scope was wrong, this var should not be 'reset' here.
This reverts commit c271c0eb04
2015-11-06 08:31:56 -05:00
299054852a
Allow tags to be specified in included file params
...
Fixes #12940
2015-10-28 10:14:20 -04:00
b2fc5142eb
moved sudo -S and -n into configurable flags as they might be absent in much older systems
...
if password is supplied exsiting -n would get remove from flags
2015-10-28 02:06:25 -04:00
7334389de6
Merge pull request #12930 from ansible/dict-key-overwrite-warning
...
Break apart a looped dependency to show a warning when parsing playbooks
2015-10-27 12:44:01 -07:00
4203850d1a
Break apart a looped dependency to show a warning when parsing playbooks
...
Display a warning when a dict key is overwritten by pyyaml
Fixes #12888
2015-10-27 12:39:42 -07:00
3fc2209ca0
Fixing retry/until logic and default value for retries
...
Fixes #12928
Fixes #12929
2015-10-27 15:37:48 -04:00
1dc23ea779
Merge pull request #12866 from bcoca/more_inheritence
...
More inheritence
2015-10-27 14:46:42 -04:00
c271c0eb04
added setting of ansible_ssh_user to current user as backwards compatibilty issue
2015-10-26 16:10:13 -04:00
677a2f95e5
Make sure Base attributes are copied cleanly
...
Fixes #12882
2015-10-26 12:09:58 -04:00
914f68f9af
allow include: directive to work during exception processing
...
prior to this commit, an attempt to use the `include:` directive would
fail in a `rescue:` or `always:` block if there were failures in the
main block task list.
Resolves #12876 .
2015-10-22 22:12:20 -04:00
86de1429e5
Cleaning up FIXMEs
2015-10-22 16:03:50 -04:00
54e821ca94
added deprecation warning to comma separated role spec
2015-10-22 08:10:51 -04:00
d861e7dd5d
moved several directives so they are not settable at play, block, role and task levels
2015-10-22 07:51:22 -04:00
002972c6cf
Allow meta/main.yml to include roles through spec file
...
ansible-playbook now works when run with a playbook
that includes a role that includes another role
specified using csv format
Updated one of the roles used in the tests to fix
broken tests - `make test_galaxy` now works
Fixes #11486 . Also addresses the problem alluded to in #10620 .
2015-10-22 13:30:42 +10:00
2b3c5aa41e
Support cmd param in Tasks by assigning it to _raw_params
...
Fixes #12856
2015-10-21 15:47:09 -04:00
1ecad5aed2
now galaxy correctly detects empty requirements file
...
also allow for 'scm' and 'src' not to be populated in requirements entries
2015-10-20 14:39:22 -04:00
b46ce47a84
Don't use local transport for delegated hosts if the inventory_hostname isn't local
...
For some situations like Vagrant, the remote_addr may be a localhost addr, but ssh
is still desired. This corrects the assumption that any localhost remote_addr should
be using the local connection by checking the inventory_hostname value as well.
Fixes #12817
2015-10-20 14:04:39 -04:00
Brian Coca
James Cammarata
Nils Steinger
Matt Martz
Toshio Kuratomi
Chrrrles Paul
Charles Paul
Yannig Perré
Toshio Kuratomi
Lars Kellogg-Stedman
Will Thames