Peter Sprygada
25294f40c8
bug fix in ios_config module for handling config contents
...
Config contents when passed via argument were returning a string but
the module expects an instance of NetworkConfig. This fixes that
problem.
2016-12-08 11:24:44 -05:00
Peter Sprygada
43ba7f3b3b
removes unneeded check_args function from ios_command
...
The module would raise a KeyError trying to find the save_config key
which is not present in the argument_spec. This was caused by the
check_args() function. Since the ios shared argument spec isn't used
the check_args function is not needed and has been removed.
2016-12-08 11:24:43 -05:00
Peter Sprygada
438b9328ea
fixup ios_template module to use NetworkModule
...
This removes the get_module() factory function and directly creates
an instance of NetworkModule. This commit includes some minor clean
up to transition to the ios shared module for 2.2
2016-12-08 11:24:43 -05:00
Peter Sprygada
66268dd3ec
fix up ios_command to use NetworkModule
...
* using check mode will now block all commands except show commands
* module will no longer allow config mode commands
* check args for unused values and issue warning
2016-12-08 11:24:43 -05:00
Peter Sprygada
5fe848fca2
refactor ios_config for network module
...
This refactors the ios_config module to use the network module added
in 2.2 to simplify common network functions
new features
* add src, dest arguments for working with config
* results now return flag if the config was saved or not
* adds append argument for updating the dest file (when dest is used)
2016-12-08 11:24:42 -05:00
Peter Sprygada
28a701128d
update ios_facts module to use NetworkModule
...
minor update to ios_facts to remove get_module() in favor of NetworkModule
2016-12-08 11:24:42 -05:00
Stian Vikan
714ced8e1c
Fixed delete statement for juniper_config.py #4007 #3984
2016-12-08 11:24:40 -05:00
Peter Sprygada
b0bdf09a00
refactor ios_command to use CommandRunner class
...
* fixes running commands in check mode. now only show commands are allowd
* renamed waitfor to wait_for with alias to waitfor for consistency
2016-12-08 11:24:40 -05:00
Peter Sprygada
622592c413
refactor the eos_command module to use the CommandRunner
...
* This adds support the CommandRunner to handle executing commands on
the remote device.
* It also changes the waitfor argument to wait_for to remain compatable
with other modules and adds an alias for waitfor.
* Restricts commands to show commands only when check mode is specified.
* add version_added to wait_for doc string
2016-12-08 11:24:39 -05:00
Peter Sprygada
a522c2d99f
initial add of ios_facts module
...
This adds the new module ios_facts for collect fact information from
ios devices
2016-12-08 11:24:39 -05:00
Brian Coca
01490688f4
document that get_url also takes file params
...
has for a long time, but was never documented, mode,group, owner can all be set here
2016-12-08 11:24:37 -05:00
Brian Coca
34b94ec4c4
Revert "Add mode option to the list" ( #3946 )
2016-12-08 11:24:37 -05:00
Victor Bocharsky
6037684d23
Add mode option to docstring for get_url ( #3630 )
...
Add mode option to the list
2016-12-08 11:24:37 -05:00
jctanner
48f096b52c
Use the six import for urlsplit instead of importing directly. ( #3902 )
...
Fixes https://github.com/ansible/ansible/issues/16191
2016-12-08 11:24:36 -05:00
Peter Sprygada
d8cb09a121
removes requirement for config argument to be specified in junos_facts
...
The config argument is optional and should not be required. This
removes the required attribute from the config argument.
fixes #3878
2016-12-08 11:24:36 -05:00
Toshio Kuratomi
79d12db02f
Fix the six import
2016-12-08 11:24:35 -05:00
Toshio Kuratomi
8ba0af5df3
Be sure to import urllib.parse from somewhere
2016-12-08 11:24:35 -05:00
Gabriele
1977b42956
Fixing bug, added missing param ( #3737 )
2016-12-08 11:24:31 -05:00
Wolfgang Powisch
20d9c0c484
Update junos_facts.py ( #3759 )
2016-12-08 11:24:31 -05:00
Michael Scherer
c0217e14a7
Convert the network subfolder to py3/py2.4 syntax ( #3690 )
2016-12-08 11:24:29 -05:00
Mike Bryant
0027158b74
junos_template: Simplify arguments. Fixes #3621
...
Simplify the arguments to junos_template, such that
merge/overwrite/replace can be selected easily.
2016-12-08 11:24:29 -05:00
Kei Nohguchi
d738ad0ee0
ops_template.py: Change integer key into stirng
...
This fix passing the update variable to the str()
so that it avoids the exception when ops.dc.read()
returns a dictionary which contains non-string keys.
This is due to the fact that some of the key types in
OpenSwitch schema are actually defined as integer
and ops.dc declerative config module encode those
in integer inside the dictionary. This could be
the right encoding from the schema point of view
but someone needs to convert it to the string
somewhere, as JSON key should be string.
2016-12-08 11:24:29 -05:00
Michael Scherer
abfc8d36a8
Add a test on jnpr.junos.utils.sw presence ( #3666 )
2016-12-08 11:24:28 -05:00
Toshio Kuratomi
291e00d43a
Docs fixes
2016-12-08 11:24:28 -05:00
Brian Coca
ca7defeee5
made note about slurp memory consumption
2016-12-08 11:24:27 -05:00
Johannes Meixner
af634ff5c7
network/*/*_config.py: Correct typo.
...
- Replace syntanx with syntax in all things network.
2016-12-08 11:24:27 -05:00
Scott Butler
e606a1237b
Fixed typos
2016-12-08 11:24:27 -05:00
John R Barker
d13046a905
ansible-validate-modules part 4: Enable check on ansible-modules-core ( #3526 )
...
* Call ansible-validate-modules
* Correct quotes + add newline
2016-12-08 11:24:26 -05:00
Peter Sprygada
bf200458d3
fixes docstring issue for junos_config arguments
...
The docstring was incorrectly merged with some old entries that will
cause the documentation not to build correclty. It is now fixed.
2016-12-08 11:24:24 -05:00
jedelman8
28db5b7dd1
add nxos_interface
2016-12-08 11:24:24 -05:00
James Cammarata
124c4b94c1
Remove extraneous debug stuff from uri module left over from testing
2016-12-08 11:24:23 -05:00
James Cammarata
50cd8b0aa5
Make sure uri output contains json output when a non-200 status is returned
...
Prior to the switch to the urls.py code, non-200 responses contained
a 'json' value when the content-type was JSON. This fix restores that
field upon a non-2xx response.
Fixes ansible/ansible#15555
2016-12-08 11:24:23 -05:00
Nathaniel Case
75dbe9f1e8
Remove unnecessary exception from nxos_command ( #3521 )
2016-12-08 11:24:23 -05:00
Peter Sprygada
8729bcde3f
adds new module junos_package
...
the new module allows playbook designers to manage packages on remote
devices running junos.
2016-12-08 11:24:22 -05:00
Peter Sprygada
ef794d95e5
adds new module ops_facts
...
This adds a new module for collect device facts from remote devices
running OpenSwitch. This module is useful when collecting fact information
over CLI transport.
2016-12-08 11:24:22 -05:00
GGabriele
b375f61d2b
Fixed doc
2016-12-08 11:24:22 -05:00
GGabriele
9aeaa70e32
Changed module name to nxos_facts
2016-12-08 11:24:22 -05:00
GGabriele
693f7c938e
Fixing bugs
2016-12-08 11:24:22 -05:00
GGabriele
84ecc21677
Adding nxos_ip_interface
2016-12-08 11:24:22 -05:00
GGabriele
02744e7cab
Adding nxos_vrrp
2016-12-08 11:24:22 -05:00
GGabriele
f4fd69bcff
Adding nxos_ping
2016-12-08 11:24:22 -05:00
jedelman8
be91a5622a
fix index for portchannel
2016-12-08 11:24:22 -05:00
GGabriele
10238bbb06
fix conditional for py24
2016-12-08 11:24:22 -05:00
jedelman8
cda210c3f9
fix docstring
2016-12-08 11:24:22 -05:00
jedelman8
ad9ede5d4c
force travis build
2016-12-08 11:24:21 -05:00
jedelman8
89aabffee8
minor test
2016-12-08 11:24:21 -05:00
jedelman8
01b8f7db5e
update return doc string
2016-12-08 11:24:21 -05:00
GGabriele
66eea14df2
Fixed RETURN string
2016-12-08 11:24:21 -05:00
GGabriele
0798968596
Fixed RETURN string and added notes
2016-12-08 11:24:21 -05:00
GGabriele
97577df048
Fixing nxos_vrf
2016-12-08 11:24:21 -05:00
GGabriele
62b0b48f58
Adding nxos_vrf_interface
2016-12-08 11:24:21 -05:00
GGabriele
2c43f6b35c
Adding nxos_vrf
2016-12-08 11:24:21 -05:00
GGabriele
b4d69262ed
Adding nxos_get_facts
2016-12-08 11:24:21 -05:00
GGabriele
95992b91bd
Addng nxos_feature
2016-12-08 11:24:21 -05:00
jedelman8
6ae109630e
add nxos_vlan
2016-12-08 11:24:21 -05:00
jedelman8
5ef3a6430a
add nxos_switchport
2016-12-08 11:24:21 -05:00
Peter Sprygada
a9b664c796
add support for netconf to junos_config
...
The junos_config module now supports the netconf transport.
2016-12-08 11:24:21 -05:00
Peter Sprygada
abb008dca7
fixes docstring format in junos_command
2016-12-08 11:24:21 -05:00
Peter Sprygada
89ebc8b066
adds config_format argument to the facts module
...
this change adds config_format argument with choices of xml, set or text to
specify the desired format of the config returned from the remote device. The
default value is text
2016-12-08 11:24:21 -05:00
Peter Sprygada
9d521aa7e0
Merge pull request #9 from dgarros/junos_modules
...
Add support for xml, set and text format for config
2016-12-08 11:24:21 -05:00
Peter Sprygada
1985115e55
adds new module junos_netconf used for configuring netconf services
...
This module allows playbook operators to configure the netconf service in
junos for use with other juniper modules.
2016-12-08 11:24:20 -05:00
Peter Sprygada
2072922875
adds new junos_facts module
...
The junos_facts module will collect basic system inforamtion about remote
devices running the Junos operating system
2016-12-08 11:24:20 -05:00
Peter Sprygada
871e586ce3
add support for netconf to junos_template
...
This commit adds support for sending full syntanx junos configurations using
junos_template and netconf
2016-12-08 11:24:20 -05:00
Peter Sprygada
923974e3c0
add support to junos_command module for netconf transport
...
This adds support for using netconf to the junos_command option and removes
the use of cli as a transport
2016-12-08 11:24:20 -05:00
jctanner
56f5ca37af
Fix status check on get_url with file schemas and update the examples. ( #3512 )
...
Addresses #3511
2016-12-08 11:24:20 -05:00
Brian Coca
34a3bc043a
removed usless default doc
2016-12-08 11:24:19 -05:00
Justin Kennedy
ab4b8e0847
Updating examples to include required fields ( #3242 )
...
Updated examples to include required fields (host, username). Also updated src option to be listed as required.
2016-12-08 11:24:19 -05:00
Kei Nohguchi
fc5ade4020
ops_template.py: Taking care of the JSON src variable ( #3313 )
...
* ops_template.py: Taking care of the JSON src variable
* ops_template.py: Specify type='str' for src argument to be explicit
2016-12-08 11:24:18 -05:00
Patrick Ogenstad
d4d86b4bc6
Fix documentation example, missing ")"
2016-12-08 11:24:18 -05:00
John Barker
d531eb146d
Replace BOOLEANS with true/false
2016-12-08 11:24:17 -05:00
Peter Sprygada
ef8b59f430
handles config replace properly in eos_template
...
fixes 3366
2016-12-08 11:24:16 -05:00
Peter Sprygada
8210ede9b4
refactor iosxr_template module to remove old diff functions
...
this replaces the old diff functions with the netcfg shared module for
handling configuration diffs between running and candidate
2016-12-08 11:24:16 -05:00
Peter Sprygada
bba38d2cf8
refactor iosxr_config module to remove old diff functions
...
this replaces the old diff functions with the netcfg lib for handling
configuration diffs between running and candidate configurations
2016-12-08 11:24:16 -05:00
Peter Sprygada
c2c8d51ba2
cleanup iosxr_command module to be consistent with other network modules
...
this cleans up some of the function calls and output keys to be consistent
with other command modules
2016-12-08 11:24:15 -05:00
Peter Sprygada
834bc225c9
refactors nxos_template and removes diff functions
...
replaces the diff functions with the netcfg shared module for handling
configuration diff
2016-12-08 11:24:15 -05:00
Peter Sprygada
5a61909b4a
refactors nxos_config and removes diff functions
...
this refactors the nxos_config module removing the diff functions and
replacing with the netcfg shared module
2016-12-08 11:24:15 -05:00
Peter Sprygada
19119a2759
cleans up nxos_command and adds some additonal info on exception
...
This cleans up some of the nxos_command module code function names to
be more consistent and adds additional information of failures
2016-12-08 11:24:15 -05:00
Peter Sprygada
a4bb4ee146
refactors eos_template to remove diff functions
...
replaces functions with netcfg shared library for handling configuration
diffs
2016-12-08 11:24:15 -05:00
Peter Sprygada
f77bb0ac28
refactors eos_config to remove config diff functions
...
replaces with netcfg shared library for handling configuration diffs
2016-12-08 11:24:15 -05:00
Peter Sprygada
006c11cf34
refactors the ios_template module to use netcfg diff
...
removes the functions for performing configuration diffs to use the
netcfg shared lib
2016-12-08 11:24:15 -05:00
Peter Sprygada
ff928d0829
refactor ios_config to use netcfg diff shared lib
...
Move the configuration diff code from the module to the shared lib
2016-12-08 11:24:15 -05:00
Toshio Kuratomi
6fae6c7b2d
Give headers a default so that we can add to it.
2016-12-08 11:24:14 -05:00
Peter Sprygada
11cd361d80
fixes #3274
2016-12-08 11:24:13 -05:00
Toshio Kuratomi
4c9f9973dd
If file attribs are specified set them even if file already exists.
...
Fixes #11821
2016-12-08 11:24:13 -05:00
Peter Sprygada
e01dd7facc
update to nxos_command with additional exception handling
...
This update adds exception handling to catch errors when trying to parse
command output to json. It also removes the dependency on importing json
opting to use the AnsibleModule methods instead
2016-12-08 11:24:12 -05:00
Peter Sprygada
ae9930f59f
doc string fixes for eos_config
...
This updates eos_config with some fixes to the documentation string
2016-12-08 11:24:12 -05:00
Peter Sprygada
ed2d46bc9e
bugfix in eos_template for backing up config
...
eos_template would connect to the remote device to get the running config
for backup even if backup is not needed.
2016-12-08 11:24:12 -05:00
Peter Sprygada
12bb95b943
minor function clean ups in eos_command
...
This commit cleans up a couple of functions and removes the json
import to use the json methods from AnsibleModule
2016-12-08 11:24:12 -05:00
jrk07
ca86923eb7
Doc Update: ios_template.py title and example
...
ios_template.py was named ios_config when viewing docs. The examples also had net_config still. Updated those here.
2016-12-08 11:24:12 -05:00
Peter Sprygada
1fd5989b9d
initial add of ops_command module
...
This commit adds a new module, ops_command, that handles executing commands
on OpenSwitch over the CLI. Since this module is designed to work with the
OpenSwitch CLI, it only supports the CLI transport option
2016-12-08 11:24:11 -05:00
Peter Sprygada
9488617d19
initial add of ops_config module
...
This commit adds a new module, ops_config, that allows playbook designers
to create tasks for configuring OpenSwitch over the CLI. The module
is designed to work directly with configuration mode in OpenSwitch and
therefore only supports the CLI transport option
2016-12-08 11:24:11 -05:00
Peter Sprygada
ba41260ae0
bugfix for ios_config module
...
This commit address a bug in the ios_config module when using the
match: strict argument. When the argument is used, the module will
compare the configuration block same as match: exact which is not the
intended behavior. This commit updates the behavior to propertly handle
the strict argument.
2016-12-08 11:24:11 -05:00
Peter Sprygada
761724f5c3
bugfix for handling match=strict in eos_config
...
Resolves an issue where match=strict would act like match=exact when
evaluating the configuration
2016-12-08 11:24:11 -05:00
Peter Sprygada
7cd3793128
bugfix for handling match=strict in iosxr_config
...
Resolves an issue where match=strict would act like match=exact when
evaluating the configuration
2016-12-08 11:24:11 -05:00
Peter Sprygada
b0a9308e0d
bugfix for handling match=strict in nxos_config
...
Resolves an issue where match=strict would act like match=exact when
evaluating the configuration
2016-12-08 11:24:11 -05:00
Matt Martz
fe22ee9423
Don't pass follow_redirects to fetch_url, use module.params instead
2016-12-08 11:24:10 -05:00
moyashiki
96ce498b77
Fix ios_command fix
...
This is not valid YAML commands. So fix it.
2016-12-08 11:24:10 -05:00
Sam Wilson
0bd95d0f2d
Fixed BOOLEANS rendering in docsite
2016-12-08 11:24:10 -05:00
Peter Sprygada
1f4625938e
refactor arguments in ops_template
...
This commit refactors the arugments used in ops_template to be strictly
typed and handle by declarative / rest and cli based configurations. It
also removes old arguments not supported and cleans up the documentation
strings
2016-12-08 11:24:10 -05:00
Gary Rybak
5ff79d0596
Add filter to eos_template to remove configuration mode command followed immediately by an exit command indented one level.
2016-12-08 11:24:09 -05:00