ab495d1916
Set the shell variable on the ssh connection type for accelerated mode
...
Fixes #8799
2014-08-28 08:22:24 -05:00
0d1197a995
Replace Get-FileHash with MD5 code that works on PowerShell 3.
2014-08-28 01:42:22 -04:00
88daac4971
ternary filter
2014-08-27 22:27:00 -04:00
a6ad374668
Use split_args directly to check for omitted params
2014-08-27 11:51:03 -05:00
04da466c7b
Fixing up serialize_args utility function
2014-08-27 10:20:07 -05:00
e99db078b4
Additional fixes for the new omit parameter variable
2014-08-27 10:06:55 -05:00
fe88ba7c8d
Undo changes to filter module
2014-08-27 10:04:47 -05:00
559c04f324
Implement omit for module args, also add tests for it
2014-08-27 10:04:47 -05:00
bce6642ab6
Implement default omit correctly
2014-08-27 10:03:07 -05:00
0b4d7f1574
Implement default omit filter
2014-08-27 10:03:07 -05:00
ed34cee36f
Atomically move known hosts file into place for paramiko connections
...
Redo of original patch, which adds an additional check to ensure the
known_hosts file isn't trampled when host_key_checking is disabled.
Fixes #8169
2014-08-26 16:02:59 -05:00
57dee4545b
Make sure cmd is UTF8 encoded before splitting. Fixes regression introduced by 80df2135e9.
2014-08-24 21:06:21 -04:00
07f12539ee
Bugfix: #8720 winrm.py: protocol.send_message() crashes with https
2014-08-22 15:09:48 -04:00
d01188033f
Checking for localized versions of the su password prompt
...
Fixes #8681
2014-08-22 09:59:40 -05:00
8a1fbed5d6
Correct variable blending from vars_files with hostvars in them
...
Fixes #8638
2014-08-20 15:49:01 -05:00
cecfede85f
Merge remote-tracking branch 'svg/issue_8621_8664' into svg_issue_8621_8664
2014-08-19 11:37:59 -05:00
d4ff0d125a
Make sure password files from lookups are created with restrictive permissions
...
Also adds checks for the lookup integration test for passwords.
Fixes #8652
2014-08-19 11:30:04 -05:00
3c06833302
group_by: make sure new group has bigger priority than all group
2014-08-19 16:34:30 +02:00
379e31883c
Fix check mode issues with copy module
...
Fixes #8639
2014-08-18 16:02:45 -05:00
54cbe3dcf9
Disallow args: to be specified as a string
2014-08-14 16:05:20 -05:00
ee18c557ec
Load group_vars for new groups loaded via add_host
...
Fixes #8605
2014-08-14 13:18:26 -05:00
b6261d05b0
Fix typo: & -> and
...
`and` is the boolean operator for AND in [Python][1].
`&` is the bitwise operator for AND in [Python][2].
[1]: https://docs.python.org/2/reference/expressions.html#boolean-operations
[2]: https://docs.python.org/2/reference/expressions.html#binary-bitwise-operations
2014-08-14 16:52:59 +03:00
99c39b1ff3
By popular request, make the no_log attribute also censor tasks from callbacks.
2014-08-12 13:36:05 -04:00
fc7859f445
Make sure playbook_dir variable is an absolute path
...
Fixes #8317
2014-08-12 09:51:44 -05:00
4940a7ad77
Merge pull request #8458 from Jmainguy/runner_8404
...
Fixes 8362, returns stderr if No space left on device
2014-08-11 23:16:57 -05:00
56f9328f93
Merge
2014-08-11 12:22:47 -04:00
03d150de35
Merge pull request #8020 from msabramo/error_when_private_key_file_permissions_incorrect
...
Error if private_key_file is group/world readable
2014-08-08 12:33:07 -04:00
8c4161d4a1
Merge branch 'retf_py' of git://github.com/berendt/ansible into devel
...
Conflicts:
lib/ansible/inventory/vars_plugins/group_vars.py
plugins/callbacks/mail.py
2014-08-08 12:17:37 -04:00
3ba516ac25
adding min() and max() filters for use in Jinja templates
2014-08-08 11:28:48 -04:00
48a0236ec6
Merge pull request #6619 from sergevanginderachter/ansible_version_var
...
Introduce an ansible_version dict as runner variable
2014-08-08 11:20:17 -04:00
d4cedfc7f1
Fix missing variable initialization for async jid
...
Fixes #8491
2014-08-07 23:51:28 -05:00
4a157a72a0
Catch auth errors in winrm and properly raise errors
...
Fixes #7875
2014-08-07 09:00:24 -05:00
ba4693051b
Removing leftover import of atomic_move
2014-08-06 15:38:08 -05:00
efbad90ef8
Revert "Atomically move known hosts file into place when edited by paramiko connections"
...
This reverts commit bd49a835b4
2014-08-06 15:31:54 -05:00
a45c3b84f3
Avoid templating raw lookup strings
2014-08-06 13:25:14 -05:00
dc69510bff
Merge branch 'callback_template_delegate' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-callback_template_delegate
2014-08-05 15:15:03 -05:00
eeec459f8a
Merge branch 'sets_v2' of https://github.com/bcoca/ansible into bcoca-sets_v2
2014-08-05 14:58:01 -05:00
535ebc4c56
Fixes 8362, returns stderr if No space left on device
2014-08-05 15:18:49 -04:00
8f39c114d8
template Runner.module_vars['delegate_to'] to accommodate callbacks
2014-08-05 15:16:43 +02:00
bd49a835b4
Atomically move known hosts file into place when edited by paramiko connections
...
Fixes #8169
2014-08-04 13:08:40 -05:00
7ff63ab754
Revert "Use atomic move function on known host file in paramiko to prevent rare occurance of Control-C"
...
This reverts commit 642b183fb6
2014-08-04 13:11:40 -04:00
6d94ae64ec
Remove unnecessary unicode conversions from parse_kv
...
Fixes #8425
2014-08-04 09:59:08 -05:00
642b183fb6
Use atomic move function on known host file in paramiko to prevent rare occurance of Control-C
...
during file operations.
2014-08-04 10:50:14 -04:00
a7d2e729f8
Add some whitespace to make paramiko_ssh more browseable
2014-08-04 10:38:16 -04:00
9c1a89ff4e
Merge branch 'patch-1' of https://github.com/debfx/ansible into debfx-patch-1
2014-07-31 11:41:21 -05:00
e6fa50a306
Move splitter to module_utils so modules can use it and fix command arg splitting
...
Fixes #8338
2014-07-29 14:55:16 -05:00
645ab7baff
Merge pull request #7950 from mesk41in/devel
...
Fix unsupported regexp parameter in assemble
2014-07-28 12:01:12 -04:00
57f89b85eb
Merge pull request #8271 from tksmd/fix-copy-set-fs-attributes-issue
...
fix an issue that copying directory will fail when trying to change file attributes
2014-07-25 09:38:24 -05:00
630f080cf0
Start of unit tests for split_args function, moved split_args to utils since not needed by modules (so far).
2014-07-24 20:15:04 -04:00
43154e5101
Using custom splitting function for module param counting
2014-07-24 14:42:35 -05:00
1b1d5d0d3d
fix an issue that copying directory will fail when trying to change file attributes and the target file already exists on remote
...
- the issue was introduced by the commit 84759faa09
2014-07-24 14:03:36 +09:00
2cc602beea
Fixes for module param counting and additional shell quoting issues
2014-07-23 22:54:59 -05:00
ac85d8444b
fix for unarchive 8257
2014-07-23 14:50:16 +00:00
84759faa09
Security fixes:
...
* Strip lookup calls out of inventory variables and clean unsafe data
returned from lookup plugins (CVE-2014-4966)
* Make sure vars don't insert extra parameters into module args and prevent
duplicate params from superseding previous params (CVE-2014-4967)
2014-07-21 11:20:49 -05:00
00e089e503
Revert "Explicitly set the user option for ssh connections"
...
This reverts commit 0f91add86fFixes #8216
2014-07-21 10:32:55 -05:00
4e9a253bef
Load existing group_vars file for new group_by group
...
if it was not loaded yet, which happens if that group
didn't exist yet in the inventory.
fixes #8159
2014-07-16 21:16:27 +02:00
0ebd19e97b
Fix regression: Sanitize sudo success_key from stdout
...
Commit 7e3dd10
2014-07-16 18:14:35 +02:00
e74853300a
Merge branch 'task-host-loop-bypass' of https://github.com/sivel/ansible into sivel-task-host-loop-bypass
2014-07-14 14:21:25 -05:00
b8ac094eaa
Tweak to only show msg on assert failure if set
2014-07-08 14:05:24 -05:00
16332b8488
Merge branch 'assert-with-msg' of https://github.com/darkk/ansible into darkk-assert-with-msg
2014-07-08 13:56:08 -05:00
d94395f48c
assert: add optional `msg` argument
...
Sample playbook when it may be useful:
```
- uri: return_content=yes url={{ api_base }}/action/{{ inventory_hostname }}
register: output
- assert:
msg: '{{ output.json | to_nice_json }}'
that:
- output.json.foo != "bar"
- output.json.boo == 42
```
2014-07-07 19:05:17 +04:00
ff04b2b532
Allow empty yaml vars files
...
Fixes #7843
2014-07-04 23:10:32 -05:00
5b783e0bc6
Error if private_key_file is group/world readable
...
Currently, if you have this, ansible fails with a generic error and
suggests running again with `-vvvv`. This isn't bad but pinpointing the
specific problem immediately is even more user-friendly.
```
$ ls -l devops.pem
-rw-r--r--+ 1 marca staff 1679 Jul 2 11:25 devops.pem
$ ansible -m ping --private-key=devops.pem mt3-pyweb01
mt3-pyweb01 | FAILED => private_key_file (devops.pem) is group-readable or world-readable and thus insecure - you will probably get an SSH failure
```
2014-07-02 13:44:53 -07:00
8ed6350e65
When parsing json from untrusted sources, remove templating tags
2014-07-01 14:14:14 -05:00
f0a7139290
Fix exec_command prototype for the plugin
2014-06-28 13:06:40 +02:00
488aec3936
Fix unsupported regexp parameter in assemble
2014-06-27 13:54:59 +04:00
1adb6dfa05
Remove redundant 'self.user or' added by 0f91add
2014-06-24 10:45:38 -05:00
0f91add86f
Explicitly set the user option for ssh connections
...
Fixes #7170
2014-06-23 15:57:49 -05:00
f8bf9cdeec
Handle TemplateNotFound to render more helpful error message.
...
At the point the exception is handled, it is likely due to error loading
a sub-template included from main template. Besides file not found, it
can be caused also by include path failing Jinja2 checks. Now, when
rendering the exception from Jinja, it will include exception name. This
will give basic context or *what* the error is.
Fixes #7103
Fixes #7105
2014-06-23 15:02:58 -05:00
5d65c1c4a4
Merge branch 'Mbosco-patch-1' into devel
2014-06-23 13:00:51 -05:00
1702c2fd50
Merge branch 'patch-1' of https://github.com/Mbosco/ansible into Mbosco-patch-1
2014-06-23 12:57:13 -05:00
726a61eb43
Add os relpath filter
2014-06-23 16:10:07 +02:00
6aaad5dc9b
Fix missing arg for _remote_chmod method.
2014-06-23 06:09:08 -04:00
94963290b9
Merge pull request #6981 from aliles/fix-localhost-executable-with-flags
...
Fix localhost tasks with complex executables
2014-06-20 12:51:54 -05:00
615f70e3f4
Fix missing space in script action plugin.
2014-06-19 21:54:21 -05:00
dd3f7c2dab
Fix trailing slash on returned temp path.
2014-06-19 16:20:18 -05:00
8a121fd6ae
Squeeze a few more bytes out of put_file script.
2014-06-19 16:20:17 -05:00
4e738e6fa9
Optimize buffer size for put_file.
2014-06-19 15:37:42 -05:00
43a7a5a990
Collapse extra whitespace in encoded powershell scripts.
2014-06-19 14:25:50 -05:00
61c236be9e
Fix for creating temp dir with older powershell versions.
2014-06-19 14:25:28 -05:00
243cd877ae
Add integration tests for fetch/slurp, make powershell fetch/slurp work as close as possible to existing fetch/slurp modules.
2014-06-19 14:25:28 -05:00
a8ca579761
Fix host parameter to vvvvv.
2014-06-19 14:25:27 -05:00
74c43c94cf
Allow specifying remote powershell version via environment variable.
2014-06-19 14:24:14 -05:00
8f762a7d15
Update logging based on verbosity, add vvvvv support to show details of put/fetch file.
2014-06-19 14:24:14 -05:00
21ba529fbe
Fixes/notes related to slashes in remote paths.
2014-06-19 14:24:14 -05:00
7e8cc65829
Refactor common args used for building PowerShell commands.
2014-06-19 14:24:13 -05:00
f7af29680b
Add default license boilerplate, refactor common powershell code, fixes for raw/script modules.
2014-06-19 14:24:13 -05:00
35a7c93c76
Added comment about implementation line.
2014-06-19 14:24:13 -05:00
3ac86e57f4
FIXME comment cleanup
2014-06-19 14:24:13 -05:00
80499346d1
Remove stray FIXME
2014-06-19 14:24:13 -05:00
5dcaa30476
Add shell_plugins to abstract shell-specific functions out of runner, add winrm connection plugin, add initial Windows modules.
2014-06-19 14:24:12 -05:00
a65fd06338
Added quotes around key path - Issue 7713
2014-06-10 16:39:47 -03:00
e5ef0eca03
Merge pull request #6507 from brdo/patch-1
...
Set keepalive to 5 seconds in paramiko_ssh.py
2014-06-09 23:44:06 -05:00
e3530dcbc2
Add environmentfilter to random filter, to ensure the result doesn't get cached. Mirrors default jinja filter.
2014-06-09 18:52:39 +01:00
ad97c618cf
Add support for relative paths in the file lookup plugin for roles
...
Fixes #7628
2014-06-04 15:20:59 -05:00
d9df607972
Fix order of merging variables for the combined cache
...
Fixes #7598
2014-06-04 10:50:41 -05:00
ce8c8ab146
now unique actually works, all operations also now use it to return
...
unique lists.
2014-06-01 16:32:48 -04:00
188ab7b952
Check groupnames for None as well as an empty string in add_host
...
Fixes #7585
2014-05-29 11:01:11 -05:00
feafc4cd8a
Merge branch 'fix_mutable_inventory_vars' of https://github.com/banterchat/ansible into banterchat-fix_mutable_inventory_vars
2014-05-27 22:09:25 -05:00
72524e1f3b
dont mutate inventory vars
2014-05-27 19:07:58 -05:00
fa86eef9f9
Make sure value in regex_replace is a string
...
Fixes #7551
2014-05-27 14:30:12 -05:00
8f58ae3305
changed exception handling for hashable test
2014-05-26 08:52:57 -04:00
92f16b3d6f
Merge pull request #7539 from jimi-c/issue_7503_freebsd_su_fixes
...
Fixes for su on freebsd
2014-05-25 15:09:58 -05:00
0dce5dae26
set theory v2, now can handle non hashable items like dicts
2014-05-25 13:20:55 -04:00
d77a6965b3
Merge module_vars into inject during template instead of updating
...
This way we won't overwrite values that are stored in the inject
with module_vars that should be lower precedence.
Fixes #7510
2014-05-23 13:36:45 -05:00
1e672a0fec
Fixes for su on freebsd
...
Addresses multiple issues when using su on freebsd including
* su prompt differs between platforms, so turned that check into a
regex comparison instead of a simple string comparison
* not using '-c' after su causes problems, so added that for all
platforms
* fixed quoting issues due to multiple uses of '-c' introduced by
the above fix
Fixes #7503
Fixes #7507
2014-05-23 10:06:09 -05:00
6b70ee23ab
Clean non-printable chars from stdout instead of dropping the whole thing
2014-05-21 19:24:28 -07:00
32628eef85
Merge pull request #7481 from jimi-c/issue_7396_env_lookup
...
Don't use listify_ function, when all we want to do is template variable...
2014-05-21 15:02:35 -05:00
56880b76bb
fix UnicodeEncode error when using pause module with unicode prompt.
2014-05-22 00:21:14 +09:00
365bfd732e
Don't use listify_ function, when all we want to do is template variables
...
This was causing a bug in the env module, due to the fact that we now
pass variables for the module through the templating engine combined
with the fact that we split-up the hostvars and setup variables. As a
result, if a variable in the env lookup had the same name as the variable
in Ansible, it would try and template itself over and over again until
the recursion limit would be hit, at which time an empty string was
returned.
Fixes #7396
2014-05-20 13:39:23 -05:00
0e953c2863
Add run_once task key
...
This caused the task to act like bypass host loop plugin and
execute only on a single host. Can be used with delegate_to
2014-05-19 12:33:47 -05:00
79731ce491
Evaluate changed_when only if task is not skipped
...
Fixes #7405
2014-05-14 16:04:37 -05:00
809b931640
Merge pull request #7382 from jimi-c/issue_7366_synchronize_inventory_dir
...
Do not base synchronize source on the inventory directory
2014-05-13 11:05:19 -05:00
712f4a631c
Update ssh.py
...
Convert to string to fix runtime error due to string concat in self.common_args += ["-o", "User="+self.user] when ansible_ssh_user is numeric
2014-05-13 11:29:19 +02:00
d725636469
Correctly initialize combined_cache for hosts if setup is skipped
...
Fixes #7364
2014-05-12 13:48:11 -05:00
38c2c60849
Do not base synchronize source on the inventory directory
...
Fixes #7366
2014-05-12 12:02:38 -05:00
fd27afdc0d
Adding ansible_shell_type and basic environment construction on it
...
Previously we assumed the shell on the target systems were 'sh'-
compliant when formatting environment variables preceding command
strings. This patch corrects that by basing the target shell type
on the DEFAULT_EXECUTABLE setting, which can be overridden on a
per-host basis using the inventory variable 'ansible_shell_type'.
Fixes #7352
2014-05-09 16:29:56 -05:00
51ef28b0d2
Merge branch 'warn_wrong_sudo_password' of https://github.com/tyll/ansible into tyll-warn_wrong_sudo_password
2014-05-08 14:16:58 -05:00
2e2e5d5321
Use the existing module_vars during the templating of module_vars
...
Since some of the vars contained in there may be used in the templating
of other variables. This also reverts e83a494#6979 but broke some other variable related things.
Fixes #6979
Fixes #7321
Fixes #7332
2014-05-08 13:09:36 -05:00
77a47dbb2d
Merge pull request #7304 from jimi-c/issue_7296_synchronize_relative_path
...
Make sure dwim'd relative path ends in a "/" if the original does
2014-05-07 12:58:04 -05:00
f9c74d6e57
Add integration tests for group_by module. Fixed bug introduced by ansible/ansible#7273 while also fixing issue described in ansible/ansible#6953
2014-05-06 22:30:37 -04:00
4d118d1c72
Make sure dwim'd relative path ends in a "/" if the original does
...
Fixes #7296
2014-05-06 13:54:41 -05:00
fd03cc04e6
Merge branch 'devel' of https://github.com/denisphillips/ansible into denisphillips-devel
2014-05-05 09:22:01 -05:00
d6f4d9b76d
Fix error handling on missing dest with unarchive
...
fixes #7107
2014-05-04 18:22:00 +03:00
cd0134d290
Used module_args passed to function instead of from runner
2014-05-04 08:49:12 -04:00
6676720ce5
fixed typos found by RETF rules in PY files
...
rules are avaialble at https://en.wikipedia.org/wiki/Wikipedia:AutoWikiBrowser/Typos
2014-05-03 18:40:05 +02:00
deb532c367
Remove OrderedDict references from runner
...
Fixes #7256
2014-05-02 12:52:36 -05:00
54b1f820fb
Modify the way we set the localization environment
...
Previously, we set the LANG (and LC_CTYPE) environment variables
directly in the module code and applied them with os.environ().
Instead, we are now pre-pending those variables to the environment
string used to execute the command which allows the user to
override the localization values by setting the environment values
directly (even on a per-task basis):
- subversion: repo=file:///path/to/repos/svn_über dest=/tmp/svntest
environment:
LANG: "C"
LC_CTYPE: "en_US.UTF-8"
So if a user wishes to default their LANG back to C, they can still
avoid unicode issues by doing the above.
Fixes #7060
2014-05-01 10:34:53 -05:00
30e4759055
Merge pull request #7208 from jf/copy-module
...
Fix "no_log=True" option for copy module (fixes #7193 )
2014-04-29 16:11:23 -05:00
be4e6d359f
Merge branch 'delegate_to_honor_ssh_private_key_file' of https://github.com/renard/ansible into renard-delegate_to_honor_ssh_private_key_file
2014-04-29 15:05:09 -05:00
0bf1a27393
Fix "no_log=True" option for copy module ( fixes #7193 )
2014-04-30 02:24:16 +08:00
b8b0865ec0
Missing 'base64' import
2014-04-25 00:11:27 +02:00
e9d8f0639f
Merge pull request #7143 from sivel/ansible-sudo-from-root-fix
...
Allow sudo to another user from root with the ansible command
2014-04-23 21:11:39 -05:00
eb8759176f
Allow sudo to another user from root
2014-04-23 16:14:48 -05:00
38b49476f8
Merge branch 'raw-script-su-support' of https://github.com/sivel/ansible into sivel-raw-script-su-support
2014-04-23 10:02:13 -05:00
a6068b09ac
Fix collision in random filter name by merging functionality
...
Merges the functionality of the original jinja2 random filter with
the one we provide.
Fixes #7113
2014-04-22 14:21:00 -05:00
086b877719
Merge pull request #7079 from mscherer/fix_error_whitespace_in_config
...
Clean a bit more the ssh_args configuration
2014-04-21 10:43:31 -05:00
c87afc1109
Clean a bit more the ssh_args configuration
...
If someone add ssh_args = " " to his .ansible.cfg, it will result into
strange failure later :
<server.example.org> ESTABLISH CONNECTION FOR USER: misc
<server.example.org> REMOTE_MODULE ping
<server.example.org> EXEC ['ssh', '-C', '-tt', '-q', ' ', '-o', 'KbdInteractiveAuthentication=no',
'-o', 'PreferredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey', '-o', 'PasswordAuthentication=no',
'-o', 'ConnectTimeout=10', 'server.example.org', "/bin/sh -c 'mkdir -p /tmp/ansible-tmp-1397947711.21-5932460998838
&& chmod a+rx /tmp/ansible-tmp-1397947711.21-5932460998838 && echo /tmp/ansible-tmp-1397947711.21-5932460998838'"]
server.example.org | FAILED => SSH encountered an unknown error during the connection. We recommend you re-run the
command using -vvvv, which will enable SSH debugging output to help diagnose the issue
The root cause is the empty string between -q and -o, who kinda break mkdir.
2014-04-20 00:47:00 +02:00
3a09c99811
Enhance error message about missing ControlPersist
...
ansible_ssh_args is good for playbook, but in the ~/.ansible.cfg
file, it should be ssh_args in a specific section.
2014-04-20 00:35:10 +02:00
a32dd34359
Make sure HostVars object is instantiated before assigning it
...
Fixes #7006
2014-04-18 16:23:01 -05:00
22d6572270
Honor ansible_private_key_file for delegated hosts
...
If a delegated host is not found in the inventory specified
private_key_file for primary host was not used.
This allows running playbooks without having to define any inventory at
all and to use the same ssh private key for both primary host and
delegated one.
2014-04-18 01:48:02 +02:00
48bf7a000d
Try to pass in item to on_skippped callback.
2014-04-16 15:40:07 +01:00
ba1a6c2e11
Removing .orig file merged in accidentally
2014-04-15 10:58:53 -05:00
aad128bac7
Use combined cache for templating module vars
...
Fixes #6901
2014-04-15 10:56:48 -05:00
40b958e348
Don't turn complex args back into a k=v string for the synchronize module
...
Fixes #6951
2014-04-14 16:35:16 -05:00
a5507275cb
Fix localhost tasks with complex executables
...
Enable the use of executable commands that use command line options with
the localhost command runner. These commands require parsing out the
base executable from the command string to pass to subprocess.
2014-04-14 22:15:39 +10:00
80cd217eb7
simple random filter
2014-04-09 09:03:38 -04:00
5ce6c86595
Merge branch 'sudo_pass_typo' of https://github.com/tyll/ansible into tyll-sudo_pass_typo
2014-04-08 14:52:42 -05:00
d240e2b9fb
Introduce an ansible_version dict as runner variable
...
Given the version:
"1.6 (ansible_version_var 14499e8bf314499e8bf3
2014-04-08 17:14:42 +02:00
318e752b6f
Fixes #6845 evaluate changed_when only if task is not skipped
2014-04-07 10:51:04 -04:00
5a65dc3b6a
Fixes #6820 fix erroneous missing vault password error when using the template module
2014-04-04 13:06:35 -04:00
82b24c162e
Adding delimiter fixes to action_plugin + fixing local assembling with a delimiter
...
Also added a new integration test for assemble using local assembly
with a delimiter.
2014-04-03 16:32:35 -05:00
2c7275e8a9
Merge pull request #6835 from sivel/version-compare-filter
...
Add version_compare filter
2014-04-03 17:07:05 -04:00
cdc0819939
Fixes #6088 turn off sudo and su if the connection is local the sudo user matches the current user
2014-04-03 12:02:51 -04:00
2a9fcdd87c
Merge pull request #6711 from j2sol/raw-unreachable
...
Treat 255 errors from raw as dark host
2014-04-03 11:16:54 -04:00
f6db60cbce
Merge pull request #6787 from tyll/pull_ssh_prompt
...
ssh: propagate prompt to _communicate()
2014-04-03 09:55:17 -04:00
5770428e91
Add version_compare filter
2014-04-02 20:21:30 -05:00
904f331210
Merge pull request #6788 from tyll/pull_ssh_verbose_comments
...
ssh connection plugin: Make comments more verbose
2014-04-02 17:24:16 -04:00
39fcbd1f10
Update ssh.py
2014-04-02 15:57:54 +03:00
165406cf35
Catch permissions errors related to opening a known_hosts file
...
Catch permissions errors related to opening a known_hosts file
2014-04-02 13:42:07 +03:00
e2d86e4f43
Splitting SETUP_CACHE into two caches, one for host vars and one for setup facts
2014-04-01 16:23:33 -05:00
e6cb32f284
ssh connection plugin: Make comments more verbose
...
Explain _communicate() more.
2014-04-01 09:46:51 +02:00
1da69309e5
ssh connection plugin: Report missing sudo password
...
If no password is provided, sudo hangs at the prompt. Identify this and
report that the password is missing as an error.
2014-04-01 09:36:59 +02:00
2cae7472ad
ssh: propagate prompt to _communicate()
...
_communicate() uses the prompt variable to detect wrong passwords early,
therefore it needs to be passed to it from exec_command().
2014-04-01 09:24:44 +02:00
b9c044b8c9
Making the exception caught during os.dup of stdin explicit
...
Related to f23bb34
2014-03-31 13:50:23 -05:00
f23bb344aa
Catch errors when duping stdin
...
Fixes #6657
2014-03-31 13:38:12 -05:00
4f140be711
Merge branch 'devel' of https://github.com/Synforge/ansible into Synforge-devel
2014-03-31 13:04:56 -05:00
efba8b4771
Merge branch 'regexreplace' of git://github.com/jacobweber/ansible into jacobweber-regexreplace
2014-03-31 13:48:13 -04:00
2492c2714a
Fixes #5307 set relative paths to the files dir for roles and the inventory dir for non-role tasks
2014-03-31 12:25:40 -04:00
b07113f358
ssh: Properly check for wrong su password
2014-03-31 15:51:12 +02:00
7e3dd1066c
Allow raw and script to support su
2014-03-28 16:46:31 -05:00
1942a69ed2
Added template call to _executor_internal to allow the passing of arbitrary data to modules.
2014-03-27 17:06:20 +00:00
3315ba0b99
Treat 255 errors from raw as dark host
...
Any other module is able to detect a dark host, but raw was treating 255
as a return code from the module execution, rather from the connection
attempt. This change allows 255 to be treated as a connection failure
when using the raw module.
2014-03-26 16:40:50 -07:00
88462729aa
Addresses #6708 fill in missing keywords for ssh.py _communicate
2014-03-26 15:55:54 -04:00
7dc3dc5279
Merge pull request #6708 from sivel/put-file-control-master
...
Share p.communicate alternative logic between exec_command and put_file
2014-03-26 15:02:14 -04:00
e09313120c
Make async jid's unique per host
...
The jid will now also contain the PID of the async_wrapper process,
and can each unique jid from each host is tracked rather than just
relying on one global jid per task.
Fixes #5582
2014-03-26 13:48:47 -05:00
b8cb23d309
Share p.communicate alternative logic between exec_command and put_file
2014-03-26 13:41:33 -05:00
7a3fa63db5
Fix for unicode environment variable handling
...
Fixes #5395
2014-03-25 20:45:04 -05:00
c9bf7eb9bb
Don't run {failed|changed}_when checks until async_status is done
...
Fixes #5117
2014-03-25 14:18:47 -05:00
a062912a1f
Merge pull request #6658 from pilou-/fix_fix
...
'changed' key is not defined when task fails
2014-03-25 11:49:18 -04:00
dc658eaa1c
Check to make sure the host is in the inventory vars cache before clearing it
...
Fixes #6660
2014-03-24 15:59:43 -05:00
c76501b8a3
'changed' key is not defined when task fails
...
fix KeyError introduced by fix of #6591 .
2014-03-24 19:31:52 +01:00
a24d3f78d9
Merge pull request #6634 from pilou-/fix
...
Remove print statements
2014-03-23 16:12:04 -04:00
31628d86a1
Adding in a configurable option for the accelerate daemon timeout
...
This was apparently an oversite, as it has never been configurable
despite having a module parameter for the timeout.
2014-03-23 14:45:49 -05:00
3ea5d573aa
Acclerate improvements
...
* Added capability to support multiple keys, so clients from different
machines can connect to a single daemon instance
* Any activity on the daemon will cause the timeout to extend, so that the
daemon must be idle for the full number of minutes before it will auto-
shutdown
* Various other small fixes to remove some redundancy
Fixes #5171
2014-03-23 14:45:49 -05:00
d3a470db0c
Remove print statements
...
"print item" raises an exception when type of item is
jinja2.runtime.StrictUndefined
2014-03-23 03:58:44 +01:00
d0cbb51170
Merge pull request #6615 from 8191/devel
...
Addresses #6591 Hide diff for lineinfile if file did not change.
2014-03-21 10:46:29 -04:00
b8158f5f6a
Addresses #6591 Hide diff for lineinfile if file did not change.
2014-03-21 08:40:38 +01:00
1c504eff68
etcd lookup: use $ANSIBLE_ETCD_URL if it exists in the env
2014-03-20 15:16:28 -07:00
ea5186ca63
Fixes #6590 add set_remote_user parameter to synchronize
...
This allows usage of custom ssh configs for remote hosts where
the inventory user does not match the configured user.
2014-03-20 13:56:07 -04:00
c9fcbf7bdd
Change print message to vvv for missing known hosts in ssh.py
2014-03-18 12:26:10 -05:00
49807877fa
Fixes #6550 Use shell for pipe lookup subprocess.popen calls
2014-03-18 12:21:26 -04:00
94e3350b38
Catch a unquoted line error. Fixes #6532
2014-03-17 17:15:42 -04:00
20262b6c15
Remove unused variable in _executor_internal
2014-03-17 15:53:48 -04:00
ebb6b8442b
Catch unicode unescape failures in copy action plugin
2014-03-17 12:14:29 -04:00
6144c5e1e2
Merge pull request #5714 from eggsby/patch-2
...
Allow templates in ansible_sudo_pass inventory var
2014-03-16 15:42:12 -05:00
3d44f7cd51
Merge pull request #6217 from ashokrajar/patch-1
...
pause plugin doesn't flush raw_input prompt
2014-03-16 12:32:58 -05:00
0749112286
Micro-optimization: replace s.find(x)!=-1 with x in s
...
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
2014-03-16 13:10:28 -04:00
3963a64a4f
Set keepalive to 5 seconds in paramiko_ssh.py
...
This update resolves https://github.com/ansible/ansible/issues/6476 .
2014-03-15 11:18:47 -07:00
6c25e78299
Merge branch 'devel' of https://github.com/dparalen/ansible into dparalen-devel
2014-03-11 15:34:15 -05:00
e4e64a9699
Rename lxc to libvirt_lxc
2014-03-11 16:16:24 -04:00
bca6adc812
Merge pull request #4064 from mscherer/lxc
...
Add a plugin that permit to use ansible for lxc system, using libvirt
2014-03-11 15:12:51 -05:00
ba0fec4f42
Force command action to not be executed by the shell unless specifically enabled
2014-03-10 16:13:30 -05:00
4993cb57f4
Merge pull request #6283 from magicrobotmonkey/upstream
...
fix missing stdin in _parallel_runner
Tested with GIST https://gist.github.com/risaacson/7290d30a612e0c70ea1b .
Passes "make tests"
Passes non_destructive tests.
2014-03-10 14:38:56 -05:00
d2cb35f898
Merge pull request #6320 from angstwad/instance-redo
...
Use isinstance() rather than a check using type()
2014-03-07 20:41:33 -06:00
f80d02d841
Properly wrap logical elements together for su/sudo detection
2014-03-07 00:07:10 -06:00
3cce3650e5
Use isinstance() rather than a check using type()
2014-03-06 16:16:25 -06:00
9b79591f23
Merge branch 'devel' of https://github.com/aresch/ansible into aresch-devel
2014-03-06 15:17:55 -06:00
4d80019ac8
Fix logic checking for both sudo and su, and their respective users
2014-03-06 10:24:16 -08:00
9f2999df79
Un-escape newlines in delimiters for assemble module
2014-03-06 09:44:56 -06:00
23a0468a4b
Fix respecting remote_tmp when sudo is used
2014-03-05 16:25:42 -08:00
4e8ed92130
Fixes #6077 decode escaped newline characters in content for the copy module
2014-03-05 18:49:54 -05:00
6129ea7566
Fixes #6298 and adds a sudo unit test for synchronize
2014-03-05 14:51:40 -05:00
7cf363910a
fixes #6244
2014-03-05 09:18:01 +01:00
5c589af191
fix missing stdin in _parallel_runner
2014-03-04 16:00:26 -05:00
92aacb198c
Merge pull request #6156 from iiordanov/devel
...
Add support for checking host against global known host files.
The effect of this is that before this fix if files are spread across the known_hosts file but not in the ~/known_hosts file the hosts will execute sequentially. This PR augments the functionality so that all of the knowns hosts will execute in parallel.
2014-03-03 23:51:51 -06:00
e79d859dfb
Merge pull request #6213 from sergevanginderachter/fix-delegate-templating
...
Fixes templating of ansible_ssh_host for delegates.
Tested that this works. Confirmed.
2014-03-03 23:10:09 -06:00
c652802d29
missing import in assert module
...
Fixed missing ansible.errors import in assert module
2014-03-02 00:59:17 +01:00
46ec8759d5
Remove the legacy templating code, which was guarded by deprecation warnings in the previous two releases, and undocumented for a long time. use {{ foo }} to access variables instead of ${foo} or $foo.
2014-02-28 18:38:45 -05:00
79645535c0
Handle empty results from failed connections in _remote_md5()
...
Fixes #5800
2014-02-28 12:50:03 -06:00
04f6367172
Fully clean 'ssh_old' and 'paramiko_alt' options
...
These transports have been removed in 33857855ad
2014-02-28 18:28:04 +01:00
cb3c6417dd
pause plugin doesn't flush raw_input prompt
...
##### Issue Type:
Bugfix Pull Request
##### Ansible Version:
ansible 1.4.3
##### Environment:
N/A
##### Summary:
We are using a wrapper python script to run ansible-playbook. We use subprocess to execute and print the stdout as and when its written. Problem is when we use pause it doesn't display the prompt string as raw_input does not flush stdout before reading from stdin.
It looks like a dirty fix to add "\n" to the prompt string but i don't see any other way to over come this. If anyone else have a better fix please do propose/suggest.
##### Steps To Reproduce:
```yaml
#File: test_play.yml
- name: Test
hosts: $nodes
gather_facts: false
tasks:
- name: Waiting for User
local_action: pause prompt="Do you want to continue (yes/no)? "
```
```python
#!/usr/bin/env python
#File: test.py
import shlex, subprocess
def run_process(process):
process = process.encode("utf-8")
command = shlex.split(process)
p = subprocess.Popen(command, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
for line in iter(p.stdout.readline, b''):
print line,
cmd = "/usr/bin/python -u /usr/bin/ansible-playbook -i hosts.txt test_play.yml -e 'nodes=local'"
run_process(cmd)
```
```
shell $ python test.py
```
##### Expected Results:
```
PLAY [Test] *******************************************************************
TASK: [Waiting for User] ******************************************************
[localhost]
Do you want to continue (yes/no)? :
```
##### Actual Results:
```
PLAY [Test] *******************************************************************
TASK: [Waiting for User] ******************************************************
[localhost]
```
2014-02-28 11:28:38 +05:30
df9de6ea71
Expand the source path in the action plugin when not using a remote source
...
Fixes #6209
2014-02-27 12:50:35 -06:00
9833263417
Fixes templating of ansible_ssh_host for delegates
2014-02-27 18:06:34 +01:00
c11e2100e0
Save the original transport in runner after detecting the smart transport
...
Fixes #6192
2014-02-27 10:30:50 -06:00
cd7d7eb1bc
Merge pull request #6202 from muffl0n/unarchive_destdir
...
unarchive: output dest in error-message
2014-02-27 10:36:10 -05:00
17946b23d5
output dest in error-message
2014-02-27 13:29:26 +01:00
2a383786dd
And remove the expanduser calls from the action_plugin
2014-02-26 15:29:00 -06:00
96f1c3ce2e
Move where the expanduser call is made, to avoid issues with None
2014-02-26 12:33:17 -06:00
e659d55d62
Merge branch 'devel' of https://github.com/muffl0n/ansible into muffl0n-devel
2014-02-26 12:28:26 -06:00
33857855ad
removing some unusued files. Paramiko alt was an experiment to attempt pipeline for paramiko, ssh_old is the non-pipelining-supported earlier
...
version of the OpenSSH transport, which is configurable now and unified.
2014-02-26 11:26:52 -05:00
af616fe15e
Rename flatten funciton.
...
flatten(x) is used a lot in the various lookup plugins where in each it is slightly different. This is to make this name slightly more unique.
2014-02-25 14:59:06 -06:00
1fcc9ff666
lookup_plugins: loop over hashes
...
Create a lookup plugin named dict that can be used to loop over hashes.
It converts a dict into a list of key-value pairs, with attributes named
"key" and "value." Also adds a brief explanation and simple example to
the docs.
Signed-off-by: Kent R. Spillner <kspillner@acm.org>
2014-02-25 11:20:15 -06:00
876035c0b1
Fixes #6161 Get the delegate host info properly from the hostvars object
2014-02-25 11:18:06 -05:00
9209581565
Fixes #6155 Inject checkmode into synchronize module args
2014-02-25 08:58:58 -05:00
0f95a905d9
Fixes #5965 Ensure the inject for each item in a loop is un-altered
2014-02-24 20:54:26 -05:00
a1854bb762
Add support for checking host against global known host files.
2014-02-24 16:05:03 -05:00
3b2d409906
Fixing several bugs in assemble and updating tests
...
Bugfixes:
* the remote_src param was not being converted to a boolean correctly,
resulting in it never being used by the module as the default behavior
was remote_src=True (issue #5581 )
* the remote_src param was not listed in the generic file params, leading
to a failure when the above bug regarding remote_src was fixed
* the delimiter should always end with a newline to ensure that the file
fragments do not run together on one line
Fixes #5581
2014-02-24 14:27:23 -06:00
93c746db9c
Merge pull request #5651 from nikut/sshfix
...
allow ansible_ssh_private_key_file to be templated (thanks to benno)
2014-02-24 14:26:48 -05:00
8be8dbc9ed
Formatting cleanup.
2014-02-24 11:11:47 -06:00
aaf0a182e1
Merge remote-tracking branch 'jeromew/ansible_script_creates' into issues_4986
2014-02-24 10:16:39 -06:00
4af1d6098b
Fixes #5939 Allow for delegate hosts that are not in inventory
2014-02-21 15:54:09 -05:00
bc65956798
Add tests that leverage most of our custom filters. A few more to add.
2014-02-20 15:24:03 -05:00
f5505425f9
Adding 'expanduser' filter to the core filters list
...
Example usage: {{ my_path | expanduser }} # my_path: "~/path/to/file"
2014-02-20 13:48:07 -05:00
ef2df8157a
Fixup result dictionary when copy module calls file module
2014-02-19 18:05:59 -05:00
b0f00cc097
already call expanduser in action_plugin
2014-02-19 21:41:57 +01:00
5f0e882d01
call expanduser for src and dest
2014-02-19 21:30:53 +01:00
0df166e7c0
Copy tests WIP, fix bug in assert module upgrades where the wrong value was being checked.
2014-02-19 14:36:54 -05:00
54117ab28f
Modified assert module to take tests as an array
2014-02-19 14:05:03 -05:00
dc403eb21e
Merge pull request #6058 from jctanner/vault_squashed_2
...
Ansible vault: a framework for encrypting any playbook or var file.
2014-02-19 11:39:55 -05:00
James Cammarata
Chris Church
Brian Coca
Victor Lin
Chris Baughman
Serge van Ginderachter
Cristian Ciupitu
Michael DeHaan
Michael DeHaan
Michael Peters
Jonathan Mainguy
someda
Benno Joy
Felix Geyer
Leonid Evdokimov
Marc Abramowitz
Michael Scherer
mesk41in
Thomas Mangin
Paul Sokolovsky
Jakub Jirutka
Eri Bastos
smoothify
Isao Jonas
Nick Irvine
WAKAYAMA shirou
Matt Martz
Marco Re
Veeti Paananen
Denis Phillips
Christian Berendt
Jeffrey 'jf' Lim
Cédric RICARD
Sébastien Gross
James Tanner
Aaron Iles
BoscoMW
Till Maas
Paul Oyston
Jesse Keating
Pierre-Louis Bonicoli
Manuel Faux
Joshua Conner
brdo
Richard Isaacson
Paul Durivage
James Cammarata
Andrew Resch
Luca Berruti
Aaron Bassett
Tefnet
Michael DeHaan
Gilles Cornu
Ashok Raja R
muffl0n
Kent R. Spillner
Iordan Iordanov
muffl0n
root