00abe6dbe7
fix UnboundLocalError nxos_bgp_af module ( #37610 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-03-20 01:53:08 +05:30
cdd21e2170
Clean up module documentation ( #36909 )
...
* Clean up module documentation
This PR includes:
- Removal of `default: None` (and variations)
- Removal of `required: false`
- Fixing booleans and `type: bool` where required
* Fix remaining (new) validation issues
2018-03-15 22:15:24 +01:00
05b266cc66
fix nxos_udld issues ( #37418 )
2018-03-15 15:37:46 +05:30
dc61f4c6b1
Fix nxos_vrf issues ( #37092 )
...
* fix nxos_vrf issues
* fix doc
2018-03-13 17:08:37 +05:30
ba5e562c76
Fix nxos_l2_interface and test typo ( #37336 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-03-13 13:36:38 +05:30
ff57fd0bb4
Fix nxos_switchport ( #37328 )
2018-03-13 12:03:05 +05:30
2501834c42
add nxos_snapshot test for missing required param ( #37248 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-03-09 17:47:14 +05:30
a10df8b0b5
fix required args for nxos_snapshot and docs improvement ( #37232 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-03-09 14:08:01 +05:30
74e79d9f5e
fix nxos_vrf_af issues ( #37211 )
2018-03-09 12:20:27 +05:30
02999b77a4
fix nxos_switchport/l2_interface trunk_vlans state absent ( #37180 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-03-08 18:10:04 +05:30
ebc71bcb16
Network modules to link to network guide ( #37033 )
...
* Network modules to link to network guide
* Make it clear what's deprecated
* enable -> become
* Detail when provider is still needed (eAPI/NX-API)
* Link to specific sections
* rx_rate & tx_rate to link to conditional docs
2018-03-06 12:01:07 +00:00
4ed0e5072d
fix nxos_vrrp issues ( #36930 )
2018-03-06 13:36:50 +05:30
51e8eab9db
Fix n3k separate to combined image upgrade ( #37017 )
...
* Fix n3k separate to combined image upgrade
* Address review comments
2018-03-06 10:05:08 +05:30
2fbfce06e7
Fix nxos_interface multiple issues ( #36827 )
...
* fix interface_type
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix setting mtu, doc for state check param, doc for params applicable for ethernet intf
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* speed idempotence and add unittest
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fabric_forwarding_anycast_gateway applicable for svi type intf only
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix speed
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-03-01 10:56:16 +05:30
db43fe6a76
nxos_facts fix and integration tests ( #36796 )
...
* fix nxos_facts ipv6 error
* time_range not supported for N35
2018-02-28 10:45:50 +05:30
44332bda78
fix nxos_vlan aggregate ( #36710 )
...
* fix nxos_vlan aggregate
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-26 12:29:49 +05:30
d6912cf40e
nxos_linkagg fix ( #36706 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-26 11:21:51 +05:30
5a6b893240
Decouple config and state check in vlan and vrf network modules ( #36386 )
...
* Decouple config and state check in {network_os }_vlan and { network_os }_vrf modules
Fixes #35567
Fixes #34754
`interfaces` option is used for configuration as well as operational state
check. If interface is configured to given vlan or vrf but if
operational state of interface is disabled it results in module failure.
Fix is to decouple same option usage for config and state.
With this fix `interfaces` is used as config option and a new
option named `associated_interfaces` will be used for intent check
for assigned interfaces.
* Fix CI failures
* Fix review comment
* Fixed integration test failure
2018-02-26 09:23:54 +05:30
713828804d
nxos_vrf fix ( #36494 )
...
* nxos_vrf fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Address review
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-21 19:33:33 +05:30
9598978e12
fix nxos_pim module doc ( #36505 )
...
* fix nxos_pim module doc
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* address review
2018-02-21 18:42:37 +05:30
f207897f32
fixed conditional error message ( #36476 )
2018-02-21 11:44:18 +05:30
47a92386c9
fix nxos_bgp_neighbor_af issues ( #36472 )
2018-02-21 10:20:24 +05:30
ef7d574920
Fix nxos_banner module for unstructured output ( #36411 )
...
* Fix nxos_banner module for unstructured output
* Refactor and bug fixes
* Fix pep8 error
2018-02-21 09:51:41 +05:30
80d19e6af3
fix nxos_bgp_neighbor issues ( #36318 )
2018-02-20 10:08:17 +05:30
736d6406c0
fix nxos_config json pipeline error ( #36236 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-19 10:11:43 +05:30
6e096cb0c9
Remove kickstart_image_required check ( #36319 )
2018-02-17 10:20:31 +05:30
e24c547a3a
Fixes for the N3500 platform that uses the A8 image ( #36261 )
...
* fix nxos_l3_interface tests as n35 doesn't support ipv6
* add terminal dont-ask to nxos_feature and nxos_lldp
* put interfaces in L2 mode for N35
* fix nxos_feature unit-tests
2018-02-17 10:16:03 +05:30
ac169f5ffd
Fix structured output bug ( #36193 )
2018-02-16 21:34:26 +05:30
75a34f6668
fix nxos_bgp_af issues ( #36147 )
...
* fix nxos_bgp_af issues
* shippable fix
* review comments
* shippable error fix
2018-02-16 09:34:24 +05:30
eab1b62cd2
fix nxos_interface_ospf issues ( #35988 )
...
* fix nxos_interface_ospf issues
* review comment
2018-02-13 09:27:22 +05:30
7a711cf942
Fix nxos_igmp_interface for diff nxos versions ( #35959 )
2018-02-12 10:30:38 +05:30
15b0371eb2
Add examples and language to better showcase the 'parents' parameter in multiple network modules ( #34486 )
...
* Add additional language and examples for 'parents' parameter to clarify its usage.
2018-02-09 13:31:37 +00:00
c7305393a3
fix nxos_evpn_vni issues ( #35930 )
2018-02-09 13:02:41 +05:30
80fcfdc0d1
fix nxos_vpc issues ( #35868 )
2018-02-08 18:50:37 +05:30
dfcae9fc8e
Remove potentially confusing `provider` from module documentation ( #35851 )
2018-02-07 16:33:11 -05:00
c9e0ce1d7d
fix nxos_vpc_interface peer_link idempotence ( #35737 )
...
* fix peer_link idempotence
* review comment
2018-02-07 08:35:43 +05:30
98f804ecb4
nxos_facts: svi support ipv4 ( #35222 )
...
* nxos_facts: svi support ipv4
* nxos_facts: copy paste error
* https://app.shippable.com/github/ansible/ansible/runs/51845/1/tests
* E111 indentation is not a multiple of four
* Update nxos_facts.py
2018-02-06 19:40:12 +05:30
109bc89bbe
fix nxos_ospf_vrf issues ( #35616 )
2018-02-05 10:59:13 +05:30
a4b7df70c7
nxos_vlan ValueError fix ( #35559 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-02 20:51:34 +05:30
dc35baa8db
fix nxos_pim_interface issues ( #35405 )
...
* fix nxos_pim_interface issues
* add absent test for pim_interface
2018-01-31 10:51:11 +05:30
a23c95023b
Module deprecation: docs, scheme and tests ( #34100 )
...
Enforce module deprecation.
After module has reached the end of it's deprecation cycle we will replace it with a docs stub.
* Replace deprecated modules with docs-only sub
* Use of deprecated past deprecation cycle gives meaningful message (see examples below)
* Enforce documentation.deprecation dict via `schema.py`
* Update `ansible-doc` and web docs to display documentation.deprecation
* Document that structure in `dev_guide`
* Ensure that all modules starting with `_` have a `deprecation:` block
* Ensure `deprecation:` block is only used on modules that start with `_`
* `removed_in` A string which represents when this module needs **deleting**
* CHANGELOG.md and porting_guide_2.5.rst list removed modules as well as alternatives
* CHANGELOG.md links to porting guide index
To ensure that meaningful messages are given to the user if they try to use a module at the end of it's deprecation cycle we enforce the module to contain:
```python
if __name__ == '__main__':
removed_module()
```
2018-01-30 12:23:52 +00:00
2293252e52
bug-35431 fixed removing encryption from user on subsequent runs of the task ( #35433 )
2018-01-30 11:26:54 +05:30
f8a89f120f
update nxos_interface doc ( #35350 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-25 20:02:02 +05:30
cff4a2d26e
fix *os_config module backward diff ( #35332 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-25 18:49:20 +05:30
0b30c42902
fix pim rp_address issues ( #35248 )
2018-01-24 11:48:49 +05:30
4bc22be614
Fix for nxos_pim issues ( #35103 )
...
* fix nxos_pim issues
* unused line removed
* unused line removed
* remove unnecessary files
2018-01-22 11:30:52 +05:30
8a6d699198
Enable nxapi nxos_banner test ( #35033 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-18 11:50:15 +05:30
9a32f5c889
Add missing extends_documentation_fragment ( #35013 )
...
NXOS modules need more work, though that will all be in
module_docs_fragments/nxos.py
2018-01-17 16:31:53 -05:00
db61f8f967
Clarify which ping module to use ( #34935 )
...
* Clarify which ping module to use
Ensure each of the ping modules link to each other
ping - Requires Python on remote-node
nxos_ping - Only on Cisco NXOS
ios_ping - Only on Cisco IOS
net_ping - For network devices
win_ping - only for Windows
2018-01-17 14:02:06 +00:00
3a144b290d
fix for nxos_vxlan_vtep_vni issues ( #34946 )
...
* fix vxlan_vtep_vni issues
* pep8 errors
2018-01-17 11:07:29 +05:30
Trishna Guha
Dag Wieers
saichint
Mike Wiebe
John R Barker
Ganesh Nalawade
Lindsay Hill
rahushen
Tyler
Nathaniel Case
chifu1234
Chip Gwyn