ecb05b03d4
Fix openstack security group rule vrrp choice apostrophe error ( #4750 )
...
Fixes #4444 that was erroneously closed and thought fixed
2016-12-08 11:25:11 -05:00
14fb0e4136
description expanded for 112, AKA VRRP protocol) ( #4645 )
...
* description expanded for 112, AKA VRRP protocol)
* corrected syntax for description for IP protocols
2016-12-08 11:25:02 -05:00
bcc738bd0d
Fix #4412 : os_security_group_rule support numbered protocols ( #4444 )
2016-12-08 11:24:55 -05:00
8274f55818
Make remote_group handle name and id in cloud/openstack/os_security_group_rule.py
...
* Make remote_group handle name and id
* fix regression breaking os_security_group_rule with no remote_group
2016-12-08 11:24:18 -05:00
aed44e8886
Fix OpenStack module failure output
...
The exception message, when shade fails, will contain much more
specific information about the failure if the exception is treated
as a string. The 'message' attribute alone is usually not helpful.
2016-12-08 11:24:00 -05:00
316ccb0e65
checking remote_group_id while comparing os_security_group_rule
2016-12-08 11:23:31 -05:00
530f12035b
Update docstring to show port ranges as optional
2016-12-08 11:23:18 -05:00
789c1fcbe7
Correct port matching logic
...
Port matching logic did not take into account recent shade change
to equate (None, None) to (1, 65535) when Nova is the backend.
Also, this encapsulates the port matching logic into a single function
and heavily documents the logic.
2016-12-08 11:23:18 -05:00
387fe5b0e7
Change required parameters for rules module
...
The ports and protocol are no longer required (and now depends on
a new version of shade).
2016-12-08 11:23:18 -05:00
4f2028439f
Use int in the parameter list instead of casting
2016-12-08 11:23:18 -05:00
2c3fc61357
Resolving issues in rule comparison algorithm
...
Port range min/max values are at times represented as string and
compared to int equivalents. This fix explicitly ensures all
port range values are ints for proper comparisons.
2016-12-08 11:23:18 -05:00
e7dd93c5c1
Compare ports as strings
...
Ports as returned from shade are ints. They are strings as they come
in to the module.
2016-12-08 11:23:18 -05:00
14212c37e2
Fix syntax error
2016-12-08 11:23:18 -05:00
60102e36e2
Return rule object
2016-12-08 11:23:18 -05:00
174254a423
Update secgroup rules module for latest shade
...
This allows the rules module to work against either nova or neutron
for handling security groups. New parameters for 'direction' and
'ethertype' are added.
Check mode is supported with this version.
2016-12-08 11:23:18 -05:00
fcc1d643f6
Recongnize None and -1 port equivalency
...
shade 0.7.0 represents disabled min/max ports as None (in the
neutron style) rather than -1. Recognize this as the same as -1.
2016-12-08 11:23:17 -05:00
b42a9d56e6
Fix id value reference
2016-12-08 11:23:17 -05:00
f02ec15c17
Update rules mode for latest shade
...
Shade 0.7.0 normalized the security group data that is returned,
when using nova, to look more like neutron security group data.
This adjusts for that change.
2016-12-08 11:23:17 -05:00
ecef2aadba
Minor fixes for os_security_group_rule module
...
Was not able to use this module as it was. The changes submitted
resolved the issues I ran into in order to get it working.
2016-12-08 11:23:17 -05:00
2d7dbc5d0c
Fix invalid syntax in openstack_module_kwargs call
2016-12-08 11:23:17 -05:00
9acc891477
Fix example code syntax
2016-12-08 11:23:17 -05:00
8d5e43c14f
Add OpenStack Security Group Rule module
2016-12-08 11:23:17 -05:00
9cbd7b2ece
Remove os_security_group_rule module
...
The rules module will have it's own branch.
2016-12-08 11:23:08 -05:00
234a6c93c7
Add OpenStack Security Group support
...
Two modules - one for security groups and one to manage rules in a
security group.
2016-12-08 11:23:07 -05:00
indispeq
David J Peacock
Donovan Jones
David Shrewsbury
Shobhit Srivastava
Monty Taylor
dagnello
Davide Guerri