94e2d87b2f
suggest to use sequential IDs ( #57142 )
...
##### SUMMARY
Suggest to use sequential IDs - otherwise action is considered to be changed always.
##### ISSUE TYPE
- Docs Pull Request
+label: docsite_pr
2019-05-30 10:39:59 -04:00
7a0af34ba9
First batch _facts -> _info rename. ( #56822 )
2019-05-27 18:17:42 +02:00
b275dede0c
Adds one more example for `rollbar_deployment` module ( #56535 )
...
- Also `name` added to existing example in order to comply documentation styleguide
2019-05-21 15:12:54 -05:00
2cfaf6e80a
sensu_subscription very minor docstring typo ( #55675 )
2019-04-23 16:42:01 -05:00
bea397b458
Add type int for various argument params ( #55026 )
...
Specify type as int for various arguments where default value is int.
Fixes : #55005
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-04-10 16:19:00 -04:00
24c5a6ef4c
grafana_plugin: Add check condition when plugin version is 'latest' ( #53369 )
...
* Add check condition when plugin version is 'latest'
* Add check condition when plugin version is 'latest' + pep 8
2019-04-10 15:55:55 -04:00
97ac03f613
zabbix_action: Checking event source for 'pause_suppressed' parameter ( #54951 )
2019-04-08 04:43:27 -04:00
0fe63ec2d6
zabbix_action: Fixing the default message checking ( #54953 )
2019-04-08 04:43:15 -04:00
bc4ef99533
standardize TLS connection properties ( #54315 )
...
* openstack: standardize tls params
* tower: tower_verify_ssl->validate_certs
* docker: use standard tls config params
- cacert_path -> ca_cert
- cert_path -> client_cert
- key_path -> client_key
- tls_verify -> validate_certs
* k8s: standardize tls connection params
- verify_ssl -> validate_certs
- ssl_ca_cert -> ca_cert
- cert_file -> client_cert
- key_file -> client_key
* ingate: verify_ssl -> validate_certs
* manageiq: standardize tls params
- verify_ssl -> validate_certs
- ca_bundle_path -> ca_cert
* mysql: standardize tls params
- ssl_ca -> ca_cert
- ssl_cert -> client_cert
- ssl_key -> client_key
* nios: ssl_verify -> validate_certs
* postgresql: ssl_rootcert -> ca_cert
* rabbitmq: standardize tls params
- cacert -> ca_cert
- cert -> client_cert
- key -> client_key
* rackspace: verify_ssl -> validate_certs
* vca: verify_certs -> validate_certs
* kubevirt_cdi_upload: upload_host_verify_ssl -> upload_host_validate_certs
* lxd: standardize tls params
- key_file -> client_key
- cert_file -> client_cert
* get_certificate: ca_certs -> ca_cert
* get_certificate.py: clarify one or more certs in a file
Co-Authored-By: jamescassell <code@james.cassell.me>
* zabbix: tls_issuer -> ca_cert
* bigip_device_auth_ldap: standardize tls params
- ssl_check_peer -> validate_certs
- ssl_client_cert -> client_cert
- ssl_client_key -> client_key
- ssl_ca_cert -> ca_cert
* vdirect: vdirect_validate_certs -> validate_certs
* mqtt: standardize tls params
- ca_certs -> ca_cert
- certfile -> client_cert
- keyfile -> client_key
* pulp_repo: standardize tls params
remove `importer_ssl` prefix
* rhn_register: sslcacert -> ca_cert
* yum_repository: standardize tls params
The fix for yum_repository is not straightforward since this module is
only a thin wrapper for the underlying commands and config. In this
case, we add the new values as aliases, keeping the old as primary,
only due to the internal structure of the module.
Aliases added:
- sslcacert -> ca_cert
- sslclientcert -> client_cert
- sslclientkey -> client_key
- sslverify -> validate_certs
* gitlab_hook: enable_ssl_verification -> hook_validate_certs
* Adjust arguments for docker_swarm inventory plugin.
* foreman callback: standardize tls params
- ssl_cert -> client_cert
- ssl_key -> client_key
* grafana_annotations: validate_grafana_certs -> validate_certs
* nrdp callback: validate_nrdp_certs -> validate_certs
* kubectl connection: standardize tls params
- kubectl_cert_file -> client_cert
- kubectl_key_file -> client_key
- kubectl_ssl_ca_cert -> ca_cert
- kubectl_verify_ssl -> validate_certs
* oc connection: standardize tls params
- oc_cert_file -> client_cert
- oc_key_file -> client_key
- oc_ssl_ca_cert -> ca_cert
- oc_verify_ssl -> validate_certs
* psrp connection: cert_trust_path -> ca_cert
TODO: cert_validation -> validate_certs (multi-valued vs bool)
* k8s inventory: standardize tls params
- cert_file -> client_cert
- key_file -> client_key
- ca_cert -> ca_cert
- verify_ssl -> validate_certs
* openshift inventory: standardize tls params
- cert_file -> client_cert
- key_file -> client_key
- ca_cert -> ca_cert
- verify_ssl -> validate_certs
* tower inventory: verify_ssl -> validate_certs
* hashi_vault lookup: cacert -> ca_cert
* k8s lookup: standardize tls params
- cert_file -> client_cert
- key_file -> client_key
- ca_cert -> ca_cert
- verify_ssl -> validate_certs
* laps_passord lookup: cacert_file -> ca_cert
* changelog for TLS parameter standardization
2019-03-28 00:19:28 -05:00
d0efe3d9fe
Added host inventory option to zabbix_host_facts module ( #54341 )
2019-03-26 02:31:42 -04:00
ab47142fa0
minor typo fix in zabbix_action ( #54229 )
...
Changed 'operaration' to 'operation'
2019-03-22 17:49:43 +05:30
0df453bb5d
Zabbix action: Correcting 'notify_all_involved' for acknowledge operations ( #53197 )
2019-03-03 04:23:22 -05:00
befd5b2ff7
Zabbix action: Adding operation condition ( #53173 )
2019-03-01 11:14:06 -05:00
832a669104
[zabbix_action] Refactoring the argument spec ( #53106 )
...
* Refactoring the argument spec
* Adding subarguments for recovery and acknowledge operations
* Correcting the linting errors
2019-03-01 07:38:45 -05:00
1b338f917f
Fixing mediatype default value ( #53114 )
...
* Fixing mediatype default value
* Updating the documentation of media_type
2019-03-01 07:25:56 -05:00
00efa26cdb
Do not delete duplicate host when fetching Zabbix Hosts ( #53160 )
2019-03-01 09:51:39 +00:00
aa2cf46a09
Fixes typo of 'registed' to 'registered' ( #52708 )
2019-02-21 13:41:19 +05:30
13fa284946
zabbix_action: Adding an option for pausing operations while in maintenance ( #52500 )
...
* zabbix_action: Adding an option for pausing operations while in maintenance
* zabbix_action: Correcting linting errors
2019-02-19 03:44:00 -05:00
d1d4f4bd27
Add support for macro contexts that have colons ( #51853 )
...
Currently when used with macro contexts that have a colon inside,
macro_name gets truncated. A common case is contexts that represent a
Windows drive. Examples:
- 'C_DRIVE_THRESHOLD: "C:"'
- 'C_DRIVE_THRESHOLD: "D:"'
This happens because line 189 assumes there are only one colon in
macro_name, and thus two substrings to join.
To solve this, it is necessary considering that macro_name could have
more that one colon. After the split, the first element is the proper
Zabbix macro name. Then, the solution is joining all the remaining
substrings after that.
This is backwards compatible in the case macro_name have only one colon.
2019-02-18 17:51:35 +00:00
81d688a7c7
clarify how users are specified ( #52260 )
...
##### SUMMARY
Clarify that usernames - which Zabbix API documentation calls "aliases" - are to be specified for recipients
##### ISSUE TYPE
- Docs Pull Request
+label: docsite_pr
2019-02-16 03:07:29 -05:00
f9ab9b4d68
Assorted pylint fixes
2019-02-15 06:54:47 -08:00
0a461380a3
Fix incorrect use of `is` for comparisons.
...
See https://bugs.python.org/issue34850 for details.
2019-02-12 16:33:13 -08:00
0f0d33a954
start getting modules to use shared import error code ( #51787 )
2019-02-06 12:39:17 -05:00
901ae2333e
acknowledge operations are update operations now ( #51304 )
...
Acknowledge operations are update operations since Zabbix 4.0
+label: docsite_pr
2019-01-29 09:51:18 -05:00
d2eb7a6cc1
Document trigger_severity values ( #51331 )
...
* Document the valid values for trigger_severity.
* Minor typo fix.
+label: docsite_pr
2019-01-26 07:17:39 -05:00
2133f0821a
zabbix_template: Fixed interactions between options and data within JSON object ( #51222 )
2019-01-26 13:15:32 +01:00
6345ea2925
Fix example, clarify "macro_name" syntax ( #51129 )
...
* Fix the macro name in example to use allowed characters.
* Clarify on the syntax for the "macro_name" parameter.
2019-01-24 14:30:12 -06:00
18ee119a40
Adding 'eval_type' option for zabbix_action module ( #51266 )
2019-01-24 09:13:01 -05:00
e7b91f331b
fix use_proxy option in icinga2_host ( #47671 )
2019-01-14 12:03:36 +01:00
95f97bb8d6
Update zabbix_action.py ( #50548 )
...
* Update zabbix_action.py
Clarify when in/not in operators can be used.
2019-01-09 09:32:39 -06:00
260285a73f
zabbix_host_facts: get list of templates ( #50007 )
...
Get list of templates among other items. It is useful because later one can edit this list using zabbix_host module.
2019-01-09 05:12:32 -05:00
33d888210b
zabbix: fix author's github handle ( #50700 )
2019-01-09 10:45:31 +01:00
c7f3829ad4
Update zabbix_action.py ( #50582 )
...
* Document "host_groups", "templates" and "inventory" operation parameters.
* Fix a couple of typos.
Fixes #50581
+label: docsite_pr
2019-01-08 10:11:48 -05:00
9093ca1f3b
Improve style and fix typos in the Zabbix module titles and descriptions ( #50575 )
2019-01-06 01:33:54 +01:00
ff4af614e1
Update zabbix_action.py ( #50490 )
...
* Add trailing dots for consistency.
* Document how the current host can be specified for "run_on_hosts".
+label: docsite_pr
2019-01-03 10:15:21 -05:00
09ba1f38f1
Zabbix Action: Idempotency fix ( #50297 )
2018-12-26 01:59:45 -05:00
47e72063a3
Update zabbix_action.py ( #50149 )
...
Mostly typo/grammar fixes. "Zabbix Server" was changed to just "Zabbix", as it could be slightly confusing - some people might interpret this referencing the server process, although API matters. "capital-case" was changed, as it usually is one of "capital" or "upper-case".
+label: docsite_pr
2018-12-19 14:09:16 -05:00
8ec9565aa9
Fix typo in ds_type in examples section ( #50166 )
...
replace ds_type elasticisearch by elasticsearch
2018-12-19 13:49:06 -05:00
05c6ff79f9
Convert to reduced list of known types ( #50010 )
2018-12-19 07:25:30 +10:00
175f3b51e5
Ensure that current uses of BaseException are required
...
* In some cases, it appears that Exception should have been used instead
as there's no need to catch sys.exit KeyboardInterrupt and similar.
* In a few cases, it appears that BaseException is used because
a library we depend on calls sys.exit() contrary to good coding
design. Comment those so that we know that those have been audited
and found to be correct and change to use (Exception, SystemExit)
instead.
2018-12-16 15:03:19 -08:00
3fba006207
Update bare exceptions to specify Exception.
...
This will keep us from accidentally catching program-exiting exceptions
like KeyboardInterupt and SystemExit.
2018-12-16 15:03:19 -08:00
b079070688
Fix grafana_dashboard py2/3 compatibility ( #49194 )
...
* Fix grafana_dashboard py2 compatibility
* Convert URL output to a text/unicode string for json.loads
2018-12-12 12:42:55 -05:00
d62492e656
zabbix: New zabbix_action module ( #49189 )
2018-12-02 10:04:45 +01:00
d1816d4908
grafana_datasource: Add CloudWatch as grafana datasource type ( #48174 )
2018-11-29 20:58:49 +01:00
a9aa1053a8
zabbix_template: fixed idempotency issues ( #49188 )
2018-11-29 20:38:32 +01:00
bbab4c1b49
Cast int for expire field to avoid call failure to sensu API ( #33239 )
2018-11-29 12:30:59 +00:00
7190c73d50
zabbix_hostmacro: Fixed support for LLD type user macros and added missing validate_certs attribute ( #48730 )
2018-11-29 09:15:13 +01:00
bc3e7bbeba
E325 Removal - Part II ( #49196 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-28 13:55:52 +05:30
91b7bee3da
-'templateLinkage' set to match Zabbix web interface defaults ( #45229 )
2018-11-27 09:17:05 -05:00
75407d3e43
Validate DOCUMENTATION.author ( #48993 )
...
* Validate DOCUMENTATION.author
Ensure that author line includes a GitHub account
2018-11-21 17:29:29 +00:00
Richlv
Felix Fontein
Alexey Nikitin
Lindsay Hill
Abhijeet Kasurde
charlrvd
Ruben Tsirunyan
James Cassell
sky_joker
Michael Miko
Shivam Singhal
Pablo Piaggio
Dag Wieers
Matt Clay
Jordan Borean
Dusan Matejka
Marcin
mindrb
René Moser
Baptiste Mille-Mathias
Toshio Kuratomi
Johann Queuniet
martinwangjian
joaocpinto
AlexZolotarenko
John R Barker