Commit Graph

111 Commits (7ee0fa3b4b4ac7e7702154685ab525f5ba15e438)

Author SHA1 Message Date
varnav a05df49998 Fixed confusion in the docs
As 'path' is actually alias for 'dest', this could be confusing.
2016-12-08 11:23:37 -05:00
Toshio Kuratomi 58573187f8 Change the example of rsync_opts to use a list instead of a string
Fixes #9889
2016-12-08 11:23:37 -05:00
James Cammarata 4a4674ca24 Fix syntax error in synchronize docstring 2016-12-08 11:23:36 -05:00
skylerbunny dabf94ab1f Explanation of privilege escalation in notes
An attempt to make clear how privilege escalation works with respect to the src/source host and dest/destination host. One existing note was incorporated into three new ones, iterating each.
2016-12-08 11:23:36 -05:00
Jérémie Astori 6695cc5c21 Fix physical walk on acl module for Linux
`-h` is for BSD [1] while `-P`/`--physical` is for Linux [2].
This commit fixes that option now that acl module is (temporarily)
only supported for Linux.
I will re-add `-h` when fixing BSD support.

[1]: http://www.freebsd.org/cgi/man.cgi?format=html&query=setfacl(1)
[2]: http://linuxcommand.org/man_pages/setfacl1.html
2016-12-08 11:23:33 -05:00
Jérémie Astori 186cc7cb17 Make sure entry is not sent when acl state=query 2016-12-08 11:23:33 -05:00
Jérémie Astori 3568f1cd78 Make sure permission-less entries are accepted when state=absent
Also, remove that try condition as, at that stage, no permissions with
other than 2 or 3 fields are sent to the function.
2016-12-08 11:23:33 -05:00
Jérémie Astori a93445c798 Remove support for `d[efault]:` in entry permissions
It is not documented in [the Ansible doc page][1] nor
[the BSD setfacl man entry][2] (which means it might not be compatible
with BSD) so removing it does not break the API.

On the other hand, it does not conform with POSIX 1003.1e DRAFT
STANDARD 17 according to the [Linux setfacl man entry][3] so safer to
remove.

Finally, the most important reason: in non POSIX 1003.e mode, only ACL
entries without the permissions field are accepted, so having an
optional field here is very much error-prone.

[1]: http://docs.ansible.com/ansible/acl_module.html
[2]: http://www.freebsd.org/cgi/man.cgi?format=html&query=setfacl(1)
[3]: http://linuxcommand.org/man_pages/setfacl1.html
2016-12-08 11:23:33 -05:00
Jérémie Astori 1b34f1a7ac Fix wrong expectation regarding entry format in acl module 2016-12-08 11:23:32 -05:00
Jérémie Astori 6c298e20c0 Fix wrong processing of lines returned by setfacl in test mode 2016-12-08 11:23:32 -05:00
Jérémie Astori 08e8f732c5 Fix minor whitespace issues 2016-12-08 11:23:32 -05:00
Matthias Frey 2ed50d5e5b assemble: add file validation support. 2016-12-08 11:23:31 -05:00
Brian Coca a1992ad890 updated encoding comment and expanded authors field 2016-12-08 11:23:31 -05:00
Jérémie Astori 288a9d8500 Set version number in recursive option description 2016-12-08 11:23:30 -05:00
Jérémie Astori 17170992c3 Ensure Python 2.4 compatibility and Linux-restricted support
- Make build_entry compatible with Python 2.4
- Re-add missing warning/comment that was forgotten while refactoring
- Replace `all()` with a good ol' for-loop Python 2.4 compatibility
- Make a condition check more explicit (when `state` is `query`)
- Make sure this module can only be run with on a Linux distribution
- Add a note about Linux-only support in the documentation
- Set the version in which recursive support was added, 2.0
2016-12-08 11:23:30 -05:00
Marius Gedminas 9ab2e9c740 Fix obvious copy-paste error in module docs 2016-12-08 11:23:30 -05:00
Toshio Kuratomi a10b0e6fff Modify the default for synchronize's dest_port again 2016-12-08 11:23:30 -05:00
Toshio Kuratomi 052320b452 Update docs to reflect precedence for synchronize's dest_port param 2016-12-08 11:23:29 -05:00
Toshio Kuratomi 9ba5a438a8 Allow mode as a synchronize parameter (handled in action plugin) 2016-12-08 11:23:29 -05:00
Markus Juenemann 47065c2a43 Removed check whether destination directory is writable from files/unarchive.py. This check will prevent extraction of an archive if the archive does not actually write to the destination directory but only writes to any writable sub-directories of it. The underlying tar command will report errors should it try to write to read-only directories. 2016-12-08 11:23:29 -05:00
Jérémie Astori edf531efd7 Add recursive support for ACL module (fix #5053, fix #5550, fix #7276) 2016-12-08 11:23:28 -05:00
Toshio Kuratomi a01a800b65 Fi the local_rsync_path parameter used by the action plugin 2016-12-08 11:23:26 -05:00
James Cammarata ba9ba7d0f5 In copy, set the mode before running th validation
Because some programs that do validation (like visudo) may require
the permissions to be more restricted.

Fixes ansible/ansible#11385
2016-12-08 11:23:26 -05:00
Brian Coca 56354731ce fixed fragment docs 2016-12-08 11:23:26 -05:00
Mike Putnam 9623cd570c Add missing GPLv3 License header
Fixes #1643
2016-12-08 11:23:25 -05:00
Jeff Widman 70b3290a3b Move validate command into doc fragment and fix a few typos 2016-12-08 11:23:24 -05:00
Isaac Simmons 07ccd3c86b Handle ini file properties that contain interpolation errors in the initial values 2016-12-08 11:23:23 -05:00
Patrik Lundin 88881415e9 synchronize: add flag for verifying target host.
Add the possibility to verify the target host using a "verify_host"
flag. It is disabled by default to not change the module behaviour.
2016-12-08 11:23:22 -05:00
Brian Coca e4dd0d98d4 now captures any exceptions when trying to create directories 2016-12-08 11:23:21 -05:00
Brian Coca 60d160a2e9 Also document in example that unarchive download was added in 2.0 2016-12-08 11:23:20 -05:00
Mitchell Ludwig b664603a4d Improved stat documentation 2016-12-08 11:23:20 -05:00
Brian Coca f8f4a7dcdf added ignore hidden to assemble 2016-12-08 11:23:18 -05:00
Matthew Gilliard 17a40aa259 Handle race condition in directory creation.
If we try to make a directory, but someone else creates the directory
at the same time as us, we don't need to raise that error to the user.
They asked for the directory to exist, and now it does. This fixes
the race condition which was causing that error to be raised, and
closes #1648.
2016-12-08 11:23:16 -05:00
verm666 6acfa5fcee unarchive: fix @bcoca's remarks, issue #1575 2016-12-08 11:23:16 -05:00
verm666 b898cb656b unarchive: fix work with 0 bytes archives
This change is in response to issue #1575
2016-12-08 11:23:15 -05:00
Vladimir Martsul db646757c1 Add "force" description
Add "force" option description
2016-12-08 11:23:15 -05:00
gimoh fd69c5687b Do not insert extra newline if line already contains it
When using YAML multi-line strings, e.g.:

- lineinfile:
    dest: /tmp/foo
    line: >
      foo
      bar

the line already ends with a newline.  If an extra newline is appended unconditionally it will lead to inserting an extra newline on each run.
2016-12-08 11:23:13 -05:00
Toshio Kuratomi 870446dd6b Update version_added to 2.0 for the partial option 2016-12-08 11:23:12 -05:00
Juan Picca 81ea358b09 synchronize module: add partial option 2016-12-08 11:23:12 -05:00
Toshio Kuratomi 5f27a073ba Bump amount of file to download in a chunk to 64k. 2016-12-08 11:23:11 -05:00
Jonathan Mainguy dd0659c83d add download ability to unarchive module 2016-12-08 11:23:11 -05:00
Ritesh Khadgaray 9c3f9d23c8 Add the ability to grep for content 2016-12-08 11:23:09 -05:00
Greg DeKoenigsberg eb881d7d5d Proper author info for all remaining modules 2016-12-08 11:23:07 -05:00
Tristan Fisher 75ef963922 removes bool type from validate. 2016-12-08 11:23:03 -05:00
Tristan Fisher 0180be25c4 standardizes bools in argument_spec 2016-12-08 11:23:03 -05:00
jaypei fbc8d4ca4a use the right way to unescape line string Reference https://github.com/ansible/ansible/issues/10864 2016-12-08 11:23:03 -05:00
Brian Coca 322518d06c stat doc fix fixes #1371 2016-12-08 11:23:02 -05:00
Greg Taylor 79dd0466b5 Adding directory creation example to file module. 2016-12-08 11:23:00 -05:00
Brian Coca b4775234c9 minor docfix 2016-12-08 11:23:00 -05:00
Toshio Kuratomi 7e5a4afb6b Update module "imports" to new style
Fixes #1351
2016-12-08 11:23:00 -05:00