a1e2f1bf73
[voss_facts] remove uneeded global declaration of variable warnings ( #45653 )
...
Since the variable is used only once, no need to declare it global.
Remove a warning from linter (lgtm.com)
2018-09-14 10:39:41 -04:00
3782a236ba
Update azure_rm_trafficmanagerprofile.py examples ( #45649 )
...
Wrong module name used in examples. changed `azure_rm_trafficmanager` to `azure_rm_trafficmanagerprofile`
2018-09-14 09:48:11 -04:00
8d6522c671
Update mysql_db.py ( #41317 )
...
Add note to inform that mysql_db is not idempotent when state is "import".
+label: docsite_pr
2018-09-13 17:31:45 -04:00
ede3a8cee1
Fix formatting for the error on azure_rm_appserviceplan_facts ( #45613 )
...
Since there is only 1 argument, {1} can't work since that's the
2nd argument for format. Flagged by lgmt.com
2018-09-13 17:00:21 -04:00
5a3a865ca0
More bigip software fixes ( #45633 )
...
Fixes problems related to token timeout. Adds cleanup of tokens.
2018-09-13 15:58:17 -04:00
e619052424
Fixes multiple lgtm issues ( #45629 )
...
Most of the issues were just inclusions of code that were not used.
This cleans those up. Other alerts were semi-false-positives for now
2018-09-13 15:26:17 -04:00
e26d758d6f
fix gce_backend_service examples for healthchecks ( #31134 )
...
gce_backend_service module expects healthchecks to be an array of string. The previous example incorrectly mentioned healthchecks as an array of objects each containing a `name` key.
2018-09-13 13:47:43 -05:00
34d08adea0
Fixes lgtm alert ( #45619 )
...
Alert was for an include that was not used.
https://lgtm.com/projects/g/ansible/ansible/latest/files/lib/ansible/modules/network/f5/_bigip_facts.py?sort=name&dir=ASC&mode=heatmap&showExcluded=false#L98
2018-09-13 13:45:55 -04:00
de84a05bf4
Remove unused import iControlUnexpectedHTTPError ( #45611 )
...
Since that's unused in the code, no need to import it.
This got flagged by linter
2018-09-13 13:16:23 -04:00
285b927889
network command modules cleanup ( #45242 )
...
* Standardize _command modules
* Centralize command transformation process
* Fix check mode error test
2018-09-13 08:55:35 -04:00
df768914a1
adding sql firewall rule facts ( #45059 )
2018-09-13 17:54:58 +08:00
8d8df46fe6
Add an error message if a pkg cannot be removed, fixes #35672 ( #40723 )
2018-09-13 02:54:38 -04:00
03dbb1d9c4
Improve code stability is checksum checking
...
- use context manager for dealing with the checksum file
- use loop that can tolerate zero, one, or more items return rather than the previous expression which would break if anything other than exactly one item was returned
2018-09-12 15:29:15 -07:00
2a3f3382fd
Ovirt add rename functionality ( #44951 )
...
* add renaming of ovirt
* add renaming func to ovirt cluster
* ovirt update examples in docs
2018-09-12 14:36:06 -07:00
ab2e6fded1
Show multi-line messages in debug documentation ( #23000 )
...
* Show multi-line messages in debug documentation
* Add two-line entry
* Indicate that jinja2 filters are not applied here
* Fix to incorrect documentation change
2018-09-12 16:55:48 -04:00
3c083837c0
Clarify how java_cert checks keystore certificates ( #26567 )
2018-09-12 15:51:37 -05:00
e266a24263
Fixes bugs in the bigip_software modules ( #45577 )
...
This patch makes hotfix code work, where before, only base images
were working
2018-09-12 15:56:43 -04:00
1ed57f1f64
moving from with_ff to just ff ( #44847 )
2018-09-12 15:35:04 -04:00
f7ef06e849
Added a note regarding the delegate_facts option. ( #25257 )
...
* Added a note regarding the delegate_facts option with a link to documentation
2018-09-12 14:30:05 -05:00
ea8924f744
Make it clear that recurse only applies to state=directory ( #40222 )
...
This would otherwise cause confusion as it could be interpreted as only changing attributes for directories (and not files inside).
+label: docsite_pr
2018-09-12 13:00:49 -04:00
ac58c36ad0
Lenovo cli bugfixes ( #45278 )
...
* To change all CLIs present in the code to latest CNOS CLI. One bug of executing with Lenovo Jakku switch is also getting fixed.
* To change the file names as the commands have changed from display to show
* To change to new CLI in test_cnos_comand.py as well
2018-09-12 10:31:45 -04:00
6040175186
Initial commit of fmgr_sys_proxy.py ( #45518 )
2018-09-12 19:18:27 +05:30
73c8041ec0
Azure load balancer crash fix ( #45546 )
2018-09-12 16:25:35 +08:00
111febe62e
extended vmss facts ( #45535 )
2018-09-12 13:22:47 +08:00
0198d93f68
Update keycloak_client.py ( #45505 )
...
Slightly improve wording about lack of input sanity checking on API calls.
+label: docsite_pr
2018-09-12 06:22:54 +02:00
821c27cefb
fixed tag support in autoscale facts ( #45533 )
...
* fixed tag support in autoscale facts
* forgot to add tags to arg spec
2018-09-11 23:00:58 -04:00
004621ef8e
Fix useless comparaison between 2 constants ( #45524 )
...
Found with https://lgtm.com
2018-09-11 19:37:50 -04:00
197059b4a2
Update the root URI to match the DMTF specification ( #45295 )
2018-09-11 19:15:59 -04:00
bf90a44468
Clarify the creates and removes options ( #45485 )
...
* Clarify the creates and removes options
The description for the creates and removes options were worded poorly. This change improves readability and is easier to understand.
Double negatives are BAD
+label: docsite_pr
* Fix trailing whitespace
2018-09-11 15:45:19 -05:00
2ea9cfcd52
Fix python 3 compatibility for network id lookup ( #45467 )
...
Due to a change in python 3 filters return filter instead of list. This breaks the network name to id lookup for the docker_swarm_module. By wrapping it in list it ensures it is a list when returned and the id is extracted.
2018-09-11 15:45:42 -04:00
e5269c047c
[AWS] cloudfront_distribution - fix method name from 'validate_distribution_id_from_caller_reference' to 'validate_distribution_from_caller_reference' and set distribution_id to the distribution's key 'Id' ( #45498 )
2018-09-11 15:08:30 -04:00
5785de582f
Fix logic to not re-download existing files when force=no ( #45495 )
...
* Fix logic to not re-download existing files when force=no. Fixes #45491
* Reduce logic complexity
2018-09-11 13:56:13 -05:00
ae4d5e3257
Avoid duplicate Azure storage account types.
2018-09-11 10:37:48 -07:00
600c7ac108
Fix remote checksums when paths have leading dots ( #45287 )
...
* Fix remote checksums with paths have leading dots
* Fix result recorded from the wrong file
* Add changelog fragment
2018-09-11 12:47:29 -04:00
804d574d1f
Add documentation for the modify command, by giving a example ( #19699 )
2018-09-11 11:38:39 -04:00
03414727ba
Add documentation about patterns with commas to find module ( #45360 )
...
Thanks @samdoran for the example and clarification!
2018-09-11 11:04:17 -04:00
fa04387550
fix the autoscale resource id ( #45477 )
...
* fix the autoscale resource id
* Update main.yml
2018-09-11 18:52:43 +08:00
8a221d81dd
fixing facts for mysql server ( #45374 )
2018-09-11 14:27:50 +08:00
01398f61d5
Win deprecate 2.8 ( #45473 )
...
* Remove deprecated/expired functionality
* win:_msi: Remove the win_msi module
* removed some missed deprecated return options and added porting guide reference
Co-authored-by: dagwieers <dagwieers@users.noreply.github.com>
2018-09-11 14:23:48 +10:00
ec6d82435f
win_scheduled_task: add deprecation warning for repetition format ( #45468 )
...
* win_scheduled_task: add deprecation warning for repetition format
* fixed up sanity issues
2018-09-11 14:22:57 +10:00
ee8a10b87d
Fixes authentication error when ansible_user is a local account and computer is already joined to domain ( #44270 )
...
* Fixes authentication error when ansible_user is a local account and computer is already joined to domain
* recommended fixes
2018-09-11 13:20:45 +10:00
3371a779b6
win_group_membership - fix random issue with CI on 2012 R2 ( #45462 )
2018-09-11 13:07:43 +10:00
881f3a599c
windows testing - changes to accomodate future behaviour changes ( #45464 )
2018-09-11 13:04:23 +10:00
0b029d6792
adding tags support to postgresql ( #45339 )
2018-09-11 10:20:27 +08:00
c9c141fb6a
win_say - fix up syntax and test issues ( #45450 )
2018-09-11 08:23:46 +10:00
69bbd32264
Grafana datasource module : Use url_argument_spec from urls ( #40402 )
...
* Added client_cert and client_key modules parem
* Use url_argument_spec to init module arguments
* Do not compare version and readOnly
* Convert HTTPResponse content to text before json.loads
* Added password in secureJsonPayload when datasource type is postgres
2018-09-10 16:06:34 -04:00
0015d4cef3
2.8 Core Deprecation Removal ( #45232 )
...
* Remove deprecated ansible.vars.unsafe_proxy. Fixes #45040
* Remove deprecated validate_md5 alias from fetch module. Fixes #45039
* Remove deprecated private arg from import/include_role. Fixes #45038
* All include deprecations bumped to 2.12. Fixes #45037
* Add changelog for deprecated removals
2018-09-10 15:05:52 -05:00
99aafcc8ca
Update postgresql_user.py ( #45146 )
...
* Update postgresql_user.py
md5sum generates output with hypen. Something like the following
```
$ echo "md5$(echo -n 'verysecretpasswordJOE' | md5sum)"
md5d011966da94d776cf59bf6dbde240e5d -
```
We need to remove hyphen from the output. Also the command by itself is incorrect
```
echo "md5$(echo -n 'verysecretpasswordJOE' | md5sum")
```
double quotes must be after right parenthesis
```
echo "md5$(echo -n 'verysecretpasswordJOE' | md5sum)"
```
+label: docsite_pr
* Update postgresql_user.py
Add curly braces
2018-09-10 16:00:18 -04:00
371d9596f4
Add Sangoma linux ( #45430 )
...
Fixes https://github.com/ansible/ansible/issues/45300
2018-09-10 14:20:22 -04:00
7d0cd81d4f
VMware: exclude start_connected from host customization check ( #40990 )
2018-09-10 16:15:47 +05:30
Michael Scherer
Deaton64
Xyon
Tim Rupp
Vibhav Sinha
Nathaniel Case
Zim Kalinowski
Strahinja Kustudic
Sam Doran
Martin Nečas
Jon "The Nice Guy" Spriggs
Ferdinand Holzer
Brian Coca
Evert
Richard Schwab
Anil Kumar Muraleedharan
Ghilli3
Brian Brooks
Jose Delarosa
Kerry
William
Sloane Hertel
Matt Martz
Matt Clay
David Rodríguez
Yuwei Zhou
Jordan Borean
Mike Klebolt
Seuf
Alexhha
Isaac McDonald
Eric Thiel