87ce503767
added stdout and stderr outputs ( #1900 )
...
* added stdout and stderr outputs
Added stdout and stderr outputs of the results from composer as the current msg output strips \n so very hard to read when debugging
* using stdout for fail_json
using stdout for fail_json so we get the stdout_lines array
2016-12-08 11:34:04 -05:00
d2d4001dc5
New preserve_node parameter to skip unreferenced node removal
2016-12-08 11:34:04 -05:00
bcfab26d78
Unchecked index causes IndexError.
2016-12-08 11:34:04 -05:00
3a319b9a84
support for 'update_cache' in pkgin module
2016-12-08 11:34:04 -05:00
971b570b67
Do not leak passwords in case of error in cloudstack modules
2016-12-08 11:34:04 -05:00
4b948af706
Enable stdout and stderr on sucessful runs, making show_diff useable
...
omit color symbols as ansible makes them illegible
2016-12-08 11:34:04 -05:00
75b172c706
hipchat api v2 rooms are now url escaped
2016-12-08 11:34:04 -05:00
7e1a538b93
Add `to_destination` parameter
2016-12-08 11:34:04 -05:00
317fe95be0
system/puppet: add --tags parameter ( #1916 )
...
* system/puppet: add --tags parameter
--tags [1] is used to apply a part of the node’s catalog.
In puppet:
puppet agent --tags update,monitoring
In ansible:
puppet: tags=update,monitoring
[1] https://docs.puppetlabs.com/puppet/latest/reference/lang_tags.html#restricting-catalog-runs
* Add example of tag usage.
* system/puppet: add list type for a tags dict.
2016-12-08 11:34:03 -05:00
817335ae0d
Client_secret is supposed to be kept secret, so mark it as no_log ( #1995 )
2016-12-08 11:34:03 -05:00
bd3172b2e8
win_updates fix to use documented InstanceGuid property name
2016-12-08 11:34:03 -05:00
e20eac089f
win_updates shouldn't install hidden updates
2016-12-08 11:34:03 -05:00
e7e1a8bfea
Avoid token leak by marking it as sensitive with no_log ( #1966 )
2016-12-08 11:34:03 -05:00
ed69d8335e
Properly label path argument with type='path' ( #1940 )
2016-12-08 11:34:03 -05:00
b8706a1f95
Do not leak mail password by error
2016-12-08 11:34:03 -05:00
0dd3296ddd
Mark password as 'no_log', to avoid leaking it
2016-12-08 11:34:03 -05:00
b93fda8573
Updated Amazon module guidelines regarding boto3
...
* Updated Amazon module guidelines regarding boto3
* Spelling correction
2016-12-08 11:34:03 -05:00
c0d281e290
type should be 'list' not the default of 'string'
2016-12-08 11:34:03 -05:00
1847f19e41
don't create world-readable archives of LXC containers
...
with the default umask tar will create a world-readable archive of the
container, which may contain sensitive data
Signed-off-by: Evgeni Golov <evgeni@golov.de>
2016-12-08 11:34:03 -05:00
3b79c1621b
Prevent password leaks in notification/irc
2016-12-08 11:34:03 -05:00
67b2623e92
Use no_log=True for campfire module to avoid leaks
2016-12-08 11:34:03 -05:00
f2bf444395
Set no log for jabber.py password
2016-12-08 11:34:03 -05:00
16b2d85d34
do not use a predictable filenames in the LXC plugin
...
* do not use a predictable filename for the LXC attach script
* don't use predictable filenames for LXC attach script logging
* don't set a predictable archive_path
this should prevent symlink attacks which could result in
* data corruption
* data leakage
* privilege escalation
2016-12-08 11:34:03 -05:00
f47a756c46
Add proper type to cpanm arguments
...
from_path, locallib, executable should be path to benefits
from path expansion for ~user.
2016-12-08 11:34:03 -05:00
432a9a31ca
osx_defaults: fix datetime
...
Fix #1742
2016-12-08 11:34:02 -05:00
c8bd27f1e8
Rebase PRs against $TRAVIS_BRANCH before performing tests
2016-12-08 11:34:02 -05:00
20fd04b9e7
firewalld: fixes documentation
...
- removes warning, aligning to existing documentation
- adds version
2016-12-08 11:34:02 -05:00
8b2d484032
firewalld: add/remove interfaces to/from zones
2016-12-08 11:34:02 -05:00
aabd6390d4
fix dscp marking documentation in iptables module
2016-12-08 11:34:02 -05:00
88d8820f1b
explicitly set "default: null" in the docs
2016-12-08 11:34:02 -05:00
e1846d2e4b
do not set a default config for lxc containers
...
otherwise deploying user-containers fail as these require information
from ~/.config/lxc/default.conf that the LXC tools will load if no
--config was supplied
Signed-off-by: Evgeni Golov <evgeni@golov.de>
2016-12-08 11:34:02 -05:00
2b8b04638d
fix security vulnerability in lxc module
...
octal/decimal confusion makes file world-writable before executing it
2016-12-08 11:34:02 -05:00
e3d8facc7f
fixxed tests
2016-12-08 11:34:02 -05:00
c82d72e12a
fixed problems related to userpricincipalname (user@domain) and undefined variables fixed variable capitalization
2016-12-08 11:34:02 -05:00
186197397c
fixxed problem with match @
2016-12-08 11:34:02 -05:00
9ba30d2cea
only call set-acl if necessary
2016-12-08 11:34:02 -05:00
700ca56c61
as suggested by @marcind, convert to boolean
2016-12-08 11:34:02 -05:00
404483ea83
fixed documentation
2016-12-08 11:34:02 -05:00
de4a271dd0
added userprincipal support
2016-12-08 11:34:02 -05:00
65d5658553
added separate module to change owner, since win_acl is ACL only and should not be more complex
2016-12-08 11:34:02 -05:00
1aec0a3ffb
mongodb_user.py: changes on comments
2016-12-08 11:34:01 -05:00
37ba9a3fe1
mongodb_user: fix checking if the roles of an oplog reader user changed
2016-12-08 11:34:01 -05:00
dc83f2c6d7
use python fallback to avoid error on old mongo version without roles
2016-12-08 11:34:01 -05:00
467d9a8090
avoid problem with old mongo version without roles
2016-12-08 11:34:01 -05:00
b07e1c13f7
fix #1731 : mongodb_user always says changed
2016-12-08 11:34:01 -05:00
d20b7ee6e6
restore version_added in dynamodb_table.py
2016-12-08 11:34:01 -05:00
846a538648
Allow port 0 as a valid pool member port
2016-12-08 11:34:01 -05:00
48931065e5
The current module supporting F5 BIGIP pool creation does not support a setup where the port number must be zero to signify the pool will listen on multiple ports. This change implements that functionality and fixes an illogical conditional.
2016-12-08 11:34:01 -05:00
a21ab5b990
Use type='path' for reposdir, since that's a path
2016-12-08 11:34:01 -05:00
051b11b983
openstack: doc: add return doc, fixes build
2016-12-08 11:34:01 -05:00
48223fd268
Allow Datadog metric alerts to define multiple thresholds
2016-12-08 11:34:01 -05:00
33d3616bab
Add OpenStack os_user_role module
2016-12-08 11:34:01 -05:00
dc94ce72c7
Use boolean instead of "yes" + choice for most option
...
This enable a more standard behavior with others modules
2016-12-08 11:34:01 -05:00
2a0c9bb3a2
Use type 'path' for rootdir, for pkgng
2016-12-08 11:34:01 -05:00
bdeb5af740
cloudflare_dns: Cosmetic cleanup
2016-12-08 11:34:01 -05:00
90503c9f2a
cloudflare_dns: normalize return value and docs
2016-12-08 11:34:00 -05:00
95f270089b
cloudflare_dns: Cleanup record update handling
2016-12-08 11:34:00 -05:00
78640328cb
cloudflare_dns: Allow CNAME content updates
2016-12-08 11:34:00 -05:00
41ed47d66e
cloudflare_dns: Fix solo SRV record creation
2016-12-08 11:34:00 -05:00
85d41db922
cloudflare_dns: Fix SRV record idempotency
2016-12-08 11:34:00 -05:00
594c9ff217
Added version restriction for uid_owner and reject_with.
2016-12-08 11:34:00 -05:00
0c888bd19f
Added docs for reject_with and uid_owner.
2016-12-08 11:34:00 -05:00
30bd75e3ae
Added reject_with and uid_owner support.
2016-12-08 11:34:00 -05:00
5d68e4fe06
Add option to use ZabbixApi via auth basic protection
2016-12-08 11:34:00 -05:00
5f9d5c1403
make: move down ansible import
2016-12-08 11:34:00 -05:00
e79e024016
make: add empty return docs
2016-12-08 11:34:00 -05:00
d605860b39
module: system/make
2016-12-08 11:34:00 -05:00
c84bd72496
Add note server 2012 note to win_scheduled_task.
...
This change adds a note to the win_scheduled_task module
docs that indicates Windows Server 2012 or later is required.
This is because the module relies on the Get-ScheduledTask
cmdlet, which is a part of the Server 2012 OS. Previous
versions, like Server 2008, simply can't work with this
module.
2016-12-08 11:34:00 -05:00
0ebabc50e4
change name to be a list type
...
remove implicit split that expects a , separated string, let list type
deal with multiple possible compatible input types.
also removed unused imports
2016-12-08 11:34:00 -05:00
2dddfbe67c
Add shade version check to os_flavor_facts
...
The range_search() API was added to the shade library in version
1.5.0 so let's check for that and let the user know they need to
upgrade if they try to use it.
2016-12-08 11:34:00 -05:00
b2c7d28f41
Modify consul certificate validation bypass keyword from 'verify' to 'validate_certs'
2016-12-08 11:34:00 -05:00
ca1efafc50
Add version_added to documentation
2016-12-08 11:33:59 -05:00
6c41d9cd38
Add https support for consul clustering modules
2016-12-08 11:33:59 -05:00
41af347d8d
renamed sl to sl_vm and updated docs
...
namespace for softlayer modules should now be sl_
2016-12-08 11:33:59 -05:00
8f444b8c4b
Added Softlayer Module
2016-12-08 11:33:59 -05:00
67222d9b5b
Update the issue and pull-request templates in sync with ansible/ansible
2016-12-08 11:33:59 -05:00
011267c04e
Add os_ironic_inspect module
...
Addition of an os_ironic_inspect module to leverage the OpenStack
Baremetal inspector add-on to ironic or ironic driver out-of-band
hardware introspection, if supported and configured.
2016-12-08 11:33:59 -05:00
b7ef068d3e
Add quotes and equals for set option documentation
...
set is an option for the openvswitch_port module, however the documentation
example omitted the equals sign and quotes around the option value.
2016-12-08 11:33:59 -05:00
b58eaca7e8
Remove dead code from pacman module
...
The manual check to see if get_bin_path() returned anything is
redundant, because we pass True to the required parameter of
get_bin_path(). This automatically causes the task to fail if the pacman
binary isn't available. Therefore, the code within the if statement
being removed is never called.
2016-12-08 11:33:59 -05:00
8227105f02
fix #1747 mongodb_user support check mode
2016-12-08 11:33:59 -05:00
ba3515bc30
Allow passing domain name on os_project
2016-12-08 11:33:59 -05:00
7a28ad63f7
dynamodb_table: doc fix
2016-12-08 11:33:59 -05:00
99c8e82b60
dynamo db indexes
2016-12-08 11:33:59 -05:00
eefd716e8c
Add better type checking for elasticsearch_plugin
2016-12-08 11:33:59 -05:00
4c63a958e5
Use no_log for the password for maven_artifact module
2016-12-08 11:33:59 -05:00
9f90c2355f
Add the proper type for the various path argument
2016-12-08 11:33:59 -05:00
4cd9933388
fix edge case where boto returns empty list after subnet creation
2016-12-08 11:33:59 -05:00
1d0ae2f4ed
cloudflare_dns: Fix wrong variable name
2016-12-08 11:33:58 -05:00
1c94395a96
system/puppet: allow to run puppet -e
...
-e or --execute [1] allows to execute a specific piece of Puppet code
such a class.
For example, in puppet you would run:
puppet apply -e 'include ::mymodule'
Will be in ansible:
puppet: execute='include ::mymodule'
[1] http://docs.puppetlabs.com/puppet/latest/reference/man/apply.html#OPTIONS
2016-12-08 11:33:58 -05:00
45a32137ad
win_unzip: Use absolute path for src and dest
...
win_unzip fails to extract files when either src or dest contains
complex paths such as "..\..\" or "C:\\Program Files" (double slashes).
Fix this by fetching absolute path of both before invoking CopyHere
method.
2016-12-08 11:33:58 -05:00
d2fe2287f9
Added return documentation to win_regmerge module
2016-12-08 11:33:58 -05:00
184d9fc4e5
Fix type used by the module
...
Set int for the various port (and so avoid to convert them later)
Set no_log=True for the login_password
Verify that db is a int, so avoid a conversion
2016-12-08 11:33:58 -05:00
8abe22c917
Fix ssl to be a bool, required to fix #1732
...
May also fix #1869
2016-12-08 11:33:58 -05:00
1a05e0f1c8
Use proper type for riak config_dir argument
2016-12-08 11:33:58 -05:00
49aa069c94
Add proper type to path and link
...
Since both of them are path, it should be checked using the
proper type.
2016-12-08 11:33:58 -05:00
2760c2ded0
Reindent with_items, fix #1849
2016-12-08 11:33:58 -05:00
0254cbad9a
Fix for existing ENIs w/ multiple security groups
...
Do a sorted comparison of the list of security groups supplied via `module.params.get('security_groups')` and the list of security groups fetched via `get_sec_group_list(eni.groups)`. This fixes an incorrect "The specified address is already in use" error if the order of security groups in those lists differ.
2016-12-08 11:33:58 -05:00
f56c557a93
Fix issue #1406 about win_firewall_rule
...
I changed the logic here to always use 'netsh ... show rule' keywords as keys for $fwsettings map. While the translation (e.g. Enabled -> enable) is performed when invoking 'netsh ... add rule' command.
I tested rule creation and rule creation when the rule was already existing on Windows Server 2012.
2016-12-08 11:33:58 -05:00
e16bd19401
win_unzip: overwrite any existing file
2016-12-08 11:33:58 -05:00
7b0b4262e5
Allow SNS topics to be created without subscriptions. Also added better error handling around boto calls.
2016-12-08 11:33:58 -05:00
be083a8fbe
author added
2016-12-08 11:33:58 -05:00
6d69956f83
Fix SNS topic attribute typo
...
Enables adding SNS topic policy. 'Policy' attribute is capitalized.
2016-12-08 11:33:58 -05:00
61672e5c61
Ensure ec2_win_password doesn't leak file handle
...
Currently the module doesn't explicitly close the file handle. This
wraps the reading of the private key in a try/finally block to ensure
the file is properly closed.
2016-12-08 11:33:58 -05:00
b92b30e3b3
ec2_vpc_dhcp_options: doc fix, add version_added to new args
...
See #1640
2016-12-08 11:33:58 -05:00
5718a5caac
Updated ec2_vpc_dhcp_options
2016-12-08 11:33:57 -05:00
f85f575a58
Add support for recursive znode deletion
2016-12-08 11:33:57 -05:00
0ecaea3ac1
Added a source parameter for setting the JIT client name
2016-12-08 11:33:57 -05:00
9e918b5955
Removed debug return values
2016-12-08 11:33:57 -05:00
7127a45d96
ecs_service will now compare whole model and update it if any difference found. Documentation #1483 . Workaround for datetime fileds #1348 .
2016-12-08 11:33:57 -05:00
9b27ed6c5d
ecs_service_facts documentation fixes #1483 . Workaround for datetime fileds #1348 .
2016-12-08 11:33:57 -05:00
b820017ed0
Allow numeric npm package versions
...
When passing a package version that parses as a number (e.g. `1.9`), the version should be converted to a string before being concatenated to the package name.
2016-12-08 11:33:57 -05:00
d8ea847739
zabbix_host : add the ability to set inventory_mode
2016-12-08 11:33:57 -05:00
427ab2f016
osx_defaults: doc fix, add version_added for host agrument
...
See #1364
2016-12-08 11:33:57 -05:00
a58a91410d
osx_defaults: add "host" attribute
...
This allows us to configure defaults using the `-currentHost` or `-host`
arguments to the `defaults` executable.
2016-12-08 11:33:57 -05:00
e97ca89953
Fix vmware_portgroup throwing an error if port group already exists
2016-12-08 11:33:57 -05:00
8a3c60cfd2
add exit_json
...
add exit_json code to succesfully exit, when you want to delete the already
deleted host.
Without this, playbook fails with
`Specify at least one group for creating host`
which is not correct message.
2016-12-08 11:33:57 -05:00
b03d1da393
change host.delete() parameter for newer ZBX api.
...
As of Zabbix API 2.4, host.delete() will not takes parameter with
`hostid` property but only the array of it.
https://www.zabbix.com/documentation/2.2/manual/api/reference/host/delete
fix #1800
2016-12-08 11:33:57 -05:00
30d76cd37c
Fixing win_updates example for listing available updates.
2016-12-08 11:33:57 -05:00
2430e295a6
lvol: remove unused import
...
See #1425
2016-12-08 11:33:57 -05:00
2149a7b1f6
Added resizing based on %values. Included support for VG|PVS|FREE
2016-12-08 11:33:57 -05:00
2095aa5100
Update mongodb_user.py
...
Typo
2016-12-08 11:33:56 -05:00
39ece09e86
cloudflare_dns: minor code improvments
...
Tweaked some things on top of the well done PR #1768
- json import
- fix expetion handling
- fix indentation
2016-12-08 11:33:56 -05:00
68fc8e75f6
Module to manage Cloudflare DNS records
2016-12-08 11:33:56 -05:00
5b84102a15
Doc fixes
2016-12-08 11:33:56 -05:00
61bdf9ee0f
Fix #1809 , use the proper method to fail
2016-12-08 11:33:56 -05:00
9c883f689d
Add optional mysql connect timeout.
2016-12-08 11:33:56 -05:00
6a202054f8
Fixes route53_facts to use max_items parameter with record_sets query.
2016-12-08 11:33:56 -05:00
a1fdff4c97
Adding missing attributes regarding the hosted zone.
2016-12-08 11:33:56 -05:00
f0f1d1edc4
system/puppet: add --certname parameter
...
certname [1] can be a useful parameter when we need to specify a
certificate name different from the default value [2] in Puppet.
Ex: the hosts have different names, in advanced network isolation
setups.
Also, it can be used when we want to run Puppet with a specific node
definition and not using hostname or fqdn to match the nodes where we want to
run Puppet [3] (not recommended by Puppetlabs though).
[1] https://docs.puppetlabs.com/puppet/latest/reference/configuration.html#certname
[2] Defaults to the node’s fully qualified domain name
[3] http://docs.puppetlabs.com/puppet/latest/reference/lang_node_definitions.html#naming
2016-12-08 11:33:56 -05:00
029b608e1e
Prevent reinstallation in case of group package
2016-12-08 11:33:56 -05:00
da668dca56
Replace deprecated zabbix api method 'exists' to support zabbix 3.0
2016-12-08 11:33:56 -05:00
cd2c7deec4
Add os_group.py OpenStack module
...
Allows an admin (or privileged user) to manage Keystone v3
groups.
2016-12-08 11:33:56 -05:00
e25c04aeb0
Add new os_flavor_facts.py module
...
New module to retrieve facts about existing instance flavors.
By default, facts on all available flavors will be returned.
This can be narrowed by naming a flavor or specifying criteria
about flavor RAM or VCPUs.
2016-12-08 11:33:56 -05:00
b697d986c1
Add new os_keystone_role module.
...
This new module allows for creating and deleting Keystone
roles.
2016-12-08 11:33:56 -05:00
030fbaef64
Use os module for checking absolute/joining paths
2016-12-08 11:33:55 -05:00
d4275e576e
cronvar.py: support absolute destinations
...
Mainly so /etc/crontab can be written to.
2016-12-08 11:33:55 -05:00
c00688a118
iptables: add defaults to docs
2016-12-08 11:33:55 -05:00
4abd217aa5
add version added to new params
2016-12-08 11:33:55 -05:00
a3b7dbe1df
fix doc issue
2016-12-08 11:33:55 -05:00
994edea253
add support for setting dscp marks with iptables module
2016-12-08 11:33:55 -05:00
7abe6b0e8c
correct win_firewall state parameter
...
- original parameter comment was probably copy&paste error
- new comment highlights that firewall rules can be
added or removed altering this parameter
2016-12-08 11:33:55 -05:00
32ff89b30e
Fix module docs
2016-12-08 11:33:55 -05:00
fd68e66827
cloudstack: new module cs_zone_facts
2016-12-08 11:33:55 -05:00
4589b67a44
Remove unused variables
...
Session_id is unused in update_session, changed is always specifically
set in all exit_json call, and consul_client.session.destroy return True
or False, and is unused later (nor checked)
2016-12-08 11:33:55 -05:00
fabd619070
Rename consul variable to consul_client
...
Since the module is also named consul, pyflakes emit a warning
about it since the variable shadow the module.
2016-12-08 11:33:55 -05:00
78571c053b
Pyflakes complain about unused import, so remove it
2016-12-08 11:33:55 -05:00
334bfbd465
Add a datacenter parameter, fix #1693
2016-12-08 11:33:55 -05:00
b8b2613c35
Replace deprecated exists API for Zabbix 3.0 compatibility
2016-12-08 11:33:55 -05:00
f623057e0e
zabbix_maintenance: Stop using api removed in zabbix 3.0
2016-12-08 11:33:55 -05:00
4a9daf6bae
New json_fail syntax for dnsimple module
2016-12-08 11:33:55 -05:00
Him You Ten
Matt Hite
kubilus1
Jasper Lievisse Adriaanse
Michael Scherer
Jonathan Mainguy
Brian Beggs
Aaron Brady
Vlad Gusev
Michael Scherer
nitzmahone
Rob
Andy Baker
Evgeni Golov
Chulki Lee
Matt Martz
mo@oclab.net
David Hocky
Chris Porter
Hans-Joachim Kliemeck
Marcos Diez
Guillaume Dufour
John Barker
Matt Hite
Jason Witkowski
Rene Moser
Paul Seiffert
David Shrewsbury
Michael Gruener
Pavel Sychev
Julien Recurt
Linus Unnebäck
Tyler Cross
Brian Coca
Chris Tooley
Matt Colton
Dag Wieers
Julia Kreger
James Slagle
Matthew Gamble
Ricardo Carrillo Cruz
Matt Ferrante
Casey Lucas
Emilien Macchi
Andrea Scarpino
jhawkesworth@users.noreply.github.com
Dennis Conrad
Rob White
Fernando J Pando
Joel Thompson
Andy Nelson
Justin Good
James Moore
Darek Kaczyński
Nate Smith
Ritesh Khadgaray
Greg Hurrell
Alex Kalinin
t.goto
nonshankus
Jonas Vermeulen
lsb
Toshio Kuratomi
Matt Clay
Gabriel Burkholder
saez0pub
Miguel Martín
Doug Luce
liquidat
Eike Frost
Calvin Walton
Ricky Cook