Nilashish Chakraborty
9365c0f468
New module for BGP configuration management in Arista EOS ( #52722 )
...
* New module for BGP in EOS
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Add function to validate input
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Fix line indentation
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Add integration tests
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Fix CI
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Fix sanity test failure
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Remove unused code
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-03-12 17:31:58 +05:30
Trishna Guha
a41028244d
Add platform facts in network facts modules ( #51434 )
...
* Add platform facts in network facts modules
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add nxos
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add vyos
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add iosxr
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add junos
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix pep8
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* update unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix vyos_facts unittest
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix ios_facts unittest
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix iosxr unittests
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix CI failure
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix junos test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-03-11 10:56:39 +05:30
Trishna Guha
5f577c7e79
Add type in eos_config module docs ( #53117 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-02-28 19:25:13 +05:30
Dag Wieers
f9ab9b4d68
Assorted pylint fixes
2019-02-15 06:54:47 -08:00
Matt Clay
0a461380a3
Fix incorrect use of `is` for comparisons.
...
See https://bugs.python.org/issue34850 for details.
2019-02-12 16:33:13 -08:00
Nilashish Chakraborty
92b0cd8e0e
Add more return values to *_config modules ( #50702 )
...
* Add more return values to *_config modules
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Add more rv
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Exclude from cli_config docs for now
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Add new rv docs for junos_config
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Fix CI errors
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Support date time for configurable backup path
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Change logic based on configurable path
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Remove unwanted import
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Fix docs
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Add filename rv
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Change dosc filename rv
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Make new rv code more readable
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-01-28 20:49:56 +05:30
Ganesh Nalawade
70bf9b9919
Add backup filename and dir path option for config network modules ( #50801 )
...
* Add configurable backup path option for network config modules
Fixes #50283
Fixes #32724
* Add back_options in network config module argspec
* Handle backup path options in network action plugin
* Fix review comments
* Add integration tests
* Update changelog
2019-01-24 09:36:16 +05:30
Nathaniel Case
9702893729
Remove deprecated options from modules ( #50246 )
...
* Remove deprecated options from modules
* Update tests
* Add porting guide notes
2019-01-22 09:18:26 -05:00
Tetsuya Sodo
1d4dbd76c0
fix eos_l2_interface insufficient commands ( #50754 )
2019-01-10 15:05:07 +05:30
Steve C
1793cad07b
fix ip address tokenization bug in eos_static_route module ( #43151 )
2019-01-08 09:11:43 -05:00
Trishna Guha
1400d161c0
fix eos_l2_interface invalid command ( #50644 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-01-08 17:27:20 +05:30
Dag Wieers
05c6ff79f9
Convert to reduced list of known types ( #50010 )
2018-12-19 07:25:30 +10:00
Abhijeet Kasurde
bc3e7bbeba
E325 Removal - Part II ( #49196 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-28 13:55:52 +05:30
José R Cordones
d3cc2f803a
Update eos_config.py ( #45810 )
...
Switches will accept the previously used syntax for /32 ACL entries, but they get changed to host ipaddress in the config file.
This results in the config check failing every time (permit ip 1.1.1.1/32 any log != permit ip host 1.1.1.1 any log), resulting in the ACL getting re-created on every single run of the Playbook.
Making this proposed change to the example will make it work in an idempotent manner.
+label: docsite_pr
2018-10-10 16:47:11 -04:00
Sandra McCann
27132cd0b8
added jinja2 example ( #46445 )
...
* added jinja2 example
2018-10-08 13:50:45 -05:00
cordones
742d702b96
incorrect sample eos_config usage ( #45750 )
...
no such option "config" for diff_against argument.
Further below, there is an example of eos_config using diff_against with a valid option.
+label: docsite_pr
2018-09-19 19:50:33 +05:30
Nathaniel Case
780dc9c561
There are other instances of transform being used... update them as well ( #45663 )
2018-09-17 08:42:20 -04:00
Nathaniel Case
285b927889
network command modules cleanup ( #45242 )
...
* Standardize _command modules
* Centralize command transformation process
* Fix check mode error test
2018-09-13 08:55:35 -04:00
Joren Vrancken
b954917761
Surround top-level function and class definitions with two blank lines.
2018-07-31 12:06:56 -07:00
Ganesh Nalawade
21dcaa4349
Handle ConnectionError exception in network modules ( #43353 )
...
* Handle ConnectionError exception in network modules
* Catch ConnectionError expection and fail module in case
expection is raised.
* Fix CI failure
2018-07-30 10:24:58 +05:30
Ganesh Nalawade
af3f510316
nxos cliconf plugin refactor ( #43203 )
...
* nxos cliconf plugin refactor
Fixes #39056
* Refactor nxos cliconf plugin as per new api definition
* Minor changes in ios, eos, vyos cliconf plugin
* Change nxos httpapi plugin edit_config method to be in sync with
nxos cliconf edit_config
* Fix CI failure
* Fix unit test failure and review comment
2018-07-27 11:05:40 +05:30
Nathaniel Case
8a0967554f
Actually fix eos_facts feature detection ( #43155 )
2018-07-23 14:51:44 -04:00
Ganesh Nalawade
c068b88b38
Update eos, ios, vyos cliconf plugin ( #42300 )
...
* Update eos cliconf plugin methods
* Refactor eos cliconf plugin
* Changes in eos module_utils as per cliconf plugin refactor
* Fix unit test and sanity failures
* Fix review comment
2018-07-04 19:45:21 +05:30
Dave Thelen
51092c6ea5
Update eos_l2_interface.py ( #42270 )
2018-07-04 10:17:46 +05:30
Dave Thelen
fa2366079a
Update eos_vlan.py ( #41852 )
...
changing show command to work for both transport methods
2018-06-28 13:19:43 +05:30
Sumit Jaiswal
c989b62eef
To fix eos_vrf failure when transport method is eapi ( #41470 )
...
* resolve bug 40930
* resolve bug 40930
* to fix review comments
* to fix review comments
* reverting the changes based on review
2018-06-20 21:32:54 +05:30
Trishna Guha
8ab0d654f3
don't retrieve config in running_config when config is provided for diff ( #41400 )
...
* don't retrieve config in running_config when config is provided for diff
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix for eos, nxos
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* add integration test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-06-14 18:02:19 +05:30
Jackson Isaac
3d6312885f
eos/eos_l3_interface.py: Add SVI Example ( #40349 )
2018-06-05 08:26:33 -05:00
Nathaniel Case
82dfa542c2
Replace bogus (but routeable) ip addresses with RFC 5737 example addresses ( #40554 )
...
* Remove 1.1.1.1 from *_config tests
* remove from *_smoke and *_system
* Miscellaneous other tests
* Remove from module documentation as well
* Remove from unit tests as well
* Remove accidental duplication from rebase
2018-05-30 13:03:20 -04:00
Nilashish Chakraborty
b9ea646839
Fixes eos_logging idempotence issue #31862 ( #40604 )
...
* eos_logging idempotence fix
* fixed eos_logging idempotence issue
* Fixed pylint and pep8 errors
* Added tests for eos_logging & minor fix
* Removed q statements
2018-05-30 18:21:54 +05:30
Nathaniel Case
0ad4b7b785
Fixes to httpapi for EAPI ( #40675 )
...
* Replace errant uses of str
* Hook up become to eapi
* Hook become up to nxapi, too
2018-05-24 14:25:19 -04:00
Nathaniel Case
e9d7fa0418
HTTP(S) API connection plugin ( #39224 )
...
* HTTPAPI connection
* Punt run_commands to cliconf or httpapi
* Fake enable_mode on eapi
* Pull changes to nxos
* Move load_config to edit_config for future-preparedness
* Don't fail on lldp disabled
* Re-enable check_rc on nxos' run_commands
* Reorganize nxos httpapi plugin for compatibility
* draft docs for connection: httpapi
* restores docs for connection:local for eapi
* Add _remote_is_local to httpapi
2018-05-17 18:47:15 -04:00
Ganesh Nalawade
afdc2364f2
Fix eos_vlan associated interface check ( #39661 )
...
* Fix eos_vlan associated interface check
Fix eos_vlan associated interface check by comparing
the interface in want and have without converting the
interface name to lower
* Update eos_vlan docs
2018-05-03 17:07:30 +05:30
Alicia Cozine
0ebc0b9e5a
adds FAQ TOC entry, links & examples to modules ( #38706 )
...
* adds FAQ TOC entry, links & examples to modules
* moves link to Notes, corrects examples
2018-04-18 11:41:54 -07:00
Deepak Agrawal
6de49f084c
doc for _config backup argument ( #38650 )
2018-04-13 12:48:49 +05:30
Dag Wieers
cdd21e2170
Clean up module documentation ( #36909 )
...
* Clean up module documentation
This PR includes:
- Removal of `default: None` (and variations)
- Removal of `required: false`
- Fixing booleans and `type: bool` where required
* Fix remaining (new) validation issues
2018-03-15 22:15:24 +01:00
John R Barker
ebc71bcb16
Network modules to link to network guide ( #37033 )
...
* Network modules to link to network guide
* Make it clear what's deprecated
* enable -> become
* Detail when provider is still needed (eAPI/NX-API)
* Link to specific sections
* rx_rate & tx_rate to link to conditional docs
2018-03-06 12:01:07 +00:00
Ganesh Nalawade
ba3201cd2f
Fix eos integration test failures ( #37020 )
...
Fixes #36919
Fix other eos modules integration test failure in dci
2018-03-06 10:04:40 +05:30
Trishna Guha
ef7f3fcab6
eos_static_route fix ( #36903 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-03-02 08:50:27 +05:30
Ganesh Nalawade
5a6b893240
Decouple config and state check in vlan and vrf network modules ( #36386 )
...
* Decouple config and state check in {network_os }_vlan and { network_os }_vrf modules
Fixes #35567
Fixes #34754
`interfaces` option is used for configuration as well as operational state
check. If interface is configured to given vlan or vrf but if
operational state of interface is disabled it results in module failure.
Fix is to decouple same option usage for config and state.
With this fix `interfaces` is used as config option and a new
option named `associated_interfaces` will be used for intent check
for assigned interfaces.
* Fix CI failures
* Fix review comment
* Fixed integration test failure
2018-02-26 09:23:54 +05:30
Lindsay Hill
f207897f32
fixed conditional error message ( #36476 )
2018-02-21 11:44:18 +05:30
Jeremy Lee
99627ab99d
eos_vlan: Modified logic to allow for more than 6 interfaces to be assigned to … ( #35568 )
...
* Modified logic to allow for more than 6 interfaces to be assigned to a vlan
* arista output to json. removing logic for string size.
2018-02-19 11:22:41 +01:00
Ganesh Nalawade
cb52509775
Add eos_command doc with more examples ( #36245 )
...
* Add eos_command doc with more examples
* More examples using cli and eapi transport
* Example on how to handle json output
* Example on handling result output in wait_for
* Fix typo
2018-02-16 11:48:12 +05:30
Lindsay Hill
08eaf37ca8
Fixed Arista typo in docstring ( #36139 )
2018-02-14 13:23:06 +05:30
John R Barker
17c0d3eae0
Fix more docs vs argspec ( #36048 )
2018-02-12 17:42:25 +00:00
Ganesh Nalawade
6a223d5576
Fix vrf parsing in eos_vrf and eos_eapi module ( #35791 )
...
* Fix vrf parsing in eos_vrf and eos_eapi module
Fixes #30250
Fix logic to parse vrf when interface value in `show vrf`
command output spans on multiple lines
* Add idempotent test case
2018-02-12 12:33:22 +05:30
Tyler
15b0371eb2
Add examples and language to better showcase the 'parents' parameter in multiple network modules ( #34486 )
...
* Add additional language and examples for 'parents' parameter to clarify its usage.
2018-02-09 13:31:37 +00:00
James Mighion
663c410da4
Fixing eos_config save option. Was removed when deprecated. Fixing ot… ( #35628 )
...
* Fixing eos_config save option. Was removed when deprecated. Fixing other deprecation documentation. Adding unit tests.
* Fixing removed_in_version for force.
2018-02-08 11:54:17 +05:30
Abhijeet Kasurde
6bd0fbb63c
Remove deprecated get_exception API
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-05 23:39:56 -05:00
Trishna Guha
b30f3b9f4d
fix eos_config second-level indent idempotece ( #35588 )
...
* fix eos_config second-level indent idempotece
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* address ganeshrn's comment - update doc
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-05 18:39:47 +05:30