Commit Graph

24194 Commits (9b44109ba3091e6538dedfac2987cf31793e892d)

Author SHA1 Message Date
Dag Wieers a8b5d30a9e win_shortcut: Rewrite using AnsibleModule (#48384)
* win_shortcut: Rewrite using AnsibleModule

* Avoid using $args, fix issue

* Small review fixes, and use 'arguments' parameter

* Update doc with new alias version change
2018-11-13 06:20:09 +10:00
Dag Wieers 0ede11da3b win_product_facts: Implement review suggestions (#48573) 2018-11-13 05:44:57 +10:00
Sam Doran 886433bd5f
Catch and handle quickly shutdown connections in reboot plugin (#48389) 2018-11-12 11:30:46 -05:00
Martin Krizek 1465f70eb5 Add ansible_play_name magic var (#48562) 2018-11-12 11:18:49 -05:00
Nathaniel Case 1fff542623
Match config prompts that aren't maint-mode (#47678) 2018-11-12 11:18:06 -05:00
Ali 320d72f08f Updated documentation for the k8s module (#48474) 2018-11-12 11:09:55 -05:00
Tzur Eliyahu 616ba5d807 IBM storage: fix domain issue by adding more keywords to pyxcli avail… (#48345)
IBM storage: fix domain issue by adding more keywords to pyxcli available fields
2018-11-12 10:47:38 -05:00
jgkirschbaum ef33159434 Added short description and moved to rabbitmq subfolder (#48566) 2018-11-12 15:34:34 +00:00
James E. King III 2bc915f58a better handling of vmware-vm-shell timeout (#48100) 2018-11-12 08:41:46 -05:00
Dario Zanzico 89bcd3ff1e clarify port.mode paramter requiremets, fail if unmet (#47938)
* clarify port.mode paramter requiremets, fail if unmet

* changelog fragment

* shorten too long line

* remove unnecessary indentation

* test version on docker_version for better maintainability

* normalize imports

* changelog fragment: minor_changes -> bugfixes

* rollback e96a7e57dfefd566fa47cf465a759637affd4795

* typo

Co-Authored-By: dariko <dariko@users.noreply.github.com>
2018-11-12 11:36:02 +00:00
Felix Fontein 0206a46e1d docker_* modules: updating argument_spec (#48491)
* Updating argument_spec for docker_* modules.

* Adjust docker_network to work with new recursive argument_spec.

* Adjust device IO limits to recursive argument_spec.

* Improve test (test Ansible's cast from str to int).

* Adjust healthcheck options construction.

* Remove superfluous check.

* Make flake8 happy.

* Simplify comparison.
2018-11-12 11:33:42 +00:00
Felix Fontein feb60b947c Docker volume fix labels (#48536)
* Add integration test for labels (which fails).

* Changing labels from list to dict.

* Add changelog.
2018-11-12 11:24:07 +00:00
Steve Dodd e51964e7a6 Fix LLDP to use json (#48318) 2018-11-12 12:31:27 +05:30
Tim Rupp 92b2d01a8a
Workaround for problems parsing the timezone (#48549)
Device facts gets a time with a timezone back from the builddate.
Unfortunately, python cannot correctly parse timezones by default.
This hacks around the problem.
2018-11-11 18:22:09 -08:00
Dag Wieers ab8125f2a6 win_tempfile: Rewrite using AnsibleModule (#48386)
* win_tempfile: Rewrite using AnsibleModule

* Fix up error check

* Fix PSParameterizedProperty issue
2018-11-12 08:30:36 +10:00
Dag Wieers b312f7f7d7 win_defrag: Rewrite using AnsibleModule (#48381)
* win_defrag: Rewrite using AnsibleModule

* Fix delta return value
2018-11-12 08:10:47 +10:00
Tim Rupp 5e7a02d574
Remove f5-sdk from bigip_vcmp_guest (#48541) 2018-11-11 13:58:11 -08:00
Dag Wieers baaa142248 win_wakeonlan: Rewrite using AnsibleModule (#48380) 2018-11-12 07:06:55 +10:00
Dag Wieers 2dd56eb15c win_product_facts: Rewrite using AnsibleModule (#48382) 2018-11-12 07:03:15 +10:00
Dag Wieers d174ebc65e win_psexec: Rewrite using AnsibleModule (#48383) 2018-11-12 07:00:57 +10:00
Tim Rupp 62332155b5
Removes the f5-sdk from bigip_routedomain (#48543) 2018-11-11 11:29:21 -08:00
Tim Rupp 708c2b4b71
Removes the f5-sdk from bigip_selfip (#48544) 2018-11-11 11:14:56 -08:00
Tim Rupp 22c9da538e
Moving client variable out in bigiq modules (#48542)
This is being done to ensure that errors are not encountered if the
exception case is hit
2018-11-11 11:10:38 -08:00
Tim Rupp 452cf2b1a3
Adds the bigip_dns_resolver module (#48540) 2018-11-11 11:09:53 -08:00
Tim Rupp 232fcb9f34
Adds the bigip_profile_server_ssl module (#48532) 2018-11-11 10:57:26 -08:00
Tim Rupp 69d24cc7fc
Remove f5-sdk from bigip_profile_udp module (#48534) 2018-11-11 10:40:25 -08:00
Tim Rupp d89fa23412
Remove f5-sdk from bigip_profile_tcp module (#48533) 2018-11-11 10:40:02 -08:00
Tim Rupp b292f8338f
Corrects parameters to flatten correctly. (#48531)
Also fixes unit tests and adds other code patterns that other f5
modules use
2018-11-11 10:39:44 -08:00
Dmitry Gamanenko f415902d04 Fix Deploy VM from template with id==0. (#48421) 2018-11-11 10:57:57 -05:00
Tim Rupp 4e2891e38f
Adds bigip_profile_fastl4 module (#48527) 2018-11-10 22:16:26 -08:00
Tim Rupp 6134281d28
Remove f5-sdk from bigip_profile_oneconnect (#48530) 2018-11-10 22:13:16 -08:00
Tim Rupp 875d83df50
Fixes unit tests in bigip_profile_http_compression (#48529) 2018-11-10 22:12:53 -08:00
Tim Rupp 77afc32621
Adds new parameters to bigip_profile_http (#48528) 2018-11-10 22:12:19 -08:00
Tim Rupp f126db7f21
Remove f5-sdk from bigip_profile_client_ssl (#48525) 2018-11-10 21:59:56 -08:00
Tim Rupp 50fb2d7795
Remove f5-sdk from bigip_profile_dns (#48526) 2018-11-10 21:46:19 -08:00
Tim Rupp ed818edd5a
Remove f5-sdk from bigip_partition. Fix partition descriptions. (#48522) 2018-11-10 21:46:04 -08:00
Tim Rupp 0c3f168087
Remove f5-sdk from bigip_policy_rule (#48524) 2018-11-10 21:35:34 -08:00
Tim Rupp dbbc752d56
Removes the f5-sdk from bigip_policy (#48523) 2018-11-10 21:33:42 -08:00
Tim Rupp 4dc5a26293
Adds new params to bigip_node. Fix unit tests. (#48521) 2018-11-10 21:16:00 -08:00
Tim Rupp 1e57b91c35
Add new parameters to bigip monitor modules (#48520) 2018-11-10 20:34:48 -08:00
Tim Rupp 240d2baebd
Removes f5-sdk from bigip_management_route (#48519) 2018-11-10 20:34:15 -08:00
Tim Rupp 73ec37b6b6
Remove f5-sdk from bigip_log_destination (#48517) 2018-11-10 20:10:07 -08:00
Tim Rupp 94d04b7da4
Remove the f5-sdk from bigip_irule (#48516) 2018-11-10 20:09:05 -08:00
Tim Rupp 25344da0ad
Remove f5-sdk from bigip_log_publisher (#48518) 2018-11-10 19:54:59 -08:00
Tim Rupp 946e093a14
Move client variable out to prevent variable declaration errors (#48515) 2018-11-10 19:46:43 -08:00
Tim Rupp 365ecbd7ad
Adds parameters to ike_peer module (#48514) 2018-11-10 19:30:47 -08:00
Tim Rupp a260e86729
Remove f5-sdk from bigip_iapp_service module (#48511) 2018-11-10 19:23:44 -08:00
Tim Rupp 1a226a86b5
Remove f5-sdk from bigip_iapplx_package (#48513) 2018-11-10 19:14:49 -08:00
Tim Rupp 4579b6516f
Remove f5-sdk from bigip_iapp_template (#48512) 2018-11-10 19:12:35 -08:00
Tim Rupp 8dabd0cde3
Remove f5-sdk from bigip_gtm_virtual_server (#48508) 2018-11-10 18:49:46 -08:00
Tim Rupp ce06cfe8ef
Remove f5-sdk from bigip_gtm_wide_ip (#48509) 2018-11-10 18:48:52 -08:00
Tim Rupp 4a74c1fec6
Add new features to gtm server module (#48507)
Remove the f5-sdk. Fix unit tests. Add new prober parameters
2018-11-10 18:34:48 -08:00
Tim Rupp 364ed4e660
Remove f5-sdk from bigip_hostname (#48510) 2018-11-10 18:23:10 -08:00
Tim Rupp bfd8dc56ea
Remove the f5-sdk from bigip_gtm_pool_member (#48506) 2018-11-10 18:22:55 -08:00
Tim Rupp 830f1880b7
Remove f5-sdk from bigip_gtm_pool (#48505) 2018-11-10 18:03:39 -08:00
Tim Rupp 98a15013dc
Remove f5-sdk from bigip_gtm_monitor_tcp_half_open (#48504) 2018-11-10 18:03:26 -08:00
Tim Rupp 8a57ae1702
Remove f5-sdk from bigip_gtm_monitor_tcp (#48503) 2018-11-10 18:03:14 -08:00
Tim Rupp 530a21dfc0
Remove the f5-sdk from bigip_gtm_monitor_https (#48502) 2018-11-10 17:39:30 -08:00
Tim Rupp 0f2ea94c00
Remove f5-sdk from bigip_gtm_monitor_firepass (#48499) 2018-11-10 15:32:07 -08:00
Tim Rupp ce1c88a7b8
Remove the f5-sdk from bigip_gtm_monitor_http (#48500) 2018-11-10 15:26:33 -08:00
Tim Rupp 75661cc5f6
Removes the f5-sdk from bigip_gtm_monitor_external (#48498) 2018-11-10 15:08:47 -08:00
Tim Rupp 7664d1d91c
Removes the f5-sdk from bigip_gtm_monitor_bigip (#48497) 2018-11-10 15:03:03 -08:00
Tim Rupp 7ce3d7c8ef
Removes the f5-sdk from bigip_gtm_global (#48496) 2018-11-10 14:53:54 -08:00
Tim Rupp 3186f2b576
Removes the f5-sdk from bigip_gtm_datacenter (#48495) 2018-11-10 14:53:41 -08:00
Thomas O'Donnell 0db06b940a Add SSL support to postgresql_schema module (#44482)
Have added some extra arguments to the postgresql_schema module to allow
configuring an SSL connection to the postgresql server. The arguments
and method used here for the connection are the same as used by the
postgresql_database module.
2018-11-10 14:52:31 -08:00
Tim Rupp 3132ce8404
Fixes unit tests and move client variable (#48494) 2018-11-10 14:42:01 -08:00
Tim Rupp 7d11e6e3e5
Adds token cleanup and fixes unit tests (#48493) 2018-11-10 14:40:14 -08:00
Tim Rupp 1afbe4d61b
Remove the f5-sdk from bigip_firewall_port_list module (#48492) 2018-11-10 14:39:26 -08:00
Tim Rupp fd0f3ad648
Fixes unit tests for bigip_firewall_policy module (#48490) 2018-11-10 14:39:10 -08:00
Tim Rupp 112ce6da89
Adds bigip_firewall_dos_vector module (#48487)
This module can be used to manage DoS vectors in a DoS profile or
device config
2018-11-10 14:08:31 -08:00
Tim Rupp d1288f9ea1
Adds bigip_dns_zone module (#48482)
This module can be used to manage zones on a BIG-IP. The managed
zones should **not** be confused with ZoneRunner zones as they are
not the same.
2018-11-10 13:14:57 -08:00
Tim Rupp 9a396cc45d
Fixes unit tests broken in ansible 2.8 and minor module cleanup (#48484) 2018-11-10 13:06:07 -08:00
Tim Rupp 1378e9fca2
Removes the f5-sdk from bigip_firewall_address_list module (#48483) 2018-11-10 12:58:12 -08:00
Tim Rupp b5ee96a576
Adds bigip_dns_nameserver module (#48480)
This module can be used to manage DNS nameservers (usually used for
DNS express) functionality on a BIG-IP.
2018-11-10 12:56:48 -08:00
Tim Rupp 0c14b75eec
Remove f5-sdk from bigip_device_trust (#48479) 2018-11-10 12:07:49 -08:00
Tim Rupp 1c7e6d354c
Remove f5-sdk from bigip_device_sshd (#48478) 2018-11-10 12:07:03 -08:00
Tim Rupp 90857004c9
Remove f5-sdk from bigip_device_ntp (#48477) 2018-11-10 12:06:46 -08:00
Tim Rupp ccb6349e70
Removes f5-sdk from bigip_device_license (#48476) 2018-11-10 12:06:32 -08:00
Tim Rupp 0873043e5a
Fixes ssl cipher ordering in bigip_device_httpd. Also fix unit tests (#48475) 2018-11-10 11:40:18 -08:00
Simon Dodsley d508d5820a Update Pure Storage FlashArray volume module (#45225) 2018-11-10 04:08:28 -05:00
Tim Rupp fccbbf3405
Removes f5-sdk from bigip_device_group_member (#48464) 2018-11-09 22:35:34 -08:00
Tim Rupp 70cdf477e4
Remove f5-sdk from bigip_device_group (#48463) 2018-11-09 22:17:49 -08:00
Tim Rupp 03ccf50466
Remove f5-sdk from bigip_device_dns (#48461) 2018-11-09 22:13:01 -08:00
Tim Rupp a1a899353c
Remove f5-sdk from bigip_device_facts and add more facts (#48462) 2018-11-09 22:12:47 -08:00
Tim Rupp de066ceef8
Removes f5-sdk from bigip_device_connectivity (#48460) 2018-11-09 21:59:21 -08:00
Tim Rupp c161ffef81
Fixes unit tests for bigip_device_auth that were broken in 2.8 (#48459) 2018-11-09 21:56:26 -08:00
Tim Rupp 68084d989c
Removes f5-sdk from bigip_data_group (#48458) 2018-11-09 21:52:46 -08:00
Tim Rupp effa22245e
Remove the f5-sdk from bigip_configsync_action (#48457) 2018-11-09 21:38:01 -08:00
Tim Rupp e6fad87e20
Removes the f5-sdk from bigip_config (#48456) 2018-11-09 21:37:48 -08:00
Tim Rupp ec2933e20b
Removes the f5-sdk from bigip_command (#48455) 2018-11-09 21:24:21 -08:00
Tim Rupp d97abff0ad
Fixes unit tests that were broken in ansible 2.8 (#48454) 2018-11-09 21:00:03 -08:00
Tim Rupp 5196188b97
Minor fixes to bigip_cli_alias (#48452) 2018-11-09 20:39:50 -08:00
Tim Rupp 70cf5acf13
Remove f5-sdk from bigip_asm_policy (#48451) 2018-11-09 20:11:46 -08:00
Tim Rupp 77d14b36b0
Remove the f5-sdk from as3 module (#48449) 2018-11-09 19:40:27 -08:00
Tim Rupp 3a2ab5959d
Fixes rebase errors from existing PR. (#48450) 2018-11-09 19:15:25 -08:00
Tim Rupp f4c2587d47
Adds new parameters to bigip_pool_member (#48448) 2018-11-09 16:48:08 -08:00
Jiri Tyr e4cadddd70 Support .yaml extension for meta file (#46505) 2018-11-09 17:29:06 -05:00
Eric Matysek 880762e07e Fix consistency issue in grafana_dashboard module. (#47459)
* Move check for 'dashboard' key to before the create/update if statement.
* Add changelog fragment for PR #47459
2018-11-09 17:27:11 -05:00
Ken Partridge 301defd915 cpm_user concat string changes (#45044)
* Add WTI OOB and PDU Device status, control and configuration module

* removed accidental file inclusions

* removed accidental file

* remove unneeded legacy files

* Changed str() to to_native()
Changed + string concat to %

* added to_native() to the remainder of strings being read externally
2018-11-09 17:22:22 -05:00
Jason Walsh 96cdc9ec06 Add release argument for redhat_subscription (#47888) 2018-11-09 17:19:06 -05:00
Tim Rupp 55f5a707fe
Removes f5-sdk from bigip_pool (#48431)
Additionally fixes forwarding, small bugs, and adds small enhancements
2018-11-09 12:31:07 -08:00
Tim Rupp 46fa68ac27
Updates to the f5 module utils (#48428)
Updating module utils to align with functionality in modules
2018-11-09 11:06:18 -08:00
David Soper 9757d9d4c3 support for iscsi vnics based on customer feature request (#48377)
* support for iscsi vnics based on customer feature request
integration tests added for iscsi vnics and vnic state absent

* correct version_added for iscsi and vnic lists
2018-11-09 16:26:23 +00:00
Brian Coca b047591dee fix tagged implicit gathering (#48294)
* fix tagged implicit gathering

 - None is not tHe default anymore, its an empty list

* Update changelogs/fragments/fix_taggged_gather.yml

Co-Authored-By: bcoca <bcoca@users.noreply.github.com>
2018-11-09 13:41:07 +00:00
Andrea Tartaglia b7d9feb7dc ec2_instance: ebs_optimized is not sub-option of 'network' (#48341)
* ebs_optimized is not suboption of 'network'

* Add Shaps as ec2_instance maintainer

* Added workaround-backward compatible check for ebs_optimized

* Added ebs_optimized test

* CI fixes, dynamic select of ENA-enabled AMI
2018-11-09 12:11:51 +00:00
FragmentedPacket 3147dc2a15 Netbox_device.py module (#46936)
* netbox_device module

* Add init.py to each directory

* Fixed a few of the shippable failed tests

* No need for import pynetbox in netbox_utils-removed, changed syntax for set

* A bit more cleanup

* Fixed the 'data' to have suboptions

* Fixed formatting for device_role

* Attempting to fix shippable errors

* Final testing and updated documentation

* Fixed return type and removed testing result files

* Updated some returns to be a list to keep 'meta' formatting consistent

* Updated module to standardize the meta return type

* Updated short_description and added David Gomez as author

* Updated short_description, added David Gomez as author, added module direcotry to BOTMETA.yml

* Updated data type to dict and removed JSON from netbox_utils
2018-11-09 07:24:13 +00:00
Martin Krizek a80c25cbd9
Do not use str() on exceptions (#46950) 2018-11-09 07:59:30 +01:00
Clément GIBAUD 2436aa1a4e vultr_server_facts: fix gather facts fails when firewall is enabled on a VM (#48342) 2018-11-09 07:48:08 +01:00
Matt Clay 8c2ccb8b31 Remove unused net_config action plugin. 2018-11-08 22:20:02 -08:00
mklassen 2fce8010b4 Added support for FUNCTION and PROCEDURE privileges to mysql_user (#23223) 2018-11-08 21:56:30 -08:00
Tim Rupp 7290bc23b8
Removes the f5-sdk from bigip_provision (#48397) 2018-11-08 21:46:56 -08:00
Tim Rupp 38806e8507
Fixes for bigip_qkview (#48396)
Fixes unit tests for ansible 2.8 and adds more error handling
for qkview generation
2018-11-08 21:08:27 -08:00
Zim Kalinowski f04139bfa3
Fixing issues with azure_rm_virtualmachine crashing (#45269)
* vm fixes
2018-11-09 11:44:51 +08:00
Christopher Gadd f75a84e382 make password locking in user module idempotent (#43671)
* Simplify logic and add FreeBSD & NetBSD

* Remove incorrect flag for lock and unlock on FreeBSD

* Add tests and changelog


Co-authored-by: Chris Gadd <gaddman@email.com>
2018-11-08 21:29:38 -05:00
Simon Dodsley d7975462da Update and correct iSCSI facts collection (#44644)
Co-authored-by: Simon Dodsley <simon@purestorage.com>
2018-11-08 21:24:51 -05:00
Matt Martz b908a348a6 Remove TOML warning on emit (#48385) 2018-11-09 12:07:42 +10:00
Strahinja Kustudic b89b688d52 Fix pip idempotence in check mode
PIP package names must be case insensitive, and must consider hyphens
and underscores to be equivalent
(https://www.python.org/dev/peps/pep-0426/#name), because of this the
module didn't work correctly in check mode. For example if the passed
package name had a different case or an underscore instead of a hyphen
(or the other way around) compared to the installed package, check mode
reported as changed, even though packages were installed. Now the module
ignores case and hyphens/underscores in package names, so check mode
works correctly.
2018-11-08 17:09:34 -08:00
James Cassell c13fa503a1 os_server_facts: support all_projects (#44800)
* os_server_facts: support all_projects

* os_server_facts: openstacksdk expects True or False, not None
2018-11-08 17:05:12 -05:00
David Soper dda753dc05 ucs_service_profile_template and integration tests (#48277) 2018-11-08 18:42:20 +00:00
Matt Clay 92dccb68ec Remove unused ops_config action plugin. 2018-11-08 10:12:21 -08:00
Jack Haden-Enneking 15e77ebfe8 ipaddr filter - return a network address when given an address with /32 subnet (#47539)
* fix #17872

* add changelog fragment and enable unit test
2018-11-08 11:49:42 -05:00
Jimmy McCrory d2969884b4 Add run_once as a valid TaskInclude keyword (#48068)
* Add run_once as a valid TaskInclude keyword

* Add changelog fragment

* Add integration test that documents run_once behavior
2018-11-08 10:29:24 -05:00
Ondra Machacek 7034d8c47a Add next_run parameter to ovirt_vms_facts (#48347)
Signed-off-by: Ondra Machacek <omachace@redhat.com>
2018-11-08 10:17:37 -05:00
Paul Neumann 3cc1b8d7d3 ios_facts: Strip header from running-config (#48047)
IOS prepends a show running-config with lines that are not part of the
configuration, keeping the output from being an entirely valid configuration:
R1#show run
Building configuration...

Current configuration : 2045 bytes
...

In order to be able to use the config from ios_facts as-is, strip this
header.
2018-11-08 20:28:47 +05:30
Stefan Siegel ae7b9ea8cd Always use /proc/sys/kernel/random/boot_id to confirm reboot on Linux (#47017)
* Always use /proc/sys/kernel/random/boot_id to confirm reboot on Linux

/proc/sys/kernel/random/boot_id is available since kernel 2.3.16 and
should be safe to rely on.

The previously used method by checking the system boot time using who -b
turned out to be unreliable: Some systems lacking an RTC report the Unix
epoch as boot time, but the code trying to detect that did't always
work.

Closes #46562

* Change DEFAULT_BOOT_TIME_COMMAND

- change to usinsg /proc by default
- add BOOT_TIME_COMMANDS for BSD, Solaris, and macOS
2018-11-08 09:54:58 -05:00
Nijin Ashok 42c6ed7078 ovirt_vm: Add option to apply the configuration change on "Next Run" (#48286)
The PR adds new option "next_run" so that user can decide if the
configuration has to be applied on the VM immediately or it has
to be configured on next restart.
2018-11-08 07:15:45 -05:00
John McDonough 9c83640d75 Add module for UCS Org (#46785)
* Add module for UCS DNS Server
2018-11-08 10:50:46 +00:00
John McDonough 7609fe8b09 Add UCS DNS Server management module (#46789)
* Add module for UCS DNS Server
2018-11-08 10:49:24 +00:00
Trishna Guha 27075ab7dd
do not override lldp neighbors nxos_facts (#48087)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-11-08 10:45:25 +05:30
Daniel Balko 58ae93d273 aix_facts: statvfs works on AIX too so make use of it (#46759) 2018-11-07 18:21:26 -05:00
Sam Doran 1e3b704ff1
Prevent duplicate entries in rhsm_repository module (#48107)
* Complie regular expressions for better performance

* Skip on empty lines

This fixes a bug where the previous repo would be inserted in the result twice since an empty line did not match any of the conditions that would exit the loop iteration.
2018-11-07 17:49:12 -05:00
Martin Krizek 41dfc5162f user: fix removing the expiry time when it's 0 (#47115)
* user: fix removing the expiry time when it's 0

* Improve tests and add changelog

Co-authored-by: Martin Krizek <martin.krizek@gmail.com>
2018-11-07 16:44:34 -05:00
Tzur Eliyahu adce695aba IBM_Storage: docs and author changes as requested by Ansible team (#48158) 2018-11-07 14:52:19 -06:00
Matt Martz f728f2bff0
Add a new "contains" jinja2 test (#45798)
* Add contains jinja2 test

* backticks
2018-11-07 14:49:00 -06:00
Martin Krizek 421d67f1ee
conditional: fix direct boolean "shortcut" (#47941)
* conditional: fix direct boolean "shortcut"

* Add unit tests
2018-11-07 21:33:54 +01:00
James E. King III 3a4ee965f5 Improve debug logging of filetree with path being walked and items found (#47884) 2018-11-07 21:32:23 +01:00
Brian Coca 8ccb44aa63 clarify insane ini typing (#48169)
* clarify how variables are interpreted in the ini inventory plugin
2018-11-07 14:19:23 -06:00
Matt Martz 0d068f1e3a
Support list of dicts with omit. Fixes #45907 (#45923) 2018-11-07 13:41:22 -06:00
Brian Coca 903cfa63cb
make inventory warnings a bit smarter (#46284)
less annoying for common cases
 add comment for 'tricky' conditional
2018-11-07 11:09:32 -05:00
Brian Coca 4961f003e5
a more in depth doc on cacheable option (#47878)
* a more indepth doc on cacheable option
2018-11-07 11:06:00 -05:00
AndyG 20e1a33959 Update yum.py (#47749)
add explanation why you must use "shell: yum clean all" and why it won't be included in the yum module as per https://github.com/ansible/ansible/pull/31450#issuecomment-352889579
2018-11-07 09:27:31 -06:00
njohnston ff37e5364c Typo and style fixes in docs and messages for svc module (#48298)
Minor typo and style fixes in documentation.

Fixed two error messages which incorrectly used "Could" instead of "Could
*not*".
2018-11-07 10:24:59 -05:00
Raphael Meudec c062f37984 Bug 42787 create volume with label (#46527)
* add None value to docker-version so it can be mocked in tests
2018-11-07 13:31:12 +00:00
Hugh Ma a858089eb2 Add survey_spec parameter to module. (#48182)
* Add survey_spec parameter to module.
Fixes #48011

* Removed trailing white space. Added integration test.
2018-11-07 13:09:40 +01:00
Nicolas Bock 3fa48dfb6f Update os_image.py (#47222)
The description of the `name` and `id` options are updated to highlight the fact that the `name` (which is required and leads to failures if several images exist with the same name) argument can also contain the image `id`.

+label: docsite_pr
2018-11-07 06:18:57 -05:00
Michael Cassaniti a2f3f16930 win_updates: Add post search category matching to support product matching (#45708)
* win_update: Add post search category matching to support product matching

* win_updates: Return categories of each update

* win_updates: Documentation fix-up

* win_updates: Adjusted documentation to reflect regex vs sub-string match of post-cat strings

* win_updates: Sped up post-category checking

* win_updates: Updated documentation to suggest querying post-category strings

* win_updates: Simplified saving and checking post-categories

* fixed some issues and added filtered categories to return value

* win_updates: Moved all category matching to occur after initial search

* win_updates: Adjustments to satisfy PowerShell lint checks

* win_updates: Dropped category validation from action plugin

* win_updates: Documentation updates

* win_updates: Fixed plugin unit tests
2018-11-07 19:32:07 +10:00
Milan Ilic 8245441b2e Minor fix in one_vm documentation (#48288) 2018-11-07 03:17:15 -05:00
Theo Ouzhinski b79e46ec6f virt: Fix return type of list_vms (#48160) 2018-11-07 08:37:37 +01:00
Jordan Borean 501acae5ab
Added basic equivalent to PowerShell modules (#44705)
* Added basic equivalent to PowerShell modules

* changes based on latest review

* Added tests

* ignore sanity test due to how tests are set up

* Changes to work with PSCore

* Added documentation and change updated more modules

* Add some speed optimisations to AddType

* fix some issues in the doc changes

* doc changes
2018-11-07 10:53:17 +10:00
Kevin Breit 74619c2036 meraki_vlan - Add note explaining VLAN support tests in a Meraki network (#48278)
* Add note explaining VLAN support tests in a Meraki network

* Small fix.
2018-11-07 01:06:24 +01:00
Adam Miller 091fb1dc3f yum also parse obsolete package output (#45365)
* yum also parse obsolete package output

This is a rebase of the patch originally proposed in
https://github.com/ansible/ansible/pull/40001 by machacekondra

Fixes #39978

Signed-off-by: Adam Miller <admiller@redhat.com>

* properly parse the obsoletes, provide a new output entry, add changelog

Signed-off-by: Adam Miller <admiller@redhat.com>

* make pep8 happy

Signed-off-by: Adam Miller <admiller@redhat.com>

* remove q debugging output

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-11-06 16:07:50 -05:00
Sloane Hertel e1aa05bf9a
[AWS] Allow the profile to take precedence to allow better compatibility between ~/.boto and ~/.aws/credential files (#45806) 2018-11-06 14:30:54 -05:00
Brian Coca 4ec2423a04
make fact gathering obey play tags (#44717)
fixes #44251
2018-11-06 13:19:44 -05:00
Chen Zhiwei 329d3b892b if we already have stderr, we don't need stderr_lines (#44675) 2018-11-06 12:36:42 -05:00
Andrew Herrington 43bbc505a1 Add threading to slack notification module (#47333)
* Add threading to slack notification module

* Fix sanity check

* Change thread_ts to thread_id
2018-11-06 12:04:07 -05:00
Matt Martz 9949629e5a
Add toml inventory plugin (#41593)
* First pass at a toml inventory

* Make EXAMPLES yaml

* Remove unnecessary comment

* Small formatting changes

* Add ansible-inventory option to list as TOML

* TOML inventory improvements, to allow a more simple inventory, specifically related to children

* changelog

* Simplify logic

* Dedupe _expand_hostpattern, making it available to all inventory plugins

* Don't make the TOML inventory dependent on the YAML inventory

* Quote IP address values

* Add more TOML examples

* Further cleanups

* Enable the toml inventory to run by default

* Create toml specific dumper

* 2.8

* Clean up imports

* No toml pygments lexer

* Don't raise an exception early when toml isn't present, and move toml to the end, since it requires an external dep

* Require toml>=0.10.0

* Further clean up of empty data

* Don't require toml>=0.10.0, but prefer it, add code for fallback in older versions

* Ensure we actually pass an encoder to toml.dumps

* Simplify recursive data converter

* Appease tests, since we haven't limited controller testing to 2.7+

* Update docstring for convert_yaml_objects_to_native

* remove outdated catching of AttributeError

* We don't need to catch ImportError when import ansible.plugins.inventory.toml

* Add note about what self.dump_funcs.update is doing

* Address some things

* A little extra comment

* Fix toml availability check

* Don't create an intermediate list

* Require toml file extension

* Add metadata

* Remove TOML docs from intro_inventory to prevent people from getting the wrong idea

* It's in defaults, remove note

* core supported, indicate very clearly that this is preview status
2018-11-06 10:02:36 -06:00
Martin Nečas 1441c6ad3f add old usages to network cluster (#47185)
* add old usages to network cluster

* set default value to old usages

* rename cluster_network_service to cluster_network_entity
2018-11-06 10:36:27 -05:00
Felix Fontein 602d02be5f Add docker_container_facts module. (#48062) 2018-11-06 15:08:28 +00:00
Konstantin Shalygin 8c9070ec05 mail: fixed STARTTLS module working with python 3.7.0 (#47412) 2018-11-06 09:54:51 -05:00
Dave Bendit d7686e1bc0 [docker_network] Add handling for Python booleans in driver_options (#48105)
Fixes #26708
2018-11-06 14:39:45 +00:00
Martin Nečas 0d9c923464 ovirt require storage_domain if state is registred (#47423) 2018-11-06 08:48:45 -05:00
Mariusz Mazur a5c8e952e8 k8s_facts: fix handling of unknown resource types (#47857) 2018-11-06 14:43:55 +01:00
Monty Taylor c5b303fa52 Test host in inventory by name in remove_host (#45639)
The host argument is a Host object, and is used as such by
group.remove_host. However, self.hosts is a dictionary of host name to
Host object. Thus, the existing code is checking to see if the Host
object is one of the keys.

Use host.name to interact with the keys of the dictionary.
2018-11-06 08:19:58 -05:00
Abhijeet Kasurde d4bb67cac0 ansible-doc: list types of plugin available (#47055)
This fix allows user to view types of plugin available in
ansible-doc command.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-06 13:18:59 +00:00
Lars b6b238ae43 facts: suse: fix SLES4SAP12 detection (#44388) 2018-11-06 08:12:38 -05:00
Andrea Tartaglia d5a4a401ea Added nonstring='passthru' when calling to_native to avoid passing a 'None' string to the ipa client (#48157) 2018-11-06 12:17:07 +00:00
Samy Coenen 1104387164 Added gitlab_runner module (#47727)
* Added gitlab_runner module
2018-11-06 12:09:17 +00:00
Deepak Agrawal d2c7665be9
cleanp net_put temp file (#48148) 2018-11-06 12:02:01 +05:30
Jordan Borean 8a9d7b3695
win_uri: stop output from mixing with module result (#48140) 2018-11-06 11:10:03 +10:00
Jordan Borean 8787c65b65
powershell: add ability to ignore specific warnings in C# Add-Type (#47643) 2018-11-06 10:48:31 +10:00
Toshio Kuratomi 1156014d9c Fix regression in synchronize when using ssh passwords
The change to add sshpass support for rsync broke synchronize when
a password was provided at all.  Have to convert an int into a string to
make it work.
2018-11-05 15:06:35 -08:00
Sam Doran 066af3b6ca
User module - allow bang and exclamation in password field without warning (#46498)
* Allow bang and exclamation without warning

Allow the password field to be ! or * without warning when using this feature to create accounts that are locked.

Add documentation  and tests to cover this.

* Use set() rather than braces for Python 2.6
2018-11-05 16:35:10 -05:00
Adam Miller 1c777976c5 Correct yum and dnf autoremove behavior (#47902)
* Correct yum and dnf autoremove behavior

Sanity check args passed to autoremove

Fixes #47184

Signed-off-by: Adam Miller <admiller@redhat.com>

* fix docs

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-11-05 16:00:42 -05:00
Yauhen Kirylau 14037443de fix(tasks: synchronize): wrap in sshpass if ssh password was provided (#30743)
* fix(tasks: synchronize): wrap in sshpass if ssh password was provided

Closes #16616

* fix(tasks: synchronize): pass rsync password to sshpass via fd

* fix(tasks: synchronize): use fail_json instead of AnsibleError

* fixup! fix(tasks: synchronize): use fail_json instead of AnsibleError

fix python2 handling

* feat(module_utils: basic: run_command): add optional arguments `pass_fds` and `before_communicate_callback`

* fix(tasks: synchronize): use module.run_command instead of subprocess.Popen

* fixup! fix(tasks: synchronize): use module.run_command instead of subprocess.Popen

remove unused import

* fixup! fixup! fix(tasks: synchronize): use module.run_command instead of subprocess.Popen

pass_fds only if they passed to run_command()
2018-11-05 15:00:34 -05:00
Dag Wieers e21270988c
aci_epg: parameter bd is not required (#47999) 2018-11-05 19:34:15 +01:00
Matt Martz cb5626cc09
Fix return statement where we short circuit _get_delegated_vars (#48102) 2018-11-05 12:28:34 -06:00
Dag Wieers df6b0b0e9e aci_aptiplp: Support missing policy_group (#48000)
* aci_aptiplp: Support missing policy_group

* Adapt integration tests to fix

* Add changelog fragment

* Fix

Co-Authored-By: dagwieers <dag@wieers.com>
2018-11-05 18:21:01 +00:00
Dag Wieers d1f6ff646a aci_iplpg: Support missing aep (#48001)
* aci_iplpg: Support missing aep
2018-11-05 18:20:23 +00:00
Dag Wieers 591b074e43
aci_switch_leaf_selector: Support missing policy_group (#47992)
* aci_switch_leaf_selector: Support empty policy_group

* Reorganize code

* Adapt integration tests to fix
2018-11-05 19:02:06 +01:00
Seebi ee13bc248b ldap_attr bugfix (#48009) 2018-11-05 17:20:37 +00:00
Gaël Lambert 0c95453a70 Doc: k8s_raw_module fixing typo K8S_AUTH_HOST -> K8S_AUTH_KEY_FILE (#46947)
The current doc of k8s_raw_module contain a copy paste of the env var name :

```
host   :
Provide a URL for accessing the API. Can also be specified via K8S_AUTH_HOST environment variable.
key_file  : Path to a key file used to authenticate with the API. Can also be specified via K8S_AUTH_HOST environment variable.
```
2018-11-05 12:13:57 -05:00
Matt Martz 45ff6df1af Remove Deprecated configs 2.8 (#46825)
* Removed deprecated ANSIBLE_HOSTS

* Bump sudo/su configs to match deprecation version for cli and playbook args

* Bump include configs to match deprecation version for 'include'
2018-11-05 12:08:13 -05:00
Felix Fontein 2728a22f73 Add docker_prune module (#48063)
* Add docker_prune module.

* Fix spelling error.
2018-11-05 17:05:26 +00:00
Miguel Angel Muñoz González c1385b6073 Initial commit for fortios_ips_sensor (#46081)
* Initial commit for fortios_ips_sensor
2018-11-05 16:59:30 +00:00
Simon Dodsley 26ad33bd8a New Pure Storage FlashArray module to enable/disable Remote Assist (#47592) 2018-11-05 16:58:04 +00:00
Chris Archibald 0cf88809ef Fix argument_spec for modules that are using the old version (#47693)
* Use correct argument spec
2018-11-05 16:56:59 +00:00
Chris Archibald 8f3e297d7d NetApp bugfix for na_ontap_snapmirror (#47621)
* Bug fixes for Snapmirror

* Bug fixes for Snapmirror
2018-11-05 16:53:29 +00:00
Matthias Fuchs 7e8d9081a7 Make the flatpak module work with Python 3.
Fixes #46994
Fixes #46995
2018-11-05 10:00:42 -05:00
e-taylor 90ea6c8d12 add support for the --be-name option (#43030)
* add support for the --be-name option
2018-11-05 09:27:38 -05:00
Miguel Angel Muñoz González 3e16eb1cb6 Initial commit for fortios_system_sdn_connector (#46105)
* Initial commit for fortios_system_sdn_connector

* Update fortios_system_sdn_connector.py

* Update fortios_system_sdn_connector.py

* Updated HTTPS handling
2018-11-05 13:23:46 +00:00
Miguel Angel Muñoz González 6e97e53b7f Initial commit for fortios_system_central_management (#46067)
* Initial commit for fortios_system_central_management

* Update Ansible version

* Update fortios_system_central_management.py

* Update fortios_system_central_management.py

* Updated HTTPS handling
2018-11-05 13:20:55 +00:00
Miguel Angel Muñoz González 197d329139 Initial commit for fortios_application_list (#46198)
* Initial commit for fortios_application_list

* Update key for deleting

* Update fortios_application_list.py

* Update fortios_application_list.py

* Updated HTTPS handling
2018-11-05 13:17:03 +00:00
Miguel Angel Muñoz González b614e1027e Initial commit for fortios_webfilter_content_header (#46393)
* Initial commit for fortios_webfilter_content_header

* Updated HTTPS handling
2018-11-05 13:16:35 +00:00
Miguel Angel Muñoz González 5be9658e22 Initial commit for fortios_webfilter_seach_engine (#46404) 2018-11-05 13:13:06 +00:00
Miguel Angel Muñoz González d2d5f22140 Initial commit for fortios_webfilter_fortiguard (#46394) 2018-11-05 13:12:39 +00:00
Miguel Angel Muñoz González 0d9639a444 Initial commit for fortios_firewall_address (#46406) 2018-11-05 13:06:42 +00:00
Miguel Angel Muñoz González 476212adad Initial commit for fortios_firewall_addrgrp (#46408) 2018-11-05 13:06:21 +00:00
Abigail Howe e8920a8357 fix boolean logic for overwrite parameter (#47916)
* fix boolean logic for overwrite parameter

* added changelog fragment
2018-11-05 12:59:01 +00:00
Abhijeet Kasurde 57c9532cad OpenStack: add an alias for name (#47972)
This fix adds an additional alias for name parameter viz. subnet

Fixes: #37352

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-05 12:56:30 +00:00
Jesse Pretorius 0fc99c3939 Fix lvg module idempotency (#47620)
* Fix lvg module idempotency

In [1] changes were made to ensure that the physical
devices were appropriately filtered, but the dev_list
which is used to prepare the filter is modified from
the original arguments to resolve any symlinks. This
results in the existing devices given in the module
args to be left out of the filter, resulting
in the module trying to add the same device again
every time the task is executed.

In this PR we change dev_list to be a copy of the
module arguments so that we're able to add the given
pv list from the module arguments into the filter
as well, ensuring that there is idempotence when
running the task again.

[1] https://github.com/ansible/ansible/pull/38446

* Add lvg module idempotence test

To ensure that the lvg module is tested for idempotency,
we add a basic integration test.

Support for MacOS and FreeBSD are skipped because the
module does not currently support those platforms.
2018-11-05 12:50:21 +00:00