Commit Graph

314 Commits (a14248ffe1ec7a7cf8623732ebc24e680883fa20)

Author SHA1 Message Date
Brian Coca 6b64fe8bdd Merge pull request #9936 from sysadmin75/9415_hostname_as_dir
Fixes #9415 - fetch: should use hostname instead of ip for directory name
2015-02-20 11:14:48 -05:00
Dan Rue 67eb9f301d Do not mark "skipped" when changed is false
When using the "creates" option with the script module, set changed
to False if the file already exists. This behavior is consistent with
other modules which use "creates", such as command and shell.
2015-02-17 15:14:21 -06:00
Dan Rue 787388ac30 Do not mark "skipped" when changed is false
When using the "creates" option with the unarchive module, set changed
to False if the file already exists. This behavior is consistent with
other modules which use "creates", such as command and shell.
2015-02-17 15:02:08 -06:00
Brian Coca 69b76a48b0 dest is not required as patchfile can have that info 2015-02-12 18:52:58 -05:00
Toshio Kuratomi 10df1b898c Fix template module broken when modifying symlinks
Needed to clear unwanted parameters from both args and complex args when
calling file module.

Fixes #10208
2015-02-11 00:10:37 -08:00
Brian Coca 476b0f6d99 support for patch module to have master as src 2015-02-09 16:34:49 -05:00
Toshio Kuratomi f1fdddb640 Do not send stat all the parameters that unarchive received
Fixes #546
2015-01-13 09:42:37 -08:00
Toshio Kuratomi edc27c5a5b Fix to_nice_json on python2.6 2015-01-12 10:45:18 -08:00
sysadmin75 aff20d911c Fixes #9415 - fetch: should use hostname instead of ip for directory name 2015-01-04 15:57:48 -05:00
Toshio Kuratomi d09b64884f Merge pull request #9810 from mscherer/fix_7732
Do not use the variable name as a key for the result of the module
2014-12-16 13:09:06 -08:00
Jon Hawkesworth e37b63386c Revised following comments from Chris Church.
Now uses sha1 checksums following merge of 9688.
Also I undid the changes I made to fetch.py
win_template.py now uses conn.shell.has_trailing_slash and
conn.shell.join_path
updated integration tests.
2014-12-16 04:47:01 +00:00
root bf916fb58a Adding first pass at win_copy, win_file and win_template modules. 2014-12-16 04:47:01 +00:00
Michael Scherer 9b8a55032d Do not use the variable name as a key for the result of the module
Using the variable name can interfere with various systems
used to communicate between modules and ansible ( as
reported in #7732 , where ansible_facts is a reserved key for
updating the fact cache, for example ).
2014-12-14 19:27:17 +01:00
Toshio Kuratomi 3a5aec9743 file does not exist is not an error when checksumming for the template modules 2014-12-08 13:08:26 -08:00
Toshio Kuratomi f2d2f425ae Fix comment 2014-12-08 13:07:34 -08:00
Toshio Kuratomi 2a288141d3 Fix template module to fail if remote checksumming failed 2014-12-08 10:55:04 -08:00
James Keener 4dfd86d847 Issue-9704 Better handling of missing python
When they python interpreter is set incorrectly for the machine the file
is being checked for (e.g. for the local or the remote), the error
manifests as a readability or directory missing error which can be very
misleading.
2014-12-03 17:15:00 -05:00
Brian Coca dd60036fb9 added changed status to return when new early create check is triggered,
added skipped check to test on create existing
2014-11-14 11:13:36 -05:00
Jon Hadfield 697582fdde Fix issue whereby file will be transferred before checking the creates argument. 2014-11-13 20:20:08 +00:00
Toshio Kuratomi d4d23b1b1f Add error when checksumming will fail because python is not present on the remote.
Comments for how the remote checksumming works.

Make the checksumming marginally more robust.
2014-11-11 20:05:27 -08:00
Toshio Kuratomi bc4272d2a2 Expand tilde remotely in action plugins 2014-11-11 12:28:19 -08:00
Toshio Kuratomi 30c50020a1 Better way to get the python_interpreter inventory variable 2014-11-10 09:16:20 -08:00
Toshio Kuratomi f1267c0b05 Move from md5 to sha1 to work on fips-140 enabled systems 2014-11-06 21:28:04 -08:00
James Cammarata b4f9631e4c Revert "remove complex_args_hack as it was only needed for Baby JSON"
This reverts commit a6029264b8.

Fixes #9400
2014-10-22 11:00:24 -05:00
James Cammarata 4c47c2273a Use convert_bare instead of string formatting for raw vars in debug action plugin 2014-10-22 11:00:24 -05:00
Toshio Kuratomi feb9ed1de8 Fix template module incorrectly handling mode when dest is a directory
Fixes #9350
2014-10-21 00:22:24 -04:00
Toshio Kuratomi a6029264b8 remove complex_args_hack as it was only needed for Baby JSON 2014-10-08 13:26:25 -04:00
James Cammarata 19703617b8 Fix action_plugins for modules not respecting check mode
Fixes #9140
2014-09-25 11:11:52 -05:00
James Cammarata 4e9c061b35 Also make sure the dest param is expanded locally before recalculating 2014-09-23 15:36:24 -05:00
James Cammarata e47f6137e5 Push the expanduser call on the source down to slurp rather than fetch
Also moves the calculation of the destination file name until after
the slurp of the file contents, since the source as returned by slurp
may now be different, so we want to use that expanded path locally.

Fixes #8942
2014-09-23 15:32:07 -05:00
James Cammarata b376e208c7 Adding "follow" param for file/copy options
Also modifies the template action plugin to use this new param
when executing the file/copy modules for templating so that links
are preserved correctly.

Fixes #8998
2014-09-16 12:05:55 -05:00
James Cammarata cdf938f2c2 Ensure remote files are chmod'd properly for su/su_user too
Fixes #8594
2014-09-15 13:15:46 -05:00
James Cammarata 0c4a7492bf Ensure checkmode is honored for templates that haven't changed
Fixes #8998
2014-09-15 11:37:53 -05:00
James Cammarata a571fd4efe Convert boolean strings from set_fact to proper boolean values
Also adds integration tests for booleanification of strings

Fixes #8629
2014-09-10 09:56:39 -05:00
Serge van Ginderachter 3c06833302 group_by: make sure new group has bigger priority than all group 2014-08-19 16:34:30 +02:00
James Cammarata 379e31883c Fix check mode issues with copy module
Fixes #8639
2014-08-18 16:02:45 -05:00
James Cammarata ee18c557ec Load group_vars for new groups loaded via add_host
Fixes #8605
2014-08-14 13:18:26 -05:00
Michael DeHaan 8c4161d4a1 Merge branch 'retf_py' of git://github.com/berendt/ansible into devel
Conflicts:
	lib/ansible/inventory/vars_plugins/group_vars.py
	plugins/callbacks/mail.py
2014-08-08 12:17:37 -04:00
James Cammarata a45c3b84f3 Avoid templating raw lookup strings 2014-08-06 13:25:14 -05:00
James Cammarata 9c1a89ff4e Merge branch 'patch-1' of https://github.com/debfx/ansible into debfx-patch-1 2014-07-31 11:41:21 -05:00
Michael DeHaan 645ab7baff Merge pull request #7950 from mesk41in/devel
Fix unsupported regexp parameter in assemble
2014-07-28 12:01:12 -04:00
someda 1b1d5d0d3d fix an issue that copying directory will fail when trying to change file attributes and the target file already exists on remote
- the issue was introduced by the commit 84759faa09
2014-07-24 14:03:36 +09:00
Benno Joy ac85d8444b fix for unarchive 8257 2014-07-23 14:50:16 +00:00
James Cammarata 84759faa09 Security fixes:
* Strip lookup calls out of inventory variables and clean unsafe data
  returned from lookup plugins (CVE-2014-4966)
* Make sure vars don't insert extra parameters into module args and prevent
  duplicate params from superseding previous params (CVE-2014-4967)
2014-07-21 11:20:49 -05:00
Serge van Ginderachter 4e9a253bef Load existing group_vars file for new group_by group
if it was not loaded yet, which happens if that group
didn't exist yet in the inventory.

fixes #8159
2014-07-16 21:16:27 +02:00
Felix Geyer 0ebd19e97b Fix regression: Sanitize sudo success_key from stdout
Commit 7e3dd10 caused a regression with sanitizing the sudo success_key from stdout.
There is no newline in front of SUDO-SUCCESS when using sudo.
This change adapts the regex to make the line break optional.

Tested on Ubuntu 14.04.
2014-07-16 18:14:35 +02:00
James Cammarata b8ac094eaa Tweak to only show msg on assert failure if set 2014-07-08 14:05:24 -05:00
James Cammarata 16332b8488 Merge branch 'assert-with-msg' of https://github.com/darkk/ansible into darkk-assert-with-msg 2014-07-08 13:56:08 -05:00
Leonid Evdokimov d94395f48c assert: add optional `msg` argument
Sample playbook when it may be useful:
```
- uri: return_content=yes url={{ api_base }}/action/{{ inventory_hostname }}
  register: output
- assert:
    msg: '{{ output.json | to_nice_json }}'
    that:
      - output.json.foo != "bar"
      - output.json.boo == 42
```
2014-07-07 19:05:17 +04:00
James Cammarata ff04b2b532 Allow empty yaml vars files
Fixes #7843
2014-07-04 23:10:32 -05:00