a-c-m
/
community.general
mirror of https://github.com/ansible-collections/community.general.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
44,158 Commits
12 Branches
186 Tags
286 MiB
Commit Graph

23 Commits (a387b8e2396c5b8373bf9238a2583964f333932f)

Author SHA1 Message Date
bhavikbhavsar bcb2f59458 Minor Undefined variable fixes (#53383) 
Signed-off-by: Bhavik Bhavsar <bbhavsar@redhat.com>
 2019-03-08 08:35:13 -05:00
Dag Wieers c44e83ee13 rhevm: Fix validate-modules issues (#52436) 
This PR includes:

* Adding parameter types
* Fix validate-modules issue
* Improve parameter types and resulting changes

This PR needs to be verified and tested by maintainer(s).
 2019-03-06 14:05:14 +00:00
Dag Wieers c2fb581414 Fix various sonarcloud issues 
This fixes various reported bugs through sonarcloud at:
https://sonarcloud.io/project/issues?id=Rodney-Reis_ansible&resolved=false&types=BUG
 2019-02-15 07:19:04 -08:00
Matt Clay 0a461380a3 Fix incorrect use of `is` for comparisons. 
See https://bugs.python.org/issue34850 for details.
 2019-02-12 16:33:13 -08:00
Toshio Kuratomi 3fba006207 Update bare exceptions to specify Exception. 
This will keep us from accidentally catching program-exiting exceptions
like KeyboardInterupt and SystemExit.
 2018-12-16 15:03:19 -08:00
Matt Clay 37b013aca3
Enable additional pylint rules and resolve issues found. (#47221) 
* Resolve unneeded-not.
* Resolve global-at-module-level.
* Resolve useless-import-alias.
* Resolve bad-whitespace.
* Resolve global-variable-not-assigned.
* Resolve logging-not-lazy.
* Resolve comparison-with-itself.
 2018-10-18 13:38:08 -07:00
Sandra McCann c5a8a911b3 fix doc links (#46094) 2018-09-24 16:08:05 -05:00
Dag Wieers b6b36276a4 Clean up BOTMETA.yml (#44574) 
This PR includes:
- Removal of maintainers that are listed as author in the module
- Removal of entries that do not extend the original author list
- Move ignored-statement to namespace/directory (where useful)
- In some cases, fix the authors-list or add missing github id

We end up with a list of exceptions/additions and a large set of
namespace/directory maintainers or team of maintainers.

Some entries could be further improved by discussing with some
maintainers.
 2018-08-24 19:43:35 -04:00
Dag Wieers cdd21e2170
Clean up module documentation (#36909) 
* Clean up module documentation

This PR includes:
- Removal of `default: None` (and variations)
- Removal of `required: false`
- Fixing booleans and `type: bool` where required

* Fix remaining (new) validation issues
 2018-03-15 22:15:24 +01:00
Matt Clay 227ff61f9d
Add module support to yamllint sanity test. (#34964) 
* Add module support to yamllint sanity test.
* Fix duplicate keys in module RETURN docs.
* Fix syntax in return_common docs fragment.
* Fix duplicate keys in module EXAMPLES docs.
 2018-01-16 15:08:56 -08:00
John Barker c57a7f05e1 Bulk autopep8 (modules) 
As agreed in 2017-12-07 Core meeting bulk fix pep8 issues

Generated using:
autopep8 1.3.3 (pycodestyle: 2.3.1)
autopep8 -r  --max-line-length 160 --in-place --ignore E305,E402,E722,E741 lib/ansible/modules

Manually fix issues that autopep8 has introduced
 2017-12-07 20:25:55 +00:00
Matt Clay 7714dcd04e Enable more pylint rules and fix reported issues. (#30539) 
* Enable pylint unreachable test.
* Enable pylint suppressed-message test.
* Enable pylint redundant-unittest-assert test.
* Enable pylint bad-open-mode test.
* Enable pylint signature-differs test.
* Enable pylint unnecessary-pass test.
* Enable pylint unnecessary-lambda test.
* Enable pylint raising-bad-type test.
* Enable pylint logging-not-lazy test.
* Enable pylint logging-format-interpolation test.
* Enable pylint useless-else-on-loop test.
 2017-09-18 23:20:32 -07:00
Toshio Kuratomi f203ca7907 Update metadata to 1.1 2017-08-15 23:12:08 -07:00
Toshio Kuratomi 8de6cff2b1 more wildcards 2017-07-29 07:02:12 -07:00
Toshio Kuratomi 225fa5d092 Fix undefined variables, basestring usage, and some associated python3 issues 2017-07-25 15:58:23 -07:00
Matt Clay 48eeab8a53 Fix errors reported by pylint. (#23282) 
* Fix pylint misplaced-bare-raise errors.
* Fix pylint return-in-init error.
* Fix pylint bad-format-character error.
* Fix pylint too-many-format-args errors.
* Fix pylint too-few-format-args errors.
* Fix pylint truncated-format-string error.
 2017-04-06 16:58:16 -07:00
Toshio Kuratomi eb1214baad New metadata 1.0 (#22587) 
Changes to the metadata format were approved here:
https://github.com/ansible/proposals/issues/54
* Update documentation to the new metadata format
* Changes to metadata-tool to account for new metadata
  * Add GPL license header
  * Add upgrade subcommand to upgrade metadata version
  * Change default metadata to the new format
  * Fix exclusion of non-modules from the metadata report
* Fix ansible-doc for new module metadata
* Exclude metadata version from ansible-doc output
* Fix website docs generation for the new metadata
* Update metadata schema in valiate-modules test
* Update the metadata in all modules to the new version
 2017-03-14 09:07:22 -07:00
Ondra Machacek 85fc930066 cloud: ovirt/rhev add note old modules were replaced (#22118) 2017-03-01 17:05:02 +00:00
Matt Martz 7c00346714 Validate EXAMPLES as YAML 2017-02-15 13:01:43 -08:00
Brian Coca 74e8aa22af no log passwords (#21229) 
* no log passwords

* removed unneeded no_log
 2017-02-10 15:13:59 -05:00
Matt Clay cb76200c7d PEP 8 E111 & E114 cleanup. (#20838) 2017-01-30 15:01:47 -08:00
Carlos E. Garcia 0b8011436d minor spelling changes 2016-12-13 13:51:13 -05:00
James Cammarata 011ea55a8f Relocating extras into lib/ansible/modules/ after merge 2016-12-08 11:35:18 -05:00