3f968ff46a
Check one more skipped scenario in with_subelements.
2013-10-09 17:14:42 -04:00
9124ebb4f1
Clear out complex_args before running async_status
...
When using complex args with an async task, the subsequent runs of
async_status would inherit them, causing a module error (invalid params).
Fixes #3150
2013-10-09 15:08:47 -05:00
2078518735
Allow subelements to work right with skipped results.
2013-10-09 15:55:47 -04:00
5ed28efe45
Script module should return changed attribute so handlers always fire, unless "changed_when" is specified.
...
Fixes #4053
2013-10-07 17:06:25 -04:00
a7adc8ef4d
Allow doing things like "groups.groupname" in with_nested.
...
Fixes #3858
2013-10-07 16:58:29 -04:00
19386c43a7
Merge
2013-10-07 10:02:21 -04:00
d10582225b
Merge branch 'issue_4215_fetch_expanduser' into devel
2013-10-07 08:27:52 -05:00
e7957b6d58
Fix group_by: do not group a host for which a condition is false
2013-10-07 08:44:42 -04:00
65178290e7
Merge branch 'devel' of git://github.com/nextus/ansible into devel
...
Conflicts:
lib/ansible/constants.py
2013-10-07 08:39:23 -04:00
4987c73bb6
Proper check for raw as module options versus raw being in the string.
2013-10-06 09:54:28 -04:00
52aea868df
Allow for updating host vars in add_host
2013-10-04 16:15:17 -04:00
d21714a37f
Fix for network byte order issues in accelerate
2013-10-02 15:37:15 -05:00
912e3a7b0b
Merge branch 'accelerate_improvements' into devel
...
Conflicts:
library/utilities/accelerate
2013-10-01 21:22:17 -05:00
fa80a17aa3
Make recv_data less greedy so it doesn't eat other packets
2013-10-01 16:50:32 -05:00
12f6957596
Cleaning up some vvvv log messages in accelerate
2013-10-01 15:34:58 -05:00
8c17711247
Removing accelerate_timeout as a playbook option
...
This will remain in ansible.cfg only.
2013-10-01 15:33:18 -05:00
d317103371
Added in an accelerate connection timeout setting
2013-10-01 15:28:59 -05:00
59a5ce23d9
Adding an accelerate_timeout parameter for plays
...
This setting makes the timeout for each play configurable, rather than
hard-coding it at 300 seconds (now the default if left unspecified)
Fixes #4162
2013-10-01 15:26:50 -05:00
f9c87868ac
Added keepalive packets to accelerate mode
...
Commands will now be started up in a separate task from the main
handler thread, so that it can be monitored for completeness while
sending a keepalive packet back to the controller to avoid a socket
receive timeout.
2013-10-01 15:19:21 -05:00
32a1dd422c
Merge pull request #4269 from jphalip/issue-4256
...
In the script action: Get around a Python bug.
2013-09-30 20:24:49 -07:00
52a42bf607
Add more verbose debugging options for accelerate
2013-09-30 14:08:07 -05:00
535ce97067
Add fileglob Jinja2 filter. Fixes #3563
2013-09-30 12:55:13 -05:00
44aeea7afc
In the script action: Get around a bug in that's been fixed in Python 2.7 but not Python 2.6.
...
See: http://bugs.python.org/issue6988
Fixes #4256 .
2013-09-27 08:57:07 -07:00
3ee7b177e8
Allow storing input from user in a pause prompt
2013-09-25 17:28:25 -05:00
994dfb84fc
Minor pep8 cleanup and CHANGELOG update for do-until
2013-09-25 15:51:49 -05:00
202c4f5294
Merge branch 'do_until_14' of https://github.com/bennojoy/ansible into bennojoy-do_until_14
2013-09-25 15:49:14 -05:00
478c400817
Minor pep8 cleanup in the new jail connection plugin
2013-09-25 14:48:30 -05:00
0e0595bdb2
Merge branch 'jail' of https://github.com/mscherer/ansible into mscherer-jail
2013-09-25 14:47:24 -05:00
70a9a797fa
Fix for accelerate when ansible_ssh_user is specified
2013-09-25 19:24:54 +05:30
ca96d74572
#4227 in upstream repo
2013-09-25 16:15:49 +04:00
0e749611ac
doc update and add attempts
2013-09-25 09:56:14 +05:30
21529de82e
dountil feature commit 2
2013-09-24 15:23:01 +05:30
53e48b63a9
dountil feature commit 1
2013-09-24 13:59:38 +05:30
2f39d37a97
Expand destination path in the fetch action
...
Fixes #4215
2013-09-23 20:23:48 -05:00
319a0f9523
Merge pull request #4154 from mplonka/AIX_MD5
...
using AIX 'csum' command for generating MD5 checksums
2013-09-23 08:27:12 -07:00
7f8126a6c9
Merge pull request #4168 from nigelm/md5_filter
...
Added md5 as a jinja filter - returns hex digest of input
2013-09-23 08:21:11 -07:00
cb4b964070
Allow for dynamic accelerate_port: and port: in plays
2013-09-23 13:33:36 +04:00
c840cbaad9
Merge branch 'fork_fixes' of https://github.com/akerl/ansible into akerl-fork_fixes
2013-09-19 10:37:45 -05:00
69cfcf7ed0
Minor change to -vvvv mode to only show debugging info for ssh conns
...
Also added this feature to the CHANGELOG
2013-09-19 08:12:43 -05:00
d5b96abd80
Added support for -vvvv to enable ssh connection debugging
...
This patch also checks specifically for a return code of 255, which
indicates an unknown SSH error of some kind. When that happens, ansible
will now recommend running with -vvvv (if not enabled) or show the
output from 'ssh -vvv' (when it is enabled)
2013-09-19 05:58:54 -05:00
f0cc2d6efe
Added md5 as a jinja filter - returns hex digest of input
2013-09-19 09:38:22 +01:00
d8cd3d603e
Straightened out the logic for delegate handling in synchronize action module
2013-09-19 03:17:44 -04:00
61e726fe82
Fix to local delegate_to override and proper sudo handling from @smoothify
2013-09-19 03:17:44 -04:00
32ae6fdd43
Return of sychronize module code for take 3
2013-09-19 03:17:43 -04:00
d0c78bdc83
using AIX 'csum' command for generating MD5 checksums
2013-09-18 21:07:25 +02:00
5b1b831cc7
Make ssh's ControlPath configurable via ansible.cfg
...
This shouldn't generally be needed unless you're working in an environment
that uses rediculously long FQDNs; if the name is too long, you wind up
hitting unix domain socket filepath limits enforced by ssh.
2013-09-18 15:07:07 -04:00
98bf473cb2
fixes for PTY handling
2013-09-16 17:44:32 -04:00
3b801dec72
Merge branch 'failed_when' of https://github.com/hnakamur/ansible into hnakamur-failed_when
2013-09-16 07:35:34 -05:00
fcc18fa105
Merge branch 'subelements' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-subelements
2013-09-16 06:14:42 -05:00
3848e02959
Merge branch 'issue4022' of https://github.com/sfromm/ansible into sfromm-issue4022
...
Conflicts:
lib/ansible/runner/connection_plugins/accelerate.py
2013-09-16 05:50:35 -05:00
d9cf1dfefb
Merge branch 'fetch' of https://github.com/bpennypacker/ansible into bpennypacker-fetch
2013-09-16 05:39:48 -05:00
f4b3defcbf
Set sudo in accelerate commands correctly
...
Fixes #4111
2013-09-15 20:20:22 -05:00
5e1828a524
add jail module, based on lxc and chroot connexion plugin
2013-09-15 17:26:48 +02:00
6786773797
filter out qoutes since they cause random errors
2013-09-10 15:00:29 +02:00
aab445a28f
add 'chars' parameter to password plugin to allow custom character set
...
It accepts comma separated list of names that are
either string module attributes (ascii_letters,digits, etc)
or are used literally
To enter comma use two commas ',,' somewhere - preferably at the end
Qoutes and double qoutes are not supported
2013-09-10 11:59:16 +02:00
2357194b39
Add failed_when module variable.
...
Implementation note: Ternery operator trick for python prior to 2.5 is used.
(test and [when_true_value] or [when_false_value])[0]
http://stackoverflow.com/questions/394809/ternary-conditional-operator-in-python#comment1466794_394887
2013-09-10 08:34:01 +09:00
4f9af7efad
subelements lookup plugin
2013-09-09 23:45:55 +02:00
6e9fa5019f
Reverting HostVars change from a mapping back to a dictionary
2013-09-06 20:24:16 -05:00
2a47f72139
Merge pull request #4049 from mscherer/fix_no_kerberos
...
Fix no kerberos
2013-09-06 07:10:10 -07:00
f489702973
Also add back gssapi-keyex
...
While this is not currently implemented in openssh as far as I know,
there is patch floating around on the web and this may land one day
upstream.
2013-09-06 10:40:34 +02:00
17c39b94a3
support GSSAPIAuth back
...
GSSAPIAuthentication has not been supported
due to PreferredAuthentications trick ( 2bdba17a85
2013-09-06 10:40:25 +02:00
ae9e38daf8
Change hostvars to a mutable mapping to more closely resemble a dict
...
Fixes #4030
2013-09-05 23:04:16 -05:00
2cbf28385a
Move check for accelerate mode deeper to account for ansible_connection
...
Fixes #4045
2013-09-05 20:20:25 -05:00
20b0dc4abd
Check for an empty executable passed into the accelerate plugin
...
This was breaking at least the script module, so it would seem best
to check for it and set it to the default executable value
2013-09-05 15:11:26 -05:00
4bf506f683
Always run the accelerate module as the user specified in the play
...
Currently, the accelerate daemon will be run as the sudo_user if
specified, which is incorrect.
2013-09-05 12:04:48 -05:00
68bffb1233
Don't force accelerate connection for local actions.
2013-09-05 09:37:47 -06:00
f6e1bdabea
Ensure ports are set correctly in accelerate module
2013-09-05 09:52:10 -05:00
64db327411
Fix: raise correct error in accelerate mode
2013-09-05 15:10:45 +09:00
d704b55860
Support using paramiko to set up accelerate connection
...
Adds original_transport attribute to Runner to track what the original
transport was before it is changed to 'accelerate'.
If using paramiko in original_transport, uses ParamikoConnection. If
not, falls back to SSHConnection like before.
2013-09-04 13:57:03 -07:00
fff497a1ae
Make sure the accelerated port is set to a sane value
2013-09-04 15:52:39 -05:00
cc21e5c90c
Adding hostvars to injected variables in accelerate ssh runner
...
Also some minor cleanup of some fb* variables and functions, which
were remnants of the old fireball2 name
Fixes #4021
2013-09-04 15:29:46 -05:00
c0fecf87d1
Increase default socket timeout to 5 minutes
2013-09-04 09:47:40 -05:00
2696135b3b
Display error during launch of accelerated daemon
...
* also minor tweak to the # of retries in the connection attempt
Fixes #4012
2013-09-03 12:28:32 -05:00
53c2f4c1bb
Fix race condition on creating the temp directory for ControlPersist
...
Fixes #3943
2013-09-03 11:00:33 -05:00
d05c61d1f0
Merge branch 'devel' into fireball2
...
Conflicts:
lib/ansible/playbook/__init__.py
lib/ansible/playbook/play.py
2013-09-02 21:54:02 -05:00
d69d5c294f
Renaming fireball2 as 'accelerate' and removing old references
2013-08-30 13:26:27 -05:00
6f6efa268b
Merge branch 'smoothify-defaults' into devel
2013-08-30 08:40:47 -05:00
637d3070dc
Allow default variables to be overridden by inventory variables
2013-08-29 17:21:28 -05:00
9806f89a04
Revert "Construct the multiprocessing manager only once."
...
This reverts commit 1d13ec2da3
2013-08-29 11:00:25 -05:00
7d3ae9fc75
Fixing a few bugs related to fireball2
...
* ssh port not being picked up, always uses default of 22
* forgot to 'import time' in the fireball2 connection plugin
2013-08-28 19:27:18 -05:00
faf82bf841
Fix bug with fetch when using sudo: true
...
Fixes #3111
2013-08-28 13:24:16 -05:00
af1dd7075f
Adding chunked file transfers to fireball2
2013-08-28 11:14:58 -05:00
959138d00d
Added accelerate_port to plays, and made it configurable
2013-08-28 11:14:58 -05:00
167f185092
Initial support for running gather_facts through fireball2
2013-08-28 11:14:58 -05:00
b45342923c
Initial support for sudoable commands over fireball2
...
Caveats:
* requiretty must be disabled in the sudoers config
* asking for a password doesn't work yet, so any sudoers users must
be configured with NOPASSWD
* if not starting the daemon as root, the user running the daemon
must have sudoers entries to allow them to run the command as the
target sudo_user
2013-08-28 11:14:58 -05:00
4b552457e7
Bail out correctly if socket.recv gets nothing (indicating a closed socket)
2013-08-28 11:14:58 -05:00
86f01965cd
Fireball2 module will now launch in a proper tmp path
2013-08-28 11:14:58 -05:00
521e14a3ad
Fireball2 mode working!
2013-08-28 11:14:58 -05:00
acc5d09351
Initial commit for the "fireball2" connection plugin
...
Still needs:
* chunked file transfer/receive
* should probably move all send/recv operations to separate
functions to reduce code duplication
* initial connection setup over ssh? or do we handle that in runner?
2013-08-28 11:14:58 -05:00
cf6a76c814
changed ignore_md5_mismatch to validate_md5
2013-08-28 14:41:00 +00:00
41c474d129
added optional ignore_md5_mismatch parameter
2013-08-28 14:16:57 +00:00
8262f7bfac
Merge branch 'with_items_and_complex_args' of https://github.com/lberruti/ansible into lberruti-with_items_and_complex_args
2013-08-22 23:01:11 -05:00
462cd4f728
Merge branch 'pulls/fix-hostvars-inconsistancy' of https://github.com/ferringb/ansible into ferringb-pulls/fix-hostvars-inconsistancy
2013-08-22 13:56:34 -05:00
e6ad3b7792
Merge pull request #3895 from mscherer/fix_option_new_ssh
...
make sure ssh do not ask password
2013-08-22 10:26:54 -07:00
157b697a83
Merge branch 'always_run-6' of https://github.com/stoned/ansible into stoned-always_run-6
2013-08-22 12:10:28 -05:00
af4f0bd008
Fix for "argument must be an int, or have a fileno() method" error
...
The issue was that, when forks == 1, the _executor() function was
being called with None for the value of new_stdin.
Fixes #3841 , #3902
2013-08-21 22:45:34 -05:00
978af89175
Disallow running async tasks with lookup plugins
...
Fixes #2897
2013-08-21 16:44:10 -05:00
6bf5d19506
SSH connection plugin creates ControlPersist socket files in a secure directory
...
Files were being created in /tmp, but will now be created in $HOME/.ansible/cp/
Addresses CVE-2013-4259: ansible uses a socket with predictable filename in /tmp
2013-08-21 11:40:46 -05:00
f0743fc32a
Introduce the 'always_run' task clause.
...
The 'always_run' task clause allows one to execute a task even in
check mode.
While here implement Runner.noop_on_check() to check if a runner
really should execute its task, with respect to check mode option
and 'always_run' clause.
Also add the optional 'jinja2' argument to check_conditional() :
it allows to give this function a jinja2 expression without exposing
the 'jinja2_compare' implementation mechanism.
2013-08-20 23:09:44 +02:00
2bdba17a85
make sure ssh do not ask password
...
For some reason, ssh seems to ask for password even when
PasswordAuthentication is set to no, adding PreferredAuthentications
with the 2 options removed do the trick.
2013-08-20 22:02:37 +02:00
Michael DeHaan
James Cammarata
Stoned Elipot
James Tanner
Matt Martz
Julien Phalip
Preston Marshall
bennojoy
nextus
Michael DeHaan
Andrey Shorin
Nigel Metheringham
Timothy Appnel
Marcin Płonka
Brian Harring
Les Aker
Michael Scherer
Marcin Kałuża
Hiroaki Nakamura
Serge van Ginderachter
Keiichi Mori
Scott Sturdivant
guersam
Stephen Fromm
Bruce Pennypacker