Commit Graph

3043 Commits (a60740a37dd94e3840293a93a10ca673c79efd7f)

Author SHA1 Message Date
Miguel Angel Muñoz González 9566708473 Fortinet's FortiOS webfilter urlfilter (#51805) 2019-02-07 21:04:15 +00:00
Miguel Angel Muñoz González 6416ddfc2f Fortinet's FortiOS antivirus heuristic (#51806) 2019-02-07 21:03:43 +00:00
Dennis Israelsson 9243c927ba Ios static route new parameters (#41478)
* Update ios_static_route.py

* Update version_added
2019-02-07 10:38:20 -05:00
rajaspachipulusu17 0745d6a10a Pluribus Networks point feature module for vrouter pim config with UT (#51013) 2019-02-07 20:13:00 +05:30
Kevin Breit f9f7b29a5a meraki_admin - Add documentation about absent priority (#51766)
* Add documentation about absent priority

* Remove 7 at the end of file
2019-02-06 10:06:57 -05:00
Sandra McCann eb6989ecbc Add note to network agnostic modules for supported platforms (#51617)
* added doc fragment to multiple network modules
2019-02-05 15:18:54 -06:00
rajaspachipulusu17 d5797aa02f Pluribus Networks role module with Unit tests (#51261)
* Pluribus Networks role module with Unit tests

* pep8 sanity fixes

* Doc fix
2019-02-05 10:23:07 +05:30
Nathaniel Case d14f16e31b
Restconf HTTPAPI plugin and modules (#49476)
* Initial code for restconf support

*  Add restconf httpapi plugin
*  Add restonf_get module

* Fix some ConnectionError usage
2019-02-04 09:28:26 -05:00
vaneuk 2a0c356da9 added response_timestamps to ios_xr_command module (#50095) 2019-02-04 18:49:06 +05:30
rajaspachipulusu17 449b7e9f10 Pluribus Networks snmp community module with unit tests (#51165) 2019-02-04 10:42:00 +05:30
Wojciech Wypior d043003cff Fixes documentation example (#51643) 2019-02-01 21:32:02 -08:00
Kevin Breit 4493ba86ec Add response documentation (#51647) 2019-02-02 05:08:09 +01:00
Wojciech Wypior 1e4d2b1001 Ammends docstring (#51641) 2019-02-01 18:15:37 -08:00
Wojciech Wypior 041da7516d fixes issue #1186 (#51642) 2019-02-01 18:14:33 -08:00
Wojciech Wypior cccb681c0a Adds aggregate functionality to the module (#51638) 2019-02-01 18:04:49 -08:00
Wojciech Wypior 803bf79dce Adds aggregate functionality to the module (#51639) 2019-02-01 18:03:45 -08:00
Wojciech Wypior a5c630a81f Adds aggregate functionality to the module (#51640) 2019-02-01 17:53:06 -08:00
Wojciech Wypior 48704d45fd Fixes indentation style issues (#51637)
Fixes docstrings
2019-02-01 17:49:33 -08:00
Wojciech Wypior fd2e0ddcac Adds clone_pools parameter (#51635)
Adds rate_limit parameter
Minor bug fixes
2019-02-01 17:47:46 -08:00
rajaspachipulusu17 a48af10b2c Pluribus Networks stp port module with UT (#51476) 2019-02-01 21:19:32 +05:30
Federico87 f94378fc2f ios_ntp module (#50705)
* ios_ntp module

* add execute_module for config func

* fix units test

* test empty list

* update example

* change want logic to follow have - removed try/except

* update commands list for config test

* add idempotent test case

* add more test
2019-02-01 09:20:02 -05:00
Anil Kumar Muraleedharan 004d8b03d4 Lenovo cnos l3interface (#51322)
* Adding cnos_l3_interface module in alignment with others vendors.
2019-02-01 09:17:52 -05:00
Simon Metzger f3907c977c added support for breakout ports (#51607) 2019-02-01 15:15:42 +01:00
Trishna Guha 9df6f152e1
add license_hostid fact nxos_facts (#51588)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-02-01 11:11:00 +05:30
Kevin Breit c8484e19ca Correct spelling in meraki_ssid documentation (#51563)
Fix spelling error for address, which was addres.

+label: docsite_pr
2019-01-31 18:20:42 -06:00
vaneuk 2a432a093b added timestamps to ios_command module (#50323)
ios_command module now returns timestamps field, which shows command execution time
2019-01-31 18:11:53 +05:30
Thomas Stewart 8719866ae8 Fix IF_ETH_REGEX to allow 1/1 and 1/1/1 interfaces (#51438) 2019-01-31 16:53:42 +05:30
rajaspachipulusu17 a9b459e406 Pluribus Networks stp module with unit test (#51475) 2019-01-31 09:47:17 +05:30
rajaspachipulusu17 5e88cd9972 Pluribus Networks pn user module with UT (#51428)
* Pluribus Networks user module with UT

* Added choice to State in doc

* pep8 standards correction
2019-01-31 09:43:04 +05:30
rajaspachipulusu17 5fa2d29c9a Pluribus Networks point feature cpu mgmt class module with UT's (#51427) 2019-01-31 09:41:58 +05:30
rajaspachipulusu17 52cab33e4e Pluribus Networks point features for snmp vacm with UT's (#51423)
* Pluribus Networks point features for snmp vacm with UT's

* Duplicates removal

* Added choice for state
2019-01-31 09:40:38 +05:30
rajaspachipulusu17 271e14638e pn snmp trap sink (#51420)
* Pluribus Network snmp trap sink module with Unit tests

* pep8 standard fix

* Added proper author name
2019-01-31 09:39:23 +05:30
Sebastian 48107ac212 junos_config documentation missing "update" choice (#51299)
* Update junos_config.py

The current junos_config module documentation only lists "merge","override" and "replace" as update parameter choices. Looking into junos_python.py "update" is another option which is really helpful and in my opinion the most needed option.

'''
update=dict(default='merge', choices=['merge', 'override', 'replace', 'update'])
'''

+label: docsite_pr

* Fixup Update junos_config.py

The current junos_config module documentation only lists "merge","override" and "replace" as update parameter choices. Looking into junos_python.py "update" is another option which is really helpful and in my opinion the most needed option.

'''
update=dict(default='merge', choices=['merge', 'override', 'replace', 'update'])
'''

Co-Authored-By: crab86 <sgesenhoff@gmail.com>
2019-01-30 10:12:17 -05:00
Nilashish Chakraborty 2f0c666b5b
Add option to enter admin configuration mode in iosxr_user (#51430)
* Add admin mode to iosxr_user

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Update docs for admin option

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix review comment

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-01-30 15:37:28 +05:30
Dag Wieers 9eef9a3702
aci_aaa_user: Fix an issue with clear_password_history (#51459) 2019-01-30 01:49:33 +01:00
Nilashish Chakraborty 77303d72ab
Add new module - junos_ping (#50711)
* WIP junos_ping

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Added junos_ping module

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Minor changes

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Minor changes - 2

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix CI

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Initial tests

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* WIP tests

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix spaces

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fixed unit tests

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Removed unused print statements

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Removed unused print statements

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Update license template

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fixed Review Comments

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-01-29 15:36:12 +05:30
vaneuk 844e194aa4 changed interface config blocks parsing logic (#50340) 2019-01-29 04:42:31 -05:00
Ganesh Nalawade 8f5cd049d6
Allow check_mode with supports_generate_diff capability in cli_config (#51384)
* If network cliconf support `supports_generate_diff` in
  that case diff between running and cnadidate config
  is generated within Ansible and if check_mode is enabled
  in that case return only diff without actually invoking
  edit_config()
2019-01-29 12:00:39 +05:30
Trishna Guha f712e86728
Add multiline config example in cli_config docs (#51413)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-01-29 10:46:16 +05:30
Dag Wieers d8a0e1a9b7
aci_aaa_user: Fix changing user description (#51408)
This fixes a reported problem with the aci_aaa_user module.
2019-01-29 03:16:58 +01:00
Nilashish Chakraborty 92b0cd8e0e
Add more return values to *_config modules (#50702)
* Add more return values to *_config modules

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add more rv

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Exclude from cli_config docs for now

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add new rv docs for junos_config

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix CI errors

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Support date time for configurable backup path

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Change logic based on configurable path

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Remove unwanted import

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix docs

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add filename rv

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Change dosc filename rv

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Make new rv code more readable

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-01-28 20:49:56 +05:30
Dag Wieers b595228983
mso_stae_contract: Add EPG contracts (#51383)
This module creates EPG contracts in schema templates.
2019-01-28 14:37:30 +01:00
Nathaniel Case 9336281a60
Standardize cliconf get_capabilities (#51147)
* Standardize cliconf get_capabilities

* Check for capabilities before querying them

* Try to be more helpful when unexpected things are found in get_capabilities

* Add flags param to get_config for compatibility
2019-01-28 08:24:44 -05:00
Dag Wieers 86c3f14972
mso_st_deploy: Deploy a schema template (#51379)
This new module deploys a schema template to sites.
2019-01-28 12:55:29 +01:00
Nilashish Chakraborty 69dd03d472
ios_user: Add support for multiple sshkeys (#51173)
* Add support for multiple sshkeys

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix CI

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add the keys at on go

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Update tests

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-01-28 13:44:15 +05:30
Dag Wieers 73636175da
MSO: Refactor modules to common structure (#51354)
This PR includes:
- Various fixes to jsonpatch interface
- Added seealso: and notes: to docs
- Various improvements to docs
- A set of bugfixes found during integration tests

Full integration tests follow.
2019-01-26 03:48:13 +01:00
Dag Wieers b7ec254816
mso_schema_site: Add sites to a schema template (#51332)
A new module to associate sites to schema templates
2019-01-25 15:27:55 +01:00
Dag Wieers 92b475f721
mso_contract_filter: Improve logic (#51315)
This PR improves the jsonpatch logic.
2019-01-25 04:23:59 +01:00
Dag Wieers 0acc4dafdd
MSO: Various small fixes (#51314)
* mso_bd: Allow adding subnets on creation

* Fix example
2019-01-25 04:23:38 +01:00
Dag Wieers fc4e93f1a3
mso_anp: Idempotency fixes (#51313) 2019-01-25 03:53:43 +01:00
Dag Wieers ebe8510f05
mso_st_contract_filter: Manage contract filters (#51300)
New module to manage contract filters in an MSO schema template.
2019-01-24 20:56:46 +01:00
Dag Wieers 0a9902174c
mso_st_vrf: Manage VRFs in templates (#51292)
A new module to manage VRFs in MSO schema templates.
2019-01-24 17:54:09 +01:00
Dag Wieers ac2476a791
mso_st_l3out: Manage l3out's in templates (#51291)
A new module to manage l3out's in MSO schema templates.
2019-01-24 17:53:20 +01:00
Dag Wieers 2413169b25
mso_st_filter_entry: Manage filter entries in templates (#51290)
A new module to manage filter entries in MSO schema templates.
2019-01-24 17:38:39 +01:00
Dag Wieers ad607083de
mso_schema_template_bd: Manage BDs in templates (#51279)
A new module to manage BDs in MSO schema templates.
2019-01-24 16:53:30 +01:00
Dag Wieers 9409826982
mso_st_externalepg: Manage external EPGs in templates (#51285)
A new module to manage external EPGs in MSO schema templates.
2019-01-24 16:53:18 +01:00
Dag Wieers 8d282de811
mso_st_bd_subnet: Manage BD subnets in templates (#51282)
A new module to manage BD subnets in MSO schema templates.
2019-01-24 16:14:51 +01:00
Dag Wieers e72bb42e21
mso_sta_epg_subnet: Manage EPG subnets in templates (#51278)
A new module to manage EPG subnets in MSO schema templates.
2019-01-24 15:43:43 +01:00
Dag Wieers 73ed1a8269
mso_schema_template: Manage templates in schemas (#51277)
A new module to manage templates in MSO schemas.
2019-01-24 15:32:07 +01:00
Dag Wieers 6d47105a2d
mso_s_t_anp: Manage ANPs in templates (#51274)
A new module to create ANPs in MSO schema templates.
2019-01-24 15:20:36 +01:00
Dag Wieers dfad17ad8a
mso_s_t_anp_epg: Manage EPGs in templates (#51275)
A new module to create EPGs in MSO schema templates.
2019-01-24 15:16:45 +01:00
Dag Wieers 7a642c783a
mso_schema: Improvements to docs (#51272) 2019-01-24 14:39:06 +01:00
Ganesh Nalawade 70bf9b9919
Add backup filename and dir path option for config network modules (#50801)
* Add configurable backup path option for network config modules

Fixes #50283
Fixes #32724

*  Add back_options in network config module argspec
*  Handle backup path options in network action plugin

* Fix review comments

* Add integration tests

* Update changelog
2019-01-24 09:36:16 +05:30
Olivier BLIN 87a01df6ad Fix 'defaults' option in the nxos_config module (#51076)
* Fix 'defaults' option in the nxos_config module

Nxos get_config is allways called with the 'all' option.
* Fix flag's calculation
* Add tests

* nxos_config: the 'backup' option take into account the value of 'defaults' option

If 'defaults' option is true, the running-config backup is done with the all
keyword.
2019-01-23 11:29:27 +05:30
linnil1 dabdf171c5 Feature junos filter (#44703)
* Add filter in l3_interface

* Add filter in vlan

* Add filter in l2_interface

* Update version to 2.8
2019-01-23 09:36:24 +05:30
rajaspachipulusu17 61a342f0bb Pluribus Networks admin syslog modules with unit tests (#50596) 2019-01-22 22:00:12 +05:30
Nathaniel Case 9702893729
Remove deprecated options from modules (#50246)
* Remove deprecated options from modules

* Update tests

* Add porting guide notes
2019-01-22 09:18:26 -05:00
QCU87Z 9169b7d2b9 Update nxos_aaa_server_host.py (#49635)
* Update nxos_aaa_server_host.py

* remove host, username, and password
2019-01-21 10:47:51 -05:00
rajaspachipulusu17 a38039bbbe Pluribus Networks port cos rate setting module with UT (#50856) 2019-01-21 12:49:31 +05:30
rajaspachipulusu17 213b2e633c Pluribus Networks switch setup module with unit test cases (#50797)
* Pluribus Networks switch setup module with unit test cases

* Module error fix and pep8 standards error fix
2019-01-21 12:48:09 +05:30
Ingate Systems 5671ff983d modules: network: ingate: Add module ig_store_edit (#47675)
* modules: network: ingate: Add module ig_store_edit

* modules: network: ingate: Add module ig_config

Manage the configuration database on an Ingate SBC.
2019-01-17 23:05:45 -05:00
Dag Wieers 31222b65c1
Fix small typo
+label: docsite_pr
2019-01-17 13:48:25 +01:00
Albert Siersema b1c295386f Match VLAN ID as whole line instead of searching for digits in line (#51019)
Searching for digits somewhere in the output line will also match VLAN name (lines) starting with digits.

Fixes issue #50998
2019-01-17 17:48:24 +05:30
Ricardo Carrillo Cruz 22d914a888
Add Checkpoint access layer facts module (#51016) 2019-01-17 12:23:34 +01:00
Nilashish Chakraborty 422604fb3e
Fix malformed string error for hashed_password (#51007)
* Fix malformed string error using ast

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Update doc for this option

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Revert "Update doc for this option"

This reverts commit 3579d1912129ab14d5009785ba896de820063d46.

* Revert type value

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-01-17 13:05:49 +05:30
vaneuk e150943314 added timestamps to nxos_command module (#50261)
* added timestamps to nxos_command module

nxos_command module now returns timestamps field, which shows command execution time

* –fixed unit test failure for /lib/ansible/module_utils/basic

* cosmetic changes to align with PEP 8
2019-01-17 10:14:31 +05:30
Ricardo Carrillo Cruz 1beb6f433b
Add object_type param to checkpoint_object_facts (#50982)
* Add object_type param to checkpoint_object_facts

* Add changelog fragment

* Fix sanity

* Fix sanity

* Pass type param to payload

Otherwise it does not do what is expected to do

* Add ip-only default to docstring
2019-01-16 17:15:50 +01:00
Dag Wieers a79441ca30
Rename MSC modules to MSO nomenclature (#50959)
* msc_tenant: improve docs

* Rename MSC modules to MSO

* Rename MSC-related objects to MSO nomenclature

* Add missing doc fragments
2019-01-16 14:53:38 +01:00
Ricardo Carrillo Cruz ac61c99821
Add checkpoint_session module (#50930)
* Add checkpoint_session module

* Add unit test

* Fix pep8

* Rename Checkpoint for Check Point
2019-01-16 13:19:36 +01:00
Ricardo Carrillo Cruz 2135ddf233
Add checkpoint_object_facts module (#50933)
* Add checkpoint_object_facts module

* Fix pep8 and bogus type for ip only param

* Fix doc issues per samccann comments
2019-01-16 13:13:15 +01:00
Dag Wieers e515b4000c
msc_schema: Manage schemas on ACI MultiSite (#47758)
This includes the new msc_schema module and integration tests.
2019-01-15 13:14:34 +01:00
Dag Wieers 67b455a8ac
Update documentation notes, copyright and license (#50927) 2019-01-15 12:24:34 +01:00
Ganesh Nalawade 9d54e58216
Fix cli_config backup option check (#50926)
Fixes #50925

*  If config or rollback option is None and backup=yes in
   that case add check so edit_config() is not invoked as
   it is not required.
2019-01-15 16:48:42 +05:30
Dag Wieers 27f4a1f927
Add support for users/sites to tenants (#50924)
* Add support for users/sites to tenants

* Better work-around
2019-01-15 11:49:54 +01:00
Ricardo Carrillo Cruz 077d6a63c1
Add autopublish and autoinstallpolicy behaviour to Checkpoint devices (#50862)
* Add autopublish and autoinstallpolicy behaviour to Checkpoint devices

Up till now we published and installed policy package for every operation,
however operators may not want that and only reconcile changes after a series
of changes.
Added flags to toggle this behaviour, which defaults to autopublish and
autoinstall policy package just as it was till now.
The policy package name defaults to 'standard', since it's the default one
created on the Checkpoint management server on AWS, unsure if that's common
in other setups.

* Change signature for publish and install policy

The module object is not needed

* Fix pep8

* Fix install_policy invocation

Also fix payload in publish/discard, since it seems passing the UID
when it's not needed has issues.

* Add doc fragments

* Remove default value of targets on install_policy method

It's already defaulting to None via checkpoint_arg_spec

* Fix pep8

* Remove doc fragment and push down auto options to resource modules

I realized if I put those options as doc fragments they will show up
on facts module, which do not apply, only on resource modules that
mangle with objects.

* Fix bogus param name and validate modules issues

* Fix bogus param name on checkpoint_host
2019-01-15 11:03:48 +01:00
Ricardo Carrillo Cruz d28bf14c67
Fix checkpoint access rule facts example (#50870) 2019-01-14 13:57:37 +01:00
abirami-n 6c47594388 Fix_facts (#50597) 2019-01-14 14:23:11 +05:30
abirami-n 063c2f9d59 fix_dellos6_config (#50599) 2019-01-14 14:05:34 +05:30
Ricardo Carrillo Cruz 22c1c5ffcb
Add docstrings (#49934) 2019-01-11 12:45:59 +01:00
Ricardo Carrillo Cruz 577765592a
Checkpoint task facts (#49932)
* Add docstrings

* Fix pep8
2019-01-11 12:33:06 +01:00
Ricardo Carrillo Cruz 8ec69e4464
Checkpoint host facts (#49935)
* Add checkpoint_host_facts module

* Rebase with devel and add docstrings
2019-01-11 11:36:09 +01:00
Ricardo Carrillo Cruz 12e0da4f20
Checkpoint access rule facts (#49933)
* Add checkpoint access rule facts module

* Add docstrings and rebase with devel

* Add ANSIBLE_METADATA
2019-01-11 11:36:02 +01:00
traittinen d3107d9915 Improve panos_commit module (#50451)
* Added description, admin commit and VSYS commit features.

* pep8 fixing

* Ansible pylint fixing + module.fail on commit fail

* Ported from lxml.etree to xml.etree. Changed username to fall back to admin if nothing else defined.

* Fixed documentation for username defaults.
2019-01-11 04:26:40 -05:00
rajaspachipulusu17 ca74c443ba Pluribus Networks port config module (#50314)
* Pluribus Networks port config module

* Documentation fix for version added

* Doc fixes
2019-01-11 14:02:36 +05:30
rajaspachipulusu17 44febe4e56 Pluribus Networks port cos bw module (#50287)
* Pluribus Networks port cos bw module

* Indentation fix

* Documentation fix

* Corrected indetentation for required_one_of

* Added maintainer name in BOTMETA.yml

* Removed maintainer name in BOTMETA.yml as my team is already there
2019-01-11 14:00:10 +05:30
Kevin Breit 476a7fc27d Clean up some of the execution of the module (#48391)
- Module now checks whether a specified network is valid very early
- Simplifies the present code flow
- No functionality enhancement
2019-01-10 12:10:31 -05:00
Ricardo Carrillo Cruz aea20f95c6
Fix comma (#50766) 2019-01-10 17:18:37 +01:00
Ricardo Carrillo Cruz 88eb01b660
Checkpoint host (#49936)
* Add checkpoint_host module

* Add state param to docstring

* Require ip_address if state is present

* Make else more explicit by doing and elif 404

* Remove bogus paren

* Add checkpoint_host module
2019-01-10 17:04:12 +01:00
Tetsuya Sodo 1d4dbd76c0 fix eos_l2_interface insufficient commands (#50754) 2019-01-10 15:05:07 +05:30
rajaspachipulusu17 abdcf2a776 Pluribus Networks pn_dscp_map_pri_map module with Unit tests (#50142)
* Pluribus Networks pn_dscp_map_pri_map module with Unit tests
* Corrected method name in unit test script
2019-01-10 12:51:07 +05:30
Jan-Philipp Litza 636e1d5fcb Fix sanitizing config lines (#50553)
Previously, the index got out of sync with the actual config list. Invoked with lines:
  - bad
  - first
  - bad
  - second
the sanitization would first delete index 0 and then index 2, which would result in the output
  - first
  - bad
By reversing the list, we avoid that problem (though a filter() would be nicer)
2019-01-09 10:56:30 -05:00
Anil Kumar Muraleedharan cb89b1758d Lenovo cnos l2interface (#50641)
* Adding cnos_l2 interface module and its associated Integration test as well as Unit test code
2019-01-09 10:46:56 -05:00
Anil Kumar Muraleedharan f5ebd9736c Lenovo cnos banner new module (#50145)
* Adding cnos_banner module to the list.
2019-01-09 10:43:57 -05:00
Felix Fontein 41de2855ae Remove elements= from arg_spec when type is not 'list'. (#50484) 2019-01-09 19:40:17 +05:30
Ricardo Carrillo Cruz 3e91ec28b8
Checkpoint access rule (#49937)
* WIP checkpoint_access_rule module

* Add fixes and docstrings

* Add dunder init

* Fix sanity tests issues

* Fix sanity test

* Add RETURN and EXAMPLES

* Fix example

* Fix pep8

* Add tests

* Fix pep8

* Fix pep8
2019-01-09 11:25:18 +01:00
Steve C 1793cad07b fix ip address tokenization bug in eos_static_route module (#43151) 2019-01-08 09:11:43 -05:00
Trishna Guha 1400d161c0
fix eos_l2_interface invalid command (#50644)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-01-08 17:27:20 +05:30
Nilashish Chakraborty 7845373f96
New Module: vyos_ping (#50193)
* New module for vyos ping functionality

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add some new parameters

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Need spaces

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix pylint errors

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix pylint errors

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix docs

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix docs

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix docs

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-01-08 10:42:24 +05:30
rajaspachipulusu17 a1e1a42341 Pluribus Networks module for connection stat settings with UT's (#50186)
* Pluribus Networks module for connection stat settings
2019-01-07 10:40:39 +05:30
Wojciech Wypior 96f7cf394f Corrects doc strings in bigip_asm_policy_* modules (#50561) 2019-01-04 14:24:42 -06:00
Wojciech Wypior 4648a441d2 adds bigip apm policy import (#50559) 2019-01-04 13:50:50 -06:00
Wojciech Wypior 7362c1d6ca Changes exists() method logic in asm policy fetch, corrects documentation (#50560) 2019-01-04 13:47:56 -06:00
Wojciech Wypior 8b1214596a adds apm policy fetch module (#50534) 2019-01-04 12:32:06 -06:00
Wojciech Wypior 3ef71e529a added new module to manipulate signatre sets on ASM policy (#50209) 2019-01-02 13:12:08 -06:00
rajaspachipulusu17 3517373cfd Pluribus Networks igmp snooping module with Unit tests (#50146) 2018-12-24 13:40:02 +05:30
Nathaniel Case 0b3aa75b7f
Add backup parameter to cli_config (#50206)
* Add backup parameter to cli_config

* Add a unit test for cli_config backup
2018-12-21 09:55:14 -05:00
anasbadaha d2446cbf0f Fix Issue #39598 (#49982)
* Fix Issue #39598

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix unit test for onyx_config

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Add comments for save running config

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Enhance onyx_config bug fix

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix result['changed'] = True comment

Signed-off-by: Anas Badaha <anasb@mellanox.com>
2018-12-21 11:54:10 +05:30
anasbadaha 6178a55afd Fix Issue #49612 (#50073)
* Fix Issue #49612

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Pep8 failures

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Add validation for send empty group name

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Error message

Signed-off-by: Anas Badaha <anasb@mellanox.com>
2018-12-21 11:53:36 +05:30
Dag Wieers 14b03ac15f
MSC: Various bugfixes and features enhancements (#50200)
* MSC: Various bugfixes and features enhancements

This PR includes:
- Lookups of roles, labels and domains
- Auto-create new labels
- Improvements to comparing complex datastructures
- Force removal of sites
- Support non top-level queries
- Document internal functions
- Add parameter types to modules
- Fix documentation examples
- Improvements to idempotency wrt. returning changed
- Support site locations
- Update permission list
- Various improvements to integration tests

* Fix Ci issues
2018-12-20 18:18:46 +01:00
Anil Kumar Muraleedharan eab3b02cb3 Refactoring of cnos_interface module like what followed by other vendors (#49927)
* Refactoring of cnos_interface module like what followed by other vendors

* To remove cnos-interface from E326 validation ignore list

* Effect of default parameters impacted UT
2018-12-19 11:38:19 -05:00
Wojciech Wypior 1a9fcd9a10 corrected valid type values in RETURN (#50148) 2018-12-19 14:39:14 +01:00
rajaspachipulusu17 afdd4e2343 Pluribus Networks dhcp filter module with unit tests (#49848)
* Pluribus Networks dhcp filter module with unit tests
* Added type which was missing in doc
* Removed unwanted global variable
* Fix return type
2018-12-19 17:16:25 +05:30
rajaspachipulusu17 8ca02d8359 Pluribus Networks admin service module with unit tests (#49854)
* Pluribus Networks admin service module with unit tests
* Documentation fix
* import module changes
* Removed unused imports
* Fix return type
2018-12-19 17:14:48 +05:30
Wojciech Wypior e9d7c8f328 fixed an issue with parameter breaking idempotency (#50117)
* fixed an issue with parameter breaking idempotency

* Update bigip_pool_member.py
2018-12-18 20:32:06 -08:00
Wojciech Wypior 0a55805ede changed oData filters (#50112)
* changed oData filters

* Update bigip_asm_policy_fetch.py

* Update bigip_asm_policy_import.py
2018-12-18 20:17:21 -08:00
Wojciech Wypior af19bc95e8 added asm endpoint facts (#50114)
* added asm endpoint facts

* Update bigip_device_facts.py
2018-12-18 20:04:39 -08:00
Wojciech Wypior 59f4871615 added bigip_asm_policy_manage (#50115)
* added bigip_asm_policy_manage

* Update bigip_asm_policy_manage.py
2018-12-18 19:35:51 -08:00
Wojciech Wypior f761cc4077 added ASM policy server technology module (#50116)
* added ASM policy server technology module

* Update bigip_asm_policy_server_technology.py
2018-12-18 18:38:19 -08:00
Toshio Kuratomi 947c4300ee Fix return types
We're now stricter on naming the return types.  Replace string with str.
2018-12-18 15:14:08 -08:00
Dag Wieers 05c6ff79f9 Convert to reduced list of known types (#50010) 2018-12-19 07:25:30 +10:00
Dag Wieers 15d39f9108 Sanity fixes in various modules (#50080) 2018-12-18 09:53:46 -06:00
rajaspachipulusu17 d28e700a22 Pluribus networks admin session timeout module with unit tests (#50012)
* Pluribus networks admin session timeout module with unit tests
* Doc fix
* Removed unused imports
* Removed unwanted global variable
2018-12-18 17:23:45 +05:30
Dag Wieers c1ac87794e
ACI: Fix module parameters (#50051)
* Fix parameter type of private_key

* Fix parameters of various ACI modules
2018-12-18 09:30:28 +01:00
rajaspachipulusu17 cf00880ab3 Pluribus Networks dscp map module with unit tests (#49849)
* Pluribus Networks dscp map module with unit tests
* Doc string fix
2018-12-18 12:50:16 +05:30
rajaspachipulusu17 4d88cdd83a Pluribus Networks cpu class module with unit tests (#49847)
* Pluribus Networks cpu class module with unit tests
* Doc string fixes
2018-12-18 12:42:33 +05:30
Ganesh Nalawade 3163780829
Add force_host and issu options support in junos_package module (#50018)
Fixes #48171
Fixes #33742

Add force_host and issu options support in junos_package module
*  Add force_host option to ignore warnings while installing package
*  Add issu option to enable issu feature from Ansible
2018-12-18 10:51:29 +05:30
Dag Wieers e8885ee4e8 ACI: Add types to modules and doc fragment (#49997)
* ACI: Add types to module doc fragment

* Add types to ACI modules too
2018-12-17 11:23:10 -06:00
f-bor 134c1a624e new network module: edgeswitch_vlan (#48041)
* initial commit

* better commands generation
2018-12-17 11:30:17 +05:30
anasbadaha 1580afbd62 Fixes #46410 Onyx show facts module does not work for onyx version 3.6.6000 and higher (#49414)
Signed-off-by: Anas Badaha <anasb@mellanox.com>
2018-12-17 10:53:54 +05:30
anasbadaha 369354547e Issue: 46475 Fix onyx magp module for supporting new json format (#49417)
Signed-off-by: Anas Badaha <anasb@mellanox.com>
2018-12-17 10:52:51 +05:30
Toshio Kuratomi 3fba006207 Update bare exceptions to specify Exception.
This will keep us from accidentally catching program-exiting exceptions
like KeyboardInterupt and SystemExit.
2018-12-16 15:03:19 -08:00
anasbadaha c0dbc1a441 Issue/38837 (#49873)
* Fix Issue #38837

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Issue #38837 2

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Enhance decumentation

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Failures in Shippable

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Version Added

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Add version_added:2.8 in purge attributes

Signed-off-by: Anas Badaha <anasb@mellanox.com>
2018-12-16 13:16:28 +05:30
Abhijeet Kasurde ef3b75afcd
fortimanager: Correct example documentation (#49925)
Fixes: #49813

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-15 12:10:32 +05:30
Dag Wieers a4998cfead
ACI: Add seealso fragments to module documentation (#49844) 2018-12-13 19:40:53 +01:00
Trishna Guha e944dba166
add host key as alias for sysname neighbors facts (#49827)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-12-13 18:11:14 +05:30
Dag Wieers baf0ad2309 Docs: Add a "seealso" section to the module docs (#45949)
* Docs: Add a separate  "seealso" section to the module docs
to list related modules and/or related references. This clears up the notes
section for things that are actual notes.

So you can add a section in your module documentation and four types of
references are possible.

    seealso:

    # Reference by module name
    - module: aci_tenant

    # Reference by module name, including description
    - module: aci_tenant
      description: ACI module to create tenants on a Cisco ACI fabric.

    # Reference by rST documentation anchor
    - ref: aci_guide
      description: Detailed information on how to manage your ACI infrastructure using Ansible.

    # Reference by Internet resource
    - name: APIC Management Information Model reference
      description: Complete reference of the APIC object model.
      link: https://developer.cisco.com/docs/apic-mim-ref/

This PR also includes:

- Implements ansible-doc support
- Implements schema support for the seealso options
- Updates to the development documentation
- Rename filter convert_symbols_to_format to rst_ify, cfr the existing html_ify and tty_ify filters
  - This makes the existing template a lot easier to read and fixes the confusion I had myself rereading the template (again).
- We fixed the possible suboption types (which was limited to 'bool' only)

* Use latest stable instead of devel docs
2018-12-12 14:19:58 -06:00
cma0 974c45a5f5 itential iap_token module (#46773) 2018-12-12 14:28:20 -05:00
Nilashish Chakraborty d729614d72
Add support for hashed password (#49464)
* Add support for hashed password

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix Shippable errors

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Make pwd options mutually exclusive

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2018-12-12 22:22:15 +05:30
Mike Wiebe 0e4a7b0889 Fix nxos_reload timeout and add integration tests (#49632)
* Fix timeout and add tests

* Correct module name
2018-12-12 10:32:27 -05:00
rajaspachipulusu17 b47cde9d4c Pluribus Networks pn access list ip module with unit test cases (#49604)
* Pluribus Networks pn access list ip module with unit test cases

* Changes according to ansibot standards in unit test modules

* Remove unwanted variables

* Removed unwanted super call
2018-12-12 13:33:01 +00:00
Sandra McCann 62af321909 added jinja2 example (#49740) 2018-12-10 13:10:17 -06:00
Dag Wieers 37820be05b
aci_rest: Fix ignoring custom port (#49715) 2018-12-10 15:08:06 +01:00
Miguel Angel Muñoz González baf99c8b62 Fortinet's FortiOS firewall ippool IPv6 (#49311)
* Fortinet's FortiOS firewall ippool IPv6

* Update fortios_firewall_ippool6.py
2018-12-07 13:53:02 +00:00
Miguel Angel Muñoz González 0732d4e2cf Fortinet's FortiOS firewall ippool (#49310) 2018-12-07 13:52:46 +00:00
Miguel Angel Muñoz González 913f6e36f1 Fortinet's FortiOS firewall policy for IPv6-IPv4 (#49309) 2018-12-07 13:42:43 +00:00
Miguel Angel Muñoz González 229013e652 Fortinet's FortiOS firewall vip group for IPv6-IPv4 (#49307) 2018-12-07 13:42:28 +00:00
Miguel Angel Muñoz González fbf311b094 Fortinet's FortiOS firewall vip group for IPv4-IPv6 (#49306) 2018-12-07 13:42:12 +00:00
Miguel Angel Muñoz González e1f1e83e77 Fortinet's FortiOS firewall vip group for IPv6 (#49305) 2018-12-07 13:41:12 +00:00
Miguel Angel Muñoz González c5dbbacce9 Fortinet's FortiOS firewal vip group (#49303) 2018-12-07 13:40:56 +00:00
Miguel Angel Muñoz González 9286763181 Fortinet's FortiOS firewal vip64 (#49302) 2018-12-07 13:35:03 +00:00
Miguel Angel Muñoz González dfccf5c542 Fortinet's FortiOS firewall vip6 (#49297)
* Fortinet's FortiOS firewall vip6

* Update fortios_firewall_vip6.py
2018-12-07 13:34:40 +00:00
Miguel Angel Muñoz González 877d40cef7 Fortinet's FortiOS firewall addgrp6 (#49295) 2018-12-07 13:31:16 +00:00
Miguel Angel Muñoz González 58711a539b Fortinet's FortiOS firewall address6 template (#49293) 2018-12-07 13:30:58 +00:00
Miguel Angel Muñoz González ea23681c76 Fortinet's FortiOS firewall address6 module (#49292) 2018-12-07 13:30:41 +00:00
Miguel Angel Muñoz González d15c221615 Initial commit for fortios_firewall_vip46 (#49106) 2018-12-07 13:29:54 +00:00
Miguel Angel Muñoz González 87905063e2 Initial commit for firewall_vip46 (#49105)
* Initial commit for firewall_vip46

* Initial commit for fortios_policy46

* Revert "Initial commit for fortios_policy46"

This reverts commit dd568b603965aabcbb9952b2ef2caf0bb9c571e9.
2018-12-07 13:29:32 +00:00
Miguel Angel Muñoz González 06871d1015 Initial commit for firewall_policy6 (#49091) 2018-12-07 13:29:03 +00:00
Miguel Angel Muñoz González 4f416597b8 Initial commit for firewall vip (#49003)
* Initial commit for firewall vip

* Limit lines to below 160 chars

* Fix trailing whitespace
2018-12-06 19:04:51 +00:00
Tim Rupp c0520b94b8
Corrects idempotency for f5 parameters (#49576)
Several parameters in the profile modules were not idempotent.
This patch fixes those modules
2018-12-05 16:17:37 -08:00
Tim Rupp 1c3fa2b07f
Deprecate the bigip_asm_policy module (#49574)
Specific import and export modules should be used instead
2018-12-05 16:02:16 -08:00
Anil Kumar Muraleedharan dd004321d4 Refactoring code of cnos_portchannel as cnos_linkagg in tune with other vendors. (#49467)
* Refactoring code of cnos_portchannel as cnos_linkagg in tune with other vendors.
2018-12-05 11:03:42 -05:00
Tim Rupp 1c644fb042
Adds description param to bigip_data_group (#49527) 2018-12-04 21:54:20 -08:00
Tim Rupp 60b75c2cfd
Adds ASM policy import module (#49526) 2018-12-04 21:34:55 -08:00
Tim Rupp 7a4c7b8c0f
Adds module for gtm topology regions (#49510) 2018-12-04 20:58:52 -08:00
Tim Rupp c7dd13758e
Adds bigip_profile_analytics module (#49499) 2018-12-04 12:53:31 -08:00
Tim Rupp caa6ed3c66
Adds ASM policy fetch module (#49494) 2018-12-04 11:24:34 -08:00
Tim Rupp 138690519d
Various small fixes for f5 ansible modules (#49492) 2018-12-04 11:15:49 -08:00
Tim Rupp 7c15417f62
Fixes for examples in f5 modules (#49490)
So that they use provider instead of deprecated args method
2018-12-04 10:31:25 -08:00
linnil1 8de46f5cf7 [Junos] Fix bug of setting user password (#44660)
* Add encrypted_password for junos

* Add readme for Junos user encrypted_password

* encrypted_password added in 2.8
2018-12-04 15:49:13 +00:00
Mike Wiebe dd984709f5 Fix issues related to track feature (#49454) 2018-12-04 09:57:35 +05:30
anasbadaha 7fcd55f3ec Fix Issue:#47076 onyx_l2_interface parameter trunk_allowed_vlans tries to remove all existing vlans on a port (#49418)
Signed-off-by: Anas Badaha <anasb@mellanox.com>
2018-12-03 10:39:39 +05:30
ftntcorecse b4ce4e1571 Fortinet FortiManager Device Group Module (#46086)
* fmgr_device_group PR candidate

* fgmr_device_group PR candidate

* PR candidate

* PR candidate

* Fixing Edits.

* Fixing Edits.

* Fixing Authors

* Removed State Parameter and replaced with Mode, per request of justjais
2018-11-30 15:54:41 +05:30
rajaspachipulusu17 fe147289b7 Pluribus Networks pn access list module (#49176)
* Pluribus Networks pn access list module
* Added shlex import which was missing and added correct author
* Added an extra space which is according to pep8
2018-11-30 12:40:43 +05:30
Paul Neumann a914f494a8 ios_facts: Gather CDP neighbor data (#49129)
* ios_facts: Gather CDP neighbor data

* ios_facts: Create tests for ansible_net_neighbors
2018-11-29 14:05:17 -05:00
Amy Buck 392a12589e Update dellos10_command.py (#48167)
<!--- Your description here -->

Updated Dell OS10 to Dell EMC OS10
2018-11-29 10:29:15 -05:00
Olivier BLIN c51407c806 Fix nxos modules idempotence issue (#46437)
* nxos_interface vlan and port-channel idempotence fix for mtu

* Fix MTU reconfiguration at each execution

* nxos_interface port-channel idempotence fix for mode (#44248)

* Fix trunk mode idempotence for port-channel
* Gather ethernet and port-channel code for mode management

* nxos_linkagg port-channel idempotence fix for channel-group's mode

The regex to retrieve channel-group's mode is not enough accurate.
Therefore, the swhitchport mode  was matched instead of the
channel-group's mode.

* This fix add accuracy to match the right configuration command

* Add support for switchport mode dot1q-tunnel in nxos_interface

* Fix layer reconfiguration at each execution
2018-11-29 10:23:51 +05:30
Mike Wiebe af1e6878e9 Fix n3k power supply facts (#49150) 2018-11-29 09:29:21 +05:30
Sandra McCann 13a6b4a856 Gather subset fix (#49264)
*  reword subset description for ios_facts
2018-11-28 15:33:16 -06:00
Anil Kumar Muraleedharan 7a81d859c5 Refactoring cnos_vlan in line with ios, eos etc. (#48924)
* Refactoring cnos_vlan in line with ios, eos etc.
2018-11-28 12:51:39 -05:00
Abhijeet Kasurde bc3e7bbeba
E325 Removal - Part II (#49196)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-28 13:55:52 +05:30
Sumit Jaiswal 991a9dfa12
PR to support commit check to confirm commits with JunOS (#49054)
* commit check support

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fixed review comments

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fixed review comments

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fixed shippable

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2018-11-28 11:27:46 +05:30
Mike Wiebe 374ca783bb nxos_logging message fix (#49205)
* nxos_logging message fix

* Remove rescue in block
2018-11-28 10:37:04 +05:30
Trishna Guha 8796085569
nxos_facts fix NameError (#48981)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-11-27 10:14:13 +05:30
Paul Neumann 2019f0e430 nxos_facts: Do not gather redundant neighbor data (#49024)
* nxos_facts: Remove dead code

The commit e51964e made this redundant as the structured case is handled
elsewhere.

* nxos_facts: Do not gather neighbors redundantly

LLDP reports the neighbor using the abbreviated interface name, whereas
CDP reports the neighbor using the full interface name. Normalize the
local interface name in the LLDP case, so there is no redundant
information. Due to the order of the gathering, CDP neighbors are saved
in case both LLDP and CDP data is available on a certain interface.
2018-11-23 14:43:40 +05:30
Abhijeet Kasurde 69191b10c1 Remove unused import (#48639)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-22 07:58:17 -08:00
John R Barker 75407d3e43
Validate DOCUMENTATION.author (#48993)
* Validate DOCUMENTATION.author

Ensure that author line includes a GitHub account
2018-11-21 17:29:29 +00:00
John R Barker 97e2fa4953
Bulk module author 2 (#48955)
* Bulk fix DOCUMENTATION.author (Part 2)
2018-11-21 10:32:42 +00:00
ftntcorecse fb7b6f9521 Fortinet FortiManager Device Add Module (#45954)
* fmgr_device PR candidate

* fmgr_device PR candidate

* fmgr_device PR candidate

* fmgr_device PR candidate

* fmgr_device PR candidate

* fmgr_device PR candidate

* fmgr_fwobj_address PR candidate

* Grammar

* grammar changes

* pylint changes

* Fixing Authors
2018-11-21 12:05:33 +05:30
ftntcorecse 050a2c51dd Fortinet FortiManager Device Config Module (#46080)
* fmgr_device_config PR candidate

* fmgr_fwobj_address PR candidate

* PR candidate

* Resolving Edits

* Resolving Edits

* Fixing Authors
2018-11-21 12:03:38 +05:30
ftntcorecse 1da3c5c302 Fortinet FortiManager Firewall Objects - Addresses (#46084)
* fmgr_fwobj_address PR candidate

* fmgr_fwobj_address PR candidate

* PR candidate

* PR candidate

* Adding requested changes by @samccann

* minor issue...

* minor pylint issue

* More changes from @samccann

* more grammar

* Author Mention Change

* Fixing Authors
2018-11-21 12:00:39 +05:30