Commit Graph

13881 Commits (a79386f2f5d1b38c661fbddffc1a766d2198e8e5)

Author SHA1 Message Date
Pieter Hollants c2992fbb81 zypper_repository: Prepend --gpg-auto-import-keys before refresh command (#3088)
Fixes #3086.
2016-12-08 11:34:55 -05:00
Robin Roth 48ee364950 Add documention for enabled option in zypper_repository (#3083) 2016-12-08 11:34:55 -05:00
René Moser d2eeabf129 slack: fix handling of html entities and escaping (#3032)
for < > & ' and "
2016-12-08 11:34:55 -05:00
Jonathan Mainguy d4b94ec6bb fix timezone for centos6 (#3078) 2016-12-08 11:34:55 -05:00
John R Barker 66eaa464ee Typos in doc's strings (#3071) 2016-12-08 11:34:55 -05:00
Toshio Kuratomi d52fc0f8a6 Update shippable config (#3063) 2016-12-08 11:34:55 -05:00
THEBAULT Julien bfb1ad6690 Fix mongodb user compatibility check (#2731)
- Check the compatibility asap
2016-12-08 11:34:55 -05:00
Bryan Hundven 50092ed629 Fix the comment in the example. (#3050)
Fix the typo: `Crate` -> `Create`. Make a complete sentence.

Signed-off-by: Bryan Hundven <bryanhundven@gmail.com>
2016-12-08 11:34:55 -05:00
Ryan Brown cdd874e61d Fix owner on gce_img 2016-12-08 11:34:55 -05:00
Rob 20cfe15e56 If parameters for policy, tags or versioning are not supplied, do not change the existing values defined for the bucket (#2938) 2016-12-08 11:34:55 -05:00
John R Barker 3a3612f57b asa_template is now deprecated (#2992)
* asa_template is now deprecated

* Delete asa_template

Since asa_template was added during 2.2 development, rather than
deprecate them
2016-12-08 11:34:55 -05:00
John R Barker 94bd3a70e5 Correct typos (#3055) 2016-12-08 11:34:55 -05:00
Ondra Machacek 7f51ec8bab ovirt_vms: wait for VM to be created for states stopped/suspended (#3044) 2016-12-08 11:34:55 -05:00
Thierno IB. BARRY c0cfd1db45 elasticsearch_plugin: rewrite module to not use unsupported parameters (#2839)
* elasticsearch_plugin: rewrite module to not use unsupported parameters (#1785)

Avoid using parameters when they are not needed (#1785)

* elasticsearch_plugin: add version only during plugin installation and parse plugin name for its removal

* elasticsearch_plugin: join command args before running it
2016-12-08 11:34:55 -05:00
Tim Rupp 781dd9c459 Distinguish between untagged and tagged vlans
We were incorrectly making VLANS always be untagged when they could
be either tagged or untagged. This change corrects the arguments to
the vlan module to allow for specifying either untagged or tagged
interfaces. The arguments are mutually exclusive
2016-12-08 11:34:55 -05:00
Michael Scherer 9ec65db778 Use 'path' type for file arguments 2016-12-08 11:34:55 -05:00
Michael Scherer c8bfab9c08 Add missing deps, since we use openssl to verify the date 2016-12-08 11:34:54 -05:00
Ryan Saunders b48e1e9b65 Fix documentation typos and broken URL (#3039) 2016-12-08 11:34:54 -05:00
René Moser 91277fc0c7 twilio: fix false negative failure - sms was sent successfully (#3033) 2016-12-08 11:34:54 -05:00
Lujeni e226211c5b Fix mongodb_user ssl_cert_reqs param (#2963) (#2965) 2016-12-08 11:34:54 -05:00
Michael Scherer ead83cd148 Fix error in description of acme_directory (#3034) 2016-12-08 11:34:54 -05:00
Matt Clay 10ac3ba617 Revert "Set PRIVILEGED=true for Linux integration tests. (#3031)"
This reverts commit 7df7b52a5e4ce876910aaa61bc75d5e66d16adb6.
2016-12-08 11:34:54 -05:00
steve-dave 587636b525 ec2_win_password.py - handle missing or unparseable key file more intuitively (#2729) 2016-12-08 11:34:54 -05:00
shane-walker f108f8ef72 Fixes #1375, will check for new and outdated packages when running. (#3020) 2016-12-08 11:34:54 -05:00
Matt Clay eedca027ee Set PRIVILEGED=true for Linux integration tests. (#3031)
This should allow test_mount tests to run on Shippable.
2016-12-08 11:34:54 -05:00
Matt Clay 841ec9ef1b Fix handling of ansible-doc errors. (#3030) 2016-12-08 11:34:54 -05:00
Lujeni 477d174fbc Fix mongodb_user default role value when update_password is set (#2997) 2016-12-08 11:34:54 -05:00
jctanner 981d1d3f96 vmware_guest: set the cpu and memory settings on clone (#3027)
Fixes #3026
2016-12-08 11:34:54 -05:00
Ryan S. Brown bdec3a7cbb Fix ec2_asg_facts when `name` parameter is None
Closes #3021
2016-12-08 11:34:54 -05:00
Tim Rupp 15df1c84ad Fixes the bigip_selfip module to respect traffic groups (#3009)
The code for traffic groups was not being tested and therefore
had errors associated with it. It is now covered in coverage tests
and bugs that were found in it have been fixed.

See this issue for details
https://github.com/F5Networks/f5-ansible/issues/28
2016-12-08 11:34:54 -05:00
nitzmahone 4ff086c1a8 Fix win_chocolatey version comparison
fixes #2995
2016-12-08 11:34:54 -05:00
Matt Clay b2b3d99839 Add shellcheck to sanity checks. (#3013)
Also disable deprecation warnings during module validation.
2016-12-08 11:34:54 -05:00
Tim Rupp 5abc8a1927 Corrects an implied map() usage as list (#3010)
In the six package, the map() function returns an iterator instead
of a list. This code was continuing to use the map() return value
as if it were a list and this broke the address_class facts.

This patch changes the code to use the list() method on the return
value of map().
2016-12-08 11:34:53 -05:00
Tom Melendez fd92b66332 Change 'values' to 'record_data' for gcdns module. (#3003)
Using values caused problems while creating an integration playbook as it is a reserved word.  Seeing as this module is not yet released, it's prudent to make this change now.  'record_data' is more descriptive and uses the _data convention that we've established for instances.

No functionality in the module has changed.
2016-12-08 11:34:53 -05:00
Ondra Machacek e7afabf060 Fix example in ovirt_auth module (#3001)
This patch fix missing quotes in ovirt_auth revoke token example
2016-12-08 11:34:53 -05:00
Robin Roth a9cd8abb75 List python-xml in requirements for zypper* (#2937) 2016-12-08 11:34:53 -05:00
René Moser 59e6203a17 composer: update docs about issues on macOS if installed by homebrew (#2987) 2016-12-08 11:34:53 -05:00
Ondra Machacek 999a6488cf Ovirt auth/vms/disks modules (#2836)
* Add oVirt module to manage VMs

This patch add oVirt module to manage Virtual Machines

* Add oVirt module to manage authentication

This patch add oVirt module to manage authentication

* Add oVirt module to manage disks

* Added VM state management and fixups
2016-12-08 11:34:53 -05:00
perbly ec05027c7e added enabled vlan functionality for f5 vip (#2988)
* added vlan functionality for f5 vip

* line 91, : was missing after description
2016-12-08 11:34:53 -05:00
Matt Clay 2152291960 Remove script previously used by Travis. 2016-12-08 11:34:53 -05:00
Lujeni aa6aedf26c Improve mongodb_user exception (#2962)
- Better error message
2016-12-08 11:34:53 -05:00
Matt Clay 46d0b4dc16 Test module docs on Shippable. (#2976) 2016-12-08 11:34:53 -05:00
Matt Clay 5d78239f07 Combined notes to avoid duplicate key warning. (#2980) 2016-12-08 11:34:53 -05:00
Rob e07c71dd99 Modification of describe_gateways key so that it is consistent with w… (#2936)
* Modification of describe_gateways key so that it is consistent with what create_gateway returns.
Also added AnsibleModule spec to require bgp_ip on state=present as defined in the doc

* Don't remove CustomerGateways key to preserve backward compatibility
2016-12-08 11:34:53 -05:00
jctanner 4cb3e87ca4 vmware_guest: do not assume disk params contain a datastore (#2974)
* vmware_guest: do not assume disk params contain a datastore
* Fix missed line during connection refactor
2016-12-08 11:34:53 -05:00
Matt Clay f3e2f5d002 Remove Travis config since we only use Shippable. (#2975) 2016-12-08 11:34:53 -05:00
Matt Clay a88dae905d Enable python 3 sanity tests for more modules. (#2973) 2016-12-08 11:34:52 -05:00
Michael Scherer 5f0017d99d Remove duplicate key from the doc (#2970) 2016-12-08 11:34:52 -05:00
Michael Scherer 6b5b90c4b8 Merge duplicated notes, fix warning returned by ansible-doc (#2969) 2016-12-08 11:34:52 -05:00
Adrian Likins f4943bcf4c Fix 'netapp_e_lun_mapping ... documentation error' (#2966)
The 'short_description' in netapp_e_lun_mapping was a
list instead of txt.

This fixes errors on 'ansible-doc -l' of form:

        ERROR! module netapp_e_lun_mapping has a documentation
        error formatting or is missing documentation

Fixes: #17634 (ansible/ansible)
2016-12-08 11:34:52 -05:00
Adrian Likins 50dcce185f Remove redundant doc keys for netapp_e_ modules (#2968)
Fixes #2967
2016-12-08 11:34:52 -05:00
jctanner 10e50652b2 vmware_guest: small refactor (#2955)
* use connecion method from module_utils
* use resource group related to host system

Addresses #2911
2016-12-08 11:34:52 -05:00
Michael Scherer 1702937ab3 Do not import xenapi without checking, so we can avoid (#1953)
backtrace
2016-12-08 11:34:52 -05:00
Michael Scherer 6967a32ce4 Fix the mysql_replication argument (#2111)
Login_password and master_password are password, should not
be logged. And config_file is a path t be expanded, so tagged as
such.
2016-12-08 11:34:52 -05:00
Hans-Joachim Kliemeck 443dba148c Fix mongodb user idempotence with 2.4 version (#2725) (#2920) 2016-12-08 11:34:52 -05:00
Alexandre Garnier f06e2e7a0b Fix mixed type comparison resulting in wrong `changed` (#2772)
When using `use_max` or `use_min` in `pam_limits`, the new value is an integer compared with the actual_value which is a string, so they are always different and the module reports a changed but none occurred.
2016-12-08 11:34:52 -05:00
Matt Clay 839adc208f Update CI badge. 2016-12-08 11:34:52 -05:00
Matt Clay d1ba765ba0 Cosmetic fix to test PR and merge hooks. (#2949) 2016-12-08 11:34:52 -05:00
Matt Clay 3e86ad1a3a Run same tests on Shippable as on Travis. (#2948)
Run the same tests as used on Travis.
2016-12-08 11:34:52 -05:00
Ryan S. Brown dc6fd4ee8a Add lambda_event module 2016-12-08 11:34:52 -05:00
Ryan Sydnor 3c6ae0063b Add Amazon Elastic File System Facts (efs_facts) module
Also switch EFS module to using boto3_conn from boto3.Session
2016-12-08 11:34:52 -05:00
Ryan Sydnor dfec3d3c4c Add Amazon Elastic File System (efs) module 2016-12-08 11:34:51 -05:00
Ryan Brown d92c3c6fa8 Import Lambda alias module from https://github.com/pjodouin/ansible-lambda (#2829) 2016-12-08 11:34:51 -05:00
Ryan S. Brown ce72e52c50 Fix redshift module Python 3.5 syntax 2016-12-08 11:34:51 -05:00
Ryan Brown 559093f1a3 Fix exception syntax for Python 3.x (#2940)
since boto already precludes python2.4, no need to use a common 2.4/3 syntax
2016-12-08 11:34:51 -05:00
Steyn Huizinga 4240d2a511 Add AWS Lambda module (#1270) 2016-12-08 11:34:51 -05:00
Jim Dalton cee898f73a Add module for managing CloudWatch Event rules and targets (#2101) 2016-12-08 11:34:51 -05:00
Jens Carl 9f2b1abbc3 New ansible module for aws Redshift and Redshift subnet group (#185) 2016-12-08 11:34:51 -05:00
Adrian Likins 68823a4e2d Add modules for NetApp SANtricity storage platform (#2929)
The modules prefixed with netapp_e* are built to support the
SANtricity storage platform.

The modules provide idempotent provisioning for volume groups, disk
pools, standard volumes, thin volumes, LUN mapping, hosts, host groups
(clusters), volume snapshots, consistency groups, and asynchronous
mirroring.

They require the SANtricity WebServices Proxy.
The WebServices Proxy is free software available at
the NetApp Software Download site:

   http://mysupport.netapp.com/NOW/download/software/eseries_webservices/1.40.X000.0009/

Starting with the E2800 platform (11.30 OS), the modules will work
directly with the storage array.  Starting with this platform, REST API
requests are handled directly on the box.  This array can still be
managed by proxy for large scale deployments.
2016-12-08 11:34:51 -05:00
jctanner 3dedecd81e vmware_guest improve and fix some of the errors (#2926)
* Add more comments and fix issue with unit conversion
2016-12-08 11:34:51 -05:00
Marcin Kawa dde76066d3 Fix undefined info error and accept HTTP 201 response code (#2643)
Prevent referenced before assignment error when `notify` argument is not specified and accept HTTP 201 (created) code.
2016-12-08 11:34:51 -05:00
jctanner d9b5d9e551 vmware_guest: use the disk argument to modify disk size and type (#2918)
Fixes #2706
2016-12-08 11:34:51 -05:00
Rene Moser bbf60e36eb zabbix_host: fix typos in arg spec of login_user
Credits to @JasonCormie
2016-12-08 11:34:51 -05:00
Ryan Brown dae2daf692 New module: `lambda_facts` (#2874) 2016-12-08 11:34:51 -05:00
David Stygstra 3539238ec7 Use `modprobe -r` instead of `rmmod` in modprobe module (#2669)
If any modules that the module being removed depends on are unused, they
will also be removed. Fixes #2140.
2016-12-08 11:34:51 -05:00
Michael Grüner 3dd0752746 letsencrypt: Improve error handling (#2868)
* letsencrypt: improve error handling

Use the new "body" field of the info dict in case of a HTTPError.

* letsencrypt: HTTP 202 is a valid status while polling
2016-12-08 11:34:51 -05:00
Steve Gargan b57b74e40b remove duration from lock delay as seconds are the only granularity supported. (#2877)
add utf header to file so that it loads correctly
2016-12-08 11:34:51 -05:00
René Moser c203283889 jenkins_job fix: NameError: global name 'module' is not defined (#2910) 2016-12-08 11:34:50 -05:00
Tim Rupp 4e8566739e Fixes domains method not defined (#2907)
The domains method was not defined, and therefore when specifying
a parent domain during route domain creation, the process would
fail.

Tests have been added to detect this going forward
2016-12-08 11:34:50 -05:00
jctanner b6fd074bd0 vmware_guest implement clonevm for multi-dc environments (#2909)
* Fix bug in processing of null return
* Fix multi-dc folder location by enhancing the foldermap and using it to search
* Remove unused functions
* Refactor finding vm by folder

Fixes #2900
2016-12-08 11:34:50 -05:00
Cougar 7dbdadb396 vmware_guest Fix: remove 'nic' and 'disk' requirements for facts (#2844) 2016-12-08 11:34:50 -05:00
Benjamin Doherty ac72df08dd Updates to `archive` module based on code review (#2699)
* Use common file arguments on destination file
* Rename 'compression' to 'format' h/t @abadger
* Add support for plain 'tar' format
* Ensure check_mode is respected
2016-12-08 11:34:50 -05:00
Peter Sprygada 4932df69bc updates to asa_config module for Ansible 2.2
* clean up functions and remove unneeded code
* config difference now includes keyword argument
* module reports changed when save argument is yes with or without check_mode
* updated fail_json return with exc kwargs
* fixed up import statements
2016-12-08 11:34:50 -05:00
Peter Sprygada dc52d3627a fixes a number of nagging issues in asa_acl due to refactoring
* fixes issues with import error
* removes need for filter attribute in Cli instance
* now filters config either from device or provided via config argument

ref: #2890
2016-12-08 11:34:50 -05:00
Rene Moser edb24dac2d jenkins_job: refactoring 2016-12-08 11:34:50 -05:00
Rene Moser 3c04ed977d jenkins_job: implement diff support 2016-12-08 11:34:50 -05:00
Rene Moser 171b71cfa0 jenkins_job: rename enable to enabled and mutually exclusive with config
Jenkins stores the information about the state (disabled/enabled) in the config, which result in a race condition between `config` and `enabled` and we loose idempotency. It makes sense to define them mutually exclusive.

Renamed `enable` to `enabled`. Ansible uses the name `enabled` in many modules, e.g. service as it indicates a state not an action.
2016-12-08 11:34:50 -05:00
Rene Moser bd4c935fd7 jenkins_job: default state to present 2016-12-08 11:34:50 -05:00
Will Thames 3eeda4f844 firewalld should fail nicely when service is stopped (#2871)
Ensure the HAVE_FIREWALLD checks check only for the
presence of the python dependencies, and not the age
of the library or the state of the service, which
are checked later.
2016-12-08 11:34:50 -05:00
Peter Sprygada 7ce98f52cf bug fix in asa_acl module for missing candidate config
This bug was introduced accidentally when refactoring to 2.2.  The instance
of the candidate config was deleted.  This adds the candidate config
instance back

fixes #2890
2016-12-08 11:34:50 -05:00
Tobias Wolf 62575fdf48 Fix one character typo in my previous PR for debconf module (#2899)
Small oops in the previous PR #2530 commit.

Instead of `diff_dict` it slipped through as `diffdict`.

Please merge and sorry.
2016-12-08 11:34:50 -05:00
Alex e2795d1401 Start zypper in non-interactive mode (#2854) 2016-12-08 11:34:50 -05:00
sgujic d34f3b4c05 Create temporary file in a secure manner. (#2887) 2016-12-08 11:34:49 -05:00
Nils Pascal Illenseer acadc2ac9c Delete lxd container in state stopped (#2885)
If a lxd container is stopped, do not stop it before deleting it.
2016-12-08 11:34:49 -05:00
Gilles Gagniard 05c8630b48 GCE : Fix image family handling with libcloud > 0.20.1 (#2289)
* fix image family handling with libcloud > 0.20.1

* add missing import
2016-12-08 11:34:49 -05:00
Robyn Bergeron 7c27f57052 Updating GUIDELINES.md
Updating info on how issues are routed via bot.
2016-12-08 11:34:49 -05:00
Greg DeKoenigsberg 39c1c14a08 Update MAINTAINERS.md
We could have deleted this, but just in case there are links to it from elsewhere, providing a redirect to the now authoritative GUIDELINES.md.
2016-12-08 11:34:49 -05:00
Greg DeKoenigsberg 41d7066a58 Point to GUIDELINES.md 2016-12-08 11:34:49 -05:00
johanwiren e98eb785df Fix share aliases logic (#2862) (#2875)
Fixes #2862
2016-12-08 11:34:49 -05:00
John R Barker 3f1c3a0532 Document a10_server new options (#2876)
* Document write_config and validate_certs
2016-12-08 11:34:49 -05:00
Steve Gargan 7cd3da9b58 correctly iterate and return results of any service checks. (#2878)
current implementation was breaking making the module unusable, changing to the list comprehension fixes this. Also default to seconds instead of throwing a exception when no duration units are supplied as this causes tests to fail
2016-12-08 11:34:49 -05:00
Matt Clay d00e941a0e Remove stderr=False from calls to exit_json. (#2879) 2016-12-08 11:34:49 -05:00
Tim Rupp 7e36f4f302 Adds bigip_ssl_certificate module (#2831)
Adds bigip_ssl_certificate module

This module is another in the ongoing "bootstrapping saga" that is
being undertaken. With this module you can manage the lifecycle of
the SSL certificates on a BIG-IP. This includes those used for
SSL offloading.

Tests for this module can be found here

https://github.com/F5Networks/f5-ansible/blob/master/roles/__bigip_ssl_certificate/tasks/main.yaml

Platforms this was tested on are

12.0.0
12.1.0
2016-12-08 11:34:49 -05:00
Ryan S. Brown a96261a391 Normalize variable naming in cloudformation_facts module using camel2snake 2016-12-08 11:34:49 -05:00
Ryan S. Brown 215a591771 cloudformation_facts: Connect boto3 using the module_utils AWS connection instead of calling boto3 directly 2016-12-08 11:34:49 -05:00
jmenga 0d6073aa47 New module cloudformation_facts (#2329) 2016-12-08 11:34:49 -05:00
Michael Scherer f8b7ab1e10 Do not crash if the system do not have required modules (#2852) 2016-12-08 11:34:49 -05:00
Tobias Wolf e969010cf9 Add diff mode output to debconf module (#2530)
Support diff such that the previous and current settings are visible
without debug output and just with `--diff` if requested.
2016-12-08 11:34:49 -05:00
sermilrod 03b1844150 adding jenkins_job module (#2521) 2016-12-08 11:34:48 -05:00
Werner Dijkerman 800e1c7bc0 Added new module opendj_backendprop for updating backend settings opendj (#2855)
Add opendj_backendprop
2016-12-08 11:34:48 -05:00
Peter Sprygada 32bbddee23 update asa_config module
* removes get_module() factory method for NetworkModule
* add src argument to provide path to config file
* add new choice to match used to ignore current running config
* add update argument with choices merge or check
* add backup argument to backup current running config to control host
* add defaults argument to control collection of config with or withoutdefaults
* add save argument to save current running config to startup config
2016-12-08 11:34:48 -05:00
Peter Sprygada e2e0029fab roll up of updates to asa_template
This updates the asa_template module with updates for Ansible 2.2.

* removes get_module() in favor of NetworkModule
* fixes up import statements
2016-12-08 11:34:48 -05:00
Peter Sprygada 283cc51fdb added new functionality to asa_command
* commands argument now accepts a dict arguments
* only show commands are allowd when check mode is specified
* config mode is no longer allowed in the command stack
* add argument match with valid values any, all
2016-12-08 11:34:48 -05:00
Peter Sprygada 8e45ec9734 roll up updates to asa_acl module
* remove get_module() in favor of NetworkModule
* fix up import statements
* roll up fixes for NetworkConfig object handling
2016-12-08 11:34:48 -05:00
Filipe Niero Felisbino 9ba2f0f266 Fix attachment issue ( thanks @gunzy83 ) 2016-12-08 11:34:48 -05:00
Filipe Niero Felisbino f4ace1e9cc Change attached parameter default to None 2016-12-08 11:34:48 -05:00
Filipe Niero Felisbino f41900920f Add "version_added" to attached attribute 2016-12-08 11:34:48 -05:00
Filipe Niero Felisbino 1c1a17bfd2 Add attached parameter to ec2_eni module 2016-12-08 11:34:48 -05:00
Filipe Niero Felisbino 94d03b6b55 Add RETURN docs 2016-12-08 11:34:48 -05:00
Filipe Niero Felisbino 7ae8693bda Fix docs 2016-12-08 11:34:48 -05:00
Filipe Niero Felisbino f8314c3e61 Fix the AMI creation/modification logic thus making it idempotent 2016-12-08 11:34:48 -05:00
Thierno IB. BARRY bc55db2ff0 elasticsearch_plugin: Fix bug when using proxy (#2603) (#2838) 2016-12-08 11:34:48 -05:00
Nadir 5de3dbbf6d Added redrive policy options (#2245) 2016-12-08 11:34:47 -05:00
Robin Roth 6c9c4e7482 Zypper repo autoimport keys (#2132)
* zypper_repository add auto_import_keys options

* also give more output on failure (rc, stdout, stderr)

* be more specific in the doc for auto_import_keys

* add runrefresh option to zypper_repository

* this comes out of ansible/ansible-modules-extras#2411, where AnderEnder adds refresh to the zypper module
* adds a way to force zypper to refresh a repository
* can be used to refresh independently of auto_import_keys
* add option to run name=* runrefresh=yes
* name runrefresh to not break existing use to refresh (now alias to autorefresh)
* add version_added flag to autorefresh

* remove wrong version_added comment
2016-12-08 11:34:47 -05:00
EarlAbides 961c076e72 Fix ec2_asg_facts module when using name parameter (#2840) (#2841) 2016-12-08 11:34:47 -05:00
Tim Rupp f48791e8bc Bugfix bigip_facts that was trying to check the length of an iterator (#2842)
Recently, a user reported that the bigip_facts module was failing with the error

    received exception: object of type 'itertools.imap' has no len()

This reported was occurring at line 1657 of the bigip_facts module

bug report is here

https://github.com/F5Networks/f5-ansible/issues/25

Upon further investigation, the map function for returning the specified
includes was returning an iterator, and calling len() on an iterator does
not work.

I believe this problem was caused by part of the Python 3.x effort insofar
as the inclusion of this line

https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/basic.py#L143

seems to affect our usage of map(), probably for the better anyway, and we need
to change our expectations in our module's code to no longer assume a list, but
instead assume an iterator.

After trawling through the module_utils/basic code, I think a list
comprehension is more appropriate here anyway, so I'm changing it to be
that. The affected user reported it works this way, and my own testing
on 2.2.0 supports that.
2016-12-08 11:34:47 -05:00
Kevin Hulquest e47a5674fb Add facts and storage system modules. (#2748)
* Add facts and storage system modules.

* Update version metadata.

* Add facts and storage system modules.

Update version metadata.

Add init files.

* Fixes for review comments.

* Fixes for review comments.

* Update document fragments for api_* options to indicate they are required.

* Correct bad string concatenation.

* Add option description for validate_certs since basic_auth arg_spec is no longer extended.

* Add default value for validate_certs in docstring.

* Rename directory name so it applies to netapp and not simply eseries platform.

* Rename modules to differentiate other netapp modules.
2016-12-08 11:34:47 -05:00
Robin Roth fb49e0401e Ensure the return value for changed is bool (#2830)
fixes #2827
2016-12-08 11:34:47 -05:00
Michael Grandjean 70e8bb3092 Fix typo in EXAMPLE section (#2833) 2016-12-08 11:34:47 -05:00
John R Barker b7afa14f64 Minor tidyup (#2828) 2016-12-08 11:34:47 -05:00
Matt Clay 7e3af74fae Add python3 testing for module PRs. (#2825) 2016-12-08 11:34:47 -05:00
Ryan Brown 2858d24acb New module: execute_lambda (AWS) (#2558)
First version of execute_lambda module

Supports:
- Synchronous or asynchronous invocation
- Tailing log of execution (sync execution only)
- check mode
2016-12-08 11:34:47 -05:00
Monty Taylor 510e1140ce Error if shade is too old for domain_id on os_project (#2806)
* Error if shade is too old for domain_id on os_project

os_project's domain_id parameter requires shade >= 1.8.1 to work. Be
explicit.

Fixes #2805 os_project requires python-shade 1.8.1 or higher

* What I really meant was 1.8.0
2016-12-08 11:34:47 -05:00
Matt Martz 91abacfca7 Make sure we don't catch rc=0 as a timeout (#2823) 2016-12-08 11:34:47 -05:00
Toshio Kuratomi 3cb7e4bd0e Style cleanups:
* Don't use iterkeys
* Don't use wildcard imports
2016-12-08 11:34:47 -05:00
Michael Scherer b255ac4ea6 Use six for iteration, to make it run on python3 (#2800) 2016-12-08 11:34:47 -05:00
Tim Rupp acdbe5cb3f Adds allow_service parameter to bigip_selfip (#2808)
This parameter can be used to open up access to (among other things)
the mgmt address of a BIG-IP. It is necessary for configuring bigips
in an HA configuration.
2016-12-08 11:34:47 -05:00
Tobias Rueetschi c0ad8b030e udm_user: change overridePWHistory and overridePWLength to snake_case 2016-12-08 11:34:47 -05:00
Tobias Rueetschi e4dd122ab7 univention udm_user: override password history. 2016-12-08 11:34:46 -05:00
Tobias Rueetschi 10a2eb9304 udm_user: change code to fit documentation with snake_case instead of camelCase 2016-12-08 11:34:46 -05:00
Tobias Rueetschi 34445d515d udm_user: change camelCase to snake_case in documentation 2016-12-08 11:34:46 -05:00
Tobias Rueetschi 3d563324dd univention udm_user: pep8 2016-12-08 11:34:46 -05:00
Tobias Rueetschi 661cf5d5ea univention udm_share: add aliases as documented 2016-12-08 11:34:46 -05:00
Tobias Rueetschi 3709fb651d univention udm_share: change documentation, use camel_case for parameters, old parameter names as alias 2016-12-08 11:34:46 -05:00
Tobias Rueetschi de34fdf681 univention udm_share: pep8 2016-12-08 11:34:46 -05:00
Tobias Rueetschi 8eb496989e univention udm_share: add example 2016-12-08 11:34:46 -05:00
Tobias Rueetschi ea72534151 univention udm_share: change some parameters to type bool 2016-12-08 11:34:46 -05:00
Tobias Rueetschi 1cc3afdbdd univention udm_share: reorder documentation parameters 2016-12-08 11:34:46 -05:00
Tobias Rueetschi 7dd96079f0 univention udm_share: add documenation 2016-12-08 11:34:46 -05:00
Tobias Rueetschi db4aca4621 univention udm_share: import only AnsibleModule from ansible.module_utils.basic 2016-12-08 11:34:46 -05:00
Tobias Rueetschi 6e4da8987e univention udm_share: add license information 2016-12-08 11:34:46 -05:00
Tobias Rueetschi b38979321d univention udm_share: add required_if to the API 2016-12-08 11:34:46 -05:00
Tobias Rueetschi bba8cdf0af univention udm_share: fix shebang 2016-12-08 11:34:46 -05:00
Tobias Rueetschi afccc72d41 univention udm_share: adapt to library univention_umc 2016-12-08 11:34:46 -05:00
Tobias Rüetschi a973d8e9c4 UCS udm_share: fix creating of new shares 2016-12-08 11:34:45 -05:00
Tobias Rüetschi 66380d6b7f UCS udm_share: added 2016-12-08 11:34:45 -05:00
Ethan Devenport dcd7544b26 Added parameter choices for bus. 2016-12-08 11:34:45 -05:00
Ethan Devenport 403c1ddf7b Set variable types, defined choices, and cleaned up whitespace. 2016-12-08 11:34:45 -05:00
Ethan Devenport f9e0830b44 Reverting recent commits back to initial PR and will move the new profitbricks_firewall_rule module and other recent changes to a new branch.
Revert "Added support for firewall rules, consolidated resource UUID retrieval methods for server and NIC modules, and set LAN type to int."

This reverts commit 464cbb89f225578386a830624633a55e39054544.
2016-12-08 11:34:45 -05:00
Ethan Devenport e1960d2488 Added RETURN documentation. 2016-12-08 11:34:45 -05:00
Ethan Devenport a3200fc98e Some further documentation updates including version. 2016-12-08 11:34:45 -05:00
Ethan Devenport 93a237f604 Minor documentation corrections. 2016-12-08 11:34:45 -05:00
Ethan Devenport 4b7a4e4495 Added support for firewall rules, consolidated resource UUID retrieval methods for server and NIC modules, and set LAN type to int. 2016-12-08 11:34:45 -05:00
Ethan Devenport e2c8fec8d9 Included version_added for new options. 2016-12-08 11:34:45 -05:00
Ethan Devenport 267052d7a5 Removed us/lasdev datacenter which the cloud provider no longer maintains. 2016-12-08 11:34:45 -05:00
Ethan Devenport 6d8e3eac7b Additional provider features added and fixed some bugs. * Added support for SSH keys, image passwords, SSD disk type, and CPU family. * Adjusted server create so that IP address is returned in response. * Restructured remove server method(s) to handle change status properly, gracefully handle missing servers, and improve overall performance. * Prevent duplicate server names from being provisioned so removals can be handled appropriately. * Fixed a bug in the count increment being a string rather than an integer. * Fixed issue with create_volume returning invalid response. * Fixed type bug in volume instance_ids for volume removal and improved volume management. * Fixed type bug in instance_ids for proper server removal and moved boot volume creation into composite server build request. * General clean up. 2016-12-08 11:34:45 -05:00
Wong Hoi Sing Edison d9a1b04e40 Fix ansible/ansible-modules-extras#1682: add dispersed volume support for gluster_volume (#2708) 2016-12-08 11:34:45 -05:00
afunix 32574aa358 gluster_volume module parses out additional hostnames provided by "gluster peer status" command [#1405] (#2811) 2016-12-08 11:34:45 -05:00
René Moser 4017be741a ec2_vpc_dhcp_options_facts: fix exception handling, fixes build (#2819) 2016-12-08 11:34:45 -05:00
Fabio Alessandro Locati 4af6033469 Require domain in rocketchat (#2803)
* Set the domain as required

* Add domain in the examples as well
2016-12-08 11:34:44 -05:00
Joe Smith 09776a9e52 Set explicit type for timeout (#2809)
vmware_maintenancemode.py needs explicit type for timeout, otherwise it reads timeout as string and breaks.
2016-12-08 11:34:44 -05:00
John R Barker abaf6afc0a ec2_vpc_dhcp_options_facts.py no py3
Old PR was merged that hadn't been updated since we added the py3 checks
2016-12-08 11:34:44 -05:00
Tobias Rüetschi e318c9b008 Feature udm dns zone (#2382)
* UCS udm_dns_zone: added

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_dns_zone: updated, add supports check mode

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_dns_zone: updated, add support to modify dns zones

* UCS udm_dns_zone: change string formating

* UCS udm_dns_zone: add a function to convert the time to the biggest unit

* UCS udm_dns_zone: add type definitions to the argument specification

* UCS udm_dns_zone: update function convert_time

* UCS udm_dns_zone: only modify object if it has changed

* UCS udm_dns_zone: add documentation

* UCS udm_dns_zone: fix checks

* UCS udm_dns_zone: if dns zone not exists, changed is always true

* UCS udm_dns_zone: documentation, add version_added

* UCS udm_dns_zone: add license and fix travis for python 3

* UCS udm_dns_zone: import common code for univention from ansible.module_utils.univention

* univention udm_dns_zone: adapt to library univention_umc

* univention udm_dns_zone: lint

* univention udm_dns_zone: add requirement python >= 2.6 to documentation

* univention udm_dns_zone: dont import time, its unused
2016-12-08 11:34:44 -05:00
Adam Števko d56c34ea9e Add modules to configure Solaris/illumos networking (1st batch) (#2416)
* Add modules to configure Solaris/illumos networking (1st batch)

* Add choices to temporary flags
2016-12-08 11:34:44 -05:00
Olivier Boukili f43eb7c79e new module: apache2_mod_proxy (#2148)
* module apache2_mod_proxy

* Moved state notes to state description.
2016-12-08 11:34:44 -05:00
TimothyVandenbrande 0b135aa6da This is an ansible module to control/create/adapt/remove VMs on a RHEV/oVirt environment. (#2202) 2016-12-08 11:34:44 -05:00
René Moser d7b68e0e80 new modules for managing exoscale DNS (#2788) 2016-12-08 11:34:44 -05:00
Tobias Rüetschi 16464d5021 Feature udm group (#2396)
* UCS udm_group: added

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_group: updated

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_group: add key description

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* python styling

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_group: updated, add supports check mode

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_group: updated, add support to modify groups

* UCS udm_group: change string formating

* UCS udm_group: add type definitions to the argument specification

* UCS udm_group: import common code for univention from ansible.module_utils.univention

* univention udm_group: add documentation

* UCS udm_group: add requirement python >= 2.6

* univention udm_group: add more examples
2016-12-08 11:34:44 -05:00
Tobias Rüetschi 7506ea3a37 Feature udm dns record (#2394)
* UCS udm_dns: added

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_dns_record: fix multiple entries in different zones

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_dns -> udm_dns_record: renamed

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_dns_record: updated, add supports check mode

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_dns_record: updated, add support to modify dns records

* UCS udm_dns_record: change string formating

* UCS udm_dns_record: add type definitions to the argument specification

* UCS udm_dns_record: import common code for univention from ansible.module_utils.univention_umc

* UCS udm_dns_record: add documentation

* UCS udm_dns_record: update documenation

* univention udm_dns_record: pylint

* univention udm_dns_record: fix reverse zone entries
2016-12-08 11:34:44 -05:00
naslanidis cbd2025223 new AWS module for ec2 dhcp option facts (#2001)
new ec2 dhcp option facts module
2016-12-08 11:34:44 -05:00
James Higgins f7ac1f7f90 Just use netloc to identify bucket name for s3 locations (#2713) 2016-12-08 11:34:44 -05:00
René Moser 43ea275856 vmware_local_user_manager: fix global name 'module' is not defined (#2818) 2016-12-08 11:34:44 -05:00
alxsey 0bfaf34286 Implement template storage selection (#2755) 2016-12-08 11:34:44 -05:00
Mike Liu 73cf1f2755 Iptables enhancements (#2789)
* Add the flush parameter.

When specified the flush parameter indicates that this module should remove all
rules from the specified table. If no table parameter is specified then the
default filter table is flushed.

* Add support for setting chain policies.

The module supports setting the policy of a given chain and table to the
following target values, ACCEPT, DROP, QUEUE, and RETURN. This parameter ignores
all other unrelated parameters.

* Fix pep8 issues.

* Fix missing quotation.

* Make 'flush' and 'policy' parameters mutually exclusive.

This combination is not supported by the wrapped iptables command. 'flush' and
'policy' however, can both take the 'chain' argument.
2016-12-08 11:34:44 -05:00
bbooysen 41713d0819 typo fix (#2816)
Changed 'memroy' to 'memory'.
2016-12-08 11:34:43 -05:00
Tim Rupp e4ddd4358c Fixes documentation bugs in bigip_irule (#2797)
The return docs were incorrect for this module. This patch fixes them
and adds some additional return values
2016-12-08 11:34:43 -05:00
Toshio Kuratomi 53e7fee617 We've decided that python-3.5 is our minimum pyhton3 version (#2798) 2016-12-08 11:34:43 -05:00
Tobias Rüetschi 3d1474bbd1 Feature udm user (#2406)
* Creating directory univention

* UCS udm_user: added

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_user: updating, added support to modify user groups

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_user: add key homedrive

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_user: add key userexpiry

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* python styling

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_user: updated, add supports check mode

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_user: updated, add support to modify users

* UCS udm_user: change string formating

* UCS udm_user: add type definitions to the argument specification

* UCS udm_user: only modify object if it has changed

* UCS udm_user: if user not exists, changed is always true

* UCS udm_user: import common code for univention from ansible.module_utils.univention_umc

* UCS udm_user: add a lot more attributes

* UCS udm_user: add license information

* UCS udm_user: fix API serviceprovider and unixhome

* UCS udm_user: add documentation

* univention udm_user: import only AnsibleModule from ansible.module_utils.basic

* univention udm_user: reorder documentation options

* univention udm_user: fix documentation

* univention udm_user: dont log password

* univention udm_user: add more examples
2016-12-08 11:34:43 -05:00
Massimo Gervasini c934ab7e8b when write_config is no, we should not try to write any configuration changes 2016-12-08 11:34:43 -05:00
Toshio Kuratomi 66af5335c2 Moved the atomic modules to cloud/atomic. (#2784)
Similar category to docker and lxd
2016-12-08 11:34:43 -05:00
Tim Rupp 97d41d54ab Adds provision info to bigip facts (#2783)
This patch adds provision information to the bigip_facts module
through a "provision" include.
2016-12-08 11:34:43 -05:00
Russell Teague 150a044728 Fix vmware_dvs_portgroup destroy task (#2776)
Fixes #2761
2016-12-08 11:34:43 -05:00
Manuel Sousa 73c39c3aaf rabbitmq_queue - Update requirements to show minimum version of requests (#2786) 2016-12-08 11:34:43 -05:00
Manuel Sousa d4d83fea2c rabbitmq_binding - Update requirements to show minimum version of requests (#2787) 2016-12-08 11:34:43 -05:00
Manuel Sousa f7c732ad34 rabbitmq_exchange - Update requirements to show minimum version of requests (#2785) 2016-12-08 11:34:43 -05:00
Lingxian Kong 0446db9afd Add openstack os_server_group module (#2702) 2016-12-08 11:34:43 -05:00
Tim Rupp e5f629500d New module bigip_irule
This module can be used to maintain the iRules for both LTM and GTM
on a BIG-IP. iRules should be supplied in their string form using
normal strings (unlikely), file lookups (likely), or template
lookups (likely).

Tests for this module can be found here

https://github.com/F5Networks/f5-ansible/blob/master/roles/__bigip_irule/tasks/main.yaml

Platforms this was tested on are

11.6.1
12.0.0
12.1.0
2016-12-08 11:34:43 -05:00
Tim Rupp d84e3b6ed7 This module can be used as part of the bootstrapping of a BIG-IP. It allows one to configure the various NTP settings that are part of a BIG-IP.
Tests for this module can be found here

https://github.com/F5Networks/f5-ansible/blob/master/roles/__bigip_device_ntp/tasks/main.yaml

Platforms this was tested on are

11.6.0
12.0.0
12.1.0
12.1.0 HF1
2016-12-08 11:34:43 -05:00
Tim Rupp 57c3ae838d Addition of bigip_device_sshd module
This module can be used as part of the bootstrapping of a BIG-IP. It
allows one to configure the various SSHD settings that are part of
a BIG-IP.

Tests for this module can be found here

https://github.com/F5Networks/f5-ansible/blob/master/roles/__bigip_device_sshd/tasks/main.yaml

Platforms this was tested on are

11.6.0
12.0.0
12.1.0
12.1.0 HF1
2016-12-08 11:34:43 -05:00
Toshio Kuratomi 7a8b080506 Get hipchat, sns, and typetalk notification modules compiling on py3 (#2782) 2016-12-08 11:34:42 -05:00