Commit Graph

15 Commits (ac44058457dd26a9d0d4b631b200b2c60f0a98db)

Author SHA1 Message Date
Adrian Likins a66a0187d1 Expect 204 status when using hipchat v2 api.
When posting to the room notication api with hipchat
v2 api, the expected return code is 204, as per:
https://www.hipchat.com/docs/apiv2/method/send_room_notification

fixes #2143
2016-12-08 11:34:11 -05:00
Michael Scherer 1d1fba5476 Mark token as no_log, since that's used for auth (#2011) 2016-12-08 11:34:05 -05:00
Brian Beggs 75b172c706 hipchat api v2 rooms are now url escaped 2016-12-08 11:34:04 -05:00
Zach Abrahamson 7d072140b3 Wrapping room parameter in a string in case of using room IDs 2016-12-08 11:33:40 -05:00
Brian Coca deb36b00d0 added missing license headers fixes #508 2016-12-08 11:33:06 -05:00
Nando Vieira 236b2d5c0d Use correct variable name. 2016-12-08 11:33:03 -05:00
Igor Khomyakov 3f697919ef fix user notification for v2 api
`notify` parameter is not working as expected for hipchat API v2.
2016-12-08 11:32:58 -05:00
Toshio Kuratomi 16bd2c7357 be explicit about urllib import and remove conditional urllib(2) import
urllib and urllib2 have been in the python stdlib since at least
python-2.3.  There's no reason to conditionalize it.

Fixes https://github.com/ansible/ansible/issues/11322
2016-12-08 11:32:52 -05:00
Paul Bourdel e00df23070 removing unnecessary white space 2016-12-08 11:32:40 -05:00
Paul Bourdel 2177ff1546 adding author username 2016-12-08 11:32:40 -05:00
Jean-Fred Berthelot ae5fed65f2 Add check_mode support to HipChat module
The HipChat module declares to support check_mode,
but the message is sent in any case.

With this, if executed in check mode, the module will exit
before actually sending the message to HipChat.

It will return changed=False, as per the convention
for notifications modules.
2016-12-08 11:32:36 -05:00
Paul Bourdel a03da8d592 Rewriting to use default ansible http libraries. 2016-12-08 11:32:36 -05:00
Paul Bourdel ca28acd07a Changing from v1 to v2 hipchat api format. 2016-12-08 11:32:36 -05:00
HPLogsdon 8efd7d217e Fix typo in hipchat notification failure message.
Wish it could be more substantial, but alas, it's just a typo in a string.
2016-12-08 11:32:28 -05:00
Michael DeHaan 5879c503bb File extensions! 2016-12-08 11:32:18 -05:00