7c8120d0de
Fix misleading cleanup/detach documentation ( #34674 )
...
* Fix misleading cleanup/detach documentation
Current documentation is not concrete regarding desired
state of `detach` to make container be properly removed
with `cleanup`
Make `detach:false` be mentioned explicitly
* Tweak formatting
2018-01-10 15:33:22 +00:00
c57a7f05e1
Bulk autopep8 (modules)
...
As agreed in 2017-12-07 Core meeting bulk fix pep8 issues
Generated using:
autopep8 1.3.3 (pycodestyle: 2.3.1)
autopep8 -r --max-line-length 160 --in-place --ignore E305,E402,E722,E741 lib/ansible/modules
Manually fix issues that autopep8 has introduced
2017-12-07 20:25:55 +00:00
4b4c1fdb13
Fix memory_reservation typo in docker_container module ( #33375 )
2017-11-29 19:01:49 -05:00
9e9f2b9ad5
Added userns support on docker_container module Fixes #20648 ( #22195 )
...
* added userns support on docker_container module
* Fixes #20648 - changed 'version_added' of userns_mode to 2.3 from 2.2
* version_added 2.5
2017-11-28 16:54:19 +00:00
9d156c6cb1
docker: PEP8 compliancy and documentation changes ( #32628 )
...
This PR includes:
- PEP8 compliancy changes
- Documentation changes
2017-11-07 15:35:50 +01:00
11faafcbf7
Fix error when there are no docker volumes present yet ( #28145 )
...
* Fix error when there are no docker volumes present yet
* fixes suggested by Shippable
2017-10-30 15:53:08 -04:00
1234a79349
Fix gender pronouns and the odd typo ( #31709 )
2017-10-13 13:52:38 -04:00
75eed6a51a
Port arg specs from type='str' to type='path'
2017-10-09 21:15:56 -07:00
aade5234a9
Fix urlparse import for Python3 ( #31240 )
...
* Fix urlparse import for Python3 in
* contrib/inventory/consul_io.py
* contrib/inventory/rudder.py
* contrib/inventory/windows_azure.py
* lib/ansible/module_utils/known_hosts.py
* lib/ansible/modules/cloud/centurylink/clc_firewall_policy.py
* lib/ansible/modules/cloud/docker/_docker.py
* lib/ansible/modules/cloud/ovirt/ovirt_disk.py
* lib/ansible/plugins/action/ce_template.py
2017-10-09 20:18:09 -07:00
e859d0da9c
data should be redacted in docker_secret ( #31366 )
2017-10-05 14:07:23 -04:00
4c0889e8fc
docker_service build command respects the "pull: no" parameter
...
Fixes #30296 .
2017-10-02 11:11:48 -04:00
fb4d065654
Fix running docker container with not readable logging driver. Fixes #27278
2017-10-02 11:00:16 -04:00
cb5f2c7ac3
[fix] issue #29886 - it misses oom_killer in host_config_params ( #30712 )
...
so it was never passed to docker API.
2017-09-25 20:42:02 -04:00
901bc2cffe
Clean code, fd.close not required since open as fd if used; remove get_redirected_output from cleanup_redirection_tempfiles since output is not used
...
(cherry picked from commit ef51f00bbc9f24485915040b863c9d034d3c272c)
2017-09-21 20:01:13 -07:00
f66c74915c
Fix docker_service python3 incompatibility
...
Looks like this is supposed to operate on native strings so there's no
need to encode or decode at all here
Fixes #30354
2017-09-21 19:50:54 -07:00
272c0ce68c
fixes #5732 - Add support for using network ID ( #22503 )
2017-08-30 17:32:45 -04:00
be2d4cc1c9
Check for an existing docker_network before trying to modify it ( #24048 )
...
This eliminates a TypeError in check mode.
2017-08-23 12:10:53 -04:00
655667527d
[docker] Fix ignore_image option not work issue. ( #19039 )
...
Currently the ignore_image option can be set, but can not work as it is
descripted in document. The reason is the code will check the difference
of configurations between current container and target image, and it
will mark the `different` to `True` when the image is different even we
set `ignore_image=true`, that will cause the container being re-create.
2017-08-17 13:47:52 -04:00
f8e79eb481
Fix changed event for docker_image in force mode
2017-08-17 10:42:09 -04:00
f203ca7907
Update metadata to 1.1
2017-08-15 23:12:08 -07:00
e419a55c71
Add correct URL for docker guide ( #27465 )
...
Fixes : #27463
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-07-30 10:08:43 +01:00
1ee08c0f06
Get rid of more wildcard imports and add boilerplate to more modules
...
This commit cleans up the following module categories:
* messaging
* inventory
* crypto
* commands
* clustering
* cloud/webfaction
* cloud/docker
* cloud/digital_ocean
2017-07-29 07:02:12 -07:00
225fa5d092
Fix undefined variables, basestring usage, and some associated python3 issues
2017-07-25 15:58:23 -07:00
df15583ad0
Promulgate house's fix for docker_volume to docker_secret
...
* Revert change to docker_common as it's not as good as the try: except fix
* limit docker_volume fix to ImportErrors
* fix docker_secret i nthe same way
* Remove docker_secret from import tests
2017-07-19 13:20:47 -07:00
2e073e73d2
Fixes doc string in docker_volume ( #27074 )
2017-07-19 15:42:31 -04:00
657ab58139
Added the docker_volume module ( #24957 )
...
* Added the docker_volume module
* Code style fixes
* Added yours truly to the copyright statement
* Added documentation link
* Fixed YAML syntax in documentation string
* Documentation style fixes based on the code review
* Implemented requested code corrections
* Added documentation for the "labels" option
* Handled APIErrors from docker-py
* Fixed the type of the "labels" option (dict -> list)
* Fixed typo
* Import APIError from docker_common, not from docker-py
2017-07-19 13:43:54 -04:00
3f67d167fe
[ Fixes #26690 ] Supports Python 3 handling of base64 encoding ( #26876 )
...
* [Fixes #26690 ] Supports Python 3 handling of base64 encoding
* Set text auth to separate variable for reuse
2017-07-17 21:11:52 -07:00
6af53cf0ef
Adds docker_secret module ( #26469 )
2017-07-06 09:22:04 -04:00
8765eadb30
Fixes list comparison ( #26042 )
2017-06-26 11:06:57 -04:00
42b608db0c
Add support for tmpfs to docker_container. ( #25747 )
2017-06-23 08:03:28 -04:00
846174b4ba
Update nocache to be the proper bool type instead of string ( #24358 )
...
* Update nocache to be the proper bool type instead of string
* Add proper bool type for params
2017-06-19 11:24:19 +01:00
20bddde669
docker_service: Forward stderr-based output from docker-compose ( #25456 )
...
PR #5165 at https://github.com/ansible/ansible-modules-core/pull/5165
adds redirection and capture of stdout during execution of
docker-compose.
This doesn't necessarily catch all errors, since some are printed to
stderr and lost.
This extends the redirection to include stderr, and does minor string
processing to attempt to find a 'useful' message to present as the
final Ansible error.
2017-06-07 23:30:26 -04:00
42d57782c0
Try to fix travis
2017-06-02 10:10:34 -07:00
981249daa1
use single line for-loop
2017-06-02 10:10:34 -07:00
b3a37da671
Add --sysctl support for cloud/docker_container
2017-06-02 10:10:34 -07:00
7363776174
fixes #19550 (docker_container with empty links list always restarts)
2017-05-24 16:14:10 -07:00
5c43bd3bae
Cmp python3 compat ( #25008 )
...
* Use double-quotes for expect integration tests
* Cast user input to string for expect integration tests
* Remove usage of cmp() for python3 compatibility
- Add code smell test to look for cmp usage
- Fixes #24756
2017-05-24 15:59:59 -07:00
64f63a3cac
Properly handle Docker image comparison for published_ports defined as IP::PORT
...
- Published port defined as IP::PORT where parsed in expected.parameters
as 0.0.0.0::PORT leading to changed==True on every playbook run.
2017-05-24 15:55:30 -07:00
5b39368108
use two-tuples rather than dicts to allow multiple aliases for the same target
2017-05-24 15:48:12 -07:00
3610a2457f
Fixed #21464 - docker_network: TypeError with existing network ( #24266 )
...
Fixed #22530 - docker_network Failed but Overlay network created successfully on Docker swarm mode
2017-05-24 14:21:24 -07:00
cb3026f769
rebuild docker containers if there are less ports exposed
2017-05-24 12:37:29 -07:00
fab2dfd1c6
typo in security opts
2017-05-24 12:16:31 -07:00
272125023f
Add working_dir to docker_container ( #20044 ) ( #24977 )
...
* docker_container: add working_dir (fixes #20044 )
Added a working directory option that will get passed with the other
docker container parameters. This is optional and addresses feature
request #20044 .
2017-05-24 11:41:54 -07:00
f5fd32eae6
docker_container: do not split command on commas ( #24900 )
...
* docker_container: do not split command on commas
Fix issue #24430
* docker_container: document command parameter
Prior behavior was strange, splitting strings on commas
only to join them again ... replacing commas with spaces.
FYI, docker-py accepts strings or lists, using shlex.split
on strings ... splitting on spaces while respecting things
like quotes.
https://github.com/docker/docker-py/blob/master/docker/api/container.py
https://github.com/docker/docker-py/blob/master/docker/types/containers.py
https://github.com/docker/docker-py/blob/master/docker/utils/utils.py
More info regarding Dockerfile syntax for CMD strings and lists
can be found at https://docs.docker.com/engine/reference/builder/#cmd
2017-05-22 15:39:57 -07:00
3324d0a4b0
Support auto_remove in docker_container ( #22929 )
...
* Support auto_remove in docker_container
* Fail if not docker>=2 and auto_remove=True, don't set auto_remove in host_config if not docker>=2
* Make quoting more readable in ansible errors
2017-05-09 16:19:27 -04:00
1ac17213ea
Rename fact returned by docker_network to avoid restricted prefix ( #23919 )
...
This fixes #23918
2017-04-28 08:45:53 -05:00
1d0a629dcc
Fixed docs for cloud modules ( #23745 )
...
* Fixed docs for cloud modules
* removed blank line in ec2_snapshot_facts
2017-04-27 12:01:11 +01:00
9812d211e7
typo: psuedo -> pseudo ( #23177 )
2017-03-31 10:48:29 -04:00
4099eb41b9
Treats both [] and {} as equal to None ( #23088 )
2017-03-29 22:48:21 +02:00
dba8edf735
cloud: docker: Fixes #22638 load image to memory when archive_path provided ( #22642 )
2017-03-16 10:06:19 -07:00
Yury Tsarev
John Barker
Nicolas DOUILLET
Harris Dimitriou
Dag Wieers
UnderwayNYC
Kenny Gillen
Toshio Kuratomi
François Scala
Andrew Lihonosov
Artem Bolshakov
Sebastien Boyron
Sebastien Boyron
Abdul Anshad A
Stephen Jennings
Jun Guo
Alvaro Aleman
Abhijeet Kasurde
Chris Houseknecht
Alex Grönholm
Will Medlar
Will Rouesnel
Matthew Schick
Kassian Sun
louis
kkjang
Konrad Klimaszewski
bengerman
Nikolay Murga
Michael Sheinberg
Andrew Shewmaker
Matt Martz
Alex Willmer
Andrea Tartaglia
smaftoul
Ilya Simonenko