Commit Graph

242 Commits (b193d327b616da2774ce4293aa52539fbd61b6ef)

Author SHA1 Message Date
Dorian Pula b193d327b6 Fix re import failure in templates module when running unit tests. 2015-04-13 12:17:07 -04:00
Feanil Patel 0abcebf1e4 Don't convert numbers and booleans to strings.
Before this change if a variable was of type int or bool and the variable was referenced
by another variable, the type would change to string.

eg. defaults/main.yml
```
PORT: 4567
OTHER_CONFIG:
  secret1: "so_secret"
  secret2: "even_more_secret"

CONFIG:
  hostname: "some_hostname"
  port: "{{ PORT }}"
  secrets: "{{ OTHER_CONFIG }}"
```

If you output `CONFIG` to json or yaml, the port would get represented in the output as a
string instead of as a number, but secrets would get represented as a dictionary.  This is
a mis-match in behaviour where some "types" are retained and others are not.  This change
should fix the issue.

Update template test to also test var retainment.

Make the template changes in v2.
Update to only short-circuit for booleans and numbers.

Added an entry to the changelog.
2015-04-11 12:03:42 -04:00
Toshio Kuratomi 2af6314f57 Comment to clarify why we add one to the line and column recording 2015-04-10 04:09:50 -07:00
Brian Coca 3c9890a358 now in v2 everything passes a single passwords hash 2015-04-08 03:17:32 -04:00
James Cammarata 7076298dc1 Adding FIXME note to playbook executor code regarding password params 2015-04-06 22:27:14 -05:00
Brian Coca d732c94ac2 a bunch of updates to connection info and related, to pass down passwords
also now options populate required fields in required order allowing play to override
added capture of debug in action plugins when stdout is not json
2015-04-06 22:35:02 -04:00
James Cammarata e82ba723e2 Fixing multiple v2 bugs 2015-04-05 01:07:47 -05:00
Brian Coca 4bc79a746a more fine tunnign on verbosity 2015-04-04 16:26:05 -04:00
Brian Coca b1e6aaa790 implemented verbosity, added 5th level and now can see how many plays per playbooko if -vvvvv 2015-04-04 15:54:54 -04:00
Brian Coca af97e732a0 updated ansible-playbook to use display, fixed issues breaking display class 2015-04-04 15:14:40 -04:00
Brian Coca e6e69c0894 finished implementing list-hosts, started adding list-tasks/list-tags
but getting just task names and have to adjust for having blocks.
2015-04-04 10:25:55 -04:00
Brian Coca 2eb2a41d05 renamed get_entries to get_plays 2015-04-04 10:24:03 -04:00
Brian Coca 3c6fdebfe3 made listhosts play output name more consistent internally 2015-04-03 13:49:00 -04:00
Brian Coca a811c8841e now listhosts shows the same info as v1 2015-04-03 13:42:05 -04:00
James Cammarata 41d9bfde07 Moving the Display() instantiation outside of v2 classes 2015-04-03 12:17:01 -05:00
Brian Coca ada86dafaf added listhosts draft
fixed assert from list to new yaml ansible object
taskqueue is now None when just listing
2015-04-03 13:02:42 -04:00
Brian Coca e719bf765d switched to use cross platform os.sep, added diff output to copy 2015-04-03 09:20:19 -04:00
Brian Coca 0f8bc038ec changed to use display as utils.warning doesnt exist in v2 2015-04-03 00:25:09 -04:00
Brian Coca 25f071b64c fixed called to find plugin, transport is not needed as suffixes are passed 2015-04-03 00:01:32 -04:00
Brian Coca 7a81167b06 brought v2 find plugins up 2 date with v1, also added exception handling for whne there is a permissions issue 2015-04-02 23:59:48 -04:00
James Cammarata 469a1250b6 Moving new patch action plugin over to v2 2015-04-02 16:22:07 -05:00
Brian Coca ee1af1b14e Merge pull request #10559 from bcoca/become_constants_fix
removed folding sudo/su to become logic from constants
2015-04-02 15:51:58 -04:00
Toshio Kuratomi 5808b68d35 Update module pointers 2015-04-02 12:41:30 -07:00
Toshio Kuratomi 2cddb093f5 Add AnsibleList for keeping track of line numbers in lists parsed from yaml 2015-04-02 12:37:02 -07:00
Toshio Kuratomi 369bf0d214 No longer need AnsibleComposer 2015-04-02 12:35:50 -07:00
Toshio Kuratomi bfae708bbf Port v2 to the PyYAML C extension 2015-04-02 11:21:55 -07:00
James Cammarata 811a906332 Fixing the synchronize action plugin for v2 2015-04-02 11:54:45 -05:00
James Cammarata 34aba2dd9a Fixing dupe option for -u in v2 2015-04-02 11:26:42 -05:00
James Cammarata 0603b9c62c Merge branch 'v2_fixing' into devel
Conflicts:
	v2/ansible/playbook/helpers.py
2015-04-02 01:25:53 -05:00
James Cammarata 785c0c0c8c V2 fixing bugs 2015-04-02 01:19:21 -05:00
Toshio Kuratomi e697de6076 Move AnsibleBaseBaseYAMLObject's position_info into a property 2015-04-01 14:54:22 -07:00
Toshio Kuratomi 05f1bed12b Use the node's start_mark to determine line and column.
* Elminates a lot of logic in the AnsibleComposer class.
* Update tests with new column offsets.  The rule should now be
  consistently: Column is the start of the entry's value (so for
  strings, the first non-space after the entry beginning, for dicts, the
  first character of the first key)
2015-04-01 13:51:01 -07:00
Toshio Kuratomi b152275a36 Test line numbers and "fix" a bug in the scalar line counting 2015-04-01 12:18:53 -07:00
Toshio Kuratomi 4a5b37542d Merge pull request #10579 from ansible/v2-unicode-yaml
Change AnsibleConstructor for yaml to only return unicode strings
2015-04-01 09:39:53 -07:00
Toshio Kuratomi c41b917162 Add a yaml constructor for unicode strings:
* Changes AnsibleConstructor so that only unicode strings are returned
  (no str type)
* Tracks line, column numbers for strings
* Adds unittests for AnsibleLoader (generic for all the yaml parsing)
2015-04-01 09:37:54 -07:00
Brian Coca 4dd233b0dd Merge pull request #10237 from emonty/remove-auth-token
Remove auth token and port openstack module_utils changes to v2 tree
2015-04-01 12:20:59 -04:00
Monty Taylor 87c99b4675 Align verify parameter with validate_certs
The rest of ansible uses validate_certs, so make that the main
documented parameter. However, leave verify as an alias since that's the
passthrough value to the underlying libraries.
2015-04-01 07:54:02 -04:00
Monty Taylor 90ca386555 Add api timeout now that shade spports it everywhere 2015-03-31 20:29:06 -04:00
Toshio Kuratomi eb788dd8f6 Just move things around so that new_inventory doesn't interfere with testing 2015-03-31 12:58:00 -07:00
Toshio Kuratomi 378dc561cb Possible fix for the first newline and triple newline problems 2015-03-30 22:47:56 -07:00
Toshio Kuratomi 43c1a97447 Various unicode and backslash escape cleanups
* Do backslash escape parsing in parse_kv() [was being done in the copy
  module purely for newlines in the copy module's content param before]
* Make parse_kv always return unicode
* Add bandaid to transform args to unicode until we can fix things
  calling parse_kv to always send it unicode.
* Make split_args deal with unicode internally.  Warning, no bandaid for
  things calling split_args without giving it unicode (shouldn't matter
  as dealt with str internally before)
* Fix copy and unarchive action plugins to not use setdefaultencoding
* Remove escaping from copy (it was broken and made content into latin-1
  sometimes). escaping is now in parse_kv.
* Expect that content is now a unicode string so transform to bytes just
  before writing to the file.
* Add initial unittests for split_args and parse_kv.  4 failing
  tests.because split_args is injecting extra newlines.
2015-03-30 19:19:34 -07:00
Toshio Kuratomi 1cc2135a0d Fix no closed parens 2015-03-30 19:15:41 -07:00
Toshio Kuratomi ce512e18f0 Remove fireball connection plugin. v2 will have accelerate but not fireball 2015-03-30 19:15:41 -07:00
Toshio Kuratomi dc9b36ccb0 Some notes on optimizing module_replacer 2015-03-30 19:15:41 -07:00
Brian Coca 5ec1f3bd6e removed folding sudo/su to become logic from constants as it is already present downstream in playbook/play/tasks 2015-03-27 08:45:04 -04:00
Toshio Kuratomi 0ec1b025a9 Update the module pointers 2015-03-26 11:59:53 -07:00
Toshio Kuratomi ea2d00c558 v2 equivalent for https://github.com/ansible/ansible/pull/8564
Looks like there's currently no code for the ansible_*_interpreter but
modified the note abouot adding it
2015-03-26 11:57:27 -07:00
Toshio Kuratomi 60f972dfe4 Fix the command module handling of non-ascii values.
We can't depend on the args being unicode text because we're in module
land, not in the ansible controller land
2015-03-25 13:57:48 -07:00
Toshio Kuratomi 38892e986e Convert exceptions to unicode using to_unicode rather than str. that stops unicode errors if the string has non-ascii text 2015-03-25 13:56:46 -07:00
Toshio Kuratomi 131683523b Add some comments to explain how the property code for Attributes works 2015-03-23 23:16:06 -07:00