b6afb77a8a
fix nxos_banner issue ( #41026 )
2018-06-04 10:53:04 +05:30
82dfa542c2
Replace bogus (but routeable) ip addresses with RFC 5737 example addresses ( #40554 )
...
* Remove 1.1.1.1 from *_config tests
* remove from *_smoke and *_system
* Miscellaneous other tests
* Remove from module documentation as well
* Remove from unit tests as well
* Remove accidental duplication from rebase
2018-05-30 13:03:20 -04:00
786ec14e54
fix nxos dci failures ( #40871 )
...
* fix structured output for nxos_linkagg
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix TypeError for nxos_interface
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-05-30 15:31:16 +05:30
17b6ecf101
nxos_vlan fix ( #40822 )
...
* nxos_vlan fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* uncomment mode test as nxapi now has get_capabilities
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-05-29 21:44:19 +05:30
a7421e8611
httpapi fix nxos ( #40806 )
...
* httpapi fix nxos
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* nxos_hsrp fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-05-29 21:43:34 +05:30
9f026309a6
Update nxos_install_os module ( #40102 )
...
* Add nxos_install_os integration tests
* Update call to check timers
* Update check_ansible_timer method
* Modify network_cli integration tests
* Add timer check for nxos_install_os
* Add comments for clear_persistent_sockets
* Update connection info for tests
* More updates
* Restructure files for provider and non-provider testing
* Update env var name and add check for ISSU switchover
2018-05-29 21:07:57 +05:30
b4baa2d484
fix nxos_vrf and migrate get_interface_type to module_utils ( #40825 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-05-29 21:06:08 +05:30
d9533c3cbf
Adding changed option to save_when ( #40640 )
...
* Adding changed option to save_when
* Fixing version when changed was added.
2018-05-24 22:18:59 +05:30
c2f7f36fc5
nxos_file_copy network_cli and httpapi fix ( #40592 )
...
* Leverage action plugin to pass credentials to nxos_file_copy for network_cli, httpapi
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* update integration test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* make sure local test uses provider
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* update tests
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* update doc
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* clarify action plugin comment
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add connection=local back to nxos_file_copy because that module is weird
Also blacklist it running on nxapi, because that is meaningless
* remove provider
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* blacklist nxapi
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Address review comment
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-05-24 20:21:18 +05:30
d04a989bd2
nxos_interface: Disable switchport for loopback/svi ( #40314 )
...
* nxos_interface: Disable switchport for loopback/svi
* Replace interface_type with get_interface_type(name)
2018-05-24 08:51:17 +05:30
0b7932db30
add normalize_interface in module_utils and fix nxos_l3_interface module ( #40598 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-05-23 21:42:58 +05:30
97070c9688
fix nxos_system issues ( #40347 )
2018-05-22 14:19:34 +05:30
63e16431b7
Fix legacy Nexus 3k integration test and module issues. ( #40322 )
...
* Add setup ignore_errors for nxos_config test
* Fix parse_fan_info for n3k
* Skip bidir tests for N3k
* Omit vni config for n3k
* Skip unsupported nxos_vrf_af test on N3K
* Add legacy N3K platform tag
2018-05-17 20:29:00 +05:30
979f1e5ed1
save_snapshot_locally nxos_snapshot ( #40227 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-05-16 14:59:23 +05:30
6fac574f17
fix nxos_ping issues ( #40028 )
2018-05-14 11:29:18 +05:30
f1103a7a02
remove purge from nxos_logging doc, argspec ( #39947 )
...
* remove purge from nxos_logging doc, argspec
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* shippable
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-05-10 15:28:37 +05:30
e3bfbe5875
fix nxos_snmp_user issues ( #39760 )
...
* fix nxos_snmp_user issues
* shipppable fix
2018-05-08 11:57:12 +05:30
3c35dd4f7f
nxos_linkagg normalize interface ( #39591 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-05-08 11:15:05 +05:30
9eff1f1d74
Handle nxos_feature issue where json isn't supported ( #39150 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-05-04 12:21:58 +05:30
f99bae1776
Fix for nxos_snmp_host issues ( #39642 )
...
* fix snmp_host issues
* source files
* fix shippable
* remove defaults to match arg spec
2018-05-03 21:36:33 +05:30
99748cbfa4
fix nxos_snmp_traps issues ( #39444 )
...
* fix snmp_traps code
* add IT cases
* fix shippable
* fix shippable without ignore
2018-05-03 21:34:25 +05:30
dca6e2d94d
nxos_interface: AttributeError: 'NoneType' object has no attribute 'group' ( #38544 )
...
This fixes an issue we recently encounteredi with nxos_interface:
```
Traceback (most recent call last):
File "/tmp/ansible_JmLoba/ansible_module_nxos_interface.py", line 777, in main
have = map_config_to_obj(want, module)
File "/tmp/ansible_JmLoba/ansible_module_nxos_interface.py", line 606, in map_config_to_obj
obj['speed'] = re.search(r'speed (\d+)', body).group(1)
AttributeError: 'NoneType' object has no attribute 'group'
```
2018-04-26 12:27:35 +05:30
2f99a17856
fix nxos_ntp issues ( #39178 )
...
* fix nxos_ntp issues
* review comments
* fix idempotent fail case
2018-04-26 12:09:46 +05:30
1afec5a48e
fix nxos_snmp_community issues ( #39258 )
2018-04-25 13:16:41 +05:30
86817cdd52
Add aggregate example in nxos_l2_interface module doc ( #39275 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-04-25 12:56:54 +05:30
6db3f522c8
sub-interface support for nxos module ( #37392 )
...
* nxos sub-interface support
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* update l3_interface test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add integration test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-04-25 12:45:56 +05:30
7c4b91844d
More validate module fixes ( #39097 )
...
* Fix type bool DOCUMENTATION issues
2018-04-24 18:05:50 +01:00
6eecbf10e6
fix nxos_igmp_interface issues ( #38752 )
...
* fix nxos_igmp_interface issues
* shippable fix
* fix oif_prefix and oif_source
* shippable fix
* shippable fix
* shippable fix
* add an example for oif_ps
* review comments
* review comments
* more review comments
* fix typo
2018-04-23 20:38:49 +05:30
0ebc0b9e5a
adds FAQ TOC entry, links & examples to modules ( #38706 )
...
* adds FAQ TOC entry, links & examples to modules
* moves link to Notes, corrects examples
2018-04-18 11:41:54 -07:00
a372142434
fix ntp_auth issues ( #38824 )
2018-04-17 08:25:05 -04:00
1d975bdc93
fix nxos_ntp_options ( #38695 )
2018-04-13 06:17:32 -04:00
6de49f084c
doc for _config backup argument ( #38650 )
2018-04-13 12:48:49 +05:30
ed42331105
fix nxos_igmp_snooping issues ( #38566 )
...
* fix nxos_igmp_snooping issue
* shippable error fix
2018-04-11 10:14:27 -04:00
361437b042
fix nxos_igmp issues ( #38496 )
2018-04-10 00:05:58 -04:00
dabe5e6d07
fix nxos_hsrp issues ( #38410 )
...
* fix nxos_hsrp issues
* shippable fix
* add examples for md5 auth
2018-04-09 23:54:05 -04:00
1bf29651af
fix nxos_acl issues ( #38283 )
...
* fix nxos_acl issues
* typo fix
* typo fix in sanity.yaml
* another typo fix in sanity.yaml
2018-04-06 00:57:13 -04:00
119352b538
nxos_vlan purge ( #38202 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-04-03 02:53:44 -04:00
24cc6b80bd
fix nxos_aaa_server_host issues ( #38188 )
2018-04-03 01:53:43 -04:00
697c301f04
fix nxos_aaa_server issues ( #38117 )
2018-04-02 07:56:06 -04:00
6f2cb28bb9
fix nxos_vlan issues ( #38008 )
2018-03-29 06:26:33 -04:00
135d343254
fix nxos_udld_interface issue ( #37527 )
2018-03-27 02:57:14 -04:00
0df5cfd41f
fix nxos_static_route issues ( #37614 )
...
* fix nxos_static_route issues
* remove nxos_static_route from ignore
2018-03-26 11:13:32 -04:00
00abe6dbe7
fix UnboundLocalError nxos_bgp_af module ( #37610 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-03-20 01:53:08 +05:30
cdd21e2170
Clean up module documentation ( #36909 )
...
* Clean up module documentation
This PR includes:
- Removal of `default: None` (and variations)
- Removal of `required: false`
- Fixing booleans and `type: bool` where required
* Fix remaining (new) validation issues
2018-03-15 22:15:24 +01:00
05b266cc66
fix nxos_udld issues ( #37418 )
2018-03-15 15:37:46 +05:30
dc61f4c6b1
Fix nxos_vrf issues ( #37092 )
...
* fix nxos_vrf issues
* fix doc
2018-03-13 17:08:37 +05:30
ba5e562c76
Fix nxos_l2_interface and test typo ( #37336 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-03-13 13:36:38 +05:30
ff57fd0bb4
Fix nxos_switchport ( #37328 )
2018-03-13 12:03:05 +05:30
2501834c42
add nxos_snapshot test for missing required param ( #37248 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-03-09 17:47:14 +05:30
a10df8b0b5
fix required args for nxos_snapshot and docs improvement ( #37232 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-03-09 14:08:01 +05:30
74e79d9f5e
fix nxos_vrf_af issues ( #37211 )
2018-03-09 12:20:27 +05:30
02999b77a4
fix nxos_switchport/l2_interface trunk_vlans state absent ( #37180 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-03-08 18:10:04 +05:30
ebc71bcb16
Network modules to link to network guide ( #37033 )
...
* Network modules to link to network guide
* Make it clear what's deprecated
* enable -> become
* Detail when provider is still needed (eAPI/NX-API)
* Link to specific sections
* rx_rate & tx_rate to link to conditional docs
2018-03-06 12:01:07 +00:00
4ed0e5072d
fix nxos_vrrp issues ( #36930 )
2018-03-06 13:36:50 +05:30
51e8eab9db
Fix n3k separate to combined image upgrade ( #37017 )
...
* Fix n3k separate to combined image upgrade
* Address review comments
2018-03-06 10:05:08 +05:30
2fbfce06e7
Fix nxos_interface multiple issues ( #36827 )
...
* fix interface_type
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix setting mtu, doc for state check param, doc for params applicable for ethernet intf
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* speed idempotence and add unittest
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fabric_forwarding_anycast_gateway applicable for svi type intf only
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix speed
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-03-01 10:56:16 +05:30
db43fe6a76
nxos_facts fix and integration tests ( #36796 )
...
* fix nxos_facts ipv6 error
* time_range not supported for N35
2018-02-28 10:45:50 +05:30
44332bda78
fix nxos_vlan aggregate ( #36710 )
...
* fix nxos_vlan aggregate
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-26 12:29:49 +05:30
d6912cf40e
nxos_linkagg fix ( #36706 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-26 11:21:51 +05:30
5a6b893240
Decouple config and state check in vlan and vrf network modules ( #36386 )
...
* Decouple config and state check in {network_os }_vlan and { network_os }_vrf modules
Fixes #35567
Fixes #34754
`interfaces` option is used for configuration as well as operational state
check. If interface is configured to given vlan or vrf but if
operational state of interface is disabled it results in module failure.
Fix is to decouple same option usage for config and state.
With this fix `interfaces` is used as config option and a new
option named `associated_interfaces` will be used for intent check
for assigned interfaces.
* Fix CI failures
* Fix review comment
* Fixed integration test failure
2018-02-26 09:23:54 +05:30
713828804d
nxos_vrf fix ( #36494 )
...
* nxos_vrf fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Address review
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-21 19:33:33 +05:30
9598978e12
fix nxos_pim module doc ( #36505 )
...
* fix nxos_pim module doc
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* address review
2018-02-21 18:42:37 +05:30
f207897f32
fixed conditional error message ( #36476 )
2018-02-21 11:44:18 +05:30
47a92386c9
fix nxos_bgp_neighbor_af issues ( #36472 )
2018-02-21 10:20:24 +05:30
ef7d574920
Fix nxos_banner module for unstructured output ( #36411 )
...
* Fix nxos_banner module for unstructured output
* Refactor and bug fixes
* Fix pep8 error
2018-02-21 09:51:41 +05:30
80d19e6af3
fix nxos_bgp_neighbor issues ( #36318 )
2018-02-20 10:08:17 +05:30
736d6406c0
fix nxos_config json pipeline error ( #36236 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-19 10:11:43 +05:30
6e096cb0c9
Remove kickstart_image_required check ( #36319 )
2018-02-17 10:20:31 +05:30
e24c547a3a
Fixes for the N3500 platform that uses the A8 image ( #36261 )
...
* fix nxos_l3_interface tests as n35 doesn't support ipv6
* add terminal dont-ask to nxos_feature and nxos_lldp
* put interfaces in L2 mode for N35
* fix nxos_feature unit-tests
2018-02-17 10:16:03 +05:30
ac169f5ffd
Fix structured output bug ( #36193 )
2018-02-16 21:34:26 +05:30
75a34f6668
fix nxos_bgp_af issues ( #36147 )
...
* fix nxos_bgp_af issues
* shippable fix
* review comments
* shippable error fix
2018-02-16 09:34:24 +05:30
eab1b62cd2
fix nxos_interface_ospf issues ( #35988 )
...
* fix nxos_interface_ospf issues
* review comment
2018-02-13 09:27:22 +05:30
7a711cf942
Fix nxos_igmp_interface for diff nxos versions ( #35959 )
2018-02-12 10:30:38 +05:30
15b0371eb2
Add examples and language to better showcase the 'parents' parameter in multiple network modules ( #34486 )
...
* Add additional language and examples for 'parents' parameter to clarify its usage.
2018-02-09 13:31:37 +00:00
c7305393a3
fix nxos_evpn_vni issues ( #35930 )
2018-02-09 13:02:41 +05:30
80fcfdc0d1
fix nxos_vpc issues ( #35868 )
2018-02-08 18:50:37 +05:30
dfcae9fc8e
Remove potentially confusing `provider` from module documentation ( #35851 )
2018-02-07 16:33:11 -05:00
c9e0ce1d7d
fix nxos_vpc_interface peer_link idempotence ( #35737 )
...
* fix peer_link idempotence
* review comment
2018-02-07 08:35:43 +05:30
98f804ecb4
nxos_facts: svi support ipv4 ( #35222 )
...
* nxos_facts: svi support ipv4
* nxos_facts: copy paste error
* https://app.shippable.com/github/ansible/ansible/runs/51845/1/tests
* E111 indentation is not a multiple of four
* Update nxos_facts.py
2018-02-06 19:40:12 +05:30
109bc89bbe
fix nxos_ospf_vrf issues ( #35616 )
2018-02-05 10:59:13 +05:30
a4b7df70c7
nxos_vlan ValueError fix ( #35559 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-02 20:51:34 +05:30
dc35baa8db
fix nxos_pim_interface issues ( #35405 )
...
* fix nxos_pim_interface issues
* add absent test for pim_interface
2018-01-31 10:51:11 +05:30
a23c95023b
Module deprecation: docs, scheme and tests ( #34100 )
...
Enforce module deprecation.
After module has reached the end of it's deprecation cycle we will replace it with a docs stub.
* Replace deprecated modules with docs-only sub
* Use of deprecated past deprecation cycle gives meaningful message (see examples below)
* Enforce documentation.deprecation dict via `schema.py`
* Update `ansible-doc` and web docs to display documentation.deprecation
* Document that structure in `dev_guide`
* Ensure that all modules starting with `_` have a `deprecation:` block
* Ensure `deprecation:` block is only used on modules that start with `_`
* `removed_in` A string which represents when this module needs **deleting**
* CHANGELOG.md and porting_guide_2.5.rst list removed modules as well as alternatives
* CHANGELOG.md links to porting guide index
To ensure that meaningful messages are given to the user if they try to use a module at the end of it's deprecation cycle we enforce the module to contain:
```python
if __name__ == '__main__':
removed_module()
```
2018-01-30 12:23:52 +00:00
2293252e52
bug-35431 fixed removing encryption from user on subsequent runs of the task ( #35433 )
2018-01-30 11:26:54 +05:30
f8a89f120f
update nxos_interface doc ( #35350 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-25 20:02:02 +05:30
cff4a2d26e
fix *os_config module backward diff ( #35332 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-25 18:49:20 +05:30
0b30c42902
fix pim rp_address issues ( #35248 )
2018-01-24 11:48:49 +05:30
4bc22be614
Fix for nxos_pim issues ( #35103 )
...
* fix nxos_pim issues
* unused line removed
* unused line removed
* remove unnecessary files
2018-01-22 11:30:52 +05:30
8a6d699198
Enable nxapi nxos_banner test ( #35033 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-18 11:50:15 +05:30
9a32f5c889
Add missing extends_documentation_fragment ( #35013 )
...
NXOS modules need more work, though that will all be in
module_docs_fragments/nxos.py
2018-01-17 16:31:53 -05:00
db61f8f967
Clarify which ping module to use ( #34935 )
...
* Clarify which ping module to use
Ensure each of the ping modules link to each other
ping - Requires Python on remote-node
nxos_ping - Only on Cisco NXOS
ios_ping - Only on Cisco IOS
net_ping - For network devices
win_ping - only for Windows
2018-01-17 14:02:06 +00:00
3a144b290d
fix for nxos_vxlan_vtep_vni issues ( #34946 )
...
* fix vxlan_vtep_vni issues
* pep8 errors
2018-01-17 11:07:29 +05:30
227ff61f9d
Add module support to yamllint sanity test. ( #34964 )
...
* Add module support to yamllint sanity test.
* Fix duplicate keys in module RETURN docs.
* Fix syntax in return_common docs fragment.
* Fix duplicate keys in module EXAMPLES docs.
2018-01-16 15:08:56 -08:00
a727930f07
Remove deprecated params from module argspec nxos modules ( #34911 )
...
* Remove deprecated param from module argspec nxos modules
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix nxos_vrrp syntaxerror
* Add choices for version _nxos_ip_interface
* remove check_args function
* remove include_defaults
2018-01-16 18:23:58 +05:30
195beebcb4
Module DOCUMENTATION should match argspec ( #34895 )
...
* Module DOCUMENTATION should match argspec
Large update of many modules so that DOCUMENTATION option name and
aliases match those defined in the argspec.
Issues identified by https://github.com/ansible/ansible/pull/34809
In addition to many typos and missing aliases, the following notable
changes were made:
* Create `module_docs_fragments/url.py` for `url_argument_spec`
* `dellos*_command` shouldn't have ever had `waitfor` (was incorrectly copied)
* `ce_aaa_server_host.py` `s/raduis_server_type/radius_server_type/g`
* `Junos_lldp` enable should be part of `state`.
2018-01-16 12:18:51 +00:00
a65f702155
add config option to replace argument ( #34342 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-15 21:17:02 +05:30
c04cd8642d
fix vxlan idempotent issue ( #34750 )
2018-01-15 12:27:37 +05:30
303894dd17
fix nxos_banner ( #34695 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-11 21:13:00 +05:30
df8b01aaf7
Handle platform os version for sandbox nxos_nxapi ( #34490 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-11 21:12:00 +05:30
6f8d3ad70d
Fixes for nxos_bgp ( #34590 )
...
* fix bgp issues
* add new tests cases
* review comments
2018-01-10 10:52:26 +05:30
saichint
Nathaniel Case
Trishna Guha
Mike Wiebe
James Mighion
Dag Wieers
John R Barker
Alicia Cozine
Deepak Agrawal
Ganesh Nalawade
Lindsay Hill
rahushen
Tyler
chifu1234
Chip Gwyn
Matt Clay