e37b63386c
Revised following comments from Chris Church.
...
Now uses sha1 checksums following merge of 9688.
Also I undid the changes I made to fetch.py
win_template.py now uses conn.shell.has_trailing_slash and
conn.shell.join_path
updated integration tests.
2014-12-16 04:47:01 +00:00
bf916fb58a
Adding first pass at win_copy, win_file and win_template modules.
2014-12-16 04:47:01 +00:00
9b8a55032d
Do not use the variable name as a key for the result of the module
...
Using the variable name can interfere with various systems
used to communicate between modules and ansible ( as
reported in #7732 , where ansible_facts is a reserved key for
updating the fact cache, for example ).
2014-12-14 19:27:17 +01:00
b84fba4439
Strip the line to filter lines composed of only whitespaces
...
Fix #9395
2014-12-13 20:56:06 +01:00
462471209e
Allow retries to be templatable
...
Fixes #5865
2014-12-10 16:54:58 -05:00
d4da58e102
Merge pull request #9720 from vlajos/typofixes-vlajos-20141204
...
typofixes - https://github.com/vlajos/misspell_fixer
2014-12-08 14:00:52 -08:00
3a5aec9743
file does not exist is not an error when checksumming for the template modules
2014-12-08 13:08:26 -08:00
f2d2f425ae
Fix comment
2014-12-08 13:07:34 -08:00
3269a349f3
Fix remote_checksum with delegate_to and add tests for several ways that delegate_to works
2014-12-08 12:44:44 -08:00
2a288141d3
Fix template module to fail if remote checksumming failed
2014-12-08 10:55:04 -08:00
b042fcc349
Fix for delegate_to with hosts that aren't in inventory
2014-12-05 12:35:43 -08:00
bf5d8ee678
typofixes - https://github.com/vlajos/misspell_fixer
2014-12-04 22:23:35 +00:00
e938f554b7
better exception handling for unexpected exceptions
2014-12-04 08:01:38 -05:00
a2b2e54992
Fix checksum code to work with delegate_to/local_action
...
Fixes #9704
2014-12-03 14:43:03 -08:00
4dfd86d847
Issue-9704 Better handling of missing python
...
When they python interpreter is set incorrectly for the machine the file
is being checked for (e.g. for the local or the remote), the error
manifests as a readability or directory missing error which can be very
misleading.
2014-12-03 17:15:00 -05:00
1c5f625295
corrected exception name
2014-12-03 14:19:11 -05:00
1ec8b6e3c5
Have remote_expanduser honor sudo and su users.
...
Fixes #9663
2014-12-03 10:46:56 -08:00
61a30e5f49
better exception handling with delegated hosts
2014-12-03 07:26:42 -05:00
2bf269568b
Merge pull request #9688 from cchurch/fix_win_fetch
...
Fixes for fetch module when connecting to Windows hosts
2014-12-02 15:15:06 -05:00
29d41bb789
Revise patch from earlier using even more variable sources for HostVars
...
Superceeds e61e8a3Fixes #9684
2014-12-01 21:44:42 -06:00
de267b5655
Fix PowerShell plugin issues affecting fetch module when used against Windows hosts.
2014-12-01 22:18:35 -05:00
e61e8a37f5
Use extra vars when creating HostVars
...
Fixes #9667
2014-12-01 11:51:09 -06:00
9a5cbf747a
fine tuned lookup/templating errors
2014-11-26 22:06:37 -05:00
db145a368d
now only flattened ignores failonundefined cause of it's special need
2014-11-25 16:12:15 -05:00
7d2937b1cc
minor fixes to template function
...
- make sure it calls itself correctly, now passes same params as it recieves
- vars is reserved, changed for templatevars to avoid confustion
- forcing mustaches again since the removal broke 'listification' as per #9622
- fixes incorrectly successful tests using undefined var, now it is defined
- now returns empty list if items is None to avoid errors
2014-11-25 12:59:13 -05:00
e8716fcbc8
Display more info when SSH errors occur
2014-11-24 00:04:59 -08:00
e9b6aaf5d8
Update PowerShell command line processing to handle parameters passed via splatting.
2014-11-23 22:53:10 -05:00
de2746ae86
Set delegate on connection prior to calling connect.
2014-11-23 21:49:33 -05:00
4b6b58ab11
Fix role parameter precedence after 9a0f8f0
...
Fixes #9497
2014-11-20 12:53:48 -06:00
0edaa6f790
Merge pull request #9270 from bcoca/do_the_shuffle
...
added new 'shuffle' filter
2014-11-20 13:43:00 -05:00
9a0f8f0158
Split out various vars-related things to avoid merging too early
...
Fixes #9498
2014-11-17 15:31:55 -06:00
dd60036fb9
added changed status to return when new early create check is triggered,
...
added skipped check to test on create existing
2014-11-14 11:13:36 -05:00
697582fdde
Fix issue whereby file will be transferred before checking the creates argument.
2014-11-13 20:20:08 +00:00
d4d23b1b1f
Add error when checksumming will fail because python is not present on the remote.
...
Comments for how the remote checksumming works.
Make the checksumming marginally more robust.
2014-11-11 20:05:27 -08:00
565e5bbdfc
Fix up the new expand_user method.
...
quoting anywhere in the user_home_path interferes with shell expansion
so we have to check it for validity ourselves.
2014-11-11 13:54:03 -08:00
bc4272d2a2
Expand tilde remotely in action plugins
2014-11-11 12:28:19 -08:00
3ccb0b8243
Revert expanding hte tilde in shell plugin until we determine why it's forcing fetch down an alternate path
2014-11-10 11:25:45 -08:00
cfe9f1c32f
Expand tilde in path names
2014-11-10 10:39:34 -08:00
30c50020a1
Better way to get the python_interpreter inventory variable
2014-11-10 09:16:20 -08:00
f1267c0b05
Move from md5 to sha1 to work on fips-140 enabled systems
2014-11-06 21:28:04 -08:00
22ef830814
fixed ssh fix, bad test case but it should work now
2014-11-06 14:56:44 -05:00
a2ba0c03e4
added error handling on private key stat in case it is saved in agent
...
but not in filesystem
2014-11-06 13:38:11 -05:00
9ae0fb5bdf
Make OSX fallback to paramiko more selective
...
Only fallback to paramiko now when the ssh password has been set,
either through inventory or via a prompt.
Fixes #9470
2014-11-03 14:32:15 -06:00
3e992b5824
Setting keepalive option before opening session
...
Setting the keepalive option before opening up the paramiko session
in order to avoid the slim chance that the connection is stalled
in the short time between opening the session and setting up the
keepalive. I described the issue I am solving at
https://groups.google.com/forum/#!topic/ansible-project/rkwvz3vyvLk
2014-11-01 00:51:52 -07:00
c86851be2c
Quote ControlPath ssh parameter
...
Fixes #9316
2014-10-22 18:45:02 -04:00
b4f9631e4c
Revert "remove complex_args_hack as it was only needed for Baby JSON"
...
This reverts commit a6029264b8Fixes #9400
2014-10-22 11:00:24 -05:00
4c47c2273a
Use convert_bare instead of string formatting for raw vars in debug action plugin
2014-10-22 11:00:24 -05:00
feb9ed1de8
Fix template module incorrectly handling mode when dest is a directory
...
Fixes #9350
2014-10-21 00:22:24 -04:00
2eda9a3a47
Fixing item loop when undefined variable errors occur because of missing attributes
...
Fixes a case where the variable 'foo' may exist, but the with_items loop
was used on something like 'foo.results', where 'results' was not a valid
attribute of 'foo'. Prior to this patch, conditionals were not evaluated
until later, meaning there was no opportunity to allow a test to skip the
task or item based on it being undefined.
2014-10-10 12:26:04 -05:00
d19fe8d95d
Fetch vars for host directly when calculating the delegated user
...
This fixes the case in which the delegated to host may not be in the
specified hosts list, in which cases facts/vars for the host were
not available in the injected hostvars.
This also fixes the inventory variable fetching function, so that an
unknown host raises a proper error as opposed to a NoneType exception.
Fixes #8224
2014-10-10 01:18:18 -05:00
a6029264b8
remove complex_args_hack as it was only needed for Baby JSON
2014-10-08 13:26:25 -04:00
b592d7653d
unchained list coercion as it removed the randomization
2014-10-08 11:54:22 -04:00
8fb88be41b
Simpler fix for module suffixes than c02e8d8c8.
2014-10-08 11:53:06 -04:00
7a94d566e5
tried to ensure input is always a list but will now be a noop for non
...
listable items
2014-10-08 10:54:14 -04:00
f3714c88a6
Revert "atfork import warning should be suppressed when system_warnings = False"
...
This reverts commit a175168686
2014-10-06 15:05:52 -05:00
3534bdf953
added new 'shuffle' filter
2014-10-05 20:53:06 -04:00
a175168686
atfork import warning should be suppressed when system_warnings = False
...
Fixes #9247
2014-10-03 15:48:56 -05:00
313f26f866
Fix issue with vars precedence from roles
...
Fixes #9219
2014-09-30 15:50:46 -05:00
0af750e3e5
Merge pull request #9182 from bbasleeper/feature_sudo_exe_from_inventory
...
Add a new inventory parameter (ansible_sudo_exe) to specify sudo command...
2014-09-30 14:55:46 -04:00
c02e8d8c80
Don't search powershell modules unless using the winrm connection.
2014-09-28 12:17:03 -04:00
91c5890247
Add some helpful detection if core modules are not found for those running on the development branch.
2014-09-28 11:31:51 -04:00
a25da4af05
Add a new inventory parameter (ansible_sudo_exe) to specify sudo command path.
2014-09-27 17:39:49 +02:00
e5116d2f9b
changes for package loading of modules
2014-09-26 11:25:56 -04:00
6af5455edc
Default 'smart' connection to paramiko for OSX platforms
...
Due to the long-standing bug in sshpass, which can crash OSX.
Fixes #5007
2014-09-25 19:22:35 -05:00
19703617b8
Fix action_plugins for modules not respecting check mode
...
Fixes #9140
2014-09-25 11:11:52 -05:00
4e9c061b35
Also make sure the dest param is expanded locally before recalculating
2014-09-23 15:36:24 -05:00
e47f6137e5
Push the expanduser call on the source down to slurp rather than fetch
...
Also moves the calculation of the destination file name until after
the slurp of the file contents, since the source as returned by slurp
may now be different, so we want to use that expanded path locally.
Fixes #8942
2014-09-23 15:32:07 -05:00
f16e107b72
Merge pull request #9014 from willthames/paramiko_sudo_no_prompt
...
Allow _remote_md5 to work with passwordless sudo even if password is supplied
2014-09-22 16:02:00 -04:00
da5de725d7
Allow with_first_files to search relative to templates and vars in roles
...
Fixes #8879
2014-09-18 16:05:30 -05:00
c3612e08f9
Move delegate_to out of runner module_vars to prevent bleeding across runs
...
Previously, the delegate_to value was stored in the module_vars of runner,
which could lead to bleeding that value across runs and incorrect hosts
being delegated to. This patch moves the value to a local variable in
the Runner class with some related refactoring of _compute_delegate() in
Runner (since the value is no longer required to be a parameter).
Fixes #8705
2014-09-17 14:24:31 -05:00
ed3c9c40ca
Redoing patch for hostvars fix, since the previous one broke other tests
2014-09-17 11:04:10 -05:00
3180a37457
Revert "Revert to using just the combined_cache for HostVars"
...
This reverts commit e9229cfeaa
2014-09-17 11:04:10 -05:00
e9229cfeaa
Revert to using just the combined_cache for HostVars
2014-09-17 02:32:09 -05:00
4a9cf3f3f2
Allow hostvars variables to be templated
...
Fixes #7844
2014-09-16 14:25:55 -05:00
b376e208c7
Adding "follow" param for file/copy options
...
Also modifies the template action plugin to use this new param
when executing the file/copy modules for templating so that links
are preserved correctly.
Fixes #8998
2014-09-16 12:05:55 -05:00
2303044ffc
Applied fix for sudo with no prompt to paramiko
...
Effectively reproduces @sivel's work from #8900 but for
the paramiko connection. Fixes #8418 when using paramiko
This allows `_remote_md5` to work if a sudo password is
passed in when no sudo password is required.
2014-09-16 10:25:21 +10:00
de77f33796
Don't throw away useful stdout and stderr. Fixes #8418
...
When supplying a sudo password to a server that uses passwordless sudo,
we should not throw away useful stdout and stderr. This is particularly
important for modules that perform md5 checks as part of the pre module
execution.
2014-09-16 10:25:21 +10:00
cdf938f2c2
Ensure remote files are chmod'd properly for su/su_user too
...
Fixes #8594
2014-09-15 13:15:46 -05:00
0c4a7492bf
Ensure checkmode is honored for templates that haven't changed
...
Fixes #8998
2014-09-15 11:37:53 -05:00
fb13e2bf2e
Merge pull request #8853 from kvar/devel
...
zypper: handle lists of packages efficiently
2014-09-11 17:30:21 -04:00
178075489b
Merge branch 'gh-7432' of https://github.com/hfinucane/ansible into hfinucane-gh-7432
2014-09-11 12:42:52 -05:00
d9e0a5ed22
Use correct keyword for this function.
2014-09-11 12:32:51 -04:00
26cdddaebf
Tracebacks are now catchable with ignore_errors and have streamlined output. Also removes 'baby-JSON' for bash modules.
2014-09-11 12:27:21 -04:00
dacb6b8561
Use utils.merge_hash() instead of update for cache merging
...
Fixes #8968
2014-09-10 16:39:02 -05:00
a571fd4efe
Convert boolean strings from set_fact to proper boolean values
...
Also adds integration tests for booleanification of strings
Fixes #8629
2014-09-10 09:56:39 -05:00
10afaee108
Fixing new caching related issue with host vars
...
The vars_cache was not being properly merged with the setup_cache
for all hosts, which was previously not noticed when registered
variables were stored in the setup_cache.
Fixes #8944
2014-09-09 15:37:15 -05:00
1711df3b75
Allow complex_args to be None
2014-09-08 08:44:53 -05:00
8cc3543918
Re-allow templating of complex_args, but count params to prevent injection
...
Fixes #8810
2014-09-05 14:24:05 -05:00
53830123fd
Make ssh debug easier to read and paste
...
Currently, ansible -vvvv show the following:
hostname EXEC ['ssh', '-C', '-vvv', '-o', 'ControlMaster=auto',
This is not good if someone want to cut and paste it to see if something
is wrong with the command line, so join the dictionnary strings with spaces
to have 1 string in the output.
2014-09-03 21:04:14 +02:00
acd37c87a9
zypper: handle lists of packages efficiently
2014-09-02 09:38:30 -04:00
36632c9529
Ensure ansible_job_id exists even for not-started jobs
2014-09-01 16:31:37 -07:00
2ddab7affc
Merge pull request #8793 from cchurch/powershell3_compat
...
Replace Get-FileHash with MD5 code that works on PowerShell 3.
2014-08-28 21:25:06 -04:00
ab495d1916
Set the shell variable on the ssh connection type for accelerated mode
...
Fixes #8799
2014-08-28 08:22:24 -05:00
0d1197a995
Replace Get-FileHash with MD5 code that works on PowerShell 3.
2014-08-28 01:42:22 -04:00
88daac4971
ternary filter
2014-08-27 22:27:00 -04:00
a6ad374668
Use split_args directly to check for omitted params
2014-08-27 11:51:03 -05:00
04da466c7b
Fixing up serialize_args utility function
2014-08-27 10:20:07 -05:00
e99db078b4
Additional fixes for the new omit parameter variable
2014-08-27 10:06:55 -05:00
fe88ba7c8d
Undo changes to filter module
2014-08-27 10:04:47 -05:00
559c04f324
Implement omit for module args, also add tests for it
2014-08-27 10:04:47 -05:00
bce6642ab6
Implement default omit correctly
2014-08-27 10:03:07 -05:00
0b4d7f1574
Implement default omit filter
2014-08-27 10:03:07 -05:00
ed34cee36f
Atomically move known hosts file into place for paramiko connections
...
Redo of original patch, which adds an additional check to ensure the
known_hosts file isn't trampled when host_key_checking is disabled.
Fixes #8169
2014-08-26 16:02:59 -05:00
57dee4545b
Make sure cmd is UTF8 encoded before splitting. Fixes regression introduced by 80df2135e9.
2014-08-24 21:06:21 -04:00
07f12539ee
Bugfix: #8720 winrm.py: protocol.send_message() crashes with https
2014-08-22 15:09:48 -04:00
d01188033f
Checking for localized versions of the su password prompt
...
Fixes #8681
2014-08-22 09:59:40 -05:00
8a1fbed5d6
Correct variable blending from vars_files with hostvars in them
...
Fixes #8638
2014-08-20 15:49:01 -05:00
cecfede85f
Merge remote-tracking branch 'svg/issue_8621_8664' into svg_issue_8621_8664
2014-08-19 11:37:59 -05:00
d4ff0d125a
Make sure password files from lookups are created with restrictive permissions
...
Also adds checks for the lookup integration test for passwords.
Fixes #8652
2014-08-19 11:30:04 -05:00
3c06833302
group_by: make sure new group has bigger priority than all group
2014-08-19 16:34:30 +02:00
379e31883c
Fix check mode issues with copy module
...
Fixes #8639
2014-08-18 16:02:45 -05:00
54cbe3dcf9
Disallow args: to be specified as a string
2014-08-14 16:05:20 -05:00
ee18c557ec
Load group_vars for new groups loaded via add_host
...
Fixes #8605
2014-08-14 13:18:26 -05:00
b6261d05b0
Fix typo: & -> and
...
`and` is the boolean operator for AND in [Python][1].
`&` is the bitwise operator for AND in [Python][2].
[1]: https://docs.python.org/2/reference/expressions.html#boolean-operations
[2]: https://docs.python.org/2/reference/expressions.html#binary-bitwise-operations
2014-08-14 16:52:59 +03:00
99c39b1ff3
By popular request, make the no_log attribute also censor tasks from callbacks.
2014-08-12 13:36:05 -04:00
fc7859f445
Make sure playbook_dir variable is an absolute path
...
Fixes #8317
2014-08-12 09:51:44 -05:00
4940a7ad77
Merge pull request #8458 from Jmainguy/runner_8404
...
Fixes 8362, returns stderr if No space left on device
2014-08-11 23:16:57 -05:00
56f9328f93
Merge
2014-08-11 12:22:47 -04:00
03d150de35
Merge pull request #8020 from msabramo/error_when_private_key_file_permissions_incorrect
...
Error if private_key_file is group/world readable
2014-08-08 12:33:07 -04:00
8c4161d4a1
Merge branch 'retf_py' of git://github.com/berendt/ansible into devel
...
Conflicts:
lib/ansible/inventory/vars_plugins/group_vars.py
plugins/callbacks/mail.py
2014-08-08 12:17:37 -04:00
3ba516ac25
adding min() and max() filters for use in Jinja templates
2014-08-08 11:28:48 -04:00
48a0236ec6
Merge pull request #6619 from sergevanginderachter/ansible_version_var
...
Introduce an ansible_version dict as runner variable
2014-08-08 11:20:17 -04:00
d4cedfc7f1
Fix missing variable initialization for async jid
...
Fixes #8491
2014-08-07 23:51:28 -05:00
4a157a72a0
Catch auth errors in winrm and properly raise errors
...
Fixes #7875
2014-08-07 09:00:24 -05:00
ba4693051b
Removing leftover import of atomic_move
2014-08-06 15:38:08 -05:00
efbad90ef8
Revert "Atomically move known hosts file into place when edited by paramiko connections"
...
This reverts commit bd49a835b4
2014-08-06 15:31:54 -05:00
a45c3b84f3
Avoid templating raw lookup strings
2014-08-06 13:25:14 -05:00
dc69510bff
Merge branch 'callback_template_delegate' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-callback_template_delegate
2014-08-05 15:15:03 -05:00
eeec459f8a
Merge branch 'sets_v2' of https://github.com/bcoca/ansible into bcoca-sets_v2
2014-08-05 14:58:01 -05:00
535ebc4c56
Fixes 8362, returns stderr if No space left on device
2014-08-05 15:18:49 -04:00
8f39c114d8
template Runner.module_vars['delegate_to'] to accommodate callbacks
2014-08-05 15:16:43 +02:00
bd49a835b4
Atomically move known hosts file into place when edited by paramiko connections
...
Fixes #8169
2014-08-04 13:08:40 -05:00
7ff63ab754
Revert "Use atomic move function on known host file in paramiko to prevent rare occurance of Control-C"
...
This reverts commit 642b183fb6
2014-08-04 13:11:40 -04:00
6d94ae64ec
Remove unnecessary unicode conversions from parse_kv
...
Fixes #8425
2014-08-04 09:59:08 -05:00
642b183fb6
Use atomic move function on known host file in paramiko to prevent rare occurance of Control-C
...
during file operations.
2014-08-04 10:50:14 -04:00
a7d2e729f8
Add some whitespace to make paramiko_ssh more browseable
2014-08-04 10:38:16 -04:00
9c1a89ff4e
Merge branch 'patch-1' of https://github.com/debfx/ansible into debfx-patch-1
2014-07-31 11:41:21 -05:00
e6fa50a306
Move splitter to module_utils so modules can use it and fix command arg splitting
...
Fixes #8338
2014-07-29 14:55:16 -05:00
645ab7baff
Merge pull request #7950 from mesk41in/devel
...
Fix unsupported regexp parameter in assemble
2014-07-28 12:01:12 -04:00
57f89b85eb
Merge pull request #8271 from tksmd/fix-copy-set-fs-attributes-issue
...
fix an issue that copying directory will fail when trying to change file attributes
2014-07-25 09:38:24 -05:00
630f080cf0
Start of unit tests for split_args function, moved split_args to utils since not needed by modules (so far).
2014-07-24 20:15:04 -04:00
43154e5101
Using custom splitting function for module param counting
2014-07-24 14:42:35 -05:00
1b1d5d0d3d
fix an issue that copying directory will fail when trying to change file attributes and the target file already exists on remote
...
- the issue was introduced by the commit 84759faa09
2014-07-24 14:03:36 +09:00
2cc602beea
Fixes for module param counting and additional shell quoting issues
2014-07-23 22:54:59 -05:00
ac85d8444b
fix for unarchive 8257
2014-07-23 14:50:16 +00:00
84759faa09
Security fixes:
...
* Strip lookup calls out of inventory variables and clean unsafe data
returned from lookup plugins (CVE-2014-4966)
* Make sure vars don't insert extra parameters into module args and prevent
duplicate params from superseding previous params (CVE-2014-4967)
2014-07-21 11:20:49 -05:00
00e089e503
Revert "Explicitly set the user option for ssh connections"
...
This reverts commit 0f91add86fFixes #8216
2014-07-21 10:32:55 -05:00
4e9a253bef
Load existing group_vars file for new group_by group
...
if it was not loaded yet, which happens if that group
didn't exist yet in the inventory.
fixes #8159
2014-07-16 21:16:27 +02:00
0ebd19e97b
Fix regression: Sanitize sudo success_key from stdout
...
Commit 7e3dd10
2014-07-16 18:14:35 +02:00
e74853300a
Merge branch 'task-host-loop-bypass' of https://github.com/sivel/ansible into sivel-task-host-loop-bypass
2014-07-14 14:21:25 -05:00
Jon Hawkesworth
root
Michael Scherer
jszwedko
Michael DeHaan
Toshio Kuratomi
Veres Lajos
Brian Coca
James Keener
Chris Church
James Cammarata
Marc Abramowitz
Brian Coca
Jon Hadfield
akinsley
Bruce Pennypacker
Toshio Kuratomi
Bruno BAILLUET
Will Thames
Matt Martz
Michael DeHaan
Michael Scherer
Kristofor Varhus
Henry Finucane
Victor Lin
Chris Baughman
Serge van Ginderachter
Cristian Ciupitu
Michael Peters
Jonathan Mainguy
someda
Benno Joy
Felix Geyer