b729b35e32
synchronize: Fix (delegated) local rsync
...
Makes delegated local rsync work even if ansible_host or ansible_ssh_host is set.
Makes local rsync work when no ssh is installed.
2017-04-27 09:33:26 -07:00
3efb11e225
synchronize: Exclude ssh_args from quoting
...
Makes it possible again to pass more than one argument via ssh_args to the synchronize module.
2017-03-30 19:40:27 -07:00
f7c9f44aab
synchronize: Convert cmd to list and fix handling of the copy_links argument ( #22573 )
...
* synchronize: Convert cmd to list and fix handling of the copy_links argument
Converting cmd from str to list stops the pain of argument quoting/escaping.
* synchronize: Update imports according to #pullrequestreview-28758614
2017-03-24 09:22:45 -07:00
65d9feea4f
Revert "Quote ssh_args"
...
This reverts commit a9c3a452f0
2017-03-24 09:18:35 -07:00
a9c3a452f0
Quote ssh_args
...
Fixes #22111
2017-03-24 09:17:34 -07:00
3164e8b561
E501 fixes ( #22879 )
2017-03-22 20:50:28 -05:00
eb1214baad
New metadata 1.0 ( #22587 )
...
Changes to the metadata format were approved here:
https://github.com/ansible/proposals/issues/54
* Update documentation to the new metadata format
* Changes to metadata-tool to account for new metadata
* Add GPL license header
* Add upgrade subcommand to upgrade metadata version
* Change default metadata to the new format
* Fix exclusion of non-modules from the metadata report
* Fix ansible-doc for new module metadata
* Exclude metadata version from ansible-doc output
* Fix website docs generation for the new metadata
* Update metadata schema in valiate-modules test
* Update the metadata in all modules to the new version
2017-03-14 09:07:22 -07:00
1ea3313c90
Document synchronize limitations around become and connections ( #22373 )
...
* Document synchronize limitations around become and connections
2017-03-07 10:22:24 -08:00
d3d1aa2dca
synchronize: quote private_key ( #21570 )
...
otherwise rsync will fail when trying to access a key with spaces:
fatal: [default]: FAILED! => {"changed": false, "cmd": "/usr/bin/rsync --delay-updates -F --compress --archive --rsh 'ssh -i /home/user/Some Folder/.vagrant/machines/default/libvirt/private_key -S none -o StrictHostKeyChecking=no -o Port=22' --out-format='<<CHANGED>>%i %n%L' \"/etc/issue\" \"vagrant@192.168.121.10:/tmp/issue2\"", "failed": true, "msg": "Warning: Identity file /home/user/Some not accessible: No such file or directory.\nssh: Could not resolve hostname folder/.vagrant/machines/default/libvirt/private_key: No address associated with hostname\r\nrsync: connection unexpectedly closed (0 bytes received so far) [sender]\nrsync error: unexplained error (code 255) at io.c(226) [sender=3.1.2]\n", "rc": 255}
2017-02-17 14:18:41 +01:00
7c00346714
Validate EXAMPLES as YAML
2017-02-15 13:01:43 -08:00
cb76200c7d
PEP 8 E111 & E114 cleanup. ( #20838 )
2017-01-30 15:01:47 -08:00
7319104552
Refreshed metadata for core modules
2016-12-08 11:25:35 -05:00
2e34bad425
Call main in conditional way - files ( #5828 )
2016-12-08 11:25:35 -05:00
a1b945a23e
> Change example syntax on synchronize module
2016-12-08 11:25:29 -05:00
5a17277bd3
clarifies synchronize module on use of --delayed-updates
2016-12-08 11:25:24 -05:00
25b6492d37
Bulk spelling improvement to modules-core ( #5225 )
...
* Correct spelling mistakes
* Correct more spelling issues
* merge conflict
* Revert typo in parms
2016-12-08 11:25:20 -05:00
c5052f9b01
Be explicit about specifying the ssh port if it was user specified ( #4302 )
...
Previously, if the port specified by the user or inventory was 22, then
the ssh client port would be used instead.
Fixes #3895
2016-12-08 11:24:48 -05:00
b06f3bbb22
fix for rsync protocol ( #4211 )
2016-12-08 11:24:47 -05:00
a28b23db86
Update delete notes for Synrhconize docs ( #3723 )
...
The example for delete=yes does not specify recursive although it is
required. In addition, the wording for the delete option is confusing
about from where files are really deleted. This should clarify that.
2016-12-08 11:24:36 -05:00
f7fb5e31c2
added rsync protocol support ( #1999 )
...
* added rsync protocol support
* correction for example document(add example for push on delegate)
* use startswith method for safety
2016-12-08 11:24:16 -05:00
e4a88eeebe
Fix synchronize docs to indicate the correct default for use_ssh_args
2016-12-08 11:24:11 -05:00
cea1125d02
Correct dest_port to be of type int
2016-12-08 11:24:08 -05:00
ceba43e701
Better error message when rsync nad ssh aren't present where synchronize is run
...
Fixes https://github.com/ansible/ansible/issues/9305
2016-12-08 11:24:01 -05:00
25ccb98d49
Add custom or 'prepared' diff field to synchronize module
...
This PR depends on pull requeest ansible/ansible#14105
rsync has a custom diff output that cannot easily be expressed as
`/usr/bin/diff before after`
2016-12-08 11:24:01 -05:00
457dfb3b4b
Add an internal param instructing synchronize to replace localhost with the host that's being ssh'd from
2016-12-08 11:24:01 -05:00
5e4fe92676
Fix documentation build
2016-12-08 11:24:01 -05:00
5f35d0d597
Document that synchronize in 2.0.0.x has broken sudo behaviour.
...
Part of the changes for #13825
2016-12-08 11:24:01 -05:00
58573187f8
Change the example of rsync_opts to use a list instead of a string
...
Fixes #9889
2016-12-08 11:23:37 -05:00
4a4674ca24
Fix syntax error in synchronize docstring
2016-12-08 11:23:36 -05:00
dabf94ab1f
Explanation of privilege escalation in notes
...
An attempt to make clear how privilege escalation works with respect to the src/source host and dest/destination host. One existing note was incorporated into three new ones, iterating each.
2016-12-08 11:23:36 -05:00
a10b0e6fff
Modify the default for synchronize's dest_port again
2016-12-08 11:23:30 -05:00
052320b452
Update docs to reflect precedence for synchronize's dest_port param
2016-12-08 11:23:29 -05:00
9ba5a438a8
Allow mode as a synchronize parameter (handled in action plugin)
2016-12-08 11:23:29 -05:00
a01a800b65
Fi the local_rsync_path parameter used by the action plugin
2016-12-08 11:23:26 -05:00
88881415e9
synchronize: add flag for verifying target host.
...
Add the possibility to verify the target host using a "verify_host"
flag. It is disabled by default to not change the module behaviour.
2016-12-08 11:23:22 -05:00
870446dd6b
Update version_added to 2.0 for the partial option
2016-12-08 11:23:12 -05:00
81ea358b09
synchronize module: add partial option
2016-12-08 11:23:12 -05:00
eb881d7d5d
Proper author info for all remaining modules
2016-12-08 11:23:07 -05:00
118382ca70
synchronize: don't add ssh_args to ssh_opts when false or null
2016-12-08 11:22:56 -05:00
1ceaa78dc0
Add version_added for the use_ssh_args option
2016-12-08 11:22:55 -05:00
4faf0d59da
Add ability to specify using ssh_args in synchronize
2016-12-08 11:22:55 -05:00
f5961f9ecf
synchronize: use a single -F instead of -FF
...
This small change corrects behavior when one uses an .rsync-filter file to exclude some paths from both being transferred and being deleted, so that these excluded paths can be handled separately with different tasks (e.g. in order to deploy the excluded paths independently from the rest paths and notify handlers appropriately). The problem with the double -FF option is that it excludes the .rsync-filter file from being transferred to the receiver. However, deletions are done on the side of the receiver, so it is absolutely necessary the .rsync-filter file to be transferred to the receiver, so that the receiver knows what files to delete and what not to delete.
2016-12-08 11:22:42 -05:00
b15a633103
Note that `rsync` must be installed on both local & remote machine
...
In particular, if `rsync` is not installed on the remote machine the following error message will be encountered:
"rsync error: remote command not found"
2016-12-08 11:22:31 -05:00
6e900744f2
fix spelling
2016-12-08 11:22:23 -05:00
6eda3cbee7
Added note to files/synchronize module about synchronizing two directories on the same host
2016-12-08 11:22:23 -05:00
213e518165
file extensions!
2016-12-08 11:22:22 -05:00
Erwin Lang
Toshio Kuratomi
Matt Martz
Evgeni Golov
Matt Clay
Fabio Alessandro Locati
Sam Doran
Timothy Appnel
John R Barker
peter.jang
Matt Fischer
Toshio Kuratomi
Tobias Wolf
James Cammarata
skylerbunny
Patrik Lundin
Juan Picca
Greg DeKoenigsberg
Ryan Hartkopf
Petros Moisiadis
follower
Ted Timmons
Joe Adams
Michael DeHaan