Matt Martz
269cdffcea
Format dict keys need to be bytes ( #52728 )
2019-02-21 11:43:45 -06:00
Shivam Singhal
19cf956453
Fixes typo digeset to digest ( #52709 )
2019-02-21 16:23:42 +05:30
Shivam Singhal
e931dd0e58
Fixes typo of formating to formatting ( #52710 )
2019-02-21 16:03:48 +05:30
Nathaniel Case
1b9745722e
Fix issues with enable become plugin ( #52657 )
...
* Work around become_user not being set
2019-02-20 16:15:45 -05:00
Martin Krizek
be9f07279e
Add stats on rescued/ignored tasks ( #48418 )
...
* Adding rescued/ignored tasks to stats gathering
Fixes #31245
* Amend integration tests to pass
* callback/dense.py: fix too-many-format-args
* Add changelog
* Amend counter_enabled and unixy callbacks
* Fix syntax error
* Fix typo in the changelog
* Remove not needed comment
* Re-add skipped
* Add test for rescued
* Fix colors...
* Fix unstable tests?
* Add a note to the porting guide
* Re-word the note in the porting guide
Fixes #20346
Fixes #24525
Fixes #14393
Co-authored-by: James Cammarata <jimi@sngx.net>
Co-authored-by: Martin Krizek <martin.krizek@gmail.com>
2019-02-20 13:00:47 +10:00
Adi Rizka
81ab3995e2
add override value for sort_keys in to_nice_json ( #52341 )
2019-02-19 16:12:08 -05:00
Dag Wieers
04a2a22c0f
zabbix: Clean up parameter types ( #52516 )
...
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement
2019-02-19 15:56:58 -05:00
Dag Wieers
e435c71c16
validate: Clean up parameter types ( #52521 )
...
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement
This breaks out PR #52182
2019-02-19 15:52:10 -05:00
Dag Wieers
2cb9d9da14
return_common: Clean up parameter types ( #52524 )
...
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement
2019-02-19 15:50:11 -05:00
Dag Wieers
1d3eb0bafd
online: Clean up parameter types ( #52527 )
...
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement
This breaks out PR #52182
2019-02-19 15:48:30 -05:00
Dag Wieers
953d4c8a7f
oneview: Clean up parameter types ( #52537 )
...
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement
This breaks out PR #52182
2019-02-19 15:47:45 -05:00
Dag Wieers
4dce9c4da9
manageiq: Clean up parameter types ( #52538 )
...
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement
This breaks out PR #52182
2019-02-19 15:47:13 -05:00
Dag Wieers
a7846391a9
ldap: Clean up parameter types (other) ( #52541 )
...
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement
This breaks out PR #52182
2019-02-19 15:46:22 -05:00
Dag Wieers
4c97481337
keycloak: Clean up parameter types ( #52542 )
...
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement
This breaks out PR #52182
2019-02-19 15:44:41 -05:00
Martin Krizek
f8d1fa80e9
debug: prevent failing when printing var=rc ( #52074 )
...
Fixes #52073
2019-02-19 15:24:11 -05:00
Dag Wieers
aa83307c68
doc_fragments: Clean up parameter types (other) ( #52182 )
...
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement
2019-02-19 15:23:26 -05:00
Matt Martz
b54086ef02
Merge doc fragments in earlier ( #52193 )
...
* Merge doc fragments in earlier
* Move it even higher
* Remove errant docs key
* Fix type
2019-02-19 09:02:12 -06:00
Dag Wieers
409345ee97
utm: Clean up parameter types ( #52517 )
...
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement
This breaks out PR #52182
2019-02-19 12:19:32 +00:00
Dag Wieers
5ee378430b
tower: Clean up parameter types ( #52522 )
...
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement
This breaks out PR #52182
2019-02-19 12:18:38 +00:00
Dag Wieers
e7df487a6c
rabbitmq: Clean up parameter types ( #52525 )
...
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement
This breaks out PR #52182
2019-02-19 12:17:28 +00:00
Sumit Jaiswal
8a2ff1cde6
PR to start support for Skydive integration with Ansible ( #50857 )
...
* skydive modules
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* skydive modules
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* skydive modules
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* skydive modules
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* skydive modules
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* skydive modules
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* skydive modules
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* fix shippable
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* modifying file name
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* fix shippable
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* renamed
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* skydive lookup
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* change in str
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* change in str
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* fix shippable error
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* renamed file
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* fix shippable error
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* change in str
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* fix shippable error
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* fix shippable error
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* fix review comments
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* fix review comments
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* deleting file to add to new PR
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* fix review comments
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* shippable and doc fix
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* placing doc at correct path
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* shippable and doc fix
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* placing doc at correct path
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* updated with review and shippable fix
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* updated with review and shippable fix
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* updated with review and shippable fix
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* updated with review and shippable fix
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* fixing review comment
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* fixing review comment
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* fixing review comment
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* fixing review comment
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* fixing review comment
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* fix shippable errors
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* fix shippable error
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* fix review comments
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* fixing shippable errors
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* fix review comments
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* review comments
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* shippable fix
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* review comment
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-02-19 16:18:40 +05:30
Abhijeet Kasurde
24d1886499
template: add additional variable for dest path ( #52015 )
...
Signed-off-by: Dustin Spicuzza <dustin@virtualroadside.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-19 14:15:19 +05:30
Alex Vasilenko
20ed819acd
Fix exception handling in credtash lookup ( #51099 )
...
Exception does not have property message and ansible returns completely different exception because of this
2019-02-18 18:28:35 -05:00
Nathaniel Case
686f4b35e3
Add enable become plugin patterned after runas ( #52496 )
2019-02-18 12:10:54 -05:00
Nilashish Chakraborty
bc403dbcda
Added new module - frr_facts ( #51804 )
...
* Add new module frr_facts
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Fix return value
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Fix review comments
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Fix review comments
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Handle empty row for mpls ldp neighbors
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Fix review comments
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Fix CI
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Remove timestamp from cliconf pluging
* Updated examples
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Fix sanity tests
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-02-18 19:35:40 +05:30
Felix Fontein
1d8e9db4a9
crypto modules: add missing option types ( #52421 )
...
* Add missing crypto option types.
* Reorder argument_spec.
* Reorder option docs.
2019-02-18 10:24:17 +00:00
Ondra Machacek
435e0c5dba
Update kubevirt_vm with new feautures ( #52311 )
2019-02-18 15:12:23 +05:30
Sayed Anisul Hoque
7d6a94e7dc
Fixed typos ( #52426 )
2019-02-17 22:49:40 +01:00
Dag Wieers
677c04c01d
Sanity fixes to parameter types ( #52325 )
2019-02-15 16:58:58 +01:00
David Soper
958653e282
Cisco Intersight module_utils and intersight_facts module ( #51309 )
...
* Cisco Intersight module_utils and intersight_facts module
* Add RETURN information and fix pylint, import, and pep8 issues.
* Review updates for specifying type of params/returns and not polluting ansible_facts.
* BSD one line license, validate_certs used, urls.fetch_urls replaces requests
2019-02-15 16:32:29 +01:00
Dag Wieers
c2fb581414
Fix various sonarcloud issues
...
This fixes various reported bugs through sonarcloud at:
https://sonarcloud.io/project/issues?id=Rodney-Reis_ansible&resolved=false&types=BUG
2019-02-15 07:19:04 -08:00
Dag Wieers
25323155d2
doc_fragments: Clean up parameter types (cloud) ( #52177 )
...
* module_utils: Clean up parameter types (cloud)
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement
- Description fixes (only for a few files, then I stopped :-))
* More cloud stuff
* Fix reported issue
* Fix quotes
* Use correct type
* Fix quotes
* Fix quotes
* Fix quotes
* Fix typo
* Fix boolean
2019-02-15 12:21:20 +00:00
Dag Wieers
203caf2570
Fix module issues ( #52209 )
2019-02-15 12:57:20 +01:00
Dag Wieers
9c1033422b
doc_fragments: Clean up parameter types (network) ( #52176 )
...
* module_utils: Clean up parameter types
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement
- Description fixes (only for a few files, then I stopped :-))
* More network stuff
* Fix typo
* Fix PEP8
* Fix booleans
* Fix typo
2019-02-15 09:52:48 +00:00
Dag Wieers
27dfdb6a6a
doc_fragments: Clean up parameter types (database) ( #52178 )
...
* module_utils: Clean up parameter types (database)
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement
- Description fixes (only for a few files, then I stopped :-))
* Fix validate-modules test ignores
2019-02-15 08:32:45 +00:00
Dag Wieers
fbca8a4615
doc_fragments: Clean up parameter types (storage) ( #52179 )
...
* module_utils: Clean up parameter types (storage)
This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement
- Description fixes (only for a few files, then I stopped :-))
* Fix quotes
* Fix rST issue
2019-02-15 08:31:12 +00:00
Emmanouil Kampitakis
1219aa811a
Feature/alphanumeric password in passwordstore ( #38121 )
...
* Alphanumeric only password may be generated
* Bump the ansible version this will have been added to 2.8
2019-02-14 17:02:24 -05:00
Matt Clay
3e778d3f8f
Fix pycodestyle E117 issues.
2019-02-13 23:35:39 -08:00
Simon Westphahl
02e87b7d70
Raise AnsibleConnectionError on winrm connnection errors ( #51744 )
...
* Raise AnsibleConnectionError on winrm con errors
Currently all uncaught exceptions of the requests library that is used
in winrm will lead to an "Unexpected failure during module execution".
Instead of letting all exceptions bubble up we catch the connection
related errors (inkl. timeouts) and re-raise them as
AnsibleConnectionError so Ansible will mark the host as unreachable and
exit with the correct return code.
This is especially important for Zuul (https://zuul-ci.org ) to
distinguish between failures and connection/host related errors.
* Update lib/ansible/plugins/connection/winrm.py
Co-Authored-By: westphahl <westphahl@gmail.com>
* Add changelog fragment
2019-02-13 14:55:55 -05:00
René Moser
02f51e865c
cloudscale: combine docs in fragment ( #52069 )
...
* cloudscale: combine docs in fragment
* workaround false negative E305
2019-02-13 13:52:01 -06:00
Jordan Borean
847d089d6b
Re-add support for setting shell from play context ( #52139 )
...
* Re-add support for setting shell from play context
* Add integration tests
* Add more tests for shell override
* fix sanity issue
2019-02-13 11:49:13 -06:00
Matt Martz
b34d141eed
Disallow use of remote home directories containing .. in their path (CVE-2019-3828) ( #52133 )
...
* Disallow use of remote home directories containing .. in their path
* Add CVE to changelog
2019-02-13 10:38:28 -06:00
Juan Antonio Osorio
9f081ca04f
identity: Add GSSAPI suport for FreeIPA authentication ( #52031 )
...
* identity: Add GSSAPI suport for FreeIPA authentication
This enables the usage of GSSAPI for authentication, instead of having
to pass the username and password as part of the playbook run.
If there is GSSAPI support, this makes the password optional, and will
be able to use the KRB5_CLIENT_KTNAME or the KRB5CCNAME environment
variables; which are standard when using kerberos authentication.
Note that this depends on the urllib_gssapi library, and will only
enable this if that library is available.
* identity: Add documentation for GSSAPI authentication for FreeIPA
This documentation describes how to use GSSAPI authentication with the
IPA identity modules.
* identity: Add changelog for GSSAPI support for IPA
This adds the changelog entry for the GSSAPI authentication feature for
the IPA identity module.
2019-02-13 15:38:13 +00:00
Alan Rominger
af9ff07c74
Send openstack inventory logs to stderr ( #51827 )
2019-02-13 13:36:37 +00:00
Abhijeet Kasurde
32fce43311
hashi_vault: fix multiple spaces in params ( #51524 )
...
Fixes param parsing in hashi_vault
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-13 18:32:00 +05:30
Pilou
51270be883
tower modules: check that 'verify_ssl' defined in ~/.tower_cli.cfg isn't ignored ( #50687 )
...
* Check that verify_ssl defined in tower_cli.cfg isn't ignored
* Avoid to override verify_ssl value defined in tower_cli.cfg
By default, tower-cli library enables SSL certificates check. But
verify_ssl false value defined in config files read by default by
tower-cli library (for example /etc/tower/tower_cli.cfg) was ignored
because overriden by the tower_verify_ssl parameter default value.
* fix a typo in comment
2019-02-13 10:26:43 +00:00
Ondra Machacek
797a5218fb
kubevirt: Add new kubevirt_vm module ( #50768 )
...
This module is managing virtual machines using KubeVirt.
Signed-off-by: Ondra Machacek <omachace@redhat.com>
2019-02-13 10:17:01 +00:00
Matt Clay
04112d47a7
Fix more incorrect uses of `is` operator.
2019-02-12 20:04:20 -08:00
Matt Davis
cd7a144515
fix docker default remote_user ( #52137 )
...
Fix bogus default value in config- exposed by become plugins (#50911 ) actually using this value in more cases.
2019-02-12 16:29:27 -08:00
Abhijeet Kasurde
4e0e09d2de
docs: update docs about pipelining ( #51856 )
...
Additional documentation about `keep_remote_files` and
`pipelining` configurations.
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-12 12:49:00 -05:00