Toshio Kuratomi
646d0e406d
Set one parameter to be type path
2016-12-08 11:24:08 -05:00
Ton Kersten
b58e16ed3d
Fix facter path
...
In Puppet 4 and in the PE edition, the Puppet tree is installed in
`/opt/puppetlabs/...` and all commands can be reached from
`/opt/puppetlabs/bin`.
2016-12-08 11:24:07 -05:00
Matt Martz
aaf762573e
Various simple linting type cleanups on modules
2016-12-08 11:24:06 -05:00
jjshoe
a160d5426d
List which version it was added
...
fixes https://github.com/ansible/ansible-modules-core/issues/2605
2016-12-08 11:24:05 -05:00
Luca Berruti
feb309e3cf
Typo.
2016-12-08 11:24:04 -05:00
Brian Coca
b5c9945485
avoid chmod in check mode
2016-12-08 11:24:04 -05:00
Brian Coca
5aff573098
revamped checkmode support in user module
...
- defaulted to commands not executing in checkmode
- added force run for info gathering (for setting changed)
- added debug for what would have been run in check mode
- added check mode for spots that made changes using system calls instead of command
- removed now redundant checkmode checks
better failure now, if i missed anything, it will misreport changed value
instead of old default of actually making the change in checkmode
2016-12-08 11:24:04 -05:00
Matt Clay
642746d0a3
Make modify_user_usermod honor check mode on AIX.
2016-12-08 11:24:03 -05:00
Matt Clay
04ad3fe304
Make modify_user honor check mode on OS X.
2016-12-08 11:24:02 -05:00
Matt Clay
c87f70429b
Make modify_user honor check mode on FreeBSD.
2016-12-08 11:24:01 -05:00
Toshio Kuratomi
f6aa1ff9a4
Remove duplicate documentation fields
2016-12-08 11:24:01 -05:00
Toshio Kuratomi
b6ff36bed3
Fix documentation build in hostname
2016-12-08 11:24:01 -05:00
Hiroaki Nakamura
f2246deaf9
Doc: Add NOTE about hostname modules does not modify /etc/hosts
2016-12-08 11:24:00 -05:00
Thomas Quinot
ef3308159f
Allow cron_file to be an absolute path
...
Support specifying an absolute path (typically /etc/crontab) rather than
a path relative to /etc/cron.d, to allow modifying the main system crontab.
Particularly useful for target systems that have /etc/crontab but no
/etc/cron.d.
2016-12-08 11:24:00 -05:00
Luca Berruti
0673a4919f
cron module: add enviroment variables management
2016-12-08 11:23:59 -05:00
Brian Coca
4c6515e299
reverse order of cron commands
...
does not affect linux but fixes issue with busybox caring about order
fixes #2807
2016-12-08 11:23:58 -05:00
Jeroen Seegers
7be08b00b0
Update cron.py
...
Minor update to documentation for the cron module to reflect the required "name" parameter when the value of "state" is "absent".
2016-12-08 11:23:58 -05:00
Brian Coca
f8a36c4047
service goes back to failing when absent
...
if no tools and no init script, this should always fail
2016-12-08 11:23:53 -05:00
Brian Coca
f435f887fa
better handling of checkmode for solaris fixes #2296
2016-12-08 11:23:51 -05:00
tobbe
65f12bccb6
add text to the description, more user friendly
2016-12-08 11:23:51 -05:00
tobbe
455da45e62
Add suport for selinux user when adding a new user on selinux enabled systems
2016-12-08 11:23:51 -05:00
Michael Scherer
55f2345829
Remove a unneeded use of use_unsafe_shell
...
Since use_unsafe_shell is suspicious from a security point
of view (or it wouldn't be unsafe), the less we have, the less
code we have to toroughly inspect for a security audit.
2016-12-08 11:23:51 -05:00
nitzmahone
0d0b78dd1e
fixed disappearing groups on OSX user module
...
Ensure that we don't try to modify the groups collection if groups are not specified
2016-12-08 11:23:51 -05:00
Dominique Barton
5c05016d1e
bugfix for issue #2537
2016-12-08 11:23:51 -05:00
Sina Sadeghi
2ad9c6c9e5
Update hostname.py
...
Added support for FreeBSD. (http://www.freebsd.org )
2016-12-08 11:23:50 -05:00
Brian Coca
b3c14ee0c3
minor doc fixes and reformating updated validate_certs feature to be 2.1
2016-12-08 11:23:50 -05:00
Veaceslav (Slava) Mindru
2eb6b566b2
Squashed commit of the following:
...
commit 406214fad214359fcf13fe8c7cd3f8f8faac5386
commit 85d1c9b0a41dd075eb2683b1a7de595ca3119614
commit 4aa5049b5ae25dee71a248238201611a466a13c4
commit 65a96974c80aea1fef88d78e218ecb665d8113e1
commit 22ea5863d1dfd628735b46cc7de51c0fd33251de
Refactoring
2016-12-08 11:23:49 -05:00
Martin André
aaa82d1942
Fix typo in ping module short description
2016-12-08 11:23:49 -05:00
Jordi De Groof
7aa57219f6
Update facts when hostname is changed
...
ansible_hostname contains the unqualified hostname
2016-12-08 11:23:48 -05:00
Greg DeKoenigsberg
f08d60388c
@bradobro stepping down as maintainer
2016-12-08 11:23:47 -05:00
Brian Coca
d2cffb31c3
rearranged systemd check, removed redundant systemctl check fixed unused cmd and state var assignements
2016-12-08 11:23:44 -05:00
Simon Hafner
923e442409
added earlier paths to systemd
...
2b583ce657
b925e72633
2016-12-08 11:23:43 -05:00
Simon Hafner
4af48e139c
simpler way to check if systemd is the init system
...
According to
http://www.freedesktop.org/software/systemd/man/sd_booted.html
check if the directory /run/systemd/system/ exists.
2016-12-08 11:23:43 -05:00
Brian Coca
505467d2ff
clarified ping module purpose
2016-12-08 11:23:42 -05:00
Toshio Kuratomi
80b3bbd55e
Mark a few parameters as no_log
2016-12-08 11:23:42 -05:00
Achilleas Pipinellis
961082620c
Add missing documentation: cron_file requires user to be set
2016-12-08 11:23:40 -05:00
gekmihesg
d003fcd662
Support sysctl on OpenBSD
...
Fixes #1233
2016-12-08 11:23:39 -05:00
Simon Li
607b7c14bd
Fix incorrect variable in group.py: user -> group
2016-12-08 11:23:39 -05:00
Brian Coca
45907f2ff3
removed typo
2016-12-08 11:23:38 -05:00
Brian Coca
d55ba3ab7c
removed syslog in favor of common module logging functions
2016-12-08 11:23:38 -05:00
Brian Coca
682cb99d45
revert must_exist
2016-12-08 11:23:38 -05:00
Mike Boone
dd76088019
Updated link to the FAQ.
2016-12-08 11:23:36 -05:00
Brian Coca
99159b3cdd
changed chmod to 2.4 compat
2016-12-08 11:23:35 -05:00
Brian Coca
917b7071d6
partially reverted previous change to deal with systemctl show status not returning errors on missing service Now it looks for not-found key instead of running status which does return error codes when service is present but in diff states. fixes #12216
2016-12-08 11:23:34 -05:00
Brian Coca
fd23120d42
check systemctl status before show as show will not return antyhing other than rc=0 even when it fails.
2016-12-08 11:23:34 -05:00
Marius Gedminas
b2fc74337a
authorized_key: fix example in documentation
...
'key=' cannot be pointing to a file name; it needs to be the key itself as a string (or a URL).
2016-12-08 11:23:33 -05:00
Tim Rupp
223cac3f39
Add hostname support for Kali linux 2.0
...
This patch allows the hostname module to detect and set the hostname for a
Kali Linux 2.0 installation. Without this patch, the hostname module raises
the following error
hostname module cannot be used on platform Linux (Kali)
Kali is based off of Debian.
2016-12-08 11:23:33 -05:00
Marius Gedminas
f97d00fbad
user: don't generate SSH keys in check mode
...
Fixes https://github.com/ansible/ansible/issues/11768
Test plan:
- (in a Vagrant VM) created a user 'bob' with no ssh key
- ran the following playbook in check mode:
---
- hosts: trusty
tasks:
- user: name=bob state=present generate_ssh_key=yes
- saw that ansible-playbook reported "changes=1"
- saw that /home/bob/.ssh was still absent
- ran the playbook for real
- saw that /home/bob/.ssh was created
- ran the playbook in check mode again
- saw that ansible-playbook reported no changes
- tried a variation with a different username for a user that didn't
exist: ansible-playbook --check worked correctly (no errors, reported
"changed")
2016-12-08 11:23:33 -05:00
Simon Li
28c44c554c
Don't fail in check_mode if user exists
...
PR #1651 fixed issue #1515 but the requirement for path to be defined is unecessarily strict. If the user has previously been created a path isn't necessary.
2016-12-08 11:23:33 -05:00
Александр Костырев
ec8a94f748
Fix documentation of authorized_key.py
...
man for sshd http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man8/sshd.8?query=sshd
says there's no "host" option but "from".
2016-12-08 11:23:31 -05:00