f89cb1717c
Fixing nxos_vtp_password ( #5037 )
2016-12-08 11:25:15 -05:00
b897b497c1
Fixing nxos_vtp_version ( #5038 )
2016-12-08 11:25:15 -05:00
58a5ec6c51
fixes junos_command module paring of wait_for strings ( #5083 )
...
The junos_command module wasn't properly parsing strings to apply
conditionals due to the return value not being converted to json
before the results where handed to the runner.
2016-12-08 11:25:15 -05:00
9ed01d0cfd
fixes junos_template ignoring the action directive ( #5080 )
...
This updates the junos_template to properly process the action
directive when loading the configuration.
2016-12-08 11:25:15 -05:00
177dcadbc0
deprecated _template network modules: Rename in modules-core ( #5072 )
2016-12-08 11:25:14 -05:00
f7b10720ac
typo in module name ( #5062 )
2016-12-08 11:25:14 -05:00
0a85e64b4a
fixes exception raised due to KeyError ( #5068 )
...
The vyos_config module would error when looking for a key called `updates`
in module.params. There is no such key. This fixes the problem.
2016-12-08 11:25:14 -05:00
73cf85d677
catches exception if conditional cannot be parsed ( #5067 )
...
If the conditional cannot be parsed, the module will now catch the exception
and return a well formed failed message.
fixes #5060
2016-12-08 11:25:14 -05:00
da4c11241f
fixes error when 'delete ...' config command is specified but doesn't exist ( #5064 )
...
The junos_config module will generate an exception if a 'delete ...' config
command is attempted to be loaded into a device configuration. This change
will first check to see if the delete command is valid and filter it out
of the change set if it is not valid.
fixes #5040
2016-12-08 11:25:14 -05:00
aa82f48dc8
Network module code cleanup ( #5061 )
...
* Fix imports in junos_template
* Python 3 compatibility in eos_command
* Python 3 compatibility for ios_command
* Clean up issues with ios_facts
* Python 3 compatibility for ios_facts
* Import shuffle in ios_template
* Python 3 compatibility for iosxr_command
* Clean up iosxr_facts.py
* Python 3 compatibility for iosxr_facts
* Python 3 compatibility for junos_command
* Python 3 compatibility for ops_command
* Cleanup issues with ops_facts
* Python 3 compatibility for ops_facts
* Cleanup issues with ops_template
* Python 3 compatibility for vyos_command
* Cleanup issues with vyos_facts
* Python 3 compatibility for vyos_facts
2016-12-08 11:25:14 -05:00
6ae0342a0a
Fix imports in junos_template ( #5059 )
2016-12-08 11:25:14 -05:00
9b286b1775
eos_facts cleanup ( #5057 )
...
* dict.iteritems does not exist in Python 3
Now just dict.items
six.iteritems handles the change
* Addresses point 1
Unsure if this is a good idea or not.
* Addresses point 2
This shouldn't have any particular change, just marks load_comments as abstract
* Remove unused import
Addresses point 3
* Clarify invalid subset error message
Addresses point 4
2016-12-08 11:25:14 -05:00
0ef16b44ca
fixes exception being raised when show configuration command issued ( #5047 )
...
The junos_command expects commands to be returned as xml by default but
`show configuration [options]` will return text not xml. This fix
will set the output format for any command that starts with `show
configuration` to text
fixes #4628
2016-12-08 11:25:14 -05:00
a5b32fa0d1
fixes return passing output from command through jxmlease in junos_command ( #5044 )
...
The return string from the commands was not being passed through the
jxmlease library and therefore being returned as a string instead of a
json data structure. This also adds back the missing xml key in the
return that includes the raw xml string.
fixes #5001
2016-12-08 11:25:14 -05:00
4504f2d8c7
Update minimum required version and ssh rate limit ( #4995 )
2016-12-08 11:25:13 -05:00
654a38897f
fixes exception raised when nxos_facts uses nxapi transport ( #4988 )
...
This fixes a condition where an exception is raised when collecting `interface`
facts and the transport is set to nxapi in the nxos_nxapi module.
fixes ansible/ansible#17691
2016-12-08 11:25:13 -05:00
df6b7703bb
fixes default value in docstring for http ( #4985 )
...
The docstring incorrectly stated the default value for http is yes when
indeed its no. This fixes the docstring
2016-12-08 11:25:13 -05:00
88b2c7e1f6
fixes bug where setting state=absent in nxos_nxapi is not idempotent ( #4984 )
...
When setting state=absent the nxos_nxapi module would always try to remove
the configuration regardless of the current state of the device. This will
fix that problem.
This also updates the docstring to correctly reflect https as default=no
fixes #4955
depends on ansible/ansible#17728
2016-12-08 11:25:13 -05:00
f63e5d078e
Force is not a 2.2 feature
...
9b5e6bbfa1
2016-12-08 11:25:13 -05:00
b06123e986
fixes junos_config to be idempotent when confirming a commit ( #4946 )
...
The junos_config module would always return true when confirming a commit
This changes the module to now check first making the feature idempontent
2016-12-08 11:25:12 -05:00
868c298968
fixes import statements in junos_package module ( #4929 )
...
This fixes the import statement to import NetworkModule from network instead
of from junos
2016-12-08 11:25:11 -05:00
3e577f6312
fix up junos_facts import statements ( #4928 )
...
This fixes the junos_facts import statements and removes importing
NetworkModule from the junos shared module.
2016-12-08 11:25:11 -05:00
b9cb9d6345
fix import in junos_command module ( #4927 )
...
This fixes the import statements in the junos_command module to be
consistent with all junos_* modules
2016-12-08 11:25:11 -05:00
82cf70e0f3
roll up of bug fixes for junos_config module ( #4925 )
...
* fixed docstring referencing old arguments
* changed out lxml for xml library to avoid import errors
* fixed issue when trying to confirm a commit will end up a NOOP
* fixed issue for passing replace argument to load_config method
2016-12-08 11:25:11 -05:00
0acab8bd19
bug fixes in junos_netconf module ( #4924 )
...
* fixes exception thrown when sending commands to device
* fixes exception thrown when retrieving current resource instance
* fixes issue where netconf would be configured in some instances when state
was set to absent
* now returns the command string sent to the remote device
* fixes argument name to be netconf_port with alias to listens_on
2016-12-08 11:25:11 -05:00
319b2b28cb
Fix YAML syntax in NXOS documentation ( #4922 )
...
* Fix YAML syntax in NXOS documentation
Use ':' and not '=' to ensure valid YAML
in the EXAMPLES
* Correcting introduced syntax error
2016-12-08 11:25:11 -05:00
6cdcf09984
Remove duplicate keys from module docs. ( #4920 )
2016-12-08 11:25:11 -05:00
c47fd4b3e9
Add feature mappings
2016-12-08 11:25:11 -05:00
25375f1057
adds exception handling to nxos_command for FailedConditionalError
...
This adds exception handling as per ansible/ansible#17638 to the
nxos_command module.
2016-12-08 11:25:11 -05:00
a8ca526450
bug fix that now catches FailedConditionalError when specifying conditionals
...
This is related to ansible/ansible#17638 and updates the eos_command module
to catch the exception and return a santatized error.
2016-12-08 11:25:11 -05:00
90378e9168
Fix duplicate required key error
...
ansible-doc -vvvv -l show this warning:
[WARNING]: While constructing a mapping from /home/misc/checkout/git/ansible/lib/ansible/modules/core/network/junos/junos_config.py,
line 88, column 5, found a duplicate dict key (required). Using last defined value only.
2016-12-08 11:25:10 -05:00
0c94d84910
eos_eapi module allows independent configuration of protocol and port
...
The eos_eapi module would not configure the port if the protocol wasn't
configured as reported in #4905 . This changes the behavior to now allow
the port to be configured independently
fixes #4905
2016-12-08 11:25:10 -05:00
6701f038ba
Fixed docstring
2016-12-08 11:25:10 -05:00
0eb63cdeaa
Fixing nxos_portchannel
2016-12-08 11:25:10 -05:00
1ee897e988
Addressed review comments, given as part of other reviews ( #4904 )
2016-12-08 11:25:10 -05:00
a7242039ad
Updated the config module to use the new Parse method for OS6
2016-12-08 11:25:10 -05:00
8adc05051c
Added support for template module for Dell OS6 devices
2016-12-08 11:25:10 -05:00
1a8e0487ff
fixing the CI issue, the python interperter line
2016-12-08 11:25:10 -05:00
4fd0ad09b3
Updated the copyright
2016-12-08 11:25:10 -05:00
89cd8c03c0
Added support for dellos6_facts module
2016-12-08 11:25:10 -05:00
1c4efc8b2c
dnos* -> dellos* (Rename module & updated copyright) ( #4888 )
...
* Renamed the Modules from dnos* -> dellos*, updated copyright, corrected doc issues
* Removed the unwanted module import
2016-12-08 11:25:10 -05:00
989793483f
fix up eos_eapi module
...
* fixes TypeError: load_config() got an unexpected keyword argument 'session'\n"
* removes qos argument
ref #4869
2016-12-08 11:25:09 -05:00
d75c2ea475
Fix documentation fragment references. ( #4890 )
2016-12-08 11:25:09 -05:00
13e87e3a6c
Adding nxos_igmp_snooping
2016-12-08 11:25:09 -05:00
15c07334c7
Adding nxos_aaa_server_host
2016-12-08 11:25:09 -05:00
4b6a59bd13
Adding nxos_udld_interface
2016-12-08 11:25:09 -05:00
f1a96986c4
Adding 2.1 and 2.2 support to nxos_switchport
2016-12-08 11:25:09 -05:00
e669d3e889
Adding nxos_snmp_user
2016-12-08 11:25:09 -05:00
693f8e623a
Improving argument_spec
2016-12-08 11:25:09 -05:00
2f58306564
Adding nxos_pim_interface
2016-12-08 11:25:09 -05:00
48942d6e32
Fixing docstring
2016-12-08 11:25:09 -05:00
b42f6da0ce
Adding nxos_mtu
2016-12-08 11:25:09 -05:00
d8b2b0387b
Adding nxos_vtp_version
2016-12-08 11:25:09 -05:00
da8aa0dd29
Removing unused function
2016-12-08 11:25:09 -05:00
d53b52d528
Fixing module name
2016-12-08 11:25:08 -05:00
d435aca86e
Adding missing version_added
2016-12-08 11:25:08 -05:00
bf2e0ec953
Adding nxos_vtp_domain
2016-12-08 11:25:08 -05:00
b1f33ca5a0
Improved function
2016-12-08 11:25:08 -05:00
d3de4c160f
Adding nxos_vtp_password
2016-12-08 11:25:08 -05:00
29ea186bd7
Adding nxos_udld
2016-12-08 11:25:08 -05:00
c45e596159
Adding nxos_ntp_options
2016-12-08 11:25:08 -05:00
77b043dcf3
Fixing conditional format
2016-12-08 11:25:08 -05:00
52dfa697c2
Adding nxos_ntp_auth
2016-12-08 11:25:08 -05:00
6efb79bbeb
Adding nxos_aaa_server
2016-12-08 11:25:08 -05:00
821b1606b3
Fixing nxos_interface
2016-12-08 11:25:08 -05:00
095d30ea63
Adding nxos_ntp
2016-12-08 11:25:08 -05:00
5f0060ec41
Fixing argument_spec
2016-12-08 11:25:08 -05:00
57f86c0efc
Fixing docstring format
2016-12-08 11:25:08 -05:00
76d7379d73
Adding nxos_snmp_traps
2016-12-08 11:25:08 -05:00
988d6bbb2b
Fixing return string
2016-12-08 11:25:08 -05:00
37170dd353
Adding nxos_snmp_location
2016-12-08 11:25:08 -05:00
2c8bc37003
Adding RETURN
2016-12-08 11:25:07 -05:00
de8b759df2
Adding nxos_install_os
2016-12-08 11:25:07 -05:00
c5ab15443f
Adding nxos_gir_profile_management
2016-12-08 11:25:07 -05:00
c7ca3654df
Adding nxos_gir
2016-12-08 11:25:07 -05:00
58501d3650
Removing indentations
2016-12-08 11:25:07 -05:00
852f5176a1
Removing indentation
2016-12-08 11:25:07 -05:00
4775c257ea
Fixing file writing format
2016-12-08 11:25:07 -05:00
2016e5d44a
Adding nxos_snapshot
2016-12-08 11:25:07 -05:00
1752082c00
Adding nxos_snmp_host
2016-12-08 11:25:07 -05:00
4a182888b8
Adding nxos_snmp_community
2016-12-08 11:25:07 -05:00
0c4c5467f7
Fixing docstring and more fix
2016-12-08 11:25:07 -05:00
346f83029b
Fixing error handling
2016-12-08 11:25:07 -05:00
e1fab98061
Fixed module structure
2016-12-08 11:25:07 -05:00
4cbcc1f91d
Adding nxos_vxlan_vtep_vni
2016-12-08 11:25:07 -05:00
a757321872
Added support for facts module for Dell Networking OS10 device. ( #4879 )
...
* Added support for dnos10_facts module
* Added the missing quotes
* Addressed @privateip comments
2016-12-08 11:25:07 -05:00
6a1290230b
pn_bgp (New Module) ( #4738 )
...
* added Py2.4 and YAML Documentation fixes
* added no_log for password
* incorporated additional review comments
* remove type for options block
* fix type for pn_multiprotocol
2016-12-08 11:25:06 -05:00
31b3fbf3ba
pn_cluster (New Module) ( #4727 )
...
* made changes to make it 2.4 compatible
* added no_log for password
* incorporated additional review comments
* remove type for options block
2016-12-08 11:25:06 -05:00
92877a39b1
pn_ospfarea (New Module) ( #4737 )
...
* added Py2.4 and YAML Documentation fixes
* added no_log for password
* incorporated additional review comments
* remove type for options block
2016-12-08 11:25:06 -05:00
5ad8cebef9
pn_trunk (New Module) ( #4728 )
...
* Cluster Module
* added Py2.4 and YAML Documentation fixes
* added no_log for password
* incorporated additional review comments
* remove type for options block
2016-12-08 11:25:06 -05:00
700c220d6b
pn_vlag (New Module) ( #4731 )
...
* added Py2.4 and YAML Documentation fixes
* added no_log for password
* incorporated additional review comments
* remove type for options block
2016-12-08 11:25:06 -05:00
cdbf08e10c
pn_vlan (New Module) ( #4732 )
...
* added Py2.4 and YAML Documentation fixes
* added no_log for password
* incorporated additional review comments
* remove type for options block
2016-12-08 11:25:06 -05:00
127a99de30
pn_vrouter (New Module) ( #4733 )
...
* added Py2.4 and YAML Documentation fixes
* added no_log for password
* incorporated additional review comments
* remove type for options block
2016-12-08 11:25:06 -05:00
e1b07d47be
pn_vrouterif (New Module) ( #4734 )
...
* added Py2.4 and YAML Documentation fixes
* added no_log for password
* incorporated additional review comments
* remove type for options block
2016-12-08 11:25:06 -05:00
23c171c21b
pn_vrouterlbif (New Module) ( #4735 )
...
* added Py2.4 and YAML Documentation fixes
* added no_log for password
* incorporated additional review comments
* remove type for options block
2016-12-08 11:25:06 -05:00
f9082b2d8e
pn_show (New Module) ( #4739 )
...
* added Py2.4 and YAML Documentation fixes
* added no_log for password
* incorporated additional review comments
* remove type for options block and fix typo
2016-12-08 11:25:06 -05:00
d5d0949958
pn_ospf (New Module) ( #4736 )
...
* Add pn_ospf module
* remove type from the options block
2016-12-08 11:25:06 -05:00
4ecab1e094
Added support dnos9_facts module ( #4873 )
...
* Added support dnos9_facts module
* Addressed @gundalow review comments
* Removing the addtional command, which is already in the default
2016-12-08 11:25:06 -05:00
8eaae151fc
Empty Init Module as required ( #4740 )
...
Add network/netvisor/__init__.py
2016-12-08 11:25:06 -05:00
91cc160b43
dnos9_config (New Module) ( #4816 )
...
* Added support for dnos9_config module
* Addressed @gundalow comments
2016-12-08 11:25:05 -05:00
616af3506c
dnos9_template (New Module) ( #4819 )
...
* Added support for dnos9_template module
* Addressed @gundalow comments
2016-12-08 11:25:05 -05:00
8f14b50b11
dnos6_config (New Module) ( #4824 )
...
* Added support for dnos6_config module
* Corrected the documention failure
* Addressed @gundalow comments
2016-12-08 11:25:05 -05:00
264bb374b9
RETURNS doesn't support markup, so remove it
2016-12-08 11:25:05 -05:00
b1243feac8
rename arugment from default to defaults
...
This argument_spec incorrectly named an argument default and it should have
been defaults. This corrects that issue
2016-12-08 11:25:05 -05:00
4327e67a7e
rename the argument default to defaults
...
The argument_spec incorrectly had the argument default and it should have
been defaults. This corrects the problem.
2016-12-08 11:25:05 -05:00
42d5d7b21b
Docs improvements to _config
2016-12-08 11:25:05 -05:00
e375b4c61c
Fixing nxos_feature
2016-12-08 11:25:05 -05:00
3a7301bb3b
fixes error when calling load_config() with session keyword
...
The session keyword is no longer needed or supported in the load_config()
method for eos. This fixes an issue in eos_template where the session
keyword was still being sent.
2016-12-08 11:25:05 -05:00
fffd7ff44b
Addressed review comments from @privateip
2016-12-08 11:25:04 -05:00
c01328b597
Document `backup` options
...
To make future diffing easier, use consistent ordering
2016-12-08 11:25:04 -05:00
9d32e313b7
Added Command module to support Dell Networking OS6
2016-12-08 11:25:04 -05:00
253cbc10a6
Added Command module to support Dell Networking OS9
2016-12-08 11:25:04 -05:00
3366a95765
Force download if checksums do not match ( #4262 )
2016-12-08 11:25:04 -05:00
ad707c2724
roll up updates to nxos_config module
...
* remote 'updates' argument
* clean up functions
* update doc strings
* add required_if dependencies
2016-12-08 11:25:04 -05:00
b6748443c7
roll up updates to junos_config module
...
* remove 'update' argument
* update doc strings
* reorder functions
2016-12-08 11:25:04 -05:00
47bd484b70
roll up updates to ops_config module
...
* 'before' and 'after' now only apply to 'lines' argument
* add required_if dependencies
* update doc strings
* remove 'update' argument
* clean up functions
2016-12-08 11:25:04 -05:00
18957c4039
roll up updates to sros_config module
...
* update doc strings
* update message if rollback isn't configured
2016-12-08 11:25:03 -05:00
a9557bc12b
roll up of updates to vyos_config module
...
* remove 'udpates' argument
* add required_if dependencies
* clean up functions
* update doc strings
2016-12-08 11:25:03 -05:00
8444b1ed8f
roll up of updates to iosxr_config module
...
* 'before' and 'after' arguments now only apply to 'lines'
* update doc strings
* remove update argument
* clean up warnings
2016-12-08 11:25:03 -05:00
6a0b04d6a7
roll up of updates to ios_config module
...
* 'before' and 'after' are now only applied to 'lines'
* remove update argument
* update doc strings
* add path argument when performing config difference
2016-12-08 11:25:03 -05:00
e5c26150fb
roll up of updates to eos_config module
...
* removes update argument
* adds `config` option to replace argument
* moves session management into shared module
* cleans up doc strings
* `before` and `after` args now only apply to lines
2016-12-08 11:25:03 -05:00
bac0c4595c
Fix missing colons in network module examples ( #4778 )
2016-12-08 11:25:03 -05:00
d73fbaaf05
add new module sros_rollback
...
Provides a configuration resource for managing the rollback feature on
remote devices running Nokia SROS
2016-12-08 11:25:03 -05:00
53bcf18eab
minor updates to junos_package module for 2.2 ( #4761 )
...
* replaces get_module() with NetworkModule()
* removes old call to package_version()
2016-12-08 11:25:03 -05:00
09b8e220ca
update junos_facts module to remove get_module() factory function ( #4760 )
...
Replaces get_module() with NetworkModule instance
2016-12-08 11:25:03 -05:00
290a4b5fac
adds path kwarg when difference() is called from iosxr_config
...
Adds the path kwarg to handle use cases with exact and strict matching
2016-12-08 11:25:03 -05:00
d339004437
minor bug fix to pass path to difference() in ios_config
...
The ios_config module needs to pass the path kwarg to difference when
specifying match=exact or strict.
2016-12-08 11:25:02 -05:00
f2c324facc
Updated get_url module to process FTP results correctly [ #3661 ] ( #4601 )
2016-12-08 11:25:02 -05:00
6cca2b06fe
fixes bug where nxos_config wasn't handling checkpoints correctly
2016-12-08 11:25:02 -05:00
d6e16ded3f
fix bug in ios_template when include_defaults is set to true
...
Module was ignoring include_defaults argument. This fixes the issue
such that the correct configuration is returned
2016-12-08 11:25:02 -05:00
8a87d7ff11
adds path kwarg when performing config diff checks in ios_config
2016-12-08 11:25:02 -05:00
eae69a154f
dnos10_template module
2016-12-08 11:25:02 -05:00
bfdc5098cb
minor bug fixes in eos_template
...
* fixes issue where configuration was not being loaded (#4704 )
* fixes issue where defaults were not included when argument was set to True
tested on EOS 4.15.4F
2016-12-08 11:25:02 -05:00
bc7b093089
Removed newline
2016-12-08 11:25:01 -05:00
dfa9904599
Added missing fullstop
2016-12-08 11:25:01 -05:00
db49e1e436
fixes issue where the configobjs are not deserialized to a list
...
When the configuration is compared and the results deserialized, the
dumps() function returns a string. This cohereces the return to a list
in case before and/or after needs to be applied
fixes 4707
2016-12-08 11:25:01 -05:00
87b839e1f8
Adding missing fullstop
2016-12-08 11:25:01 -05:00
d2d1b18ef4
Fixed param value format in docstring
2016-12-08 11:25:01 -05:00
745b504aa1
Fixed module structure and added one new param
2016-12-08 11:25:01 -05:00
a71b84853c
Fixed config function
2016-12-08 11:25:01 -05:00
f577f46ccf
fix imports
2016-12-08 11:25:01 -05:00
8eab599ade
removes state argument from ops_config module
...
this removes the state argument from ops_config. The state argument should
not have been there
2016-12-08 11:25:01 -05:00
c071273fbf
removes argument from vyos_config module
...
The state argument should not be in vyos_config. This commit removes the
state argument
2016-12-08 11:25:01 -05:00
807974f515
updates nxos_config to remove state argument
...
The state argument should not be in the nxos_config module. This change
removes the state argument for this release
2016-12-08 11:25:01 -05:00
c38a90a2e9
removes state argument from ios_config
...
The state argument should not be in ios_config. This change removes the
state argument
2016-12-08 11:25:01 -05:00
51613d4307
roll up of minor fixes in eos_config module
...
* fixes save argument to be type bool
* now properly sets the changed returned flag based on diff
* updates docstring RETURNS to add backup_path
* removes unneeded state argument
tested on EOS 4.15.4F
2016-12-08 11:25:01 -05:00
7010a66638
Removed tabs
2016-12-08 11:25:01 -05:00
7a234fc7cc
update junos_netconf module
...
Updates the junos_netconf module with changes to load the
NetworkModule instead of the get_module factory method. This
update is part of the 2.2 refactor of network modules
2016-12-08 11:25:01 -05:00
f5e62a0611
update junos_template module
...
This updates the junos_template module implementing the changes for
Ansible 2.2
2016-12-08 11:25:01 -05:00
174ffde2e9
Adding nxos_igmp_interface
2016-12-08 11:25:00 -05:00
Gabriele
Peter Sprygada
John R Barker
Nathaniel Case
Senthil Kumar Ganesan
Josh Lothian
Matt Clay
Peter Sprygada
Michael Scherer
amitsi
Martin Matuška
Andrew Gaffney
afunix
@skg_net