e0f482a8c5
Fixes #27340 - make indent consistent for nxos_config ( #27652 )
2017-08-03 07:09:31 -04:00
123b5e222f
nxos_bgp_neighbor fixes ( #27348 )
...
* Fix `timers` idempotency
* `shutdown` is not documented as having a `default` option
* dynamic_capability is the inverse of BOOL_PARAMS
2017-08-02 11:07:46 -04:00
b93878b685
Minor cleanup to nxos_vrrp ( #27593 )
...
* Safe changes
* Fold `[0]` into `execute_show_command()`
We only ever execute one command, so only return the one response
* Streamline `results`
2017-08-02 08:46:44 -04:00
37392318a6
fix nxos_vlan and nxos_switchport issues ( #27505 )
2017-08-01 16:27:12 -04:00
407dc2dc68
fix nxos_vrf removal failure ( #27547 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-08-01 11:51:25 -06:00
d7202e6155
Add fabricpath support for nxos_vlan ( #26013 )
...
* Add files via upload
Fix for issue #25720
* nxos_vlan fabricpath (#25720 )
Fix for issue #25720
* Add files via upload
* Add files via upload
* Delete nxos_vlan.py
* Add files via upload
* Add files via upload
2017-08-01 11:27:47 -06:00
350018de73
nxos_vxlan_vtep fixes and integration tests ( #27405 )
...
* fix issue 27404
* conflict resolve
2017-07-31 08:37:31 -04:00
07b097af7c
Fix nxos portchannel force option ( #27190 )
...
* Add integration tests
* Fix force option
* Enable nxos_portchannel test
* Satisfy ansibot demands
2017-07-28 13:06:41 -04:00
fb2b3de5e4
Fix nxos_vtep_vni typo
2017-07-28 13:04:08 -04:00
a49c419651
fix nxos_vrf_af nxapi & cli ( #27307 )
...
* fix nxapi failure #27142
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix nxos_vrf_af nxapi and cli
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-07-28 09:02:02 +05:30
81151ef02c
Remove Deprecated Template network modules ( #27076 )
...
* removed deprecated networking template modules
* update changelog
* update changelog
2017-07-27 19:40:11 +01:00
7351ee9a76
fix nxos_interface multiple issues ( #27106 )
...
* fix execute_show_command
* fix pep8 issues
* fix AttributeError #26562
* legacy-file remove
* modify execute_show_command output
* fix admin_state up doc
* fix admin_state for all interfaces doc
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-07-27 19:23:35 +05:30
9b9a8749da
Add integration tests and fix nxos providers ( #26913 )
...
* fix issues with python3.x
* Add integration testa and fix for nxos_evpn_vni
* add nxos_evpn_vni to nxos.yaml
* fix get_vtp_config()
* add new integration tests
* fix rollback
* add integration test files
2017-07-27 09:32:35 -04:00
2eaf3571f3
fix state absent nxos_hsrp ( #27366 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-07-27 14:28:46 +05:30
8643e9cb34
changed collection arg to argregate on 2.4 network modules ( #26649 )
...
* changed collection arg to argregate on 2.4 network modules
* replace users with aggregate in eos_user, junos_user, nxos_user
* added version_added to places where we replaced users with aggregate in the docs
* fix ios_static_route test
* update tests to reference aggregate instead of collection/users
2017-07-26 10:09:17 -04:00
41ce724801
fix nxos_hsrp ( #27306 )
...
* fix nxos_hsrp
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* modify nxos_hsrp test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-07-26 11:38:55 +05:30
225fa5d092
Fix undefined variables, basestring usage, and some associated python3 issues
2017-07-25 15:58:23 -07:00
8b34e31e05
Remove the error checking from apply_patch()
...
The error checking would itself cause a traceback. The load_config()
function that we'd need to check for errors from only returns None so
there's no way to check for errors via the return value. In the future
someone could rewrite the load_config function to return useful
information and restore the error checking but for now this is better as
it won't traceback on success and it will let us turn on static analysis
of undefined variables
Fixes #27255
References #27254
2017-07-25 06:12:44 -07:00
e37e736ddb
nxos_logging implementation module ( #26949 )
...
* nxos_logging implementation module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* pep8 fixes
* nxos_logging integration test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* test typo fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* idempotent fix
* rename feature to facility
* make dest_group global var
* remove str from arg_spec
2017-07-25 17:03:54 +05:30
85e7e342b0
nxos_bgp_af correct parents ( #26996 )
...
* move config location
* client-to-client is inverse of BOOL_PARAMS
2017-07-20 13:42:26 -04:00
56a0b988a9
nxos integration fix part 1 ( #27069 )
...
* Assorted Python 3 fixes
* Fix `testcase` definition in integration tests
* Fix nxos_acl_interface
* clean up nxapi after nxos_nxapi
2017-07-19 14:00:05 -04:00
a3aa5d799e
Fix nxos_system name-server parsing ( #25973 )
...
* Fix nxos_system name-server parsing
* Introduce lookup_source as a noop, but don't advertise its use
2017-07-17 11:15:43 -04:00
855544604a
Fix nxos_bgp_neighbor_af advertise_map and advertise_map_non_exist ( #26721 )
2017-07-17 11:15:06 -04:00
61249995a1
Update nxos_interface_ospf & add test ( #26644 )
...
* Update nxos_interface_ospf & add test
2017-07-14 12:31:36 -04:00
b9a1998af5
changes `changed` to `modified` in save_when choices ( #26801 )
2017-07-14 15:08:19 +02:00
62e4353ba1
nxos_facts cleanup ( #26192 )
2017-07-13 16:56:04 -04:00
5cfdd5df0f
nxos_pim_interface ( #26367 )
...
* Add unit tests to nxos_pim_interface
* Update tests to match module
* Update nxos_pim_interface
* Address pep8 issues
2017-07-12 15:39:43 -04:00
63fe40c691
fixes issue when creating instance of NetworkConfig ( #26665 )
2017-07-11 21:28:35 -04:00
0b6f0e6c0d
adds more intelligent save logic and diff to network config modules ( #26565 )
...
* adds more intelligent save logic and diff to network config modules
* adds sha1 property to NetworkConfig
* adds new argument save_when to argument_spec
* adds new argument diff_against to argument_spec
* adds new argument intended_config to argument_spec
* renames config argument to running_config with alias to config
* deprecates the use of the save argument
* before and after now work with src argument
* misc module clean
Modules updated
* nxos_config
* ios_config
* eos_config
Most notably this makes the save mechanism more intelligent for config
modules for devices that need to copy the ephemeral config to
non-volatile storage.
The diff_against argument allows the playbook task to control what the
device's running-config is diff'ed against. By default it will return
the diff of the startup-config.
* removes ios_config from pep8/legacy_files.txt
* extends the ignore lines argument to the module
* clean up CI errors
* add missing list brackets
* fixes typo
* fixes unit test cases
* remove last line break when returning config contents
* encode config string to bytes before hashing
* fix typo
* addresses feedback in PR
* update unit test cases
2017-07-11 20:34:20 -04:00
07498ebed3
fix nxos_overlay_global ( #26422 )
...
* fix nxos_overlay_global
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* swap check_mode with candidate
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-07-10 18:53:52 +05:30
c5fb4bbcc0
Fix nxos_switchport and unit test ( #26131 )
...
* fix nxos_switchport
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* nxos_switchport unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* legacy file
* update unit test
* handle exception
2017-07-06 18:58:36 +05:30
5229370364
fix for nxos_acl_interface idempotency ( #26156 )
...
* fix for nxos_acl_interface idempotency
* shippable error fix
* fix issues with python3.x
2017-07-05 12:05:47 -04:00
240de965ee
Fix nxos_acl module and add IT tests ( #25966 )
...
* Fix nxos_acl module and add IT tests
* Add nxos_acl test
* Add additional properties to test
2017-06-29 14:55:08 -04:00
3102746ebe
nxos_pim_rp_address fixes ( #26119 )
...
* nxos_pim_rp_address tests
* nxos_pim_rp_address changes
* Address issues with idempotence
2017-06-29 10:22:26 -04:00
ad6c4a544e
nxos_pim updates ( #26145 )
...
* nxos_pim tests
* Cleanup nxos_pim
2017-06-28 19:40:19 -04:00
eea18e9875
nxos_vxlan_vtep_vni fixes ( #25913 )
...
* nxos_vxlan_vtep_vni first pass
* nxos_vxlan_vtep_vni tests
2017-06-28 19:38:31 -04:00
21c7fcf9c0
nxos_vxlan_vtep ( #25971 )
...
* nxos_vxlan_vtep tests
* Fix issues with nxos_vxlan_vtep
2017-06-24 14:09:11 -04:00
3482a6326b
Fixes nxos_vpc_interface ( #25907 )
...
* nxos_vpc_interface fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* nxos_vpc_interface unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix state_present
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* add state_present unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* make ansibot happy
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* teardown get_config
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-06-24 18:05:07 +05:30
0296c2285b
nxos_vrf fix ( #25812 )
...
* Fixes #25031
* Slight cleanup and add tests
2017-06-20 10:59:03 -04:00
450263e934
Add junos_banner declartive module ( #25826 )
...
* Add junos_banner declartive module
* junos_banner implementation
* Integration test for junos_banner
* Integration test for net_banner (junos)
* Minor fixes
* Minor doc change
2017-06-18 01:32:48 +05:30
a38e727380
nxos_nxapi fix ( #25306 )
...
* Add nxos_nxapi tests
* Simple changes to nxos_nxapi
* Move validation to check_args
* Don't mark protocol change unless change is requested
* Add different regex to handle HTTP{,S} ports on a different version of nxos
2017-06-16 07:15:08 -06:00
9c6ee8d0bb
Add nxos_banner implementation module ( #25695 )
...
* Add nxos_banner implementation module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* nxos_banner integration test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* nxos_banner unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* doc update
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-06-15 22:05:38 +05:30
4344132a7d
nxos_vpc updates ( #25452 )
...
* Add nxos_vpc tests
* Split execute-show between get_config and run_commands
2017-06-14 11:06:49 -04:00
b76acc8ce8
Fix nxos_vpc idempotence issues ( #25219 )
...
* Fix nxos_vpc idempotence issues
* Remove legacy-file pep8 now passing
2017-06-07 10:35:08 -04:00
f6a4803669
New module: platform agnostic way to manage local users on network devices (network/net_user.) ( #25259 )
...
* Add net_user platform agnostic module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Integration test for net_user
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* modify eos_user module to support name param as alias to username
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Test collection of users
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-06-06 20:05:08 +05:30
343b83041e
nxos_feature fix and unit test ( #25200 )
...
* nxos_feature fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* nxos_feature unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* remove from pep8/legacy-file
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-06-01 08:58:35 +05:30
fb87680046
fix state present nxos_evpn_vni ( #25212 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-06-01 08:57:17 +05:30
53837c2ab0
Assorted nxos_bgp_* fixes ( #25080 )
...
* Simplify apply_key_map
* Fix nxapi
* Clean up get_value
* Fix missing non-values
* Add test for existing bgp_af case
* Fix small issues with bgp_neighbor_af
2017-05-30 14:11:15 -04:00
31c59ad5f9
nxos_portchannel fix and unit test ( #25019 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-05-30 21:22:24 +05:30
8985f7c930
nxos_static_route updates ( #24992 )
...
* Add static_route tests
* Add VRF tests
2017-05-25 12:19:04 -04:00
rahushen
Nathaniel Case
saichint
Trishna Guha
Dennis Israelsson
Mike Wiebe
Nathaniel Case
David Newswanger
Toshio Kuratomi
Peter Sprygada
Ganesh Nalawade