a4b7df70c7
nxos_vlan ValueError fix ( #35559 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-02 20:51:34 +05:30
dc35baa8db
fix nxos_pim_interface issues ( #35405 )
...
* fix nxos_pim_interface issues
* add absent test for pim_interface
2018-01-31 10:51:11 +05:30
a23c95023b
Module deprecation: docs, scheme and tests ( #34100 )
...
Enforce module deprecation.
After module has reached the end of it's deprecation cycle we will replace it with a docs stub.
* Replace deprecated modules with docs-only sub
* Use of deprecated past deprecation cycle gives meaningful message (see examples below)
* Enforce documentation.deprecation dict via `schema.py`
* Update `ansible-doc` and web docs to display documentation.deprecation
* Document that structure in `dev_guide`
* Ensure that all modules starting with `_` have a `deprecation:` block
* Ensure `deprecation:` block is only used on modules that start with `_`
* `removed_in` A string which represents when this module needs **deleting**
* CHANGELOG.md and porting_guide_2.5.rst list removed modules as well as alternatives
* CHANGELOG.md links to porting guide index
To ensure that meaningful messages are given to the user if they try to use a module at the end of it's deprecation cycle we enforce the module to contain:
```python
if __name__ == '__main__':
removed_module()
```
2018-01-30 12:23:52 +00:00
2293252e52
bug-35431 fixed removing encryption from user on subsequent runs of the task ( #35433 )
2018-01-30 11:26:54 +05:30
f8a89f120f
update nxos_interface doc ( #35350 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-25 20:02:02 +05:30
cff4a2d26e
fix *os_config module backward diff ( #35332 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-25 18:49:20 +05:30
0b30c42902
fix pim rp_address issues ( #35248 )
2018-01-24 11:48:49 +05:30
4bc22be614
Fix for nxos_pim issues ( #35103 )
...
* fix nxos_pim issues
* unused line removed
* unused line removed
* remove unnecessary files
2018-01-22 11:30:52 +05:30
8a6d699198
Enable nxapi nxos_banner test ( #35033 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-18 11:50:15 +05:30
9a32f5c889
Add missing extends_documentation_fragment ( #35013 )
...
NXOS modules need more work, though that will all be in
module_docs_fragments/nxos.py
2018-01-17 16:31:53 -05:00
db61f8f967
Clarify which ping module to use ( #34935 )
...
* Clarify which ping module to use
Ensure each of the ping modules link to each other
ping - Requires Python on remote-node
nxos_ping - Only on Cisco NXOS
ios_ping - Only on Cisco IOS
net_ping - For network devices
win_ping - only for Windows
2018-01-17 14:02:06 +00:00
3a144b290d
fix for nxos_vxlan_vtep_vni issues ( #34946 )
...
* fix vxlan_vtep_vni issues
* pep8 errors
2018-01-17 11:07:29 +05:30
227ff61f9d
Add module support to yamllint sanity test. ( #34964 )
...
* Add module support to yamllint sanity test.
* Fix duplicate keys in module RETURN docs.
* Fix syntax in return_common docs fragment.
* Fix duplicate keys in module EXAMPLES docs.
2018-01-16 15:08:56 -08:00
a727930f07
Remove deprecated params from module argspec nxos modules ( #34911 )
...
* Remove deprecated param from module argspec nxos modules
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix nxos_vrrp syntaxerror
* Add choices for version _nxos_ip_interface
* remove check_args function
* remove include_defaults
2018-01-16 18:23:58 +05:30
195beebcb4
Module DOCUMENTATION should match argspec ( #34895 )
...
* Module DOCUMENTATION should match argspec
Large update of many modules so that DOCUMENTATION option name and
aliases match those defined in the argspec.
Issues identified by https://github.com/ansible/ansible/pull/34809
In addition to many typos and missing aliases, the following notable
changes were made:
* Create `module_docs_fragments/url.py` for `url_argument_spec`
* `dellos*_command` shouldn't have ever had `waitfor` (was incorrectly copied)
* `ce_aaa_server_host.py` `s/raduis_server_type/radius_server_type/g`
* `Junos_lldp` enable should be part of `state`.
2018-01-16 12:18:51 +00:00
a65f702155
add config option to replace argument ( #34342 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-15 21:17:02 +05:30
c04cd8642d
fix vxlan idempotent issue ( #34750 )
2018-01-15 12:27:37 +05:30
303894dd17
fix nxos_banner ( #34695 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-11 21:13:00 +05:30
df8b01aaf7
Handle platform os version for sandbox nxos_nxapi ( #34490 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-11 21:12:00 +05:30
6f8d3ad70d
Fixes for nxos_bgp ( #34590 )
...
* fix bgp issues
* add new tests cases
* review comments
2018-01-10 10:52:26 +05:30
5e6b2495c0
Convert nxos_vrf to DI module ( #34274 )
...
* Convert nxos_vrf to DI module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add purge example and improve logic
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* revert version_added for rd param
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* update test to use network_cli
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-08 10:10:34 +05:30
c371ed8d30
nxos tests to use network_cli ( #34474 )
...
* Fix over-byte
* Fix nxos_l2_interface docs
* Update connections for tasks
* Add default ssh port
* Only report provider when using connection=local
* Send empty provider when connection=network_cli
* Fix find tasks
2018-01-05 12:39:04 -05:00
2be5ad4f08
deprecation dict not live yet ( #34493 )
2018-01-05 03:28:53 -05:00
9d2182bcf8
Deprecate nxos_switchport and Add nxos_l2_interface DI module ( #33813 )
...
* Deprecate nxos_switchport
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add nxos_l2_interface DI module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* pep8 fixes
* aggregate test for nxos_l2_interface
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* revert nxos_switchport test change
* gundalow's comment
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-05 07:44:02 +00:00
e9a5ff912a
nxos_file_copy: fix broken import and 2.6 compatibility ( #34480 )
...
* Fix broken import: paramiko could be missing
* doc: use formatting function
* Use Python 2.6 compatible format string
2018-01-05 11:36:11 +05:30
ab67539bef
Add nxos_lldp module ( #34453 )
...
* Add nxos_lldp module
* Implemetation for nxos_lldp module
* Integration test for nxos_lldp module
* Minor change
2018-01-04 18:06:15 +05:30
552d1df901
Adds parents to mutually_exclusive with src for *_config modules ( #33957 )
...
* mutually_exclusive add - ios_config parents works with lines by not src
* mutually_execlusive parents,src added to all other net modules
* tests for mutually_exclusive parents,src and whitespce removal
2018-01-03 09:47:12 -05:00
80ba767204
Convert nxos_interface to DI ( #34240 )
...
* Convert nxos_interface to DI
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add integration test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* commit for ganeshrn's comment
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-12-28 16:41:09 +05:30
60f3649ebd
Convert nxos_vlan to DI module ( #31866 )
...
* Convert nxos_vlan to DI
* fix conflict
* push fix for qalthos's comment
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-12-21 14:08:33 +05:30
4a4da2b774
nxos_static_route DI module ( #33797 )
...
* nxos_static_route DI module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* add version_added
2017-12-20 17:08:29 +05:30
be89822bb5
Deprecate nxos_portchannel and add nxos_linkagg DI module ( #33376 )
...
* deprecate nxos_portchannel
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add nxos_linkagg DI module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* remove nxos_portchannel unit test
* fix syntax issues
* fix ansible-doc failure
* update nxos_portchannel unittest
* minor fixes and integration test
* update nxos_linkagg
2017-12-20 11:26:07 +05:30
3cce8dfafd
Deprecate nxos_ip_interface and Add nxos_l3_interface DI module ( #33866 )
...
* Deprecate nxos_ip_interface module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add nxos_l3_interface DI module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add integration test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* pep8 fixes
* Add nxapi cli test
* Improve complexity
* manage layer3 interface
* fix unit test
2017-12-20 11:07:23 +05:30
27be2a0f5a
Handle nxos platform diffs with cli conf implementation ( #34020 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-12-20 10:41:10 +05:30
9f86b923e9
[CLI_CONF] Refactor nxos module common library to use cliconf plugin ( #31524 )
...
* refactor nxos modules
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* get_config update
* fix get_config
* update nxos module
* device_info
* fix conflict
* add failure message check
* pep8 fixes
* use get_capabilities to check cliconf
* Add logic to detect platform in get_capabilities and cache in module_utils
* return msg in edit_config
* fix conflicts
* make modules compatible
* fix nxos cliconf api
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* cache capabilities
* Update transport queries to get_capabilities in module level
* fix unit tests
* load_config error code
* remove unnecessary change
* Refactor nxos_install_os module
2017-12-19 12:22:33 +05:30
ea18b9021a
Revert "Deprecate Entity, EntityCollection and use subspec in network modules ( #33575 )" ( #33849 )
...
This reverts commit 4349b56643
2017-12-13 13:07:52 +05:30
c2b4fd7f1e
Convert non-DI module to DI nxos_user ( #33770 )
2017-12-11 20:55:05 +05:30
4349b56643
Deprecate Entity, EntityCollection and use subspec in network modules ( #33575 )
...
* Deprecate Entity, EntityCollection and use subspec in network modules
* As per proposal https://github.com/ansible/proposals/issues/76
deprecate use of Entity, EntityCollection, ComplexDict, ComplexList
and use subspec instead.
* Refactor ios modules
* Refactor eos modules
* Refactor vyos modules
* Refactor nxos modules
* Refactor iosxr modules
* Add support for key in suboptions handling
* Fix CI issues
2017-12-11 20:31:25 +05:30
10cd2cd1b7
Manually fix issues that autopep8 introduced
...
* iam.py 161 -> 160 chars
* lamba -> single line function -> multiline function
Avoid redefining key
iam line length
iam.py now clean
2017-12-07 20:25:55 +00:00
c57a7f05e1
Bulk autopep8 (modules)
...
As agreed in 2017-12-07 Core meeting bulk fix pep8 issues
Generated using:
autopep8 1.3.3 (pycodestyle: 2.3.1)
autopep8 -r --max-line-length 160 --in-place --ignore E305,E402,E722,E741 lib/ansible/modules
Manually fix issues that autopep8 has introduced
2017-12-07 20:25:55 +00:00
1a12e733b9
nxos_facts: add check for ipv6 ( #33594 )
2017-12-06 09:41:31 -05:00
961c3fcca7
Add missing comma in lists ( #33557 )
...
This fix adds missing comma in different modules.
This removes implicit string concatenation in given list.
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-12-05 15:44:56 +01:00
11c9ad23d5
Refactor common network shared and platform utils code into package ( #33452 )
...
* Refactor common network shared and platform specific code into package (part-1)
As per proposal #76 refactor common network shared and platform specific
code into sub-package.
https://github.com/ansible/proposals/issues/76
* ansible.module_utils.network.common - command shared functions
* ansible.module_utils.network.{{ platform }} - where platform is platform specific shared functions
* Fix review comments
* Fix review comments
2017-12-03 21:42:30 +05:30
819f9ee8fa
Add port arg to establish ssh connection in nxos_file_copy ( #33304 )
...
* Add port arg to establish ssh connection in nxos_file_copy
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* resolve kedar's comment
2017-11-28 10:54:23 +05:30
7b19c28438
nxos_vrf_interface fix ( #33249 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-11-27 22:56:39 +05:30
25a465ffcb
loopback doesn't support passive_interface ( #33252 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-11-27 22:56:16 +05:30
c6bb6c72cc
Fix anomalous backslashes and enable pylint test.
2017-11-21 23:22:51 -08:00
95a2140f4b
Use show command to support wider platform set for nxos_interface module ( #33037 )
...
* Use show command to support wider platform set
* Fix unit tests
2017-11-20 18:59:09 +00:00
84117e57ba
nxos: 32 bits AS in as-dot format not recognized by regexp asn_regex ( #30569 )
...
* added test for 32 bits AS
* Lint not happy.
2017-11-20 10:09:16 +00:00
208208ab8f
Fix nxos_snmp_host bug ( #32916 )
...
* Fix nxos_snmp_host bug
* Enable nxos_snmp_host tests
2017-11-16 06:17:42 +00:00
e2fef7beed
nxos_facts: cdp support ( #31202 )
...
* nxos_facts get CPD neighbor
* nxos_fact: cdp support
* remove blank spaces
* add ansible_net_neighbors cdp informations
2017-11-15 07:38:19 -07:00
Trishna Guha
saichint
John R Barker
Chip Gwyn
Matt Clay
Nathaniel Case
Pilou
Ganesh Nalawade
bdowling
rahushen
Abhijeet Kasurde
Mike Wiebe
Arnaud
chifu1234