Commit Graph

13154 Commits (c98cec17e0dc4e34a0657f05d97b2b179bc4b64e)

Author SHA1 Message Date
Alicia Cozine 34b8cbd365 Explain what happens when gpgcheck is not set in yum
PR #45796
2018-09-20 15:14:55 +03:00
Yanis LISIMA 45c7facd64 ec2_vpc_igw: migrate to boto3 (#45346)
* ec2_vpc_igw: draft migrate to boto3

* ec2_vpc_igw: migrate to boto3

* ec2_vpc_igw: fix error and implement code review

* ec2_vpc_igw: always catch BotoCoreError with ClientError, remove unused fail method

* ec2_vpc_igw: fix pep error
2018-09-20 19:56:19 +10:00
Jordan Borean 5c73d4f4bd
async: use async_dir for the async results file directory (#45461)
* win async: use async_dir for the async results file directory

* tried to unify POSIX and PowerShell async implementations of async_dir

* fix sanity issue
2018-09-20 19:37:54 +10:00
Zim Kalinowski 60979a96a9
Fixing azure_rm_containerregistry_facts (#45897)
* fixing cr facts

* final fix?

* fixed

* syntax

* sanity
2018-09-20 16:58:07 +08:00
Dag Wieers 197ddd3c45
Fix incorrect type in arg_spec 2018-09-20 02:13:29 +02:00
Zim Kalinowski 83645963fb Fixing assigning ssl certificate to http listener in app gateway (#45830)
* fixed ssl certificate reference

* modified test
2018-09-19 17:00:27 -07:00
Zim Kalinowski 16fa49a894 adding os disk name (#45126)
* adding os disk name

* fixed test
2018-09-19 16:51:37 -07:00
Marc Sensenich 2b4e40c109 Add Check Mode to consul_kv (#28934) 2018-09-19 18:21:03 -04:00
ansibot 534de2df27
Fixing but on version check when the "Apache/2.4.x (Distro)" regex is not met (#27457) 2018-09-19 18:10:29 -04:00
Joseph Benden 36ab77d454 New module: Xfconf-based management of the Xfce 4 DE (#28112) 2018-09-19 18:10:22 -04:00
David Resnick 02bfb9047c datadog_monitor: fix template vars in 'name' and 'escalation_message' (#38483) 2018-09-19 17:34:53 -04:00
Adam Miller 5fdf0290d0 handle yum and dnf lockfiles - fixes #44120 (#45359)
* handle yum and dnf lockfiles - fixes #44120

Signed-off-by: Adam Miller <admiller@redhat.com>

* fix logic problem to properly check for dnf lockfile glob

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-09-19 16:14:25 -04:00
Chris Archibald e3ec9e5345 NetApp Bulk Doc changes (#45856)
* Doc changes

* fix ansibot issue

* Fix spacing
2018-09-19 20:26:28 +01:00
Adrián f85065dabf Explain disk size in mount and add example (#41681)
* Explain disk size in mount and add example

- Explain mount with 8GB
- Add new example to start container with mount

* Removed trailing whitespace
2018-09-19 20:01:49 +01:00
Tom Paine 61f2791d95 Update postgresql_user.py (#45777)
<!--- Your description here -->
Add expires example.
+label: docsite_pr
2018-09-19 19:46:26 +01:00
Stuart MacKay f964277628 Added documentation for collectstatic --clear. (#42007)
* Added documentation for collectstatic --clear.

Added a description of the --clear argument used with the Django management
command, collectstatic. (When #1810 added this feature the documentation
was not updated).
2018-09-19 19:23:17 +01:00
Eric Helms 74b94e119e Deprecate foreman and katello modules (#42043)
* Deprecate foreman and katello modules in 2.8, remove in 2.12
2018-09-19 11:41:54 -05:00
Daniel Speichert d34cf93f1a Migrate from MySQLdb to PyMySQL (#40123)
* Migrate from MySQLdb to PyMySQL

* Deduplicate driver loading and failure message

* Explain requirements

* Apply requirements docs change to proxysql too

* Add changelog
2018-09-19 08:44:05 -07:00
ndswartz 205693a3f9 Update short description for NetApp E-Series modules. (#45820)
Update short description according to new standards
2018-09-19 11:23:49 -04:00
Michael Scherer ec2c131bac Remove unused import and lines, to make linter happy (#45665) 2018-09-19 19:52:52 +05:30
cordones 742d702b96 incorrect sample eos_config usage (#45750)
no such option "config" for diff_against argument.
Further below, there is an example of eos_config using diff_against with a valid option.
+label: docsite_pr
2018-09-19 19:50:33 +05:30
Trishna Guha 1b0c4fde86
fix nxos_facts indefinite hang for text based output (#45845)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-09-19 19:37:44 +05:30
Dag Wieers 2edf20d1ed Docs: Avoid use of 'default: null' (#45795)
Various modules document the default 'null' value, but it causes None to
be shown in the documentation explicitly.
2018-09-19 09:02:27 -05:00
Jon Dufresne 2097d25506 Correct capitalization of PyPI (#45698)
As spelled on https://pypi.org/.
2018-09-19 08:51:49 -05:00
Michael Scherer 795b711394 Do not reset permissions in checkmode
If using authorized_key on a directory with non standard permissions,
using checkmode will reset the permission silently.
2018-09-19 14:40:33 +02:00
Michael Tipton 1b92e43dcb VMware: vCenter plugin : new module (#44963) 2018-09-19 17:58:11 +05:30
Dag Wieers 5f4173b8bf A few small fixes 2018-09-19 12:52:31 +02:00
João Soares 097902c35a Remove whitespaces 2018-09-19 12:52:31 +02:00
João Soares 01db7239ed Add input validation for the new asn parameter
Fix asn type from str to int
2018-09-19 12:52:31 +02:00
João Soares 165000adcd Update version_added on the asn parameter 2018-09-19 12:52:31 +02:00
João Soares a60b14c826 Update aci_l3out documentation 2018-09-19 12:52:31 +02:00
João Soares dd67e89f47 Add eigrp as a possible l3protocol in aci_l3out
Also fixes an error related to the required parameters. The l3out parameter is required but only 'name' was being accepted, and that should only be the alias.
2018-09-19 12:52:31 +02:00
Tim Rupp ccfbed3dbc
Adds bigiq_device_facts module (#45822)
This module can be used to query a variety of facts from a BIG-IQ
2018-09-18 22:30:31 -04:00
Julien PRIGENT 6059246093 EFS - add support for new Provisioned Throughput (#43253)
* efs.py: Add support for EFS provisioned throughput

* efs_facts.py: Add support for EFS provisioned throughput

* efs_facts integration tests updated with provision throughput

* efs_facts: Tests refactoring - add failure and success playbook according to botocore version.

* efs_facts: More tests and new option descriptions adjustment

* efs_facts tests renamed to efs
2018-09-19 09:10:56 +10:00
Tim Rupp 8acbf10ed2
Removes unused f5 imports (#45821) 2018-09-18 18:34:31 -04:00
René Moser 1ed3bd9168
vultr: fix for unreliable API behavior (#45712) 2018-09-19 00:01:53 +02:00
René Moser 22986648dc
vultr_server: fix diff for user data (#45753) 2018-09-18 23:20:11 +02:00
Sloane Hertel 8d2df9be52 ec2_group - fix VPC precedence for security group targets (#45787)
Update the dictionary with the preferred values last to get the right order of VPC precedence

Fixes #45782
2018-09-18 15:33:19 -04:00
Stijn Martens 049a462058 Update influxdb_database.py (#39984)
InfluxDB >= 1.2.4 is not supported

+label: docsite_pr
2018-09-18 12:54:02 -05:00
Christer Hemgren 4da13eefb2 asa_config add doc l3 interface (#41250)
* asa_config add doc l3 interface

+label: docsite_pr
Issue ansible/community#311

* fix interface idempotent

* newline, names, and debug:var
2018-09-18 13:39:14 -04:00
Christer Hemgren 7b1c61000e update asa_config with bgp doc example (#41376)
* update asa_config with bgp doc example

+label: docsite_pr
Issue ansible/community#311

* fix spelling
2018-09-18 10:53:32 -05:00
Sloane Hertel c004a639b3
[ovirt] remove 2.8 deprecations (#45506) 2018-09-18 08:28:00 -04:00
mrmagooey 1f8c5905b3 VMware: fix return to return a tuple instead of a bool (#45764)
fixes "'bool' object is not iterable" exception when `res` is falsey
2018-09-18 16:53:17 +05:30
Martin Nečas 28a074c835 ovirt add vnic (#44716)
* ovirt add vnic
2018-09-18 10:02:49 +01:00
Dario Zanzico 54c3d1c24e New module: add docker_stack module (clound/docker/docker_stack) (#24588)
* add docker_stack module + tests
2018-09-18 09:54:44 +01:00
Felix Fontein 0961d914d7 Don't parse/interpret options if state is 'absent'. (#45700) 2018-09-17 22:07:52 -04:00
Will Thames d2569a3f7d Improve iam_group exception handling (#45599)
* Improve iam_group exception handling

Use AnsibleAWSModule for iam_group and handle BotoCoreErrors
as well as ClientErrors. Use fail_json_aws to improve error messages

* Add minimal iam_group test suite

Update some of the read-only IAM permissions (this is not sufficient
to run the test suite but it gets further than it did until it tries
to add a (non-existent) user)

* Clean up after tests
2018-09-17 19:53:44 -04:00
Michael Scherer 5c49641798 Port the aix_inittab to python 3 (#45678)
Since izip no longer exist on python 3, we need to use zip
Fix #45220
2018-09-17 19:01:38 -04:00
Sandra McCann 7092dd7fbf Add 'Wait for' example to asa_command module (#45190)
* Added example to register result of a ping test, including a wait_for command.
* added names to tasks
* updated examples to remove deprecated commands etc
* removed group_var
2018-09-17 15:12:46 -05:00
Denis GERMAIN 68e264e878 Wrong parameter in scaleway sshkey module example (#45737)
* Update scaleway_sshkey.py
fix: typo "present" in example
2018-09-17 15:04:09 -05:00
C. Friedrichs 05840ffe16 updated documentation in vmware_guest.py (#45481)
Added note regarding online disk resizing and changed wording of a few sentences. Also added vSphere 6.7 as "tested on" as it works very well.
2018-09-17 15:59:21 -04:00
Rémy Jacquin 63444136ba Add example for multiple package selection with dnf (#45610)
Thanks for enhancing the Ansible documentation!
2018-09-17 15:54:48 -04:00
Michael Scherer bef1e5621b Add a alias from organisation to organization (#45688)
Since 'organization' is the spelling used accross all others modules,
I think it would be better to at least have this one as a alias.

Organisation is the UK/Australia/NZ spelling, while organization is the
US one.
2018-09-17 15:50:46 -04:00
Sloane Hertel 21f4b5911e [aws] fix version_added for elb_classic_lbmodule (#45559) 2018-09-17 14:32:51 -04:00
Sloane Hertel b42c7f4512 [iam_role] A hyphen with nothing following becomes [None] rather than []. Fix example syntax. (#45742) 2018-09-17 14:32:15 -04:00
Sloane Hertel d7ca3f2bd3 ec2_group: fix regression for targets that are a list containing strings and lists (#45594)
* Fix targets that may be a list containing strings and lists which worked prior to 2.6.

* Add ec2_group integration tests for lists of nested targets

* changelog

* Add diff mode support for lists of targets containing strings and lists.
2018-09-17 14:31:41 -04:00
Lingxian Kong cf1e0bde99 os_loadbalancer: support to create populated load balancer (#44619)
The user can use os_loadbalancer module to configure a fully functional
load balancer by specifying the sub-resources definition in the module,
rather than combining os_listener, os_pool and os_member modules.
2018-09-17 14:10:03 -04:00
David Passante 05328ebf21 Cloudstack: fix support for some VPC service capabilities (#45727)
* Fix support for VPC capabilities such as redundant routers or region level VPC

* Add integration test cases for "region level VPC" and "distributed router" capabilities
2018-09-17 16:08:16 +02:00
Nathaniel Case 780dc9c561
There are other instances of transform being used... update them as well (#45663) 2018-09-17 08:42:20 -04:00
René Moser 00d04ef757
twilio: fix multi to_number support (#44878)
* twilio: fix multi to_number support

* use json helper
2018-09-16 08:38:25 +02:00
julianladisch 5adcaf4538 Suggest full fingerprint for apt_key. (#44697)
* Suggest full fingerprint for apt_key.
Background: https://gwolf.org/node/4070 (Gunnar Wolf: Stop it with those short PGP key IDs!)
I've put the full fingerprint into the examples.
* avoids the phrase 'best practice'
2018-09-14 14:50:46 -05:00
Jon Cormier 7aaa5da41d [aws_ssm_parameter_store] use describe_parameters paginator (#45632)
Fix the service reaching an internal limit while processing the results and returning unexpected data
2018-09-14 15:17:15 -04:00
lwm 1d754b43de Linode: clarify how to create/delete linode machines with `linode_id`. (#45659)
* Attempt to explain `linode_id` a bit better.

Don't include in any example that creates a Linode.

Based on comments in

> https://github.com/ansible/ansible/issues/45403#issuecomment-419752856

* Add simple creation example. Show how to pass `linode_id`.
2018-09-14 15:10:32 -04:00
Maugli 235b11f681 Return correct version on installed VyOS (#39115)
* Return correct version on installed VyOS

Previously existing regexp will shows only "VyOS" without numeric output of router version.
For example: from  "Version:      VyOS 1.1.6" only VyOS will be written in ansible_net_version variable
For more informative output numeric value should be returned as well

* Fixed unittests
2018-09-14 22:51:30 +05:30
Michael Scherer a1e2f1bf73 [voss_facts] remove uneeded global declaration of variable warnings (#45653)
Since the variable is used only once, no need to declare it global.
Remove a warning from linter (lgtm.com)
2018-09-14 10:39:41 -04:00
Deaton64 3782a236ba Update azure_rm_trafficmanagerprofile.py examples (#45649)
Wrong module name used in examples. changed `azure_rm_trafficmanager` to `azure_rm_trafficmanagerprofile`
2018-09-14 09:48:11 -04:00
Xyon 8d6522c671 Update mysql_db.py (#41317)
Add note to inform that mysql_db is not idempotent when state is "import".

+label: docsite_pr
2018-09-13 17:31:45 -04:00
Michael Scherer ede3a8cee1 Fix formatting for the error on azure_rm_appserviceplan_facts (#45613)
Since there is only 1 argument, {1} can't work since that's the
2nd argument for format. Flagged by lgmt.com
2018-09-13 17:00:21 -04:00
Tim Rupp 5a3a865ca0
More bigip software fixes (#45633)
Fixes problems related to token timeout. Adds cleanup of tokens.
2018-09-13 15:58:17 -04:00
Tim Rupp e619052424
Fixes multiple lgtm issues (#45629)
Most of the issues were just inclusions of code that were not used.
This cleans those up. Other alerts were semi-false-positives for now
2018-09-13 15:26:17 -04:00
Vibhav Sinha e26d758d6f fix gce_backend_service examples for healthchecks (#31134)
gce_backend_service module expects healthchecks to be an array of string. The previous example incorrectly mentioned healthchecks as an array of objects each containing a `name` key.
2018-09-13 13:47:43 -05:00
Tim Rupp 34d08adea0
Fixes lgtm alert (#45619)
Alert was for an include that was not used.
https://lgtm.com/projects/g/ansible/ansible/latest/files/lib/ansible/modules/network/f5/_bigip_facts.py?sort=name&dir=ASC&mode=heatmap&showExcluded=false#L98
2018-09-13 13:45:55 -04:00
Michael Scherer de84a05bf4 Remove unused import iControlUnexpectedHTTPError (#45611)
Since that's unused in the code, no need to import it.
This got flagged by linter
2018-09-13 13:16:23 -04:00
Nathaniel Case 285b927889
network command modules cleanup (#45242)
* Standardize _command modules

* Centralize command transformation process

* Fix check mode error test
2018-09-13 08:55:35 -04:00
Zim Kalinowski df768914a1 adding sql firewall rule facts (#45059) 2018-09-13 17:54:58 +08:00
Strahinja Kustudic 8d8df46fe6 Add an error message if a pkg cannot be removed, fixes #35672 (#40723) 2018-09-13 02:54:38 -04:00
Sam Doran 03dbb1d9c4 Improve code stability is checksum checking
- use context manager for dealing with the checksum file
- use loop that can tolerate zero, one, or more items return rather than the previous expression which would break if anything other than exactly one item was returned
2018-09-12 15:29:15 -07:00
Martin Nečas 2a3f3382fd Ovirt add rename functionality (#44951)
* add renaming of ovirt
* add renaming func to ovirt cluster
* ovirt update examples in docs
2018-09-12 14:36:06 -07:00
Jon "The Nice Guy" Spriggs ab2e6fded1 Show multi-line messages in debug documentation (#23000)
* Show multi-line messages in debug documentation

* Add two-line entry
* Indicate that jinja2 filters are not applied here

* Fix to incorrect documentation change
2018-09-12 16:55:48 -04:00
Ferdinand Holzer 3c083837c0 Clarify how java_cert checks keystore certificates (#26567) 2018-09-12 15:51:37 -05:00
Tim Rupp e266a24263
Fixes bugs in the bigip_software modules (#45577)
This patch makes hotfix code work, where before, only base images
were working
2018-09-12 15:56:43 -04:00
Brian Coca 1ed57f1f64 moving from with_ff to just ff (#44847) 2018-09-12 15:35:04 -04:00
Evert f7ef06e849 Added a note regarding the delegate_facts option. (#25257)
* Added a note regarding the delegate_facts option with a link to documentation
2018-09-12 14:30:05 -05:00
Richard Schwab ea8924f744 Make it clear that recurse only applies to state=directory (#40222)
This would otherwise cause confusion as it could be interpreted as only changing attributes for directories (and not files inside).

+label: docsite_pr
2018-09-12 13:00:49 -04:00
Anil Kumar Muraleedharan ac58c36ad0 Lenovo cli bugfixes (#45278)
* To change all CLIs present in the code to latest CNOS CLI. One bug of executing with Lenovo Jakku switch is also getting fixed.

* To change the file names as the commands have changed from display to show

* To change to new CLI in test_cnos_comand.py as well
2018-09-12 10:31:45 -04:00
Ghilli3 6040175186 Initial commit of fmgr_sys_proxy.py (#45518) 2018-09-12 19:18:27 +05:30
Zim Kalinowski 73c8041ec0 Azure load balancer crash fix (#45546) 2018-09-12 16:25:35 +08:00
Zim Kalinowski 111febe62e extended vmss facts (#45535) 2018-09-12 13:22:47 +08:00
Brian Brooks 0198d93f68 Update keycloak_client.py (#45505)
Slightly improve wording about lack of input sanity checking on API calls.

+label: docsite_pr
2018-09-12 06:22:54 +02:00
Zim Kalinowski 821c27cefb fixed tag support in autoscale facts (#45533)
* fixed tag support in autoscale facts

* forgot to add tags to arg spec
2018-09-11 23:00:58 -04:00
Michael Scherer 004621ef8e Fix useless comparaison between 2 constants (#45524)
Found with https://lgtm.com
2018-09-11 19:37:50 -04:00
Jose Delarosa 197059b4a2 Update the root URI to match the DMTF specification (#45295) 2018-09-11 19:15:59 -04:00
Kerry bf90a44468 Clarify the creates and removes options (#45485)
* Clarify the creates and removes options

The description for the creates and removes options were worded poorly. This change improves readability and is easier to understand.

 Double negatives are BAD

+label: docsite_pr

* Fix trailing whitespace
2018-09-11 15:45:19 -05:00
William 2ea9cfcd52 Fix python 3 compatibility for network id lookup (#45467)
Due to a change in python 3 filters return filter instead of list. This breaks the network name to id lookup for the docker_swarm_module. By wrapping it in list it ensures it is a list when returned and the id is extracted.
2018-09-11 15:45:42 -04:00
Sloane Hertel e5269c047c [AWS] cloudfront_distribution - fix method name from 'validate_distribution_id_from_caller_reference' to 'validate_distribution_from_caller_reference' and set distribution_id to the distribution's key 'Id' (#45498) 2018-09-11 15:08:30 -04:00
Matt Martz 5785de582f
Fix logic to not re-download existing files when force=no (#45495)
* Fix logic to not re-download existing files when force=no. Fixes #45491

* Reduce logic complexity
2018-09-11 13:56:13 -05:00
Matt Clay ae4d5e3257 Avoid duplicate Azure storage account types. 2018-09-11 10:37:48 -07:00
David Rodríguez 600c7ac108 Fix remote checksums when paths have leading dots (#45287)
* Fix remote checksums with paths have leading dots

* Fix result recorded from the wrong file

* Add changelog fragment
2018-09-11 12:47:29 -04:00
Michael Scherer 804d574d1f Add documentation for the modify command, by giving a example (#19699) 2018-09-11 11:38:39 -04:00
Sam Doran 03414727ba Add documentation about patterns with commas to find module (#45360)
Thanks @samdoran  for the example and clarification!
2018-09-11 11:04:17 -04:00