305c88700d
PEP8 E712 fixes ( #21916 )
2017-02-24 16:49:43 -06:00
d64d38a1f4
[cloud][docker] Insensitive search for docker port publishing ( #21579 )
2017-02-17 10:41:26 -05:00
fe02dbecc0
[cloud] Fix a minor doc error in docker_container module ( #21033 )
2017-02-17 10:01:15 -05:00
30026cfb84
[cloud] module docker_image: print output on failure ( #20757 )
...
Fixes https://github.com/ansible/ansible-modules-core/issues/5161
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
2017-02-16 09:47:18 -05:00
7c00346714
Validate EXAMPLES as YAML
2017-02-15 13:01:43 -08:00
cb76200c7d
PEP 8 E111 & E114 cleanup. ( #20838 )
2017-01-30 15:01:47 -08:00
10d9318de7
PEP 8 indent cleanup. ( #20800 )
...
* PEP 8 E121 cleanup.
* PEP 8 E126 cleanup.
* PEP 8 E122 cleanup.
2017-01-29 07:28:53 +00:00
d0d1158c5e
PEP 8 cleanup. ( #20789 )
...
* PEP 8 E703 cleanup.
* PEP 8 E701 cleanup.
* PEP 8 E711 cleanup.
* PEP 8 W191 and E101 cleanup.
2017-01-28 00:12:11 -08:00
d913f69ba1
PEP 8 W291 whitespace cleanup.
2017-01-27 17:08:02 -08:00
95789f3949
PEP 8 whitespace cleanup. ( #20783 )
...
* PEP 8 E271 whitespace cleanup.
* PEP 8 W293 whitespace cleanup.
* Fix whitespace issue from recent PR.
2017-01-27 15:45:23 -08:00
619e97d67e
docker_container: remove third digit from version_added docs
2017-01-25 12:04:10 -05:00
7a19a18e61
[docs] Update docker_container docs to match syslog-tag deprecation in docker 1.13
...
Closes #20591
2017-01-25 10:19:10 -05:00
cfed617dba
Support option none in docker_container when setting log_driver ( #19040 )
...
Per official docker document, it support setting `--log-driver=none` to
disable any logging for the container. So let's add it to this module.
Fixes #5337
2017-01-23 20:23:58 +00:00
e2a1ce2916
[docker] Add compatibility with docker-py v2.0
2017-01-18 14:39:18 -05:00
38d42e8b36
module is a property of the global object client ( #19744 )
...
Fixes #5466
2017-01-05 08:59:30 -08:00
31526595c5
docker_image: docs: won't be pushed to private registry without push parameter. ( #19691 )
2016-12-27 08:15:12 +01:00
ef391a11ec
Removed dict.iteritems() in modules. ( #18859 )
...
This is for py3 compatibility, addressed in #18506
2016-12-12 15:16:23 -08:00
8afa090417
Resolving differences in core modules post-merge
2016-12-08 11:25:36 -05:00
7319104552
Refreshed metadata for core modules
2016-12-08 11:25:35 -05:00
dddf810a19
Fixed typo in docker_image.py docs ( #5764 )
2016-12-08 11:25:34 -05:00
be7af0193d
error in docker_container example ( #5631 )
2016-12-08 11:25:31 -05:00
480c364afd
fixes issue #5517 ( #5519 )
2016-12-08 11:25:31 -05:00
38c0769abb
Examples syntax batch5 ( #5622 )
...
* Change example syntax on supervisorctl module
* Change example syntax or _ec2_ami_search module
* Change example syntax on cloudformation module
* Change example syntax on ec2 module
* Change example syntax on ec2_facts module
* Change example syntax on ec2_eip module
* Change example syntax on rds module
* Change example syntax on route53 module
* Change example syntax on s3 module
* Change example syntax on digital_ocean module
* Change example syntax on docker_service module
* Change example syntax on cloudformation module
* Change example syntax on gc_storage module
* Change example syntax on gce module
* Change example syntax on gce_mig module
* Change example syntax on _glance_image module
* Change example syntax on _keystone_user module
* Change example syntax on _nova_keypair module
* Change example syntax on _quantum_floating module
* Change example syntax on _quantum_floating_ip_associate module
* Change example syntax on _quantum_network module
* Change example syntax on _quantum_router module
* Change example syntax on _quantum_router_gateway module
* Change example syntax on _quantum_router_interface module
* Change example syntax on _quantum_subnet module
* SQUASH _quantum_subnet
* Add missing quotes
2016-12-08 11:25:31 -05:00
dc4cff7350
Remove duplicated option from examples
2016-12-08 11:25:28 -05:00
06e1141106
replace type() with isinstance() ( #5541 )
...
Replace all use of type() with isintance()
Addresses https://github.com/ansible/ansible/issues/18310
2016-12-08 11:25:27 -05:00
ba6bc5382d
corrected version added
2016-12-08 11:25:25 -05:00
20f2fe4e91
added logout to docker_login
...
also cleaned up 'actions' and minor doc issues
2016-12-08 11:25:25 -05:00
ca36d232d5
fix unclear documentation for docker container
...
the docker container module's `exposed_ports` was slightly ambigous.
Use the official Docker documentation to define what an `exposed port`
is.
Resolves : ansible/ansible-modules-core#5303
Signed-off-by: Daniel Andrei Minca <mandrei17@gmail.com>
2016-12-08 11:25:22 -05:00
25b6492d37
Bulk spelling improvement to modules-core ( #5225 )
...
* Correct spelling mistakes
* Correct more spelling issues
* merge conflict
* Revert typo in parms
2016-12-08 11:25:20 -05:00
bca8bbe7c2
Correct functional typos
2016-12-08 11:25:19 -05:00
8e9befa5ba
Surface Compose stdout on failure
...
Signed-off-by: Chris Houseknecht <chouseknecht@ansible.com>
2016-12-08 11:25:18 -05:00
63b6672ea5
Improved enumeration of actions
2016-12-08 11:25:18 -05:00
1e4b8c13a3
Improved build and pull error handling
2016-12-08 11:25:18 -05:00
0e4b470ee2
Let docker-py handle decoding and JSON parsing of stream data. Fixes #4930 .
2016-12-08 11:25:14 -05:00
9432adfaf7
Put requested devices in correct format to enable config comparison. Fixes #5000 .
2016-12-08 11:25:14 -05:00
c3f815a6f6
Docker module: add support for OomScoreAdj
...
* docker-py param name oom_score_adj
* translates to OomScoreAdj in the docker remote API
* setting version_added to "2.2"
2016-12-08 11:25:13 -05:00
bcbeed244b
Fix #4504 Respect timeout option when starting/stopping/restarting containers.
2016-12-08 11:25:13 -05:00
f33828e753
Cast scale value to int. Fixes #4592 .
2016-12-08 11:25:11 -05:00
b01af0d747
Make project start and stop error handling more resilient, and improve message text.
2016-12-08 11:25:11 -05:00
e95f773d96
Set default log_driver to None to prevent config comparison when a log_driver is not specified. Fixes #4600 .
2016-12-08 11:25:03 -05:00
05303a974d
Purge networks using network name rather than ID. Fixes 4596.
2016-12-08 11:25:03 -05:00
890c2d04e2
Default restart_retries to None rather than 0. Fixes #4534 .
2016-12-08 11:25:03 -05:00
964b7ecffa
Fix container labels expected vs actual comparison.
2016-12-08 11:24:54 -05:00
1b4a3dbc86
Fix doc strings. Use of > was breaking HTML generation on docs site module page.
2016-12-08 11:24:52 -05:00
8da17b750d
docker_service: fix files/project_files typo
...
The original decision to rename from `project_files' to `files' was in
3a5dd0007634c9d4e379f20cac77c8fd64b67f42.
2016-12-08 11:24:51 -05:00
fb99277066
Exposing tcp and udp for same port fails. Fixes issue #4354 .
2016-12-08 11:24:51 -05:00
fc87dd9650
Allow specifying human readable value for option `memory_limit` again ( #4049 )
2016-12-08 11:24:50 -05:00
76260d3aa8
Fix network alias and network link comparison. - Using set based comparison was not working consistently - With != operator worked locally but consistently failed on Travis - With 'not in' operator failed locally and on Travis
2016-12-08 11:24:50 -05:00
433b5e187f
If debug true, include actions and differences in output.
2016-12-08 11:24:50 -05:00
a8111adcd6
Some post merge clean up: ( #4406 )
...
- Removed required_if.
- Fixed doc strings.
- Removed debug output being appended to actions.
- Put import of basics at bottom to be consistent with other docker modules
- Added 'containers' alias to 'connected' param
- Put facts in ansible_facts.ansible_docker_network
2016-12-08 11:24:50 -05:00
94486c5c77
doc fix
2016-12-08 11:24:50 -05:00
af3884f558
Adding docker_network module. ( #4404 )
2016-12-08 11:24:50 -05:00
16db1d54d1
typo in the documentation of the "state" parameter ( #4353 )
2016-12-08 11:24:48 -05:00
2514ec5056
Add buildargs parameter to support Dockerfile ARG directive. ( #4349 )
...
* Add buildargs parameter to support Dockerfile ARG directive.
* Fix doc_strings. Doc string for load_path was completely missing.
2016-12-08 11:24:48 -05:00
f6b126d412
Default repository tag value to tag parameter value or 'latest'.
2016-12-08 11:24:48 -05:00
3dab1785ba
Always returns changed when state present and name includes :tag.
2016-12-08 11:24:48 -05:00
1cf9d3e68e
Add *build* to state parameter choices. Updated deprecation message. Will be deprecated in release 2.3. Removed ( #4342 )
...
mention of *tagged* state in the force parameter doc strings. There is no *tagged* state.
2016-12-08 11:24:48 -05:00
2ea29fee3f
Fix image tag operation. Allows repository in form of repo:tag. If no tag value, defaults to 'latest'.
2016-12-08 11:24:48 -05:00
0c4da5d3a0
Added implementation of ignore_image, which prevents recreation of containers on image change.
2016-12-08 11:24:47 -05:00
5992c21c9c
Fix #3670 host IP defaults to 0.0.0.0 ignoriing bridge Host IP option.
2016-12-08 11:24:47 -05:00
a6bfeea1c4
Improved documentation for returned actions.
2016-12-08 11:24:47 -05:00
cd7b34547d
When build true call docker-compose build, and add nocache option.
2016-12-08 11:24:47 -05:00
df09b4f668
Set version_added
2016-12-08 11:24:47 -05:00
1670d9b030
Add pull option to pull images prior to evaluating service state.
2016-12-08 11:24:47 -05:00
7ba3ba2da9
Fix Typo in docker_image_facts module
2016-12-08 11:24:46 -05:00
c91de38322
Entrypoint fails with 'command not found' error.
2016-12-08 11:24:43 -05:00
7ffa6a43c5
Add push parameter. Let API handle registry authentication check.
2016-12-08 11:24:43 -05:00
4002caf60e
Fix module failing when no ports are exposed
2016-12-08 11:24:43 -05:00
d8b752b3cf
Fixed a typo ( #4168 )
2016-12-08 11:24:43 -05:00
030dcccad4
Fix multi-interface port binding.
2016-12-08 11:24:43 -05:00
bd3e1c77fe
Add cleanup parameter. ( #4144 )
2016-12-08 11:24:43 -05:00
7515b2d563
Fix 'all' option for published_ports parameter.
2016-12-08 11:24:43 -05:00
dc496ffeb4
Fix purge_networks
2016-12-08 11:24:43 -05:00
b86a229b61
Fix getting actual_stdin_open
2016-12-08 11:24:42 -05:00
82c26ad2d7
Do not forcibly push when building, either.
2016-12-08 11:24:39 -05:00
89e8787d65
Don't forcibly push loaded images to registry. Fixes #3763
2016-12-08 11:24:39 -05:00
3d5f84c528
Fix compose_version error. Check has compose before checking version.
2016-12-08 11:24:38 -05:00
1e9590ab65
Fix index
2016-12-08 11:24:38 -05:00
cc053c45ce
Fix ulimit comparison
2016-12-08 11:24:38 -05:00
320aea77c6
fixed unknown type <type 'list'> error ( #3959 )
2016-12-08 11:24:37 -05:00
16e7dc4e2e
Remove dns from container create parameters.
2016-12-08 11:24:37 -05:00
4d51a51ac3
Fix #3945 docker_container detach not waiting on container to execute.
2016-12-08 11:24:37 -05:00
82436d5519
Fix #3941
2016-12-08 11:24:37 -05:00
7c4a469174
docker_service: make PyYAML requirement explicit
...
The "Developing Modules" documentation states:
Include a minimum of dependencies if possible. If there are
dependencies, document them at the top of the module file, and have
the module raise JSON error messages when the import fails.
When docker_service runs on a remote host without PyYAML it crashes with
ImportError.
This patch raises a JSON error message when import fails, but only if
the PyYAML module is actually used. It's only needed when the
"definition" parameter is given.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
2016-12-08 11:24:37 -05:00
617c230b62
Fix #16211 - only stop/kill running containers
2016-12-08 11:24:36 -05:00
b5820c7398
Fix #3906 - Enforce required minimum compose version. ( #3925 )
...
* Fix #3906 - Require minimum compose version.
* Fix typo in message text.
2016-12-08 11:24:36 -05:00
38013de366
Stream image data in load_image() to avoid out-of-memory
...
Reading the entire tar file into memory can result in out-of-memory
conditions such as this traceback:
Traceback (most recent call last):
File "/tmp/ansible_YELTSu/ansible_module_docker_image.py", line 486, in load_image
self.client.load_image(image_data)
File "/usr/local/lib/python2.7/dist-packages/docker/api/image.py", line 147, in load_image
res = self._post(self._url("/images/load"), data=data)
...
File "/usr/lib/python2.7/httplib.py", line 997, in endheaders
self._send_output(message_body)
File "/usr/lib/python2.7/httplib.py", line 848, in _send_output
msg += message_body
MemoryError
Luckily docker-py's load_image(), which calls requests post(), accepts a
file-like object instead of a string. Pass in the file object to avoid
reading the full file into memory. This allows larger tar files to load
succesfully.
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
2016-12-08 11:24:36 -05:00
42a38f9141
move environment variable gathering to end of __init__() ( #3890 )
...
* This moves the lines in the code that parse the `env` and `env_file` options for docker to the end of the `__init__()` function.
This is needed because the `_check_capabilites` function needs both a working `self.client` and a proper `self.docker_py_versioninfo`.
`_check_capabilities` is used by `ensure_capabilities` which is, in turn, used by `get_environment`
This means that before this commit, the environment variables could not be loaded because both `self.client` and `self.docker_py_versioninfo` were not set at that time.
This commit fixes that by putting the environment variable parsing after those two.
* This moves the lines in the code that parse the `env` and `env_file` options for docker to the end of the `__init__()` function.
This is needed because the `_check_capabilites` function needs both a working `self.client` and a proper `self.docker_py_versioninfo`.
`_check_capabilities` is used by `ensure_capabilities` which is, in turn, used by `get_environment`
This means that before this commit, the environment variables could not be loaded because both `self.client` and `self.docker_py_versioninfo` were not set at that time.
This commit fixes that by putting the environment variable parsing after those two.
2016-12-08 11:24:36 -05:00
fc486824b8
Fix issue #3866
2016-12-08 11:24:35 -05:00
8494b0af4b
fix #3528 : dns type
2016-12-08 11:24:34 -05:00
9549c66a56
Fix #147 automatically expose published ports
2016-12-08 11:24:34 -05:00
17fc0f11db
Remove unused method in ContainerManager
2016-12-08 11:24:34 -05:00
e2dbd0f445
Fixing Docker compile time errors irt exception handling for Python 3
2016-12-08 11:24:34 -05:00
ec9f56d8e0
Fix #3822 stop container
2016-12-08 11:24:33 -05:00
c9e4955d38
Remove registery option per #3824 .
2016-12-08 11:24:33 -05:00
be2d32f04d
Fix upate typo and expected volume compare.
2016-12-08 11:24:33 -05:00
9dd95efe76
Fixed binds and volumes. Now recognizes bound vs unbound as well as named volumes.
2016-12-08 11:24:33 -05:00
d373e0a7c4
Fix volume to support not binding volumes to host
2016-12-08 11:24:33 -05:00
96192ead02
Remove debug/register from examples.
2016-12-08 11:24:33 -05:00
3d0d14c5ff
Fix network comparison. Fix handling of links. Updated doc strings. Added more examples.
2016-12-08 11:24:33 -05:00
a4bd558240
Set version added to 2.2 so that tests pass
2016-12-08 11:24:32 -05:00
e398efb04f
For new options move vesion_added to 2.1.1
2016-12-08 11:24:32 -05:00
c8f63e867a
Fixed bug in _get_network_id
2016-12-08 11:24:32 -05:00
a9ddb5023d
Fix doc strings.
2016-12-08 11:24:32 -05:00
1d327a23cd
Fixed issues post testing.
2016-12-08 11:24:32 -05:00
39bfb136a7
First pass at implementing networks parameter. Also added purge_networks option to remove container from networks not included in networks param.
2016-12-08 11:24:32 -05:00
f3c33ee35f
Fix for 3768 - adding support for env_file
2016-12-08 11:24:32 -05:00
2016911e64
Check self.parameters.env exists.
2016-12-08 11:24:32 -05:00
bc665fca9c
Fix for issue #3775 - env config comparison
2016-12-08 11:24:32 -05:00
65e71d8960
Update restart_policy doc strings.
2016-12-08 11:24:32 -05:00
b5666c0f1c
Fix restart_poicy
2016-12-08 11:24:32 -05:00
8f9ef1213d
Fix for #3783 - command returns not found or does not exist.
2016-12-08 11:24:32 -05:00
c8ec843ac2
Fix "ansbile_facts" typo in docker_container module
2016-12-08 11:24:32 -05:00
d0da544aef
Fix for issue 3740. Make docker_service more resilient when targeting older API versions.
2016-12-08 11:24:31 -05:00
f6690828af
deprecated docker ( #3710 )
...
* deprecated docker
* updated formatting
2016-12-08 11:24:31 -05:00
afc8c42e57
Fixed the URL in description. It's now valid Yaml.
2016-12-08 11:24:29 -05:00
f14d675d2a
Remove the U().
2016-12-08 11:24:29 -05:00
176363052f
Uppercase
2016-12-08 11:24:29 -05:00
2b4ee0c19d
Make the new bits a NOTE
2016-12-08 11:24:29 -05:00
4ac31f1e8d
Where to get the full docker picture.
2016-12-08 11:24:29 -05:00
8a6237955d
remove module argument, fix #3682 ( #3683 )
2016-12-08 11:24:29 -05:00
190f24f30e
Revert "Fix doc strings spacing."
...
This reverts commit 127d518011224289f7917fd3b2ec8ddf73c7dd17.
2016-12-08 11:24:28 -05:00
26392077c0
Fix doc strings spacing.
2016-12-08 11:24:28 -05:00
8e6d00f28e
Fix doc strings. Missing requirements and doc fragment reference.
2016-12-08 11:24:28 -05:00
d5b82d67b8
Fail gracefully when build path is not found.
2016-12-08 11:24:27 -05:00
9a021b4181
Fixed files/project_files naming. Correct name is files.
2016-12-08 11:24:27 -05:00
5837f744e0
Flip version added back to 2.2 to make tests pass.
2016-12-08 11:24:27 -05:00
018c2f8f73
Moving version added to 2.1
2016-12-08 11:24:27 -05:00
e8d49261e3
Added actions to RETURN docs. Show actions when debug or check mode.
2016-12-08 11:24:27 -05:00
2860f57551
Removed use of --diff. Replaced 'diff' in output with 'actions'. Only show 'actions' in output if debug true.
2016-12-08 11:24:27 -05:00
be24f83a41
Removed fail method. Combined recreate and force_recreate params.
2016-12-08 11:24:27 -05:00
50ef604713
Adding docker_service
2016-12-08 11:24:27 -05:00
8ba5cc4392
Fixed parameters passing in container_create method. ( #3618 )
2016-12-08 11:24:27 -05:00
c03e1bd2d5
fixed documentation and arg issues
2016-12-08 11:24:26 -05:00
ed932a53cd
Fix documentation
2016-12-08 11:24:26 -05:00
d13046a905
ansible-validate-modules part 4: Enable check on ansible-modules-core ( #3526 )
...
* Call ansible-validate-modules
* Correct quotes + add newline
2016-12-08 11:24:26 -05:00
1d6517489b
Add doc string for container_limits. Fixed push fail message. Use path type.
2016-12-08 11:24:25 -05:00
b4caa29b00
Adding docker_image_facts ( #3493 )
...
* Adding docker_image_facts
* Fix github credentials
2016-12-08 11:24:25 -05:00
bc3391f1f9
Adding docker_container ( #3495 )
...
* Adding docker_container
* If state absent, stop the container before attempting to remove. Fixed status running check.
* If container absent, stop before removing. Fix container status check.
2016-12-08 11:24:25 -05:00
371d7ec73d
Fix docs building
2016-12-08 11:24:25 -05:00
5f0dc2b90f
Some beginning python3 porting for modules which have unittests
2016-12-08 11:24:24 -05:00
a67e9f3122
Updated version_added on options to reflect options added for 2.1.
2016-12-08 11:24:24 -05:00
f2e7f1935b
Clean up and fixes post API version 1.20 testing.
2016-12-08 11:24:24 -05:00
6f122bdc88
Fix github credentials
2016-12-08 11:24:24 -05:00
f257fb3efa
Fix unfriendly exeption handling.
2016-12-08 11:24:23 -05:00
6aa76b835a
Updater per PR comments
2016-12-08 11:24:23 -05:00
fd0554c67e
Adding refactored docker_image module.
2016-12-08 11:24:23 -05:00
c5b7e456bd
Adding docker_login ( #3494 )
...
* Adding docker_login
* Set correct version_added.
* Fix github credentials
2016-12-08 11:24:23 -05:00
08ad68984c
Fix for 'cannot unmarshal array into Go value of type string' error about HostConfig Binds ( #3496 )
2016-12-08 11:24:20 -05:00
a90fd67c7e
docker: fix type issue ( #3491 )
...
* fix type issue
* fix type issue for 'volumes-from'
2016-12-08 11:24:20 -05:00
Matt Martz
Ryan Brown
Zhuo Peng
Tomas Tomecek
Matt Clay
Jun Guo
dariko
Tyrone Tudehope
Andrea Tartaglia
James Cammarata
Toshio Kuratomi
Asara
Luc Charpentier
Abdul Anshad A
Sam Doran
Patrick F. Marques
jctanner
Brian Coca
Daniel Andrei Minca
John R Barker
Chris Houseknecht
Aditya Marella
shaung
Chris Houseknecht
Linus Arver
PikachuEXE
muxator
chouseknecht
Julien Vey
jjshoe
Qi Luo
Rodríguez, Jorge
Hagen Kuehn
Stefan Hajnoczi
Vince v. Oosten
pic
Mike Mars
Jirayut 'Dear' Nimsaeng
Dan Schmidt
Brian Coca
Shubham
Toshio Kuratomi
Darek Kaczyński
ThomasSteinbach