Commit Graph

2445 Commits (ce515a626c5d31fec55ab7b0304575d2bf7b9eb0)

Author SHA1 Message Date
Michael Scherer ec2c131bac Remove unused import and lines, to make linter happy (#45665) 2018-09-19 19:52:52 +05:30
cordones 742d702b96 incorrect sample eos_config usage (#45750)
no such option "config" for diff_against argument.
Further below, there is an example of eos_config using diff_against with a valid option.
+label: docsite_pr
2018-09-19 19:50:33 +05:30
Trishna Guha 1b0c4fde86
fix nxos_facts indefinite hang for text based output (#45845)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-09-19 19:37:44 +05:30
Dag Wieers 2edf20d1ed Docs: Avoid use of 'default: null' (#45795)
Various modules document the default 'null' value, but it causes None to
be shown in the documentation explicitly.
2018-09-19 09:02:27 -05:00
Jon Dufresne 2097d25506 Correct capitalization of PyPI (#45698)
As spelled on https://pypi.org/.
2018-09-19 08:51:49 -05:00
Dag Wieers 5f4173b8bf A few small fixes 2018-09-19 12:52:31 +02:00
João Soares 097902c35a Remove whitespaces 2018-09-19 12:52:31 +02:00
João Soares 01db7239ed Add input validation for the new asn parameter
Fix asn type from str to int
2018-09-19 12:52:31 +02:00
João Soares 165000adcd Update version_added on the asn parameter 2018-09-19 12:52:31 +02:00
João Soares a60b14c826 Update aci_l3out documentation 2018-09-19 12:52:31 +02:00
João Soares dd67e89f47 Add eigrp as a possible l3protocol in aci_l3out
Also fixes an error related to the required parameters. The l3out parameter is required but only 'name' was being accepted, and that should only be the alias.
2018-09-19 12:52:31 +02:00
Tim Rupp ccfbed3dbc
Adds bigiq_device_facts module (#45822)
This module can be used to query a variety of facts from a BIG-IQ
2018-09-18 22:30:31 -04:00
Tim Rupp 8acbf10ed2
Removes unused f5 imports (#45821) 2018-09-18 18:34:31 -04:00
Christer Hemgren 4da13eefb2 asa_config add doc l3 interface (#41250)
* asa_config add doc l3 interface

+label: docsite_pr
Issue ansible/community#311

* fix interface idempotent

* newline, names, and debug:var
2018-09-18 13:39:14 -04:00
Christer Hemgren 7b1c61000e update asa_config with bgp doc example (#41376)
* update asa_config with bgp doc example

+label: docsite_pr
Issue ansible/community#311

* fix spelling
2018-09-18 10:53:32 -05:00
Sandra McCann 7092dd7fbf Add 'Wait for' example to asa_command module (#45190)
* Added example to register result of a ping test, including a wait_for command.
* added names to tasks
* updated examples to remove deprecated commands etc
* removed group_var
2018-09-17 15:12:46 -05:00
Nathaniel Case 780dc9c561
There are other instances of transform being used... update them as well (#45663) 2018-09-17 08:42:20 -04:00
Maugli 235b11f681 Return correct version on installed VyOS (#39115)
* Return correct version on installed VyOS

Previously existing regexp will shows only "VyOS" without numeric output of router version.
For example: from  "Version:      VyOS 1.1.6" only VyOS will be written in ansible_net_version variable
For more informative output numeric value should be returned as well

* Fixed unittests
2018-09-14 22:51:30 +05:30
Michael Scherer a1e2f1bf73 [voss_facts] remove uneeded global declaration of variable warnings (#45653)
Since the variable is used only once, no need to declare it global.
Remove a warning from linter (lgtm.com)
2018-09-14 10:39:41 -04:00
Tim Rupp 5a3a865ca0
More bigip software fixes (#45633)
Fixes problems related to token timeout. Adds cleanup of tokens.
2018-09-13 15:58:17 -04:00
Tim Rupp e619052424
Fixes multiple lgtm issues (#45629)
Most of the issues were just inclusions of code that were not used.
This cleans those up. Other alerts were semi-false-positives for now
2018-09-13 15:26:17 -04:00
Tim Rupp 34d08adea0
Fixes lgtm alert (#45619)
Alert was for an include that was not used.
https://lgtm.com/projects/g/ansible/ansible/latest/files/lib/ansible/modules/network/f5/_bigip_facts.py?sort=name&dir=ASC&mode=heatmap&showExcluded=false#L98
2018-09-13 13:45:55 -04:00
Michael Scherer de84a05bf4 Remove unused import iControlUnexpectedHTTPError (#45611)
Since that's unused in the code, no need to import it.
This got flagged by linter
2018-09-13 13:16:23 -04:00
Nathaniel Case 285b927889
network command modules cleanup (#45242)
* Standardize _command modules

* Centralize command transformation process

* Fix check mode error test
2018-09-13 08:55:35 -04:00
Tim Rupp e266a24263
Fixes bugs in the bigip_software modules (#45577)
This patch makes hotfix code work, where before, only base images
were working
2018-09-12 15:56:43 -04:00
Anil Kumar Muraleedharan ac58c36ad0 Lenovo cli bugfixes (#45278)
* To change all CLIs present in the code to latest CNOS CLI. One bug of executing with Lenovo Jakku switch is also getting fixed.

* To change the file names as the commands have changed from display to show

* To change to new CLI in test_cnos_comand.py as well
2018-09-12 10:31:45 -04:00
Ghilli3 6040175186 Initial commit of fmgr_sys_proxy.py (#45518) 2018-09-12 19:18:27 +05:30
Michael Scherer 004621ef8e Fix useless comparaison between 2 constants (#45524)
Found with https://lgtm.com
2018-09-11 19:37:50 -04:00
Kevin Breit afbf72cfeb meraki_network - Fix enabling my.meraki.com (#45352)
* Fix enabling my.meraki.com
- A parameter of "no" wouldn't be picked up
- Check for False in addition to whether it exists

* Clean up disable_my_meraki parameter check
2018-09-09 20:31:35 +02:00
Trishna Guha d5bfd93e28
cli_config module doc update (#45345)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-09-07 17:09:08 +05:30
Tim Rupp e21b99b098 Corrects documentation for parameters and examples (#45311)
Documentation for the bigiq modules was a little out of date.
This patch corrects the examples and parameters.
2018-09-06 17:24:49 -04:00
amb1s1 25563dc7cf Fixed an issue when expecting may be, but getting maybe (#44908)
Tested an install on a Nexus 5596 and was failing due that this model will send an output of "Another install procedure maybe in progress" when running the show install all while the install is running. This is how the module knows that an install is being processed. In my case, it will not match that conditional statement.
2018-09-05 19:15:06 +05:30
Ganesh Nalawade 455dfbe732
Fix netconf module and plugin issues (#45140)
* Fix netconf netconf issues

*  Identifier is optional for get_schema api
*  Fix dispatch api mandatory argument check
*  Add save option handling to copy config from target datastore
   to startup datastore if supported
*  Validate config in check-mode or if validate option set to true

* Copy config if check-mode is not enabled
2018-09-04 13:23:18 +05:30
Senthil Kumar Ganesan 3beeeffef9 Docs updated and review comments addressed (#45133) 2018-09-04 07:13:59 +01:00
Dag Wieers 6faf400621
aci_switch_policy_vpc_protection_group: Fix idempotency (#45091) 2018-09-03 16:39:39 +02:00
Matt Martz f89d873698
Stub out modules scheduled for 2.8 removal (#44985)
* Remove modules scheduled for 2.8

* Add changelog and porting guide

* Skip docs test on removed modules

* Don't link to removed modules
2018-08-31 16:27:32 -05:00
Anil Kumar Muraleedharan fbf55a09cc Lenovo image refactor (#44953)
* Refactoring code to adhere to persistence connection.

* Update cnos_rollback.py

* Updating license for the refactored method

* Update cnos_rollback.py

* Removing the BSD License as suggested by Legal

* Adding cnos_image after testing on sftp. Test code is also added

* Removing debug comments

* adding space
2018-08-31 20:04:57 +05:30
Ganesh Nalawade c0326aea2f
Fix cli_command multiple prompt issue (#44922)
* Add check in network_cli to handle all prompts

* Add check_all flag to mandatory handle all the command prompt
  in prompts list. By default if any one prompt is handled
  remaining prompts are ignored.

* Fix cli_command multiple prompt issue

* If multiple prompt and answers are given as input network_cli
  handles only the first prompt that matched by default
* If a command execution results in muliple prompt the fix
  add support to set a boolean option C(check_all) to indicate
  network_cli to wait till all the prompts and answers are processed.

* Update cli_command

* Update api doc

* Fix unit test failure

* Fix CI failure

* Update network_cli

* Fix review comment
2018-08-31 20:04:12 +05:30
Ganesh Nalawade 005233f814
Fix iosxr_config integration test failure (#44969)
*  Check for commands presence in case running config
   is used as base config for diff
*  Correct the fixtures
2018-08-31 19:57:38 +05:30
Ganesh Nalawade b0d6867fbb
Fix netconf_config module default_operation issue (#44958)
* Pass parameters as dict to edit_config api
  as either dict or args can be passed over
  jsonrpc 2.0 and not combination of args and
  kwargs
2018-08-31 16:33:34 +05:30
Nilashish Chakraborty 0f268e70a1
Fix ios_user issues (#44904)
* Fix ios_user issues

* Modify regex and fix unittests
2018-08-31 11:08:46 +05:30
Ryan Breaker c9adfdf68b Reword documentation for IOS L2/L3 interface modules (#44870)
* Update documentation to be cohesive with ios_l2_interface

* Fix small typo in documentation
2018-08-30 14:48:43 -05:00
Senthil Kumar Ganesan a64b97da42 Support for Openswitch (OPX) Control Plane Services (CPS) Module (#44745)
* Generic module to support Openswitch (OPX) Contorl Plane Services (CPS)

* Address ansible-test sanity issues
2018-08-30 17:39:47 +01:00
Ganesh Nalawade 1fdd0e10bb
Update netconf_config module doc (#44910)
* Fix review comments from wisotzky
2018-08-30 21:39:37 +05:30
Ganesh Nalawade 1a684df109
Fix iosxr cli_config module diff issue (#44898)
* Fix iosxr cli_config module diff issue

* Modify iosxr plugin to support configuration
  diff capability (get_diff()) within Ansible
  to be in sync with iosxr_config module.

* Fix unit test case failure
2018-08-30 21:39:11 +05:30
Ghilli3 7bc2660017 fortimanager/fmgr_provisioning.py (#35743)
* Initial commit for new provisioning module
2018-08-30 14:25:17 +01:00
Justin Yaple a767929456 Fix 'macro name' timeout (#44001)
* Fix 'macro name' timeout

Added function to send macro to device using 'sendonly'.

* Filter 'macro' from normal commands

* Removed white space

* Undefined variable 'cmd'
2018-08-30 18:11:51 +05:30
linnil1 d89a1be011 Fix bug of interface-mode in Junos (#44380)
* Fix bug of interface-mode in Junos

* Fix typo. Thanks webknjaz.
2018-08-30 18:10:58 +05:30
Tim Rupp 5bdcaff921
Various f5 fixes (#44858)
* Remove sdk from modules
* Correct IP address bugs in data_group
* Correct compare_dictionary bug in several modules
2018-08-29 16:08:37 -07:00
Anil Kumar Muraleedharan 822dbe3016 Refactoring code to adhere to persistence connection. (#44398)
* Refactoring code to adhere to persistence connection.

* Update cnos_rollback.py

* Review comment of Qalthos incorporated

* Updating license for the refactored method

* Update cnos_rollback.py

* Removing the BSD License as suggested by Legal
2018-08-29 15:25:19 -04:00