Matt Martz
9773a1f289
Add a Singleton metaclass, use it with Display ( #48935 )
...
* Add a Singleton class, use it with Display
* update six import
* Move remaining failes to display singleton
* Fix rebase issues
* Singleton improvements
* Add code-smell for 'from __main__ import display'. ci_complete
* s/self/cls/g
* Add docs for no-main-display
* Address linting issues
* Add changelog fragment. ci_complete
* Implement reentrant lock for class instantiation in Singleton
* Add Display singleton porting guide
2018-11-20 17:06:51 -06:00
Lindsay Hill
727503c5ab
fix typo in edit_config_capability name ( #44102 )
2018-08-14 09:17:50 +05:30
Nathaniel Case
a3385a60b4
httpapi: let httpapi plugin handle HTTPErrors other than 401 ( #43436 )
...
* Hold httpapi response in BytesIO
* Let httpapi plugin deal with HTTP codes if it wants
* Python 3.5 won't json.loads() bytes
* Don't modify headers passed to send
* Move code handling back to send()
but let httpapi plugin have a say on how it happens
2018-08-13 10:25:06 -04:00
Trishna Guha
96346938ee
nxos_vlan refactor to support non structured output ( #43805 )
...
* nxos_vlan refactor to support non structured output
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* unittest fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* minor fixes
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* use check_rc
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* address review comment
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* remove additional return statement
* address Nate's review
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-08-10 21:03:56 +05:30
Trishna Guha
09ae1ec308
cliconf refactor eos, nxos fix ( #43596 )
...
* cliconf refactor eos and nxos fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* move nxos replace check to plugins
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* address review comment
* fix shippable
2018-08-02 16:34:48 +05:30
Ganesh Nalawade
af3f510316
nxos cliconf plugin refactor ( #43203 )
...
* nxos cliconf plugin refactor
Fixes #39056
* Refactor nxos cliconf plugin as per new api definition
* Minor changes in ios, eos, vyos cliconf plugin
* Change nxos httpapi plugin edit_config method to be in sync with
nxos cliconf edit_config
* Fix CI failure
* Fix unit test failure and review comment
2018-07-27 11:05:40 +05:30
Nathaniel Case
ab40c72a3c
httpapi: Split off and save response text contents ( #43305 )
...
* Split off and save response text contents
* login might depend on httpapi
2018-07-26 10:12:34 -04:00
Nathaniel Case
97ffb4c4d2
New base class for HttpApi plugins ( #41915 )
2018-06-25 15:48:12 -04:00
Trishna Guha
f170298332
fix nxos edit_config for httpapi and have uniform load_config ( #41358 )
...
* fix nxos load_config for httpapi and migrate to cliconf
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* add comment
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* address review comment
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* address review comment
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-06-14 22:02:12 +05:30
Nathaniel Case
91fd98a2bd
Complain if API response is not JSON ( #40966 )
2018-05-31 13:20:17 -04:00
Trishna Guha
a7421e8611
httpapi fix nxos ( #40806 )
...
* httpapi fix nxos
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* nxos_hsrp fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-05-29 21:43:34 +05:30
Nathaniel Case
0ad4b7b785
Fixes to httpapi for EAPI ( #40675 )
...
* Replace errant uses of str
* Hook up become to eapi
* Hook become up to nxapi, too
2018-05-24 14:25:19 -04:00
Nathaniel Case
d028a0257a
Change default output of NXAPI to text to match CLI ( #40607 )
...
* Default output format for nxapi now 'text'
* Apply json output to both types of input
* Add missing ConnectionError import to cliconf plugins
2018-05-23 10:09:50 -04:00
Nathaniel Case
e9d7fa0418
HTTP(S) API connection plugin ( #39224 )
...
* HTTPAPI connection
* Punt run_commands to cliconf or httpapi
* Fake enable_mode on eapi
* Pull changes to nxos
* Move load_config to edit_config for future-preparedness
* Don't fail on lldp disabled
* Re-enable check_rc on nxos' run_commands
* Reorganize nxos httpapi plugin for compatibility
* draft docs for connection: httpapi
* restores docs for connection:local for eapi
* Add _remote_is_local to httpapi
2018-05-17 18:47:15 -04:00