Commit Graph

973 Commits (d804ac6f4ba78a033b8addee102222a308e7fbe9)

Author SHA1 Message Date
Alex Feinberg 1ac9c20b6e Fix a typo in create_instances
Fix a typo in create_instances: use 'placement_group' instead of placement_group
when calling boto_siupports_param_in_spot_request().
2016-12-08 11:22:57 -05:00
Brian Coca 2e9462aa21 minor doc fixes, set version added for new tags: parameter should Fix #10894 2016-12-08 11:22:56 -05:00
Brian Coca b5b34f6931 removed unused and undefined aws_regions 2016-12-08 11:22:56 -05:00
Brian Coca 953ed0aecc avoid exception when boto is not available 2016-12-08 11:22:56 -05:00
Brian Coca 5e892b894b removed redundant region def 2016-12-08 11:22:56 -05:00
Bobby Calderwood cd14b8115b Fixes regression introduced by edf1ac1ea6ffd5d44bb2bb62ad320364baf310a3 2016-12-08 11:22:55 -05:00
bw-will-usher efd2cc6089 Fixed MS SQL port number in documentation (1443->1433) per: https://support.microsoft.com/en-us/kb/287932 2016-12-08 11:22:55 -05:00
Brian Coca 88e3c19e9a added new ec2_ami_find as per #905 2016-12-08 11:22:54 -05:00
Brian Coca 2733705a19 deprecated ec2_ami_search 2016-12-08 11:22:54 -05:00
sisso 17a409f20d fixed bug where scaling policy return a random policy if many autoscale group have policies with same name. 2016-12-08 11:22:54 -05:00
Jan Brauer 31abdc7ace Add missing comma 2016-12-08 11:22:54 -05:00
Daekwon Kim a22bdd8356 Fix indent of "register" key 2016-12-08 11:22:54 -05:00
Daekwon Kim 4591761c73 Fix typo (volue -> volume) 2016-12-08 11:22:54 -05:00
Jaanus Torp 0f0cb9dc16 Added support for tagging images in ec2_ami.py 2016-12-08 11:22:53 -05:00
Kyle Johnson cf61778689 Fix typo in rds_subnet_group.py
aws_connection_kwargs should be aws_connect_kwargs
2016-12-08 11:22:53 -05:00
Jesse Rusak 9d93f052c2 Update rds module for RDS2 parameter name change.
boto's rds2 renamed `vpc_security_groups` to `vpc_security_group_ids`
and changed from a list of `VPCSecurityGroupMembership` to just a
list of ids. This accommodates that change when rds2 is being used.
2016-12-08 11:22:53 -05:00
steenzout 67f769d9a6 issue #994: use HAS_BOTO to determine if import was successful: - removed import of sys module. - HAS_BOTO constant to check if import was successful. - trigger a failure when import fails. - removed unnecessary imports. 2016-12-08 11:22:53 -05:00
Brian Coca 7985682c94 added support for postgres9.4 which is now available from amazon 2016-12-08 11:22:52 -05:00
Brian Coca 706db441b4 really fixed docs this time 2016-12-08 11:22:52 -05:00
Brian Coca 2dafff3f97 fixed doc issues on cloudformation 2016-12-08 11:22:52 -05:00
Rob Johnson d8af3f3b67 allow both template and template_url parameters 2016-12-08 11:22:52 -05:00
Mick Bass 5de4c053b6 clean rebase of https://github.com/ansible/ansible-modules-core/pull/1024 on a new branch 2016-12-08 11:22:51 -05:00
Brian Coca 4f7bc895d2 removed requirements/boto as it broke documentation as it is duplicated in shared aws fragements 2016-12-08 11:22:51 -05:00
Adam Chainz 21339664ce Make cloudformation module's template argument not required in case of stack deletion 2016-12-08 11:22:51 -05:00
Jonathan Davila de85294d2d allow boto profile use with s3 2016-12-08 11:22:51 -05:00
Lorin Hochstein 5224375a5a Use the correct alias syntax 2016-12-08 11:22:51 -05:00
Lorin Hochstein 17e6be671b ec2 module: add instance_id alias
Create an alias named instance_id for the instance_ids parameter.
2016-12-08 11:22:51 -05:00
Robert Estelle 268763995c ec2_group allow empty rules. 2016-12-08 11:22:51 -05:00
Kohei YOSHIDA f0db5c0cd0 support secure connection on fakes3 2016-12-08 11:22:51 -05:00
Scott Miller 751434de9d describe choices in alias documentation 2016-12-08 11:22:51 -05:00
Mick Bass 9980205edc Add support for AWS Security Token Service (temporary credentials) to all AWS cloud modules. 2016-12-08 11:22:51 -05:00
Toshio Kuratomi e710e46ff2 Make lack of boto call fail_json instead of sys.exit
Fixes #994
2016-12-08 11:22:51 -05:00
Brandon W Maister c1571928e5 Make cache_subnet_group default to empty security groups
Since they can't be specified together, it seems like setting the
default to no security groups is the right option.
2016-12-08 11:22:51 -05:00
Tom Wadley ad248376b1 use aws connect call in rds_subnet_group that allows boto profile use 2016-12-08 11:22:50 -05:00
Dan Abel 2250a95638 use simpler ec2_connect ec2 util call
This allows boto profile use
2016-12-08 11:22:50 -05:00
Mick Bass e9a0fad36b add retry with exponential backoff when we receive throttling error code from cloudformation 2016-12-08 11:22:50 -05:00
Brandon W Maister cffb2bdee9 Add `cache_subnet_group` to elasticache module
According to the [docs] cache subnet groups are required inside a VPC.

[docs]: http://docs.aws.amazon.com/AmazonElastiCache/latest/UserGuide/CacheSubnetGroups.html
2016-12-08 11:22:50 -05:00
Brian Coca 7cd7bad2e8 added patch to workaround some s3 connection faliures 2016-12-08 11:22:50 -05:00
Brian Coca 252df8685a refactrored connection exception handling, added check to see if we actually get a connection before proceeding
Fixes #964
2016-12-08 11:22:50 -05:00
Sarah Zelechoski 17334b21ea fix syntax in last example 2016-12-08 11:22:50 -05:00
James Martin 57cf6e8bb4 Re-wording of feature. 2016-12-08 11:22:50 -05:00
Toshio Kuratomi e5149f3b30 Fix review comments from @bcoca in #745 2016-12-08 11:22:50 -05:00
Toshio Kuratomi 5378b5db98 Minor code formatting 2016-12-08 11:22:50 -05:00
Rowan Wookey 04fcfdad2c Fixed group name not being passed to wait_for_new_instances when replacing instances
Fixed group_name not being passed to wait_for_elb
Minor code clean up
2016-12-08 11:22:49 -05:00
moe bd09ebe5b4 Woops, make collect/delete loop more efficient. 2016-12-08 11:22:49 -05:00
moe 5e1e1a4dff Fixes #744.
The following cases work for me now:
- Create new ASG with tags
- Update tags on ASG (create/change/delete)

In short, the module should now work as expected
wrt tagging. The previous code did not work at all
with latest boto for me (serialization errors) and
the logic was buggy anyway; e.g. removed tags
would never get deleted from ec2.
2016-12-08 11:22:49 -05:00
James Martin cadfd56304 check lb for instance healthy and some refactoring of rolling replace functions.
Optionally waiting for new instances to be in viable state on ASG creation/update.

Properly updating properties and terminating group.
2016-12-08 11:22:49 -05:00
Julien Syx c676adde0b Fix the issue #931
Checking that the parameter doesn't exist. The old code had a bug when the parameter was 0.
2016-12-08 11:22:49 -05:00
Alex Rowley eeb867daf0 cloud/amazon/s3: update documentation
update description to show that module can do more than just put files into s3
2016-12-08 11:22:48 -05:00
Toshio Kuratomi c9b33d5de2 Fix for py2.6 (no dict comprehensions on py2.6) 2016-12-08 11:22:48 -05:00
Toshio Kuratomi c9cc8d0b70 Initialize the value of vpc_id variable 2016-12-08 11:22:48 -05:00
Toshio Kuratomi ba90eea165 Also don't fail if files are different and overwrite is false for uploads (this mimics copy and template).
Related to #489
2016-12-08 11:22:48 -05:00
Hagai Kariti 7d16ec283e Fix KeyError in public zones in route53 2016-12-08 11:22:48 -05:00
Toshio Kuratomi bba322a10e Sort subnets by the order they are specified in the play
Fixes #172
2016-12-08 11:22:47 -05:00
Bret Martin 650a7365f9 Allow vpc_subnet_id to remain unspecified (see bc0c169) 2016-12-08 11:22:47 -05:00
Matt Ferrante aaca9b5127 check keys is in dim2 before evaluating 2016-12-08 11:22:47 -05:00
Toshio Kuratomi 49511ea078 Small code cleanup 2016-12-08 11:22:46 -05:00
Brandon W Maister 2121bbc208 ec2: Apply all security groups at instance-creation
The code was picking out the first instance from the security groups
specified, even when multiple groups were specified. Now we use all of
them.
2016-12-08 11:22:46 -05:00
Michael Laccetti 8efb138fdc Moving the import to the top of the file and getting rid of the redundancy
I sure do wish I knew where the whitespace change was coming from, though. Frustrating.
2016-12-08 11:22:46 -05:00
Michael Laccetti 0bd25a9a38 Change s3 to use connect_to_region
* Allows us to use Ansible/s3 for GovCloud when accessing a pre-existing bucket
2016-12-08 11:22:46 -05:00
Peter Gehres 878ff1e929 Issue #489: s3 should not fail on checksum mismtach when overwrite=no 2016-12-08 11:22:46 -05:00
Feanil Patel a0caaf7f42 Compare DNS names case insensitively. 2016-12-08 11:22:45 -05:00
James Cammarata 7fd7cffb61 Updating version added fields for new alias parameters in route53 2016-12-08 11:22:45 -05:00
James Cammarata 657d9d1f25 Add private_zone parameter for route53
Fixes #473
2016-12-08 11:22:45 -05:00
Brian Coca 49c10e4359 now captures connection exceptions and returns in 'nicer' module failure 2016-12-08 11:22:44 -05:00
Coderah 0fbe26273d add alias support to route53 module 2016-12-08 11:22:44 -05:00
Coderah 40c41ed4ec add hosted_zone information to ec2_elb_lb return 2016-12-08 11:22:44 -05:00
Capi Etheriel 103caa2853 add ec2 instance tags and groups info 2016-12-08 11:22:44 -05:00
Joel Thompson 646657e325 Fixes issue 697 -- only purge the grants that need to be purged 2016-12-08 11:22:44 -05:00
Bret Martin ed3f1a133b ec2: make group only match group names in this VPC 2016-12-08 11:22:43 -05:00
Brian Coca 70856d5228 fix instance=None documentation 2016-12-08 11:22:43 -05:00
Brian Coca cd7f498755 Revert "Revert "Don't use 'tenancy' in ec2 spot requests"" 2016-12-08 11:22:43 -05:00
Brian Coca 6e55a0324b Revert "Don't use 'tenancy' in ec2 spot requests" 2016-12-08 11:22:43 -05:00
Doug Ellwanger cc6cc6e302 Pull SSL certificate IDs from existing ELBs 2016-12-08 11:22:42 -05:00
Luc Bourlier ae97d76a12 Don't use 'tenancy' in ec2 spot requests
The problem was introduced in commit f5789e8e. 'tenancy' is a parameter of
ec2.run_instances, but not in ec2.request_spot_instances. So it was breaking
the support for spot requests.
2016-12-08 11:22:41 -05:00
Jean-Baptiste Barth c0b2960892 Improve formatting after previous commit 2016-12-08 11:22:41 -05:00
Jean-Baptiste Barth 58ff9bece2 EC2: move logic about terminated instances up (#423)
As stated in #423, the commit 7f11c3d broke ec2 spot instance launching
after 1.7.2. This is because it acts on the 'res' variable which have 2
different types in the method, and in case we request spot instances,
the resulting object is not a result of ec2.run_instances() but
ec2.request_spot_instances(). Actually this fix doesn't seem to be
relevant in the spot instances case, because by construction we won't
retrieve 'terminated' instances in the end.
2016-12-08 11:22:40 -05:00
Brian Coca b853ad6c90 corrected version added for latest features 2016-12-08 11:22:40 -05:00
Brian Coca 83e0516478 minor fixes on new rds refactor 2016-12-08 11:22:40 -05:00
Brian Coca f90da6b2ba ec2 fix docs format 2016-12-08 11:22:39 -05:00
Brian Coca 1f1ebf248f updated tenancy version added 2016-12-08 11:22:39 -05:00
Alex Clifford 4097cbf317 ttl should always be used during a delete 2016-12-08 11:22:38 -05:00
Brian Coca 02a1cb62df corrected release when this feature was added 2016-12-08 11:22:38 -05:00
Toshio Kuratomi f3d41cdb06 Potential fix for 640 2016-12-08 11:22:38 -05:00
Alex Clifford d4c4dd31d8 Fix slight typo in doco 2016-12-08 11:22:37 -05:00
James Martin 07dbc333b2 vpc_zone_identifier must be a csv string when an asg is updated. 2016-12-08 11:22:37 -05:00
Philip Misiowiec f3abfa0f19 Adds tenancy state to returning json 2016-12-08 11:22:37 -05:00
Luís Guilherme F. Pereira b347875de0 Allow ec2_lc to create EC2-Classic Launch Configs
Removes default value from ec2_lc so it can create launch configurations valid on a EC2-Classic environment. AWS API will not accept a assign_public_ip when creating an ASG outside of VPC.
2016-12-08 11:22:36 -05:00
Philip Misiowiec c57c1ea419 added version 2016-12-08 11:22:35 -05:00
Phillip Holmes 0d3b144eb2 Route53 fix - forcing zone_in, record_in to lower case
Fixed the .tolower to .lower() for correct syntax (copied change from older notes).
2016-12-08 11:22:35 -05:00
Philip Misiowiec 23668e41b0 Support for EC2 dedicated tenancy option 2016-12-08 11:22:35 -05:00
Philip Misiowiec d30881a461 Ability to detach an EBS volume from an EC2 instance 2016-12-08 11:22:35 -05:00
Brian Coca 945909bf67 update to use connect_to_region to avoid errors with china 2016-12-08 11:22:34 -05:00
Will Thames 834c8d2f59 Added better region handling and enabled eu-central-1
Make use of improved connect_to_aws that throws an exception
if a region can't be connected to (e.g. eu-central-1 requires
boto 2.34 onwards)

Add eu-central-1 to the two modules that hardcode their regions
Add us-gov-west-1 to ec2_ami_search to match documentation!
This pull request makes use of the changes in ansible/ansible#9419
2016-12-08 11:22:33 -05:00
Kale Franz 7c8f0b99af #531 correction
correct list comprehension for older versions of python (back to python 2.4)
2016-12-08 11:22:33 -05:00
Kale Franz eac743dc39 fixes #529 ec2_group module bug 2016-12-08 11:22:33 -05:00
Jeff Gonzalez 8eedd915cd Fixed formatting in documentation
The example was using mixed shorthand and long form yaml (region: "us-east-1 disable_rollback=true"

I modified the entire example to be long form.
2016-12-08 11:22:33 -05:00
Mike Putnam d2d0ffd83a Type fix on delete_snapshot docs. 2016-12-08 11:22:32 -05:00
Harald Skoglund 1a8b9b8935 add support for stack policies in cloudformation 2016-12-08 11:22:32 -05:00
Mike Putnam 1de5248a0a Clarify possible variable value in the docs. 2016-12-08 11:22:32 -05:00
Marcus Ahle a71b1b7385 Preventing Nonetype is not iterable error when no tags are passed in for a newly created ASG 2016-12-08 11:22:31 -05:00
Ben Whaley 6609ebde27 vpc_zone_identifier should be a list as per the docs 2016-12-08 11:22:31 -05:00
Scott Miller c49a20b0e5 fix documentation
AWS does not recognize the subnet if it is presented in a comma delimited format with spaces. you must remove the space for Amazon to recognize the second subnet.
2016-12-08 11:22:31 -05:00
Toshio Kuratomi cd7cc07e85 Gixes to doc formatting 2016-12-08 11:22:31 -05:00
Steve Fox 7af1c96623 retry_interval needs to be a float before passing to time.sleep 2016-12-08 11:22:31 -05:00
Philip Misiowiec 3f4d412bff Ability to specify new SSD EBS option 2016-12-08 11:22:30 -05:00
Will Thames 63656e5ef7 Fixed tagging 2016-12-08 11:22:30 -05:00
Denver Janke 61cfccff1c Fix few bugs around renaming db instances. 2016-12-08 11:22:30 -05:00
Will Thames daac0e3a3e Improved error handling
More tests, particular for failure testing
2016-12-08 11:22:30 -05:00
Will Thames 22a3b3f811 RDS rewrite to use boto.rds and boto.rds2
Using rds2 allows tags and the control over whether or not DBs are
publicly accessible.
Move RDS towards a pair of interfaces implementing the details of rds
and rds2
Added tests to ensure that all operations work correctly as well as
requirements files that allow virtualenvs to test either boto.rds or
boto.rds2
2016-12-08 11:22:29 -05:00
willthames ef88ff6dd8 Added the ability to remove snapshots
Added state option, and accompanying snapshot_id option for
when state=absent.
2016-12-08 11:22:29 -05:00
Michael DeHaan f875cc5197 Remove potentially out of date or specific product references. 2016-12-08 11:22:29 -05:00
Michael DeHaan 76efaa6cfb More EC2 doc tweaks 2016-12-08 11:22:29 -05:00
Michael DeHaan 590d20db24 Misc EC2 doc tweaks. 2016-12-08 11:22:29 -05:00
follower 4889701874 Fix typo of "rules_egress"
Or is "rules_egree" supposed to be a plural? The sentence is difficult to parse.

Maybe the correct fix is to "Purge existing rules on security group that are not found in rules_egress"?
2016-12-08 11:22:28 -05:00
Robert Estelle 4e2d05b1f3 Remove incorrect executable permissions. 2016-12-08 11:22:26 -05:00
James Martin dd46f7275f asg will now be terminated if state=absent.
adds mutually exclusive options
2016-12-08 11:22:26 -05:00
James Cammarata e9fbb5f1b6 Serialize tag attributes to ASG properties in ec2_asg
Fixes #108
2016-12-08 11:22:26 -05:00
James Martin f59a1348ad Removes orphaned code. 2016-12-08 11:22:26 -05:00
James Martin 17cd9d18b0 fixes #240, #274, #108 2016-12-08 11:22:26 -05:00
José Moreira 82450c6811 Fixed small typo on ec2 task name 2016-12-08 11:22:25 -05:00
Brian Coca 5a467bc72c added __init__.py to new cloud subcategories so builds work again 2016-12-08 11:22:25 -05:00
Brian Coca 32e85c0944 made subcategories for cloud modules for better organization 2016-12-08 11:22:24 -05:00