Peter Sprygada
ebc2716be7
removes old module.connected property from result ( #21977 )
2017-02-26 23:14:56 -05:00
Peter Sprygada
216877c6ca
adds system_mtu argument to nxos_system ( #21970 )
...
* updates argument_spec
* adds unit test case
2017-02-26 11:33:58 -05:00
Peter Sprygada
4c354c9c70
adds integration tests cases for nxos_feature ( #21966 )
2017-02-26 08:12:57 -05:00
Peter Sprygada
10b23f3a00
adds unit test cases for nxos_command ( #21959 )
2017-02-26 07:38:08 -05:00
Peter Sprygada
0cb2019293
roll up of bug fixs for nxos_evpn_global ( #21961 )
...
* updates nxos_evpn_global module
* adds integration test cases
* adds unit test cases
2017-02-26 06:45:26 -05:00
Peter Sprygada
a284c3f7ea
roll up of fixes for nxos_facts ( #21954 )
...
* fixes commands to work with nxapi
* updates test case timeouts
2017-02-25 17:48:09 -05:00
Peter Sprygada
14c05d9e2b
roll up of fixes for nxos_config ( #21949 )
...
* fixes provider to not log entries
* fixes nxapi send_request with config statements
* fixes nxapi get_config()
* updates nxos_config integration tests
2017-02-25 16:36:00 -05:00
Peter Sprygada
01ac1bc6e5
roll up of fixes from nxos integration tests ( #21948 )
...
* now fails nxos_nxapi if the transport=nxapi
* fixes typos in nxos_nxapi integration tests cases
2017-02-25 13:17:04 +00:00
Matt Martz
305c88700d
PEP8 E712 fixes ( #21916 )
2017-02-24 16:49:43 -06:00
Peter Sprygada
c3150fbfa9
fixes _nxos_template to use persistent connection ( #21841 )
...
The module needed full update to use the persistent connection
introduced in Ans2.3.
fixes #21835
2017-02-23 16:59:41 -05:00
Peter Sprygada
381f7209f8
fixes issue in nxos_config when retrieving current config ( #21843 )
...
When parsing the configuration, the wrong indent level was set so the
configurations could not be properly compared. Also noted that
defaults: yes needed to be added to the integration tests to make the
test cases valid, which is also included in this patch
fixes #21828
2017-02-23 16:59:29 -05:00
Peter Sprygada
06d0278290
fix bug that would cause stack trace in nxos_nxapi ( #21861 )
...
The parse_sandbox function will generate a stack trace if the command
is not supported. This patch will resolve that issue.
2017-02-23 16:59:06 -05:00
Peter Sprygada
b25c51f99a
cast http_port, https_port to int from config ( #21840 )
...
When retrieving the http_port, https_port values from the configuration
of the device, the values need to cast to int in order to correctly
compare against the argspec values. This patch fixes that problem.
fixes #21832
2017-02-23 13:05:59 +00:00
Peter Sprygada
ab0f992b3a
fixes import statement in nxos_facts module ( #21834 )
...
trying to import from the wrong shared lib, this patch changes
network_common to connection. Also fixes a bug found in the nxos
action plugin to detect transport
fixes #21829
2017-02-23 13:00:34 +00:00
Peter Sprygada
730bd682c6
sends save command in text mode otherwise it fails ( #21812 )
...
Sending the save command over nxapi requires text mode otherwise nxapi
will reject the command. This commit ensures that the command is always
sent in text mode
fixes #18971
2017-02-22 22:41:14 -05:00
Peter Sprygada
7b30203016
cleans up nxos_vlan output ( #21807 )
...
Only returns debug return keys when the debug flag is set
2017-02-22 20:36:43 -05:00
Peter Sprygada
9e6980a039
fixs command dict to be sent to connection socket ( #21713 )
...
There as an invalid key in the command dict that would cause failure
using prompts. This changes the key from response to answer which is
what is expected by network_cli
2017-02-22 09:44:04 -05:00
Peter Sprygada
76c9ad9dfc
new module nxos_system ( #21627 )
...
* provides declarative config support for nxos system attributes
* adds unit test cases for new module
2017-02-18 18:56:02 -05:00
Peter Sprygada
920f9f4815
fixes nxos nxapi implementation ( #21615 )
...
* correctly maps play_context to nxapi values
* fixes bug in nxos_nxapi module detecting nxapi feature
* updates nxos shared lib provider values
* fixes missing ssh_keyfile in nxos shared lib
2017-02-18 11:20:26 -05:00
Matt Martz
7c00346714
Validate EXAMPLES as YAML
2017-02-15 13:01:43 -08:00
Peter Sprygada
21d993a4b8
refactors nxos module to use persistent connections ( #21470 )
...
This completes the refactor of the nxos modules to use the persistent
connection. It also updates all of the nxos modules to use the
new connection module and preserves use of nxapi as well.
2017-02-15 11:43:09 -05:00
Gabriele
db786fc211
Fixing nxos_portchannel bug caused by wrong regex ( #20850 )
2017-02-14 16:08:43 -05:00
Gabriele
5fbe64a324
Fixing nxos modules when interface is loopback ( #20645 )
...
* Fixing modules when interface is loopback
* Remove capitalize
2017-02-14 12:10:46 -05:00
Brian Coca
74e8aa22af
no log passwords ( #21229 )
...
* no log passwords
* removed unneeded no_log
2017-02-10 15:13:59 -05:00
Matt Clay
462ab6b1db
PEP 8 E111 cleanup for nxos modules.
2017-01-30 15:45:05 -08:00
Matt Clay
10d9318de7
PEP 8 indent cleanup. ( #20800 )
...
* PEP 8 E121 cleanup.
* PEP 8 E126 cleanup.
* PEP 8 E122 cleanup.
2017-01-29 07:28:53 +00:00
Matt Clay
e2c0b375d3
PEP 8 cleanup. ( #20790 )
...
* PEP 8 E115 cleanup.
* PEP 8 E131 cleanup.
2017-01-28 01:39:40 -08:00
Matt Clay
d913f69ba1
PEP 8 W291 whitespace cleanup.
2017-01-27 17:08:02 -08:00
Matt Clay
95789f3949
PEP 8 whitespace cleanup. ( #20783 )
...
* PEP 8 E271 whitespace cleanup.
* PEP 8 W293 whitespace cleanup.
* Fix whitespace issue from recent PR.
2017-01-27 15:45:23 -08:00
Matt Clay
63b1e0c277
Fix infrequent PEP 8 issues.
2017-01-27 14:06:21 -08:00
Gabriele
c980b52d33
Fixing issue when multiple vni exist ( #19928 )
2017-01-06 16:36:13 -05:00
Gabriele
f2baa6d61a
fix nxos_facts to support multiple neighbors and modules ( #19946 )
2017-01-06 16:34:59 -05:00
John R Barker
40ecc3188f
Use M() to link to the replacement module. ( #19976 )
2017-01-06 16:21:39 +00:00
Daniel
7cf9ee30a5
Removed 'no vn-segment' when state == 'absent' ( #19952 )
2017-01-05 22:03:46 +00:00
Gabriele
c58278b1c2
Fixing nxos_ntp when no config exists ( #19678 )
2017-01-03 10:50:31 -05:00
Eric Beahan
dce8f3899e
Modify an initial value causing exception when vlan_range param is present ( #19019 )
2016-12-15 16:31:34 -05:00
Andrea Tartaglia
ef391a11ec
Removed dict.iteritems() in modules. ( #18859 )
...
This is for py3 compatibility, addressed in #18506
2016-12-12 15:16:23 -08:00
Matt Clay
2cb6a10a0e
Fix module names in module docs.
2016-12-09 18:13:57 -07:00
James Cammarata
fa5386c488
Some additional module cleanup of mistakes made during merging
2016-12-08 11:35:20 -05:00
James Cammarata
14833f1c7a
A few more organizational cleanups from the repo merge
2016-12-08 11:35:19 -05:00
James Cammarata
8afa090417
Resolving differences in core modules post-merge
2016-12-08 11:25:36 -05:00
Toshio Kuratomi
7319104552
Refreshed metadata for core modules
2016-12-08 11:25:35 -05:00
René Moser
507559dba5
doc: network: fix syntax errors in examples ( #5780 )
2016-12-08 11:25:34 -05:00
Sam Doran
c0c26f83a8
Examples syntax batch7 ( #5624 )
...
* Change example syntax on nxos_feature module
* Change example syntax on nxos_hsrp module
* Change example syntax on nxos_igmp module
* Change example syntax on nxos_interface module
* Change example syntax on nxos_interface_ospf module
* Change example syntax on nxos_ip_interface module
* Change example syntax on nxos_ping module
* Change example syntax on nxos_switchport module
* Change example syntax on nxos_vlan module
* Change example syntax on nxos_vrf module
* Change example syntax on nxos_vrf_interface module
* Change example syntax on nxos_vrrp module
* Change example syntax on meta module
* Change example syntax on set_fact module
* Change example syntax on win_copy module
* Change example syntax on win_file module
* Change example syntax on win_get_url module
Remove escaping of \ characeter in Windows paths since it's no longer required for single quoted or unquoted values when using multi-line YAML syntax.
* Change example syntax on win_lineinfile module
* Change example syntax on win_msi module
* Change example syntax on win_stat module
* Remove nxos_bgp example from nxos_igmp module
* Mark examples as regexp to avoid syntax error
* Cleanup win_copy.py examples
* Cleanup win_file.py examples
* Remove quotes in win_get_url.py examples
* Cleanup quotes and languare in win_lineinfile.py
* Cleanup examples in win_group.py
* Cleanup examples in win_service.py
* Don't use : in documentation because it breaks the YAML syntax check
* Cleanup win_copy.py examples
* Cleanup win_copy.py examples
* Minor change to fix test failure
* Use single quotes
2016-12-08 11:25:33 -05:00
Dag Wieers
54fdff16db
Performance improvement using in-operator on dicts
...
Just a small cleanup for the existing occurrences.
Using the in-operator for hash lookups is faster than using .keys()
http://stackoverflow.com/questions/29314269/why-do-key-in-dict-and-key-in-dict-keys-have-the-same-output
2016-12-08 11:25:31 -05:00
John R Barker
2a9e5687eb
Correct typos in docs strings ( #5233 )
2016-12-08 11:25:25 -05:00
Michael Scherer
18b0920311
Do not leak the vtp_password in log ( #5199 )
2016-12-08 11:25:20 -05:00
John R Barker
25b6492d37
Bulk spelling improvement to modules-core ( #5225 )
...
* Correct spelling mistakes
* Correct more spelling issues
* merge conflict
* Revert typo in parms
2016-12-08 11:25:20 -05:00
John Barker
bca8bbe7c2
Correct functional typos
2016-12-08 11:25:19 -05:00
Nathaniel Case
5a8ebf5953
nxos module cleanup ( #5065 )
...
* Fix imports on nxos_bgp* modules
* Fix imports on nxos_evpn* modules
* Cleanup issues for nxos_facts
* Shuffle imports for nxos_template
* Fix imports on nxos_ospf* modules
* Fix nxos_hsrp
As get_hsrp_groups_in_devices is not actually called anywhere, I presume this
change is reasonable.
* Fix imports on nxos_interface* modules
* Update nxos_static_route imports
* update nxos_vrf
* Update nxos_config imports
2016-12-08 11:25:19 -05:00
Bill Nottingham
765269e547
Fix deprecation notices. ( #5180 )
2016-12-08 11:25:19 -05:00
Gabriele
f8d2be407d
Fixing docstring ( #5130 )
2016-12-08 11:25:18 -05:00
Gabriele
b4565b6667
Adding more details on DOCSTRING about how to use the module ( #5121 )
2016-12-08 11:25:18 -05:00
Peter Sprygada
9707ae6490
adds exception handling for AddConditionError ( #5124 )
...
AddConditionErrors are now handled by nxos_command and a well formed error
is returned from the module
2016-12-08 11:25:17 -05:00
Gabriele
d4c2a13325
Improving nxos_igmp_snooping ( #5011 )
2016-12-08 11:25:17 -05:00
Gabriele
3c257688bc
Fixing nxos_igmp_interface ( #5010 )
2016-12-08 11:25:17 -05:00
Gabriele
b6c07bc9e9
Fixing nxos_hsrp ( #5009 )
...
* Fixing nxos_hsrp
* Adding space after =
2016-12-08 11:25:17 -05:00
Gabriele
62bf8d0c78
Add ethernet-link-oam mapping to nxos_feature ( #4956 )
...
* Add ethernet-link-oam mapping
* Adding port-secutiry mapping
* Fixing command output format
2016-12-08 11:25:17 -05:00
Gabriele
67d6f2c0d6
Fixing nxos_vlan ( #5005 )
...
* Fixing nxos_vlan
* Fixing docstring
* Fixing docstring
2016-12-08 11:25:17 -05:00
Gabriele
43632951fe
Fixing nxos_aaa_server ( #5002 )
...
* Fixing command output formatting
* Fixing cmds
2016-12-08 11:25:17 -05:00
Gabriele
7f861fb9ce
Fixing nxos_acl ( #5006 )
...
* Fixing nxos_acl
* Fixing nxos_acl
2016-12-08 11:25:17 -05:00
Gabriele
272b20000f
Fixing nxos_acl_interface ( #5007 )
2016-12-08 11:25:17 -05:00
Gabriele
75c4051933
Fixing nxos_interface ( #5012 )
2016-12-08 11:25:16 -05:00
Gabriele
1be7ca4f70
Fxing nxos_ip_interface ( #5013 )
2016-12-08 11:25:16 -05:00
Gabriele
6708874f1c
Fixing nxos_mtu ( #5014 )
2016-12-08 11:25:16 -05:00
Gabriele
6934f11e1f
Fixing nxos_ntp ( #5015 )
2016-12-08 11:25:16 -05:00
Gabriele
6201a57d83
Fixing nxos_ntp_auth ( #5016 )
2016-12-08 11:25:16 -05:00
Gabriele
c50324fb08
Fixing nxos_ntp_options ( #5017 )
2016-12-08 11:25:16 -05:00
Gabriele
4b6ee73f8c
Fixing nxos_pim_interface ( #5018 )
2016-12-08 11:25:16 -05:00
Gabriele
5b96fb1dac
Fixing nxos_portchannel ( #5019 )
2016-12-08 11:25:16 -05:00
Gabriele
ebb39a0151
Fixing nxos_smu ( #5021 )
2016-12-08 11:25:16 -05:00
Gabriele
cda65cad18
Fixing nxos_snmp_community ( #5022 )
2016-12-08 11:25:16 -05:00
Gabriele
f74275fc1d
Fixing nxos_snmp_contact ( #5023 )
2016-12-08 11:25:16 -05:00
Gabriele
73d66e28ab
Fixing nxos_snmp_host ( #5024 )
2016-12-08 11:25:16 -05:00
Gabriele
7c7eee94b2
Fixing nxos_snmp_location ( #5025 )
2016-12-08 11:25:16 -05:00
Gabriele
19769903e6
Fixing nxos_snmp_traps ( #5026 )
2016-12-08 11:25:16 -05:00
Gabriele
bf59e458b1
Fixing nxos_snmp_user ( #5027 )
2016-12-08 11:25:16 -05:00
Gabriele
04e62346d1
Fixing nxos_udld_interface ( #5030 )
2016-12-08 11:25:16 -05:00
Gabriele
6bedeb28d8
Fixing nxos_switchport ( #5028 )
2016-12-08 11:25:16 -05:00
Gabriele
773f1703b7
Fixing nxos_udld ( #5029 )
2016-12-08 11:25:15 -05:00
Gabriele
d61950d48c
Fixing nxos_vpc_interface ( #5032 )
2016-12-08 11:25:15 -05:00
Gabriele
51c37e9f58
Fixing nxos_vrf ( #5033 )
2016-12-08 11:25:15 -05:00
Gabriele
8f331e01ca
Fixing nxos_vpc ( #5031 )
2016-12-08 11:25:15 -05:00
Gabriele
9ff6070eb8
Fixing nxos_vrf_interface ( #5034 )
2016-12-08 11:25:15 -05:00
Gabriele
e7286ed43c
Fixing nxos_vtp_domain ( #5036 )
2016-12-08 11:25:15 -05:00
Gabriele
c19e3b5924
Fixing nxos_vrrp ( #5035 )
2016-12-08 11:25:15 -05:00
Gabriele
f89cb1717c
Fixing nxos_vtp_password ( #5037 )
2016-12-08 11:25:15 -05:00
Gabriele
b897b497c1
Fixing nxos_vtp_version ( #5038 )
2016-12-08 11:25:15 -05:00
John R Barker
177dcadbc0
deprecated _template network modules: Rename in modules-core ( #5072 )
2016-12-08 11:25:14 -05:00
Peter Sprygada
654a38897f
fixes exception raised when nxos_facts uses nxapi transport ( #4988 )
...
This fixes a condition where an exception is raised when collecting `interface`
facts and the transport is set to nxapi in the nxos_nxapi module.
fixes ansible/ansible#17691
2016-12-08 11:25:13 -05:00
Peter Sprygada
88b2c7e1f6
fixes bug where setting state=absent in nxos_nxapi is not idempotent ( #4984 )
...
When setting state=absent the nxos_nxapi module would always try to remove
the configuration regardless of the current state of the device. This will
fix that problem.
This also updates the docstring to correctly reflect https as default=no
fixes #4955
depends on ansible/ansible#17728
2016-12-08 11:25:13 -05:00
Josh Lothian
319b2b28cb
Fix YAML syntax in NXOS documentation ( #4922 )
...
* Fix YAML syntax in NXOS documentation
Use ':' and not '=' to ensure valid YAML
in the EXAMPLES
* Correcting introduced syntax error
2016-12-08 11:25:11 -05:00
Matt Clay
6cdcf09984
Remove duplicate keys from module docs. ( #4920 )
2016-12-08 11:25:11 -05:00
GGabriele
c47fd4b3e9
Add feature mappings
2016-12-08 11:25:11 -05:00
Peter Sprygada
25375f1057
adds exception handling to nxos_command for FailedConditionalError
...
This adds exception handling as per ansible/ansible#17638 to the
nxos_command module.
2016-12-08 11:25:11 -05:00
GGabriele
6701f038ba
Fixed docstring
2016-12-08 11:25:10 -05:00
GGabriele
0eb63cdeaa
Fixing nxos_portchannel
2016-12-08 11:25:10 -05:00
GGabriele
13e87e3a6c
Adding nxos_igmp_snooping
2016-12-08 11:25:09 -05:00
GGabriele
15c07334c7
Adding nxos_aaa_server_host
2016-12-08 11:25:09 -05:00
GGabriele
4b6a59bd13
Adding nxos_udld_interface
2016-12-08 11:25:09 -05:00
GGabriele
f1a96986c4
Adding 2.1 and 2.2 support to nxos_switchport
2016-12-08 11:25:09 -05:00
GGabriele
e669d3e889
Adding nxos_snmp_user
2016-12-08 11:25:09 -05:00
GGabriele
693f8e623a
Improving argument_spec
2016-12-08 11:25:09 -05:00
GGabriele
2f58306564
Adding nxos_pim_interface
2016-12-08 11:25:09 -05:00
GGabriele
48942d6e32
Fixing docstring
2016-12-08 11:25:09 -05:00
GGabriele
b42f6da0ce
Adding nxos_mtu
2016-12-08 11:25:09 -05:00
GGabriele
d8b2b0387b
Adding nxos_vtp_version
2016-12-08 11:25:09 -05:00
GGabriele
da8aa0dd29
Removing unused function
2016-12-08 11:25:09 -05:00
GGabriele
d53b52d528
Fixing module name
2016-12-08 11:25:08 -05:00
GGabriele
d435aca86e
Adding missing version_added
2016-12-08 11:25:08 -05:00
GGabriele
bf2e0ec953
Adding nxos_vtp_domain
2016-12-08 11:25:08 -05:00
GGabriele
b1f33ca5a0
Improved function
2016-12-08 11:25:08 -05:00
GGabriele
d3de4c160f
Adding nxos_vtp_password
2016-12-08 11:25:08 -05:00
GGabriele
29ea186bd7
Adding nxos_udld
2016-12-08 11:25:08 -05:00
GGabriele
c45e596159
Adding nxos_ntp_options
2016-12-08 11:25:08 -05:00
GGabriele
77b043dcf3
Fixing conditional format
2016-12-08 11:25:08 -05:00
GGabriele
52dfa697c2
Adding nxos_ntp_auth
2016-12-08 11:25:08 -05:00
GGabriele
6efb79bbeb
Adding nxos_aaa_server
2016-12-08 11:25:08 -05:00
GGabriele
821b1606b3
Fixing nxos_interface
2016-12-08 11:25:08 -05:00
GGabriele
095d30ea63
Adding nxos_ntp
2016-12-08 11:25:08 -05:00
GGabriele
5f0060ec41
Fixing argument_spec
2016-12-08 11:25:08 -05:00
GGabriele
57f86c0efc
Fixing docstring format
2016-12-08 11:25:08 -05:00
GGabriele
76d7379d73
Adding nxos_snmp_traps
2016-12-08 11:25:08 -05:00
GGabriele
988d6bbb2b
Fixing return string
2016-12-08 11:25:08 -05:00
GGabriele
37170dd353
Adding nxos_snmp_location
2016-12-08 11:25:08 -05:00
GGabriele
2c8bc37003
Adding RETURN
2016-12-08 11:25:07 -05:00
GGabriele
de8b759df2
Adding nxos_install_os
2016-12-08 11:25:07 -05:00
GGabriele
c5ab15443f
Adding nxos_gir_profile_management
2016-12-08 11:25:07 -05:00
GGabriele
c7ca3654df
Adding nxos_gir
2016-12-08 11:25:07 -05:00
GGabriele
58501d3650
Removing indentations
2016-12-08 11:25:07 -05:00
GGabriele
852f5176a1
Removing indentation
2016-12-08 11:25:07 -05:00
GGabriele
4775c257ea
Fixing file writing format
2016-12-08 11:25:07 -05:00
GGabriele
2016e5d44a
Adding nxos_snapshot
2016-12-08 11:25:07 -05:00
GGabriele
1752082c00
Adding nxos_snmp_host
2016-12-08 11:25:07 -05:00
GGabriele
4a182888b8
Adding nxos_snmp_community
2016-12-08 11:25:07 -05:00
GGabriele
0c4c5467f7
Fixing docstring and more fix
2016-12-08 11:25:07 -05:00
GGabriele
346f83029b
Fixing error handling
2016-12-08 11:25:07 -05:00
GGabriele
e1fab98061
Fixed module structure
2016-12-08 11:25:07 -05:00
GGabriele
4cbcc1f91d
Adding nxos_vxlan_vtep_vni
2016-12-08 11:25:07 -05:00
John Barker
264bb374b9
RETURNS doesn't support markup, so remove it
2016-12-08 11:25:05 -05:00
John Barker
42d5d7b21b
Docs improvements to _config
2016-12-08 11:25:05 -05:00
GGabriele
e375b4c61c
Fixing nxos_feature
2016-12-08 11:25:05 -05:00
John Barker
c01328b597
Document `backup` options
...
To make future diffing easier, use consistent ordering
2016-12-08 11:25:04 -05:00
Peter Sprygada
ad707c2724
roll up updates to nxos_config module
...
* remote 'updates' argument
* clean up functions
* update doc strings
* add required_if dependencies
2016-12-08 11:25:04 -05:00
Andrew Gaffney
bac0c4595c
Fix missing colons in network module examples ( #4778 )
2016-12-08 11:25:03 -05:00
Peter Sprygada
6cca2b06fe
fixes bug where nxos_config wasn't handling checkpoints correctly
2016-12-08 11:25:02 -05:00
GGabriele
bc7b093089
Removed newline
2016-12-08 11:25:01 -05:00
GGabriele
dfa9904599
Added missing fullstop
2016-12-08 11:25:01 -05:00
GGabriele
87b839e1f8
Adding missing fullstop
2016-12-08 11:25:01 -05:00
GGabriele
d2d1b18ef4
Fixed param value format in docstring
2016-12-08 11:25:01 -05:00