Commit Graph

15 Commits (e5ead914393ccb9d99c6c64b1b7aa7e5e98fe9c9)

Author SHA1 Message Date
Chris Weber 891245c6f6 Fixed modules/system py files for 2.4 to 3.5 exceptions (#2367) 2016-12-08 11:34:20 -05:00
Brian Coca 3f22667151 added note about behaviour change in 2.2 2016-12-08 11:34:16 -05:00
Leo Antunes c0570d275b Allow multiple keys per host + minor improvements (#716)
* known_hosts: clarify key format in documentation

Add a small clarification to the documentation about the format of the
"key" parameter.
Should make #664 less of a issue for newcomers.

* known_hosts: normalize key entry to simplify input

Keys are normalized before comparing input with present keys. This
should make it easier to deal with some corner cases, such as having a
hashed entry for some host and trying to add it as non-hashed.

* known_hosts: allow multiple entries per host

In order to support multiple key types and allow the installed ssh
version to decide which is more secure, the module now only overwrites
an existing entry in known_hosts if the provided key is of the same
type.
Old keys of different types must be explicitly removed. Setting
state to "absent" and providing no key will remove all entries for the
host.
2016-12-08 11:34:16 -05:00
Michael Scherer ea6a2bfd95 Use type='path' rather than str, so path is expanded correctly 2016-12-08 11:34:13 -05:00
Brian Coca eae8942583 avoid index error on empty list, key being true means its not None nor [] fixes #13009 2016-12-08 11:33:33 -05:00
Michael Scherer 2ff3438435 Use the parameter 'name' everywhere for consistency
Fix https://github.com/ansible/ansible/issues/11395
2016-12-08 11:33:03 -05:00
Greg DeKoenigsberg c65a612d1f Changes to author formatting, remove emails 2016-12-08 11:32:51 -05:00
Brian Coca d344a3fde3 more string corrections 2016-12-08 11:32:39 -05:00
Sterling Windmill 0eaee21d81 Allow for specifying name instead of host as per the documentation at http://docs.ansible.com/known_hosts_module.html 2016-12-08 11:32:35 -05:00
Brian Coca 48e1f1b0bc fixed 2.4 compatibility 2016-12-08 11:32:34 -05:00
Brian Coca fd060d453c now also captrure OSErrors on temp file fixes #360 2016-12-08 11:32:32 -05:00
Matthew Vernon dd9d5cc670 Fix for issue #353 (handle change in ssh-keygen behaviour)
Prior to openssh 6.4, ssh-keygen -F returned 0 (and no output) when no
host was found. After then, it instead returned 1 and no output. This
revised code behaves correctly with either behaviour. There is
currently no other code path that results in exit(1) and no output.
2016-12-08 11:32:32 -05:00
Tyler Kellen 12b2cab5ba correct version_added for known_hosts
It was added in 1.9, not 1.6.
2016-12-08 11:32:31 -05:00
Matthew Vernon 1e21e34e0f Changes from Brian Coca's review of this module
These are all the code changes from Brian's review:
* change #! line
* rename "host" to "name" [keep as alias]
* make documentation clearer
* imports 1 per line
* use get_bin_path to find ssh-keygen
* key not actually required when removing host
2016-12-08 11:32:27 -05:00
Matthew Vernon e76ad916ef known_hosts: manage ssh known_hosts files with ansible.
The known_hosts module lets you add or remove a host from the
known_hosts file. This is useful if you're going to want to use the
git module over ssh, for example. If you have a very large number of
host keys to manage, you will find the template module more useful.

This was pull request 7840 from the old ansible repo, which was
accepted-in-principle but not yet merged. The mailing list thread
reading it is:

https://groups.google.com/forum/#!topic/ansible-devel/_e7H_VT6UJE/discussion
2016-12-08 11:32:27 -05:00