Commit Graph

3688 Commits (ebeb78811700bb7dd1b293fd27c98963b2e962ac)

Author SHA1 Message Date
Jason Meridth 667c40e80b Fix typo in ec2_vpnc_nat_gateway module (#46304)
- Added space between `format` and `in` on return item `create_time`
2018-10-01 09:16:04 -05:00
abarbare c5d5d08b6b feat: add scaleway security_group_rule management (#45694)
* feat: add scaleway security_group_rule management
2018-10-01 12:37:48 +01:00
Remo Wenger 83e584577a docker_container: ambiguous parameter "stop_timeout" (#43874)
* docker_container: Honour stop_timeout when creating docker containers (#43814)

* Adjusting description to what actually happens.

See docker-py changelog for 2.7.0: 'APIClient.stop will
no longer override the stop_timeout value present in the
container’s configuration.'

* Add a test whether stop_timeout can be configured for the container.

* Added changelog.

* Integrate with comparisons (by default, ignore stop_timeout value for restarts; will be configurable with PR ansible/ansible#44789).

* Fix config change code and tests (#2)

* Improving wildcard test.
* Using correct config.
2018-09-30 12:03:53 +01:00
Ondra Machacek 142d1f1f1c ovirt_host: Fix fail condititon of upgrade (#46104)
Signed-off-by: Ondra Machacek <omachace@redhat.com>
2018-09-28 09:59:59 +01:00
Felix Fontein 84682464c7 docker_container: allow to configure comparison for existing containers (#44789)
* Added comparison configuration.

* Improving user feedback on specifying a wrong option.

* Avoid bare except.

* Added basic integration tests.

* Adding wildcard support.

* Warn if ignore_image=yes is overridden.

* Added changelog fragment.
2018-09-28 08:33:38 +01:00
Sloane Hertel 9efc3dc761
Fix ec2_group for EC2-Classic accounts (#46242)
* Fix ec2_group for EC2-Classic accounts

* changelog
2018-09-27 23:11:04 -04:00
Felix Fontein a727a1ee67 [aws] route53 module: fix idempotency for CAA records (#46049)
* Fixing record order for CAA records to properly handle idempotency.

* Add integration tests that reproduce CAA failure
2018-09-27 15:08:47 -04:00
David Passante 382641ff24 cs_account: Implement role parameter support (#46166) 2018-09-27 07:37:56 +02:00
Yunge Zhu 69594c5370 add azure_rm_cdnprofile and azure_rm_cdnprofile_facts (#45097)
* add cdn profile with facts

* fix merge issue

* fix version

* fix lint

* move cdn client out of azure_rm_common

* fix lint

* fix helper

* fix code bug

* fix bug

* fix import

* fix typo

* fix test
2018-09-27 10:10:01 +10:00
René Moser f73996e6eb
cs_resourcelimit: use query_api for error handling (#46036) 2018-09-26 09:05:48 +02:00
René Moser 48b9992446
cs_ip_address: use query_api, fixes error handling (#46034) 2018-09-26 09:05:07 +02:00
René Moser 7f92a8c94c
cs_staticnat: fix sanity (#46037) 2018-09-26 09:03:16 +02:00
René Moser c09b785a66
cs_instance: doc: fix typo in examples (#46035) 2018-09-26 09:02:06 +02:00
Felix Fontein 95cfcac694 docker-py: bump minimal version to 1.8.0 (#46134)
* Bumping docker-py minimal version to 1.8.0.
* Improve docs formatting.
2018-09-26 11:58:32 +05:30
Abhijeet Kasurde c98cec17e0 VMware: trigger customization for customization_spec (#45415)
This fix allows to trigger VM customization if user specifies
customization spec.

Fixes: #44159

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-26 02:26:45 -04:00
Abhijeet Kasurde a6b095756c
VMware: Add support for service type (#40651)
* Add support for - Replication, Provisioning
* Update documentation
* Update example

Fixes: #40529

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-26 11:53:45 +05:30
Nathan Webster 3b786acb86 EC2_ASG: Enable support for launch_templates (#45647)
* Enable support for launch_templates in ec2_asg

* Fix asg create with LT and no version number

* Update mutually exclusive list

* Better function names
2018-09-25 16:39:34 -04:00
José Maia 923a7bd30f [azure] Fix name for the symbol * in docs (#46119)
Correct name is "asterisk", not "asterix", which is a popular franco-belgian comic character!

+label: docsite_pr
2018-09-25 15:21:24 -04:00
Zim Kalinowski 6056b89675
fix for managed disk facts (#46021) 2018-09-26 00:48:22 +08:00
abarbare 98b0594352 feat: add scaleway security group module (#45686)
fix: pep8 coding style

fix: error order requests
2018-09-25 16:39:49 +01:00
René Moser e7926cf9f4
cs_instance: fix host migration without volume (#46115) 2018-09-25 16:48:45 +02:00
Abhijeet Kasurde 4b4b21d745 [docs] Fix typos in aws_s3 and s3_bucket module docs (#46106)
Eucalypus to Eucalyptus

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-25 08:57:44 -04:00
Hirshr c11c3506cd spotinst_aws_elastigroup elastic_ips example (#41190)
* Update spotinst_aws_elastigroup.py
2018-09-25 11:41:07 +01:00
Anoop Sood d1688adefc Update sl_vm.py (#43966)
* Update sl_vm.py

Updated the list of datacenters to include new datacenters.
2018-09-25 11:15:51 +01:00
Sandra McCann c5a8a911b3 fix doc links (#46094) 2018-09-24 16:08:05 -05:00
Dominik Holler 67e87d3d1c ovirt_host_network: Add save parameter to example (#45965)
The parameter 'save' is added to an example and the default
behavior is mentioned in the description of the other
examples.
2018-09-24 16:44:07 -04:00
Rémy Léone 53886ecc9b Add an Online servers fact 2018-09-24 21:03:50 +02:00
Vinay Dandekar fe6b7f6b5d [aws] Change IAM role name parsing to come from the ARN (#45534) 2018-09-24 12:41:23 -04:00
Sloane Hertel 485320aab8 [sns_topic] Don't mask non-authorization errors (#46030) 2018-09-24 11:58:46 -04:00
Dag Wieers f90fc8a9a2 Fix author in modules (#46068)
Fix a few cases where the author was incomplete or incorrect.
2018-09-24 10:14:29 -05:00
José Maia 9039002886 Fix typo in Azure ARM module documentation (#46065) 2018-09-24 09:57:23 -05:00
Rémy Léone 6d7004f367 Add a Scaleway IP module (#45121)
- Add an option to enable public ip at server creation
2018-09-24 10:14:23 -04:00
Felix Fontein 7caf70db42 docker_container: fix various idempotency problems and non-working options (#45905)
* Sorting args.

* Doing comparisons of options with container parameters in a more context-sensitive way.

This prevents unnecessary restarts, or missing restarts (f.ex. if parameters are removed from ``cmd``).

* Make blkio_weight work.

* Fix cap_drop idempotency problem.

* Making groups idempotent if it contains integers.

* Make cpuset_mems work.

* Make dns_opts work.

* Fixing log_opts: docker expects string values, returns error for integer.

* Adding tests from felixfontein/ansible-docker_container-test#2.

* Make uts work.

* Adding changelog entry.

* Forgot option security_opts.

* Fixing typo.

* Explain strict set(dict) comparison a bit more.

* Improving idempotency tests.

* Making dns_servers a list, since the ordering is relevant.

* Making dns_search_domains a list, since the ordering is relevant.

* Improving dns_search_domains/dns_servers.

* Fixing entrypoint test.

* Making sure options are only supported for correct docker-py versions.
2018-09-24 10:40:05 +01:00
René Moser 83ec418470
cs_loadbalancer_rule_member: fix error handling (#46012)
* make use of query_api
* fix sanity
2018-09-22 13:40:40 +02:00
Tom Hodder c123b4e7ef digital_ocean_domain: fix to allow updating the module param ip between calls (#42009)
* update the domain record with the new ip from params if resource exists

* fixes for pylint and pep8 checks
2018-09-22 03:13:20 -04:00
Matt Davis 3b52d968e6
fix premature exit when RG doesn't exist (#46013)
* fixes #45941
* corrects regression introduced by #26104; when the resource group doesn't exist, the module exits prematurely with an error instead of creating it.
2018-09-21 16:23:21 -07:00
Abhijeet Kasurde 0ecbd50c3b Misc typo fixes (#45969)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-21 14:43:22 +01:00
Abhijeet Kasurde a9680ee3ef
VMware: new module vcenter_extension_facts (#45472)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-21 13:57:47 +05:30
lwm 0947948d6b Use dashes not underscores for linode labels. (#44719)
This is because underscores are illegals in hostnames and users might
want to create the same host names are the name of the Linode machine
(as in the report in #30059).

Closes https://github.com/ansible/ansible/issues/30059.
2018-09-20 15:42:45 -04:00
lwm 4774ea7a15 Linode: docs note for py3 limitation and deprecated API (#44723)
* Add note that linode-python having no py3 support.

Closes https://github.com/ansible/ansible/issues/44695.

* Add note that the module uses the deprecated API.
2018-09-20 15:41:46 -04:00
Michael Johnson 1a3bc7d746 Update azure_rm_virtualmachine.py (#45325)
* Update azure_rm_virtualmachine.py

A lot of Azure images are not cloud-init ready and need to be prepared manually before attempting to use the custom_data option of this module. Adding a line to the description to make others aware. If, like me, they are used to working with AWS AMIs that all seem to have cloud-init baked in, this could prevent some troubleshooting as to why their custom_data scripts aren't running in Azure.

* fixing addition to azure_rm_virtualmachine.py

* Update azure_rm_virtualmachine.py

* final update

* fixed url syntax

* nuked trailing whitespace
2018-09-21 02:22:53 +08:00
Rémy Léone 7c7a7efbbe Add an option to enable public ip at server creation (#44826) 2018-09-20 12:13:26 -04:00
Yanis LISIMA 45c7facd64 ec2_vpc_igw: migrate to boto3 (#45346)
* ec2_vpc_igw: draft migrate to boto3

* ec2_vpc_igw: migrate to boto3

* ec2_vpc_igw: fix error and implement code review

* ec2_vpc_igw: always catch BotoCoreError with ClientError, remove unused fail method

* ec2_vpc_igw: fix pep error
2018-09-20 19:56:19 +10:00
Zim Kalinowski 60979a96a9
Fixing azure_rm_containerregistry_facts (#45897)
* fixing cr facts

* final fix?

* fixed

* syntax

* sanity
2018-09-20 16:58:07 +08:00
Dag Wieers 197ddd3c45
Fix incorrect type in arg_spec 2018-09-20 02:13:29 +02:00
Zim Kalinowski 83645963fb Fixing assigning ssl certificate to http listener in app gateway (#45830)
* fixed ssl certificate reference

* modified test
2018-09-19 17:00:27 -07:00
Zim Kalinowski 16fa49a894 adding os disk name (#45126)
* adding os disk name

* fixed test
2018-09-19 16:51:37 -07:00
Adrián f85065dabf Explain disk size in mount and add example (#41681)
* Explain disk size in mount and add example

- Explain mount with 8GB
- Add new example to start container with mount

* Removed trailing whitespace
2018-09-19 20:01:49 +01:00
Dag Wieers 2edf20d1ed Docs: Avoid use of 'default: null' (#45795)
Various modules document the default 'null' value, but it causes None to
be shown in the documentation explicitly.
2018-09-19 09:02:27 -05:00
Jon Dufresne 2097d25506 Correct capitalization of PyPI (#45698)
As spelled on https://pypi.org/.
2018-09-19 08:51:49 -05:00
Michael Tipton 1b92e43dcb VMware: vCenter plugin : new module (#44963) 2018-09-19 17:58:11 +05:30
Julien PRIGENT 6059246093 EFS - add support for new Provisioned Throughput (#43253)
* efs.py: Add support for EFS provisioned throughput

* efs_facts.py: Add support for EFS provisioned throughput

* efs_facts integration tests updated with provision throughput

* efs_facts: Tests refactoring - add failure and success playbook according to botocore version.

* efs_facts: More tests and new option descriptions adjustment

* efs_facts tests renamed to efs
2018-09-19 09:10:56 +10:00
René Moser 1ed3bd9168
vultr: fix for unreliable API behavior (#45712) 2018-09-19 00:01:53 +02:00
René Moser 22986648dc
vultr_server: fix diff for user data (#45753) 2018-09-18 23:20:11 +02:00
Sloane Hertel 8d2df9be52 ec2_group - fix VPC precedence for security group targets (#45787)
Update the dictionary with the preferred values last to get the right order of VPC precedence

Fixes #45782
2018-09-18 15:33:19 -04:00
Sloane Hertel c004a639b3
[ovirt] remove 2.8 deprecations (#45506) 2018-09-18 08:28:00 -04:00
mrmagooey 1f8c5905b3 VMware: fix return to return a tuple instead of a bool (#45764)
fixes "'bool' object is not iterable" exception when `res` is falsey
2018-09-18 16:53:17 +05:30
Martin Nečas 28a074c835 ovirt add vnic (#44716)
* ovirt add vnic
2018-09-18 10:02:49 +01:00
Dario Zanzico 54c3d1c24e New module: add docker_stack module (clound/docker/docker_stack) (#24588)
* add docker_stack module + tests
2018-09-18 09:54:44 +01:00
Felix Fontein 0961d914d7 Don't parse/interpret options if state is 'absent'. (#45700) 2018-09-17 22:07:52 -04:00
Will Thames d2569a3f7d Improve iam_group exception handling (#45599)
* Improve iam_group exception handling

Use AnsibleAWSModule for iam_group and handle BotoCoreErrors
as well as ClientErrors. Use fail_json_aws to improve error messages

* Add minimal iam_group test suite

Update some of the read-only IAM permissions (this is not sufficient
to run the test suite but it gets further than it did until it tries
to add a (non-existent) user)

* Clean up after tests
2018-09-17 19:53:44 -04:00
Denis GERMAIN 68e264e878 Wrong parameter in scaleway sshkey module example (#45737)
* Update scaleway_sshkey.py
fix: typo "present" in example
2018-09-17 15:04:09 -05:00
C. Friedrichs 05840ffe16 updated documentation in vmware_guest.py (#45481)
Added note regarding online disk resizing and changed wording of a few sentences. Also added vSphere 6.7 as "tested on" as it works very well.
2018-09-17 15:59:21 -04:00
Michael Scherer bef1e5621b Add a alias from organisation to organization (#45688)
Since 'organization' is the spelling used accross all others modules,
I think it would be better to at least have this one as a alias.

Organisation is the UK/Australia/NZ spelling, while organization is the
US one.
2018-09-17 15:50:46 -04:00
Sloane Hertel 21f4b5911e [aws] fix version_added for elb_classic_lbmodule (#45559) 2018-09-17 14:32:51 -04:00
Sloane Hertel b42c7f4512 [iam_role] A hyphen with nothing following becomes [None] rather than []. Fix example syntax. (#45742) 2018-09-17 14:32:15 -04:00
Sloane Hertel d7ca3f2bd3 ec2_group: fix regression for targets that are a list containing strings and lists (#45594)
* Fix targets that may be a list containing strings and lists which worked prior to 2.6.

* Add ec2_group integration tests for lists of nested targets

* changelog

* Add diff mode support for lists of targets containing strings and lists.
2018-09-17 14:31:41 -04:00
Lingxian Kong cf1e0bde99 os_loadbalancer: support to create populated load balancer (#44619)
The user can use os_loadbalancer module to configure a fully functional
load balancer by specifying the sub-resources definition in the module,
rather than combining os_listener, os_pool and os_member modules.
2018-09-17 14:10:03 -04:00
David Passante 05328ebf21 Cloudstack: fix support for some VPC service capabilities (#45727)
* Fix support for VPC capabilities such as redundant routers or region level VPC

* Add integration test cases for "region level VPC" and "distributed router" capabilities
2018-09-17 16:08:16 +02:00
Jon Cormier 7aaa5da41d [aws_ssm_parameter_store] use describe_parameters paginator (#45632)
Fix the service reaching an internal limit while processing the results and returning unexpected data
2018-09-14 15:17:15 -04:00
lwm 1d754b43de Linode: clarify how to create/delete linode machines with `linode_id`. (#45659)
* Attempt to explain `linode_id` a bit better.

Don't include in any example that creates a Linode.

Based on comments in

> https://github.com/ansible/ansible/issues/45403#issuecomment-419752856

* Add simple creation example. Show how to pass `linode_id`.
2018-09-14 15:10:32 -04:00
Deaton64 3782a236ba Update azure_rm_trafficmanagerprofile.py examples (#45649)
Wrong module name used in examples. changed `azure_rm_trafficmanager` to `azure_rm_trafficmanagerprofile`
2018-09-14 09:48:11 -04:00
Michael Scherer ede3a8cee1 Fix formatting for the error on azure_rm_appserviceplan_facts (#45613)
Since there is only 1 argument, {1} can't work since that's the
2nd argument for format. Flagged by lgmt.com
2018-09-13 17:00:21 -04:00
Vibhav Sinha e26d758d6f fix gce_backend_service examples for healthchecks (#31134)
gce_backend_service module expects healthchecks to be an array of string. The previous example incorrectly mentioned healthchecks as an array of objects each containing a `name` key.
2018-09-13 13:47:43 -05:00
Zim Kalinowski df768914a1 adding sql firewall rule facts (#45059) 2018-09-13 17:54:58 +08:00
Martin Nečas 2a3f3382fd Ovirt add rename functionality (#44951)
* add renaming of ovirt
* add renaming func to ovirt cluster
* ovirt update examples in docs
2018-09-12 14:36:06 -07:00
Zim Kalinowski 73c8041ec0 Azure load balancer crash fix (#45546) 2018-09-12 16:25:35 +08:00
Zim Kalinowski 111febe62e extended vmss facts (#45535) 2018-09-12 13:22:47 +08:00
Zim Kalinowski 821c27cefb fixed tag support in autoscale facts (#45533)
* fixed tag support in autoscale facts

* forgot to add tags to arg spec
2018-09-11 23:00:58 -04:00
William 2ea9cfcd52 Fix python 3 compatibility for network id lookup (#45467)
Due to a change in python 3 filters return filter instead of list. This breaks the network name to id lookup for the docker_swarm_module. By wrapping it in list it ensures it is a list when returned and the id is extracted.
2018-09-11 15:45:42 -04:00
Sloane Hertel e5269c047c [AWS] cloudfront_distribution - fix method name from 'validate_distribution_id_from_caller_reference' to 'validate_distribution_from_caller_reference' and set distribution_id to the distribution's key 'Id' (#45498) 2018-09-11 15:08:30 -04:00
Matt Clay ae4d5e3257 Avoid duplicate Azure storage account types. 2018-09-11 10:37:48 -07:00
Michael Scherer 804d574d1f Add documentation for the modify command, by giving a example (#19699) 2018-09-11 11:38:39 -04:00
Yuwei Zhou fa04387550 fix the autoscale resource id (#45477)
* fix the autoscale resource id

* Update main.yml
2018-09-11 18:52:43 +08:00
Zim Kalinowski 8a221d81dd fixing facts for mysql server (#45374) 2018-09-11 14:27:50 +08:00
Zim Kalinowski 0b029d6792 adding tags support to postgresql (#45339) 2018-09-11 10:20:27 +08:00
Eric Thiel 7d0cd81d4f VMware: exclude start_connected from host customization check (#40990) 2018-09-10 16:15:47 +05:30
Abhijeet Kasurde d4bef8652a VMware: skip customization if no type is specified (#44510)
VM customization is not necessary if user is not specifying IP address
and netmask. This fix adds exception for type 'DHCP' which is set by default
if no networking details are provided.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-10 06:07:15 -04:00
Zim Kalinowski e203531735 fixing broken sql server tags (#45378) 2018-09-10 15:31:01 +08:00
Abhijeet Kasurde d41e568a4d
VMware: use UUID to find templates and VMs (#45208)
This fix adds functionality to find the templates or VMs for cloning
operations.

Fixes: #45081

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-10 12:45:47 +05:30
Harald Albers a9c829bdf2 VMware: honor "wait_for_ip_address" when powering on a VM (#45226)
Signed-off-by: Harald Albers <github@albersweb.de>
2018-09-10 12:25:35 +05:30
Zim Kalinowski 6110163f99 Fixes in container registry documentation (#45390)
* adding tags to container registry

* fixed tags
2018-09-10 01:49:04 -04:00
Zim Kalinowski 6d0b0f8338 added missing facts in container instance (#45380)
* returning tags in container instance facts

* small fix
2018-09-10 01:10:40 -04:00
Stéphane Travassac 0f7ef141ad VMware: more detail error on bad http code return for vmware_guest_file_operation.py (#41897)
Fixes: #41721
2018-09-10 09:21:00 +05:30
Zim Kalinowski 376082c37d added tags to webapp documentation (#45375) 2018-09-10 09:51:17 +08:00
kryptsi 1325ddbb0b VMware: new plugin for setting an object's role/permission (#39988) 2018-09-07 19:03:58 +05:30
Ryan Brown 4d7e261074 [aws] Remove deprecated `ec2_vpc_dhcp_options_facts` alias of ec2_vpc_dhcp_option_facts (#45322) 2018-09-07 09:09:28 -04:00
Ryan Brown 8d363f7693 [aws] Remove deprecated `ec2_vpc_dhcp_options` alias of ec2_vpc_dhcp_option (#45321) 2018-09-07 09:08:09 -04:00
Pieter Avonts 1a810f8f11 VMware: Rewrite get_resource_pool method for correct resource_pool selection (#39792)
* rewrite get_resource_pool method for correct resource_pool selection
* only keep name if path is given for cluster, esxi_hostname or resource_pool
* Revert "only keep name if path is given for cluster, esxi_hostname or resource_pool"
* This reverts commit 50293ec763c024b0eaceac5d775ccc0ad3ff8bd7.
* if the name argument contains a path, only use the last part for matching
* remove path from cluster argument in tests
* remove find_objs in favour of reusing find_obj with an extra folder argument
* fix find_obj ignoring first if name is not given
2018-09-07 18:23:26 +05:30
Abhijeet Kasurde fd985db72d
VMware: Refactor disc logic (#39285)
* Refactoring related to network device
* Assign unique random temporary key while creating SCSI or/and IDE controller devices
* Add testcase for this change

Fixes: #38679

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-07 17:04:02 +05:30