b95b077993
Restore skipped/failed in JSON callback, add custom facts ( #37204 )
...
* Restore skipped/failed keys. Fixes #37050
* Display custom stats. Fixes #37184
* Add version_added
* Drop fallback, use self.get_option
* Remove unused import
2018-03-20 10:32:33 -04:00
0d0bdbec62
Load plugin config defs on first load only ( fixes #37553 ) ( #37584 )
2018-03-19 13:34:15 -04:00
594840c1d6
Close & remove paramiko connection where appropriate ( #37528 )
...
* Close & remove paramiko connection where appropriate
* Update unit test
2018-03-16 13:28:04 -04:00
cdd21e2170
Clean up module documentation ( #36909 )
...
* Clean up module documentation
This PR includes:
- Removal of `default: None` (and variations)
- Removal of `required: false`
- Fixing booleans and `type: bool` where required
* Fix remaining (new) validation issues
2018-03-15 22:15:24 +01:00
85cc5ea129
Raise error when trying to use older iosxr modules with netconf ( #37423 )
2018-03-15 12:49:35 -04:00
6292fe1116
small typo fix
...
small typo fix
2018-03-15 11:01:32 -04:00
c2a063a5c0
aws ssm parameter lookup - testing and documentation around negative and failure cases ( #36550 )
2018-03-09 12:30:33 -05:00
708869edd6
win: handle non string as an environment value ( #37215 )
...
* win: handle non string as an environment value
* Changed powershell environment handler to use .net function instead for special chars
2018-03-09 08:02:54 +10:00
0fee332643
Added missing store regex pattern for prompt found after error ( #35820 )
2018-03-07 09:35:35 -05:00
f0dc0b28d4
Fix side-effect of flags being passed to ios get_config again ( #37084 )
2018-03-06 13:55:36 -05:00
23f15e6ff6
Lenovo license update ( #36840 )
...
* Editing the License text after Review of Lenovo Legal team.
2018-03-06 18:02:46 +00:00
905b3e2f65
fix NIOS DNS lookup example ( #36737 )
2018-03-05 13:52:02 -05:00
7016b3b9ca
ios_static_route idempotence fix ( #35912 )
...
* Remove default admin_distance and fix the idempotence thereof
Fixes #33290
* Fix tests and use yaml anchors to shorten tests
* Add test for undefined admin_distance
* Read config from `show run` if `show ip static route` fails
* Restore flags to ios.get_config & use get_config where appropriate
2018-03-05 09:28:37 -05:00
0feea66988
Move _start_connection() to module_utils/connection and fix Popen() call ( #36249 )
...
* Fix Popen() call to use ansible python
* Remove PATH searching, reuse location of ansible instead
2018-03-05 09:12:01 -05:00
6cbc69447b
adds fix for terminal plugins
2018-03-05 08:54:40 -05:00
18d605a132
ugh q
2018-03-05 08:54:40 -05:00
d1ff03e84c
fixes cliconf and netconf plugin loaders
...
This change updates the configuration and plugin loader objects for
cliconf and netconf to pull be able to configure where to find the
plugins.
2018-03-05 08:54:40 -05:00
4021194532
Fix_regex ( #36569 )
2018-03-05 06:30:37 -05:00
b12e90311f
map network_os to ncclient device_params ( #36819 )
...
* map network_os to ncclient device_params
Fixes #36786
* update device map
* Add default netconf fallback plugin
2018-03-01 22:23:14 +05:30
41d75783b5
Fix junos_command py3 related issues ( #36782 )
...
Fixes #36204
* tostring() input string shoulb be in byte string format
* to_ele() input is required in unicode format
2018-03-01 12:09:11 +05:30
809106ba77
fix unixy when debug's msg is not text ( #36882 )
...
fixes #36850
2018-03-01 09:23:39 +10:00
c2feab0606
fix plugin-to-doc naming mismatch, typos, grammar ( #36366 )
2018-02-26 14:25:28 -08:00
fb6a8c0133
fix cliconf get_config method to match base signature ( #36682 )
...
This commit fixes up the get_config method to match the minimum method
signature as defined by the base class. Without this patch, the
get_config method calls will fail in some cirumstances.
2018-02-26 10:56:22 -05:00
07e8fb5dbb
Windows: Clean up documentation ( #36684 )
...
This PR includes:
- Further cleanup of BOTMETA.yml
- Cleanup of author github handles
- Use of proper booleans
- One-line license statement
- Copyright format statement
- Smaller cleanups
2018-02-25 03:09:54 +01:00
2f13ddbd69
debug should have item ( #36534 )
...
* debug should have item
* item should only be present when var
2018-02-23 15:12:14 -05:00
73fd593d45
aws_ec2 inv plugin: remove extra call to verify_file ( #36588 )
...
* Remove extra call to verify_file
* Allow next inventory plugin to be tried if the file isn't verified
2018-02-22 12:10:47 -05:00
10fefc7156
Re-use logic from StrategyBase._load_included_file in StrategyModule.run for free and linear ( #36470 )
...
This improves include_role performance and recursion limits
2018-02-21 09:53:15 -06:00
52f2057472
aws ssm parameter lookup - change to return Nones for missing variables ( #36456 )
...
* aws ssm parameter lookup - change to return Nones for missing variables
* aws ssm parameter lookup - fix error case message to dump response
* aws ssm parameter lookup - fix integration test cases
2018-02-21 06:50:00 -05:00
df8a5d7a4f
fetch: set fail_on_missing: True as default as per docs ( #36469 )
...
* fetch: set fail_on_missing: True as default as per docs
* Updated docs for fetch to say behaviour was changed in 2.5 and updated tests
2018-02-21 18:10:23 +10:00
d5858bbcbe
fail module when config is invalid and jsonrpc doesn't return error ( #36482 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-21 12:36:10 +05:30
a79378fccb
remove extra fields from debug output
...
fixes #35493
updated tests
2018-02-20 08:46:05 -05:00
6af5693dc2
hide uneeded fields for callbacks ( #36259 )
...
* hide uneeded fields for callbacks
fix selective instead of pushing uneeded fields to the methods
* piipii
2018-02-20 08:41:18 -05:00
b39534201f
[cloud] If inventory file isn't able to be parsed by aws_ec2, raise an AnsibleParserError ( #36387 )
...
* If inventory file isn't able to be parsed by aws_ec2, return an empty dict instead of None
* Raise an AnsibleParserError instead
* remove extra lines
* aws_ec2 inventory plugin - fix path matching logic
2018-02-19 17:12:56 -05:00
edaeb69a35
Fix the script and patch plugins tempfile ownership
...
Unified tmp accidentally removed the containing tmpdir from the list of
files to fix the permissions on when we're becoming a different
unprivileged user. This resulted in a visible bug for script but not
for patch. This is because patch also uploads the module to the same
temporary directory and the uploaded module also ends up calling
fixup_perms2() which includes the temporary directory. So by the time
patch needs to access the temporary patch file, the directory is
appropriately set.
script's breakage was visible because script does not upload a module
(it's akin to raw in this way). Therefore, we only call fixup_perms2()
once in script and so leaving out the tmpdir in script means that the
containing directory never has its permissions set appropriately.
Fixing both because it does not cause an extra round trip for patch so
any speedup would be minimal and it's better to fix the perms as close
as possible to where we know we need it. Otherwise, changes to
seemingly unrelated code later could end up breaking it.
Fixes #36398
2018-02-19 13:07:58 -08:00
3ce5261272
mail: Fix cannot concatenate 'str' and 'int' objects
...
Fix an error in callback plugin when exceptions are being returned on failure.
2018-02-19 20:39:25 +01:00
b34ab6a0c4
hashi_vault: fix typo ( #36368 )
2018-02-19 08:34:05 +01:00
f2818caa61
Fix None stringification call to send_command ( #36254 )
...
send_command already performs the to_bytes safely on prompts (checking
for None). Without this check the literal 'None' became a subprompt trigger!
Fixes #35662
2018-02-16 10:37:01 -05:00
06f73ad578
Normalize usage of temp and tmp on tmp ( #36221 )
...
* Normalize usage of temp and tmp on tmp
* Rename system_tmps system_tmpdirs
* Add ANSIBLE_REMOTE_TMP spelling of environment variables
2018-02-15 09:01:02 -08:00
f67ff4a78e
Alter ASA regexes to be byte-strings ( #36176 )
2018-02-15 10:11:26 -05:00
dae737c8b7
Only template each hostvars var on-demand ( fixes #33259 )
2018-02-15 10:09:04 -05:00
a612137098
Final fix for #35666 Previous PR ( #36143 ) was merged prematurely.
2018-02-14 18:46:13 -08:00
15fe59ef0c
* Fix for setting remote_tmp as a subdirectory of a system temp dir ( #36143 )
...
Fixes #35666
* Check that system_temps is all absolute paths
2018-02-14 20:34:14 -05:00
8fb66c18de
win_updates: fix regression when using string cat names ( #36015 )
2018-02-15 06:14:06 +10:00
97573d8b0c
Add unit tests for edgeos_command ( #35861 )
2018-02-14 09:27:03 -05:00
cf9b427add
Changing Lenovo Inc to Lenovo and update License file to be consistent. ( #36155 )
2018-02-14 10:44:05 +00:00
69be2c169f
Upgrade to openshift client 0.4.0 ( #35127 )
2018-02-13 10:34:24 -05:00
e4c04aa0f3
Fix YAML issue ( #36103 )
2018-02-13 12:46:56 +00:00
e8b631d4df
corrected dump signature
2018-02-12 16:52:04 -05:00
39d9496282
add_host: check if name or hostname arg is provided
2018-02-12 15:24:45 -05:00
e8fc269cd3
fix spelling. Seriously, that's it.
2018-02-12 13:17:55 -05:00
Matt Martz
Andrew Gaffney
Nathaniel Case
Dag Wieers
Mans Matulewicz
mikedlr
Jordan Borean
bdowling
Anil Kumar Muraleedharan
David Newswanger
Peter Sprygada
abirami-n
Ganesh Nalawade
Brian Coca
Alex Ratner
Peter Sprygada
Sloane Hertel
Trishna Guha
Brian Coca
Toshio Kuratomi
Henri Salo
Sam Doran
Chris Houseknecht
John R Barker
Martin Krizek
tedder