Commit Graph

6 Commits (f64e438150b4fb9e14b0983c8bcff2a10504c568)

Author SHA1 Message Date
Dreamcat4 f64e438150 fix: win10 - Add exception handling for 'Profiles:' textual output key name mismatch.
In win10 (and pribably win8x also):

The output of 'show rule' key includes the line "Profiles:<TAB>Public,Private".
Yet your script expects the key name printed out to be "Profile:<TAB>value".

This commit added the necessary exception handling to avoid flagging 'different=true' under the false circumstance. The key name to SET a firewall rule is still "profile=" and not "profiles=".

There is coming up another commit to fix the value handling for win10/win8. Which is another (different) error with the profile: key.
2016-12-08 11:33:26 -05:00
Dreamcat4 b9dd3568f3 fix: fw rule names must always be quoted, to permit spaces ' ' and brackets '()'
Without this fix, the 'netsh' command gets name=Firewall Rule Name instead of name="Firewall Rule Name". Thus causing all sorts of havoc. Basic shell quoting rules seems to apply to Windows Powershell too. This is very much needed as many of windows 10's default firewall rules contain spaces and brackets () characters.
2016-12-08 11:33:26 -05:00
TimothyVandenbrande 8cb80ce7bf upon request, added the license 2016-12-08 11:33:20 -05:00
Timothy Vandenbrande 8aa14ac4aa renamed profile var 2016-12-08 11:33:20 -05:00
Timothy Vandenbrande c7fb582b9c windows default to current instead of all 2016-12-08 11:33:20 -05:00
Timothy Vandenbrande 3511497dc1 renamed the module 2016-12-08 11:33:20 -05:00