Commit Graph

193 Commits (f7fcb81dd9859de0a96e586b19c3b383b85fc33f)

Author SHA1 Message Date
Alvaro Aleman 2f2f80ad4c Fix can_update test in os_subnet (#3664) 2016-12-08 11:24:31 -05:00
René Moser 5fc7bc45ac Add no_gateway_ip option to os_subnet module (#3736)
no_gateway_ip option can provide subnet that is not having a gateway.
fixes #1880
2016-12-08 11:24:31 -05:00
John R Barker d13046a905 ansible-validate-modules part 4: Enable check on ansible-modules-core (#3526)
* Call ansible-validate-modules

* Correct quotes + add newline
2016-12-08 11:24:26 -05:00
tonyqui cb9df31ef3 Fixing a typo, floating-ips has been used instead of floating_ips (#3540) 2016-12-08 11:24:23 -05:00
Donovan Jones 8274f55818 Make remote_group handle name and id in cloud/openstack/os_security_group_rule.py
* Make remote_group handle name and id

* fix regression breaking os_security_group_rule with no remote_group
2016-12-08 11:24:18 -05:00
John Barker d531eb146d Replace BOOLEANS with true/false 2016-12-08 11:24:17 -05:00
Ricardo Carrillo Cruz 682d97b765 Create subnet by domain
A cloud/domain admin should be able to create a subnet on any
project it is granted on.
This change adds the 'project' parameter that accepts either
a name (admin-only) or id.
2016-12-08 11:24:17 -05:00
Ricardo Carrillo Cruz eecceaef6e Add project parameter to os_network
A cloud/domain admin should be able to create a network on any project
it is granted to.
This changes adds the possibility to pass either a project ID or
project name.
2016-12-08 11:24:17 -05:00
Rene Moser aa32ae65a6 openstack: doc fix, add version_added
see #3388
2016-12-08 11:24:16 -05:00
David Shrewsbury dcbbd72cfd Wrap calls to main() with if check
A change was merged to the main Ansible core code that can cause

a potential hang if any libraries are called that use threading.

This change was:

  4b0aa1214c

This affected the os_object module by causing a hang on the shade

create_object() API call (which in turn calls swiftclient which

uses threading). The fix is to make sure all modules have a main()

that is wrapped with an "if __name__ == '__main__'" check.
2016-12-08 11:24:16 -05:00
Ricardo Carrillo Cruz 1b5288b703 Only check default_project on resource creation
The default_project is checked at the beginning of the module.
This raises an exception if the project passed does not exist.
This logic only makes sense on resource creation, if a user
puts state=absent the module fails, even though the default
project is not relevant
2016-12-08 11:24:15 -05:00
Brian Coca 37513ca8bb corrected required docs as only boolean is allowed
these complex values were not displayed and would always show the fields as requried
2016-12-08 11:24:15 -05:00
David Shrewsbury 1bdc3b3bb0 Pass wait/timeout parameters to floating IP APIs in os_server
If a server already exists when os_server is run, but a floating
IP was not assigned to the server when one was requested, the
module will attempt to add an IP to the existing server. But it
would not pass the wait/timeout params to the floating IP APIs.
If wait was True, you could get back a server dict that did not
show the floating IP because it did not wait.
2016-12-08 11:24:15 -05:00
David Shrewsbury 82a1208e64 Set type on floating_ip_pools in os_server
This has been expected as a list, so let's be explicit about it
so it will work correctly in 2.1 release.
2016-12-08 11:24:15 -05:00
Ricardo Carrillo Cruz 5d402f31c8 Fix is_public type on os_image
Without this fix, the is_public value is a string and the shade
call handling the module does not evaluate correctly when
passing is_public: no
2016-12-08 11:24:15 -05:00
David Shrewsbury 4b97cd3a42 Add support for provider network options.
Adds new parameters for specifying options for provider network plugins.
2016-12-08 11:24:14 -05:00
Michael Scherer 55bbe191e5 s/plubic/public/in the doc 2016-12-08 11:24:14 -05:00
David Shrewsbury 285ab7656f Fix allowed_address_pairs and extra_dhcp_opts in os_port
Commit f71542c set the incorrect type for these two parameters to
dict when they are actually list of dicts.

Also, the extra_dhcp_opts was incorrectly named (without the terminal
's') and NEVER worked, so this was corrected.

Fixes #3301
2016-12-08 11:24:13 -05:00
Ricardo Carrillo Cruz 344a559b61 Allow passing domain name on os_server
A cloud admin can search domains, thus it should be possible
to pass a domain name, just like ids.
2016-12-08 11:24:13 -05:00
David Shrewsbury b750b926d3 Fix size parameter documentation
The generated documentation shows the size parameter as required.
Set 'required' to 'false' and move the explanation to the description.

Fixes #3278
2016-12-08 11:24:13 -05:00
Rene Moser facf61366e openstack: os_server: add version_added for scheduler_hints
See #3172
2016-12-08 11:24:13 -05:00
David Hocky d6e32b8245 add explicit type for scheduler hints 2016-12-08 11:24:12 -05:00
David Hocky 3b800f1f34 port 'scheduler_hints' feature from nova_compute to os_server module 2016-12-08 11:24:11 -05:00
Terry Howe a06b07221d Fix openstack module documentation 2016-12-08 11:24:10 -05:00
David Shrewsbury d7568a50e2 Fix parameters where type is assumed.
A change is coming to Ansible where module params will default to str.
Many of our modules were taking advantage of this by not being explicit
about the type, so they will break when that change merges. This hopefully
catches those cases.
2016-12-08 11:24:05 -05:00
David Shrewsbury 66c83fc788 Fix for os_server module when specifying region
Fix the OpenStack os_server module for when region_name is specified.
This should not be passed through to the shade create_server() call
as it's only used with the auth parameters.

Fixes bug: https://github.com/ansible/ansible-modules-core/issues/2797
2016-12-08 11:24:04 -05:00
Monty Taylor 6aaee42604 Add user_data alias for userdata in os_server
The old nova_compute module called the parameter user_data - having an
alias to the old name is friendly.

Fixes Issue #2920
2016-12-08 11:24:04 -05:00
Brian Coca 19b3d43aa5 added missing version_Added 2016-12-08 11:24:01 -05:00
Yair Fried 63a0b99b6a Fix glance_client module
Wrong variable name.
2016-12-08 11:24:01 -05:00
Julia Kreger 060e12a2d3 Add wait support to os_ironic_node
Add support for the os_ironic_node module to be capible of waiting
until the baremetal node activation or deactivation has completed.
2016-12-08 11:24:00 -05:00
David Shrewsbury f6d6895ce9 Add purge option to os_floating_ip module
Add the ability to completely delete a floating IP from the pool
when disassociating it from a server. When state is absent and
purge is true, the IP will be completely deleted. The default
keeps the current behavior, which is to only disassociate the IP
from the server.
2016-12-08 11:24:00 -05:00
David Shrewsbury aed44e8886 Fix OpenStack module failure output
The exception message, when shade fails, will contain much more
specific information about the failure if the exception is treated
as a string. The 'message' attribute alone is usually not helpful.
2016-12-08 11:24:00 -05:00
Timothy R. Chavez 2ef913a288 Pass network argument to add_ips_to_server
The `network` argument needs to be passed through `add_ips_to_server`
so that the default value can be properly overridden from ansible.
2016-12-08 11:23:58 -05:00
Dmitry Labutin b20066ff8e Fix issue #2721: os_object parameters and docs don't align (file/filename) 2016-12-08 11:23:56 -05:00
Brian Coca 7d6c704404 fix bad linebreak 2016-12-08 11:23:55 -05:00
Michael Scherer 69036826a8 Fix #2629, replace choices=BOOLEANS by type='bool' 2016-12-08 11:23:55 -05:00
Sam Thursfield eba767902c os_server: Add some error checking for the 'nics' parameter
If this parameter was not of the right type, the module would fail with a
traceback, with a "AttributeError: 'str' object has no attribute 'get'"
exception.

It now gives a proper error message on type errors.
2016-12-08 11:23:54 -05:00
Alberto Gireud 58c39f47c1 Update root_volume variable 2016-12-08 11:23:53 -05:00
Toshio Kuratomi 8d293651df Fix os_server docs build 2016-12-08 11:23:53 -05:00
Donovan Jones 8b9cd7f410 fix typo in os_server security_groups description 2016-12-08 11:23:53 -05:00
Monty Taylor a715c91d0b Add support for network, boot_from_volume and volumes
nics is a great flexible parameter, but it's wordy. Shade now supports
a simple parameter too, which is just "network" and takes a name or id.
Add passthrough support.

In addition to supporting booting from a pre-existing volume, nova and
shade both support the concept of booting from volume based on an image.
Pass the parameters through.

Shade supports boot-time attachment of additional volumes for OpenStack
instances. Pass through the parameter so that ansible users can also
take advantage of this.
2016-12-08 11:23:52 -05:00
Timothy R. Chavez 37ac954123 Get new server object after adding floating IP
We need a new server object once we add the floating ip, otherwise we
will be operating with the older server object pre-floating-ip
assignment.
2016-12-08 11:23:52 -05:00
Markus Suonto 39d3c3dea6 fixed quantum_ modules to work with minimum access rights if greater access rights are not needed 2016-12-08 11:23:49 -05:00
David Shrewsbury 5c5db04ff0 Bug fix for os_image and min_disk/min_ram
The min_disk and min_ram parameters were not being passed to
the shade API. They also need to be integer values. Also
updated the description of these parameters for better
clarification.
2016-12-08 11:23:49 -05:00
David Shrewsbury ebd977e780 Fix os_user_group module
This module had a couple of errors in it. Also added check mode
support.
2016-12-08 11:23:48 -05:00
Monty Taylor a848d06a04 Use add_ips_to_server API
This module is still using an old pre-release API and needs to update
to use the current API.

Co-Authored-By: Marton Kiss <marton.kiss@gmail.com>
2016-12-08 11:23:47 -05:00
Lars Kellogg-Stedman 35240830f6 os_server_facts returns facts about multiple servers
have `os_server_facts` call `list_servers` rather than `get_server`, and
treat the `server` parameter as a wildcard pattern.  This permits one to
get facts on a single server:

    - os_server:
        server: webserver1

On mutiple servers:

    - os_server:
        server: webserver*

Or on all servers:

    - os_server:

Introduces a `detailed` parameter to request additional server details
at the cost of additional API calls.
2016-12-08 11:23:47 -05:00
Greg DeKoenigsberg 742b452dc1 @lorin stepping down as maintainer 2016-12-08 11:23:45 -05:00
Lars Kellogg-Stedman 51fae74e7c make os_router return a top level 'id' key
make os_router return a top-level 'id' key, much like other
os_* resources.
2016-12-08 11:23:43 -05:00
Lars Kellogg-Stedman 45cc987fe0 allow os_port to accept a list of security groups
with this commit, the `security_groups` attribute for `os_port` will
accept either a common-delimited string or ` YAML list.  That is, either
this:

    - os_port:
        [...]
        security_groups: group1,group2

Or this:

    - os_port:
        [...]
        security_groups:
          - group1
          - group2
2016-12-08 11:23:43 -05:00