Commit Graph

96 Commits (f8f4a7dcdf293fb699238b5334416ff588b3d56a)

Author SHA1 Message Date
Jesse Keating 16381fb5c0 Plumb ipv6 modes into os_subnet
Shade already supports these, we just need to plumb them into the module
code.
2016-12-08 11:23:18 -05:00
Jesse Keating 72809ac329 Fix up docs 2016-12-08 11:23:18 -05:00
Monty Taylor 530f12035b Update docstring to show port ranges as optional 2016-12-08 11:23:18 -05:00
David Shrewsbury 789c1fcbe7 Correct port matching logic
Port matching logic did not take into account recent shade change
to equate (None, None) to (1, 65535) when Nova is the backend.

Also, this encapsulates the port matching logic into a single function
and heavily documents the logic.
2016-12-08 11:23:18 -05:00
David Shrewsbury 387fe5b0e7 Change required parameters for rules module
The ports and protocol are no longer required (and now depends on
a new version of shade).
2016-12-08 11:23:18 -05:00
Davide Guerri 531b93490b Fix reuse argument documentation 2016-12-08 11:23:18 -05:00
Davide Guerri 95cfe3da96 Update os_floating_ip with new shade methods 2016-12-08 11:23:18 -05:00
Monty Taylor 4f2028439f Use int in the parameter list instead of casting 2016-12-08 11:23:18 -05:00
dagnello 2c3fc61357 Resolving issues in rule comparison algorithm
Port range min/max values are at times represented as string and
compared to int equivalents.  This fix explicitly ensures all
port range values are ints for proper comparisons.
2016-12-08 11:23:18 -05:00
David Shrewsbury e7dd93c5c1 Compare ports as strings
Ports as returned from shade are ints. They are strings as they come
in to the module.
2016-12-08 11:23:18 -05:00
David Shrewsbury 14212c37e2 Fix syntax error 2016-12-08 11:23:18 -05:00
Monty Taylor 60102e36e2 Return rule object 2016-12-08 11:23:18 -05:00
David Shrewsbury 174254a423 Update secgroup rules module for latest shade
This allows the rules module to work against either nova or neutron
for handling security groups. New parameters for 'direction' and
'ethertype' are added.

Check mode is supported with this version.
2016-12-08 11:23:18 -05:00
David Shrewsbury fcc1d643f6 Recongnize None and -1 port equivalency
shade 0.7.0 represents disabled min/max ports as None (in the
neutron style) rather than -1. Recognize this as the same as -1.
2016-12-08 11:23:17 -05:00
David Shrewsbury b42a9d56e6 Fix id value reference 2016-12-08 11:23:17 -05:00
David Shrewsbury f02ec15c17 Update rules mode for latest shade
Shade 0.7.0 normalized the security group data that is returned,
when using nova, to look more like neutron security group data.
This adjusts for that change.
2016-12-08 11:23:17 -05:00
dagnello ecef2aadba Minor fixes for os_security_group_rule module
Was not able to use this module as it was.  The changes submitted
resolved the issues I ran into in order to get it working.
2016-12-08 11:23:17 -05:00
Davide Guerri 2d7dbc5d0c Fix invalid syntax in openstack_module_kwargs call 2016-12-08 11:23:17 -05:00
Monty Taylor 9acc891477 Fix example code syntax 2016-12-08 11:23:17 -05:00
Monty Taylor a657e80bc8 Add OpenStack Floating IP Module
Also deprecate the two old quantum floating ip modules.
2016-12-08 11:23:17 -05:00
Monty Taylor 8d5e43c14f Add OpenStack Security Group Rule module 2016-12-08 11:23:17 -05:00
Toshio Kuratomi cf595b3c52 Fix indentation levels in os_keypair 2016-12-08 11:23:16 -05:00
Toshio Kuratomi 4c863187ad Few minor things from review of the pull request 2016-12-08 11:23:16 -05:00
Jesse Keating 2b5af82706 Document auto_floating_ip argument 2016-12-08 11:23:16 -05:00
David Shrewsbury 3cd81d2dd3 Use newest documentation style for return value. 2016-12-08 11:23:16 -05:00
David Shrewsbury c4bc6dea13 Add a note about the return value. 2016-12-08 11:23:15 -05:00
Monty Taylor c0190b0443 Fix dict syntax typo 2016-12-08 11:23:15 -05:00
David Shrewsbury 341efbf7ae Update os_keypair for latest shade
Uses the latest version of shade for cleaner code. Also, always
return the key dict whether we create the key, or it already exists.
The example using public_key_file is corrected to use a full path
since ~ is not converted for us.
2016-12-08 11:23:15 -05:00
Monty Taylor 869da89b35 Move the order of argument processing 2016-12-08 11:23:14 -05:00
Monty Taylor 377311db56 Add filter ability 2016-12-08 11:23:14 -05:00
Davide Guerri c1d7678cc2 Avoind using lookup() in documentation
lookup() is currently broken (current Ansible devel branch), so better to avoid
it in our examples.
2016-12-08 11:23:14 -05:00
Monty Taylor 0c0359798b Add OpenStack Keypair module
Also deprecate old nova_keypair module.
2016-12-08 11:23:13 -05:00
Monty Taylor 186fbd7645 Remove duplicate shade requirement 2016-12-08 11:23:10 -05:00
Monty Taylor 73cb529d2c Make sure we're always returning objects too 2016-12-08 11:23:10 -05:00
dagnello 072110c757 Resolving secgroup.id issue in this module
secgroup['id'] was not being returned in all cases where the
specified security group exists.
2016-12-08 11:23:10 -05:00
Monty Taylor 8ff71a3fa8 Actually use changed variable 2016-12-08 11:23:09 -05:00
Monty Taylor 4125b576e9 Return the secgroup for all present states 2016-12-08 11:23:09 -05:00
Monty Taylor b955b2f5c8 Return resource objects from OpenStack modules
It's not uncommon for people to want to do additional things after
creating a module. Also, add a note about it to the dev notes.
2016-12-08 11:23:09 -05:00
Monty Taylor 89f95471f8 Return secgroup, not just id 2016-12-08 11:23:09 -05:00
David Shrewsbury 9cbd7b2ece Remove os_security_group_rule module
The rules module will have it's own branch.
2016-12-08 11:23:08 -05:00
David Shrewsbury 6527f895a1 Remove 'result' value
This value is pretty much useless, and a holdover from the old
module code. Let's remove it.
2016-12-08 11:23:08 -05:00
Monty Taylor eb2f3c8a44 Update version added 2016-12-08 11:23:08 -05:00
David Shrewsbury 7f0da6d851 Update the docstring for os_security_group
Indicate that idempotence is on security group names, and give
an example for updating a security group description.
2016-12-08 11:23:08 -05:00
David Shrewsbury 640dbee643 Update for latest shade API
Shade version 0.7.0 introduces new API methods for creating,
deleting, and updating security groups. Let's use those and
clean up the module.
2016-12-08 11:23:08 -05:00
Julia Kreger d67ba5e25b Updating os_ironic_node module
Updating the os_ironic_node module to the most recent version
including support for power and maintenance states.
2016-12-08 11:23:08 -05:00
Julia Kreger 51149b9643 Updating os_ironic module
Updating os_ironic module to the most recent version accounting for
changes in Ansible devel branch and the shade library since the
original creation of the module.
2016-12-08 11:23:08 -05:00
Greg DeKoenigsberg 18ca7aee07 Updating cloud modules with proper github author information 2016-12-08 11:23:07 -05:00
Monty Taylor 574bcac277 Add developer docs for the OpenStack modules 2016-12-08 11:23:07 -05:00
Monty Taylor 51ce05bfb9 Add Ironic Node module 2016-12-08 11:23:07 -05:00
Monty Taylor e534753092 Add Ironic module 2016-12-08 11:23:07 -05:00